[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #32 from Jonathan Druart --- Created attachment 117916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117916&action=edit Bug 7806: [20.05] (follow-up) Update to use sanitize_zero_date Signed-off-by: Ma

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #31 from Jonathan Druart --- Created attachment 117915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117915&action=edit Bug 7806: [20.05] Fix remaining occurrences of -00-00 We should remove all S

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #30 from Jonathan Druart --- Andrew, resolve the conflict like that: 108 $patron->{dateexpiry} = undef; 109 my $d = C4::Circulation::CalcDateDue( $today, $item->{itype}, $branch->{branchcode}, $patron ); 110

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolution

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04 r

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Keywords|RM_priority | -- You are receiving thi

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master V

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Depends on||27821 --- Comment #26 from

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #25 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #22) > Thanks for QAing this Marcel, your right, I should have detailed my testing > :(.. I basically looked at where the code changed and tried to trig

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #24 from Marcel de Rooy --- Can't call method "subtract" on an undefined value at /usr/share/koha/Koha/Patron.pm line 770 When dateexpiry == -00-00 But I did put it in explicitly ;) -- You are receiving this mail bec

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #23 from Martin Renvoize --- 142 when I reduce the query to only those fields that are nullable: SELECT Concat(col.table_name, '.', col.column_name), col.data_type FROM information_schema.columns col JOIN

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #22 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #19) > Although this looks quite good to me, it is really hard to be convinced that > all appearances of -00-00 in the data now are caught correctly

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl --

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added Attachment #117267|0 |1 is obsolete|

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added Attachment #117266|0 |1 is obsolete|

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are rec

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 f

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #18 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > Not sure about the change from reports/issues_avg_stats.pl Since returndate comes from oldissues and you sanitize the field in the atomic update,

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #17 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #13) > These patches appear to work as expected for me so signing off. Since there is no test plan, it would be beneficial for us to know what you exac

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #15 from Martin Renvoize --- (In reply to Owen Leonard from comment #14) > (In reply to Martin Renvoize from comment #13) > > > > In many places DataTable columns are sorted not by the value displayed but > the value in

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #14 from Owen Leonard --- (In reply to Martin Renvoize from comment #13) > In many places DataTable columns are sorted not by the value displayed but the value in the title attribute as seen above. Instances where "-

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- Yo

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #12 from Martin Renvoize --- Created attachment 117267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117267&action=edit Bug 7806: (follow-up) Update to use sanitize_zero_date Signed-off-by: Martin Renv

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize changed: What|Removed |Added Attachment #114528|0 |1 is obsolete|

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org ---

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2021-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are re

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #9 from Jonathan Druart --- Created attachment 114528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114528&action=edit Bug 7806: Fix remaining occurrences of -00-00 We should remove all SQL querie

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Depends on||26997 Referenced Bugs: h

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Depends on||27276 Referenced Bugs: h

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2020-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #7 from Jonathan Druart --- It could be useful to know if production DBs still contain such values (?) -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Katrin Fischer changed: What|Removed |Added Summary|Illegal dates are used to |Don't use -00-00 to