http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #93 from M. de Rooy ---
Created attachment 18877
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18877&action=edit
Bug 8190: Followup for opac-search
Script should not create a second logger object, but us
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #89 from M. de Rooy ---
Created attachment 18873
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18873&action=edit
Bug 8190: FIX Unit test
Set the KOHA_LOG environment variable in the test
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #92 from M. de Rooy ---
Created attachment 18876
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18876&action=edit
Bug 8190: Add the 'alert' level.
Signed-off-by: Jonathan Druart
Signed-off-by: Marcel de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #91 from M. de Rooy ---
Created attachment 18875
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18875&action=edit
Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to
OPAC Signed-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Patch complexity|Small patch |Medium patch
QA Contact|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #90 from M. de Rooy ---
Created attachment 18874
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18874&action=edit
Bug 8190: QA Followup
- Remove the private variables
- Remove the use of C4::Context in th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #88 from M. de Rooy ---
Created attachment 18872
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18872&action=edit
Bug 8190: raise an error if the Log::LogLite module is not installed
Signed-off-by: Kyle M
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #87 from M. de Rooy ---
Created attachment 18871
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18871&action=edit
Bug 8190: Follow Add some POD
Add POD and prefix private methods with _
Signed-off-by: Ky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Attachment #18799|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #85 from M. de Rooy ---
(In reply to comment #84)
> Did you add any logging code to an opac script to test it? I just added this
> to my opac-main.pl to test:
>
> C4::Context->logger->debug("This is a debug message");
> C4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
CC||kyle.m.h...@gmail.com
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #83 from M. de Rooy ---
(In reply to comment #81)
> Created attachment 18819 [details] [review]
> Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs
> to OPAC
I understand the changes for opac and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #82 from Jonathan Druart ---
Created attachment 18820
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18820&action=edit
Bug 8190: Add the 'alert' level.
Signed-off-by: Jonathan Druart
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #81 from Kyle M Hall ---
Created attachment 18819
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18819&action=edit
Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to
OPAC
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #80
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #79 from M
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
M. de Rooy changed:
What|Removed |Added
Attachment #16426|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #77 from M. de Rooy ---
Created attachment 18803
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18803&action=edit
Bug 8190: QA Followup
- Remove the private variables
- Remove the use of C4::Context in th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #74 from M. de Rooy ---
Created attachment 18800
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18800&action=edit
Bug 8190: Follow Add some POD
Add POD and prefix private methods with _
Signed-off-by: Ky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #76 from M. de Rooy ---
Created attachment 18802
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18802&action=edit
Bug 8190: FIX Unit test
Set the KOHA_LOG environment variable in the test
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #75 from M. de Rooy ---
Created attachment 18801
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18801&action=edit
Bug 8190: raise an error if the Log::LogLite module is not installed
Signed-off-by: Kyle M
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #72 from Jonathan Druart ---
Created attachment 16430
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16430&action=edit
Bug 8190: QA Followup
- Remove the private variables
- Remove the use of C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #71 from Jonathan Druart ---
Created attachment 16429
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16429&action=edit
Bug 8190: FIX Unit test
Set the KOHA_LOG environment variable in the test
Signed-off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #70 from Jonathan Druart ---
Created attachment 16428
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16428&action=edit
Bug 8190: raise an error if the Log::LogLite module is not installed
Signed-off-by: K
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #69 from Jonathan Druart ---
Created attachment 16427
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16427&action=edit
Bug 8190: Follow Add some POD
Add POD and prefix private methods with _
Signed-off-b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Attachment #14318|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Paul Poulain changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #67 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #14324|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #14388|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #14321|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #14320|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #62 from Jonathan Druart ---
(In reply to comment #57)
> There are five issues that absolutely must be fixed:
> 1) The ->debug() level needs to work.
It has always worked, see comment #49
> 2) Private variable need to be
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #61 from Jonathan Druart ---
Created attachment 14388
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14388&action=edit
Bug 8190: QA Followup
- Remove the private variables
- Remove the use of C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #60 from Chris Cormack ---
(In reply to comment #59)
> (In reply to comment #58)
> > If we are going to always access the logger object via C4::Context, we could
> > do this all without the need of a new module.
>
> That s
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #59 from Jared Camins-Esakov ---
(In reply to comment #58)
> If we are going to always access the logger object via C4::Context, we could
> do this all without the need of a new module.
That seems reasonable to me. Is ther
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--- Comment #58
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #57 from Jared Camins-Esakov ---
I think I favor Log4Perl over LogLite, since it allows us to cut down
dramatically on the amount of code that we are maintaining. However, I do not
have a strong opinion on that.
There are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #56 from Chris Cormack ---
Created attachment 14324
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14324&action=edit
DO NOT USE - Partial rewrite of Logger
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #55 from Chris Cormack ---
I started trying to tidy it, but didn't get super far, attached is the patch,
for interest sake.
I might try another approach if time allows.
--
You are receiving this mail because:
You are wat
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment #54 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Attachment #14296|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Attachment #14294|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Attachment #13926|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Attachment #13925|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #50 from Chris Cormack ---
Created attachment 14318
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14318&action=edit
Bug 8190: Koha::Utils::Logger, Logging module
use Koha::Utils::Logger qw/$log/;
$log =
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #49 from Jonathan Druart ---
Hi Katrin,
Yes it is normal.
Try with :
my $log = C4::Context->logger;
the constructor Koha::Utils::Logger->new takes a level parameter. If it does
not exist, the normal level is used.
C4:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #48 fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #47 from Jonathan Druart ---
(In reply to comment #46)
> (In reply to comment #44)
> > A quick start:
> > http://wiki.koha-community.org/wiki/Logger
>
> It seems to me that ->debug calls *should* be included in code commit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #46 from Jared Camins-Esakov ---
(In reply to comment #44)
> A quick start:
> http://wiki.koha-community.org/wiki/Logger
It seems to me that ->debug calls *should* be included in code committed to
Master. Isn't the entire
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #45 from Katrin Fischer ---
Hi Jonathan, thx for your work - still testing. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing li
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #44 from Jonathan Druart ---
A quick start:
http://wiki.koha-community.org/wiki/Logger
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #43
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #42 from Jonathan Druart ---
Created attachment 14296
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14296&action=edit
Bug 8190: FIX Unit test
Set the KOHA_LOG environment variable in the test
--
You ar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #41 fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #40 from Jonathan Druart ---
The patch displays a specific message if the module Koha::Utils::Logger raises
an error.
It is not a clean way but I don't know how to do this differently.
--
You are receiving this mail becau
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #39 from Jonathan Druart ---
Created attachment 14294
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14294&action=edit
Bug 8190: raise an error if the Log::LogLite module is not installed
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #38 from Katrin Fischer ---
Often the perl error message is more helpful, indicating that there is a
missing dependency. I think the way this explodes now is going to make us
answer lots of questions.
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #37 from Jonathan Druart ---
(In reply to comment #36)
> I have started testing this. I notice, that when you have
> liblog-loglite-perl not installed, Koha is unusable. And instead of giving
> you an error indicating what'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #36 from Katrin Fischer ---
I have started testing this. I notice, that when you have liblog-loglite-perl
not installed, Koha is unusable. And instead of giving you an error indicating
what's going wrong, it explodes with:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #13763|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Kyle M Hall changed:
What|Removed |Added
Attachment #13740|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Attachment #13762|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #32 from Jonathan Druart ---
Created attachment 13762
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13762&action=edit
Bug 8190: Follow Add some POD
Add POD and prefix private methods with _
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #31 from Paul Poulain ---
(In reply to comment #30)
Forget patch updated in comment 29, I forgot to squash the updatedatabase
changes:
> Bug 8190 follow-up moving updatedatabase part at the right place
the comment 30 patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Paul Poulain changed:
What|Removed |Added
Attachment #13739|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Paul Poulain changed:
What|Removed |Added
Attachment #12743|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Paul Poulain changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
Pa
77 matches
Mail list logo
