[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolutio

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Fridolin SOMERS changed: What|Removed |Added Depends on||18465 Referenced Bugs: h

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Version|18.05 |master -- You are receivin

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #34 from Marcel de Rooy --- Chris: You fixed the problem without clearing $image_data too. Further testing and looking at the code now helped me reach that conclusion. Sorry for the misunderstanding raised. What remains, i

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Attachment #76779|0 |1 is obsolete|

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Passed QA -- You are recei

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #32 from Marcel de Rooy --- I will finish this up Friday. No need to make it more difficult. This can wait until then. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #31 from Katrin Fischer --- I feel like Chris makes some valid points here when he says there is no proof that the additional changes are needed. We have tested this patch and found it to fix the problem we had reported. P

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #30 from Chris Nighswonger --- (In reply to Marcel de Rooy from comment #24) > (In reply to Chris Nighswonger from comment #22) > > (In reply to Marcel de Rooy from comment #19) > > > Chris: > > > I have the impression > >

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #29 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #28) > This is a privacy issue, I just didn't want it to die "in discussion". Yeah it is. No problem! Thx for following up.. Imo we are just clearing on

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #28 from Katrin Fischer --- This is a privacy issue, I just didn't want it to die "in discussion". -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #26) > I think setting back to SO after the dev has commented or provided a > follow-up is process-wise ok and standard - requires another check then by

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #26 from Katrin Fischer --- I think setting back to SO after the dev has commented or provided a follow-up is process-wise ok and standard - requires another check then by QA. -- You are receiving this mail because: You

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #25 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #23) > Pushing this back into the QA queue (for discussion between QA and developer > we usually don't use "In Discussion" - only when you can't agree) I

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 f

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #23 from Katrin Fischer --- Pushing this back into the QA queue (for discussion between QA and developer we usually don't use "In Discussion" - only when you can't agree) -- You are receiving this mail because: You are w

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Signed Off -- You are rece

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #22 from Chris Nighswonger --- (In reply to Marcel de Rooy from comment #19) > Chris: > I have the impression Just an impression? ;-) Did you test and find a case where this fix does not work? that you are clearing the

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What|Removed |Added Status|Failed QA |In Discussion --- Commen

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #20 from Marcel de Rooy --- (In reply to Chris Nighswonger from comment #17) > Some kind soul please correct the spelling of "relegated" on line 180 during > QA! Your kind soul? :) -- You are receiving this mail because:

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Cont

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA C

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What|Removed |Added Attachment #76690|0 |1 is obsolete|

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #17 from Chris Nighswonger --- Comment on attachment 76690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76690 This patch corrects referential problems which caused the script to "re-use" images as well

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You ar

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #16 from Chris Nighswonger --- Created attachment 76690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76690&action=edit This patch corrects referential problems which caused the script to "re-use" image

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What|Removed |Added Version|17.11 |18.05 -- You are receiv

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What|Removed |Added Priority|P5 - low|P1 - high St

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #15 from Katrin Fischer --- Yes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://l

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #14 from Chris Nighswonger --- (In reply to Christian Stelzenmüller from comment #13) > Here are the results from your requested query: > > > > > > > > > BSZ Bibliothek >text_alignment="L" />

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #13 from Christian Stelzenmüller --- Here are the results from your requested query: BSZ Bibliothek Ausweis -- You are receiving this mail because: You are w

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmu

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #12 from Chris Nighswonger --- Better yet, could someone(s) provide me with the results of the following query: SELECT layout_xml FROM creator_layouts\G -- You are receiving this mail because: You are watching all bug c

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #11 from Chris Nighswonger --- (In reply to Katrin Fischer from comment #8) > We've just seen this behaviour in 17.11. The problem seems to appear as soon > as another graphic in addition to the photo is added to the patro

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #10 from Chris Nighswonger --- (In reply to lightpurpledye from comment #6) > Possibly related: If the image file for one patron has a greater > horizontal:vertical ratio than the image file for the patron immediately > af

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #9 from Chris Nighswonger --- (In reply to Derryn from comment #0) > Steps to reproduce: > > 1. In the patron creator, set up a layout with patron images enabled > 2. Create a batch starting with a patron that does NOT ha

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What|Removed |Added Version|3.14|17.11 Severity|no

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #7 fr

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 lightpurple...@gmail.com changed: What|Removed |Added Version|3.8 |3.14 --- Comment #6

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #5 from Chris Nighswonger --- (In reply to lightpurpledye from comment #4) > Oops, I did mean create-pdf.pl, well spotted. > > I don't think I've misunderstood where images should be stored, however. I > only have one imag

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #4 from lightpurple...@gmail.com --- Oops, I did mean create-pdf.pl, well spotted. I don't think I've misunderstood where images should be stored, however. I only have one image in the creator_images table in the db, which

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #3 from Chris Nighswonger --- (In reply to lightpurpledye from comment #2) > This problem goes away if you comment out lines 152 - 159 of > /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif > ($images->{$

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 lightpurple...@gmail.com changed: What|Removed |Added CC||lightpurple...@gmail

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #1 from Chris Nighswonger --- Removing myself from the CC since I am the default assignee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bug

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What|Removed |Added CC|cnighswon...@foundations.ed | |u

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 gabrielle.dussea...@gmail.com changed: What|Removed |Added CC||cnighswon...@fo