https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Jonathan Druart changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Blocks|6427|
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Volkan Sonmez mvson...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|In Discussion |Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Passed QA |Pushed to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19137|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19138|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19139|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19140|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19141|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Blocks||10565
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #93 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to Galen Charlton from comment #92)
As far as the namespace questions are concerned, because of the potential
complexity, in my view an IRC meeting is not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #92 from Galen Charlton gmcha...@gmail.com ---
(In reply to Magnus Enger from comment #91)
(In reply to Paul Poulain from comment #89)
We spoke of it already, at KohaCon12 In Edinburgh, and on koha-devel. See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #91 from Magnus Enger mag...@enger.priv.no ---
(In reply to Paul Poulain from comment #89)
We spoke of it already, at KohaCon12 In Edinburgh, and on koha-devel. See
http://wiki.koha-community.org/wiki/Koha_Namespace_RFC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #88 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to Galen Charlton from comment #86)
I'm not seeing UTF8-releated breakage -- try running this program after
applying the squashed patch. The output (not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #89 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to Galen Charlton from comment #87)
I'm setting this bug back to 'In discussion', as I believe that the Unicode
issue that Paul was running into is a red
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #90 from Galen Charlton gmcha...@gmail.com ---
(In reply to Paul Poulain from comment #89)
I think we should focus on getting DBIx::Class::Schema::Loader support
ready, including sussing out any necessary schema updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #82 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 19249
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19249action=edit
DBIx::Class Branch.pm implementation
This package, and the test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #83 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 19250
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19250action=edit
DBIx::Class tests: replacing GetBranchName by it's DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Attachment #19137|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #84 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 19251
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19251action=edit
Testing DBIx::Class, continued
I tried to replace the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #86 from Galen Charlton gmcha...@gmail.com ---
I'm not seeing UTF8-releated breakage -- try running this program after
applying the squashed patch. The output (not counting a DBIx::Class::Carp
about the nullability of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19249|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19250|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #19251|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Marc VĂ©ron ve...@veron.ch changed:
What|Removed |Added
CC||ve...@veron.ch
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #67 from Kyle M Hall k...@bywatersolutions.com ---
Jonathan I had a short discussion about this patch DBIC: we have the
same question: what's the next step once this patch is pushed ? We need to
have clear directions,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #68 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #67)
Jonathan I had a short discussion about this patch DBIC: we have the
same question: what's the next step once this patch is pushed ? We
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #69 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #68)
On the other hand, a squashed patch could be uploaded for QA purposes, and
the individual patches pushed afterward. I think that should provide
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #70 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #66)
(In reply to comment #60)
Chris and I discussed this bug today and he's agreed to update the patch
series for master; I intend to push DBIC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #71 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #70)
What I propose is a multi-part process:
[1] Once DBIC support is pushed, along with at least one other patch that
uses it, we promote the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #72 from Kyle M Hall k...@bywatersolutions.com ---
[1] Once DBIC support is pushed, along with at least one other patch that
uses it, we promote the existence of it vigorous, with the aim of
encouraging folks to use it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #73 from Galen Charlton gmcha...@gmail.com ---
Paste of an IRC conversation with the maintainer of DBIX::Class today:
riba I wanted to comment on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 but didn't
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #74 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #71)
(In reply to comment #70)
I think it would be a reasonable goal to get to the point where, once the
cycle for 3.16 starts, DBIC is required for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #75 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #74)
My preference is that that every effort should be made when introducing a
DBIC-based method to remove the C4 function(s) that it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #76 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #72)
I agree with unit testable-ness for functions, but what about scripts? One
of the great reasons to have DBIC is we can just use find() or single()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #77 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #75)
(In reply to comment #74)
My preference is that that every effort should be made when introducing a
DBIC-based method to remove the C4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #78 from Kyle M Hall k...@bywatersolutions.com ---
I cannot agree more with this assertion. Koha scripts have often been too
'smart' for their own good ; )
Over time this has definitely improved with more and more logic
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #79 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #78)
I cannot agree more with this assertion. Koha scripts have often been too
'smart' for their own good ; )
Over time this has definitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #80 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #79)
tests of their core functionality can be easily written.
Test::www::Mechanize can also help us testing scripts in web-environment as
well. It's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #66 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #60)
Chris and I discussed this bug today and he's agreed to update the patch
series for master; I intend to push DBIC support unless some
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Blocks||10493
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #55 from Magnus Enger mag...@enger.priv.no ---
I think the digital signs in bug 8628 would be good candidates for testing
DBIC, and for them speed would not really be an issue either. But I'd need some
kind of guarantee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #56 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #55)
I think the digital signs in bug 8628 would be good candidates for testing
DBIC, and for them speed would not really be an issue either. But
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #59 from Kyle M Hall k...@bywatersolutions.com ---
Updating the schema files is trivial with this patch set (
misc/devel/update_dbix_class_files.pl ). I would say once this is pushed,
future patches that modify the database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #58 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19134
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19134action=edit
Bug 8798 - Add the use of DBIx::Class - Followup - Update schema
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #60 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #56)
(In reply to comment #55)
I think the digital signs in bug 8628 would be good candidates for testing
DBIC, and for them speed would not really be
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #17584|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #17585|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #17586|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19134|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #65 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 19141
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19141action=edit
Bug 8798 - Moving code to Koha::Database and adding tests
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Magnus Enger mag...@enger.priv.no changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #52 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #51)
I think the main objection to using DBIx::Class in Koha has been concerns
about speed? It looks like the newest release addresses that:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12480|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #46 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17582
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17582action=edit
Bug 8798 - Add the use of DBIx::Class - Rename schema class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #47 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17583
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17583action=edit
Bug8798 Updated to remove tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #17581|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #49 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17585
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17585action=edit
Bug 8798 - Add the use of DBIx::Class - Rename schema class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #50 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17586
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17586action=edit
Bug8798 Updated to remove tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
Blocks||6427
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #44 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #42)
After closely looking at bug 8309 it appears that this is a more closely
integrated solution.
Sorry Eliott, but I think I'm missing what you
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Status|RESOLVED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Status|REOPENED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #40 from Paul Poulain paul.poul...@biblibre.com ---
wajasu, ping again !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Priority|P5 - low|P3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Version|master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12480|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12480|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12520|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12506|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
wajasu matted-34...@mypacks.net changed:
What|Removed |Added
Attachment #12521|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #34 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 12506
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12506action=edit
[Follow-up] Updated to remove tabs
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #28 from Colin Campbell colin.campb...@ptfs-europe.com ---
(In reply to comment #24)
Wajasu perhaps it is a package oddity. Colin what are you testing on?
Should this prevent this from being signed off on?
No it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12453|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #30 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 12478
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12478action=edit
Added base class files for all tables in koha using the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12477|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
wajasu matted-34...@mypacks.net changed:
What|Removed |Added
Attachment #12478|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
wajasu matted-34...@mypacks.net changed:
What|Removed |Added
Attachment #12443|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
wajasu matted-34...@mypacks.net changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #25 from wajasu matted-34...@mypacks.net ---
Better news.
I got my fresh debian VM built. Here are may latest observations:
In the VM:
koha@biblio:~/kohaclone/local/lib/perl5/DBIx$ grep VER *
Class.pm:$VERSION =
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12442|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #27 from wajasu matted-34...@mypacks.net ---
i found a way to squelch the validation warning. in C4/Context.pm i put
$ENV{'DBIC_DONT_VALIDATE_RELS'} = 1; # FIXME once the DBIx schema has its
schema adjusted we should remove
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
wajasu matted-34...@mypacks.net changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Colin Campbell colin.campb...@ptfs-europe.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #7 from Elliott Davis elli...@bywatersolutions.com ---
Sure Colin! Thanks for reminding me.
Also Wajasu, You're right! I misspelled the package name. Must've had one too
many beers after dinner. Note to self, never
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
Elliott Davis elli...@bywatersolutions.com changed:
What|Removed |Added
Attachment #12405|0 |1
1 - 100 of 124 matches
Mail list logo