http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #28 from Kyle M Hall ---
This problem is actually an issue with Koha's transfer implementation, and is
not directly related to this feature.
(In reply to Olli-Antti Kivilahti from comment #26)
> Rotating collections test c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #29 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #21008|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #21010|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #23969|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #35 from Kyle M Hall ---
Created attachment 23971
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23971&action=edit
Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode
field
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #21011|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #21009|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #36 from Kyle M Hall ---
Created attachment 23976
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23976&action=edit
Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued
and waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Owen Leonard changed:
What|Removed |Added
Blocks||11595
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Joel Sasse changed:
What|Removed |Added
CC||jsa...@plumcreeklibrary.net
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #37 from Chris Cormack ---
(In reply to Kyle M Hall from comment #29)
> While I agree that we should try to add unit tests, these patches do not add
> any new perl subroutines. There are many existing modules that do not ha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Galen Charlton changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #38 fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #28140|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #39 from Kyle M Hall ---
Created attachment 28140
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28140&action=edit
Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link
collections.colBranchcode to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #41 from Kyle M Hall ---
(In reply to Galen Charlton from comment #38)
> More to the point, the collections.colbranchcode column is too narrow. It
> should be varchar(10) and a FK linking to the branches table. Failing Q
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #12 from Katrin Fischer ---
Hi Kyle, I noticed a problem in the rotating collections templates while
working on the po files: "[ editColDescription %]" in editCollections.tt.
--
You are receiving this mail because:
You ar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #14 from Kyle M Hall ---
Created attachment 19337
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19337&action=edit
Bug 8836 - Resurrect Rotating Collections - Followup 3 - Fix bad TT tag
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #19337|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #19339|Bug 8836 - Resurrect|Bug 8836 - Resurrect
des
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |new feature
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Nicole C. Engard changed:
What|Removed |Added
CC||neng...@gmail.com
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Chris Cormack changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #16746|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #19118|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #19119|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #20 from Kyle M Hall ---
Created attachment 21011
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21011&action=edit
Bug 8836 - Resurrect Rotating Collections - Followup 3
* Fix bad TT Tag
* Fix bad sql que
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #19339|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #21 from Katrin Fischer ---
Hi Kyle, the QA script found something:
FAILcirc/returns.pl
OK pod
OK forbidden patterns
FAIL valid
"my" variable $itemnumber masks earlier declaration in same sco
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Version|3.14|master
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Olli-Antti Kivilahti changed:
What|Removed |Added
CC||olli-antti.kivila...@jn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #23 from Magnus Enger ---
(In reply to Olli-Antti Kivilahti from comment #22)
> We need this functionality as well. Is there some way I can help?
More testing and another signoff never hurts. ;-)
--
You are receiving thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #24 from Katrin Fischer ---
You could test the feature some more and add an additional sign-off :)
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #25 from Olli-Antti Kivilahti ---
Could I have a test plan for this feature?
I have no idea where to start looking or how to operate this?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #26 from Olli-Antti Kivilahti ---
Rotating collections test case.
In "Tools" -> "Rotating Collections" -> "Add/Remove items":
When adding item barcodes to the collection, the input field
should become active
automatical
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Olli-Antti Kivilahti changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #27 from Olli-Antti Kivilahti ---
Also unit tests are required.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@li
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Juhani Seppälä changed:
What|Removed |Added
CC||jsep...@student.uef.fi
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #42 from Juhani Seppälä ---
Hello, we're looking at bringing this feature into production and I've been
going through this component - a trivial issue in additems.tt -template:
[% IF ( previousActionRemove ) %]
[% IF ( r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Nick Clemens changed:
What|Removed |Added
CC||n...@quecheelibrary.org
--
Yo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Juhani Seppälä changed:
What|Removed |Added
Attachment #23966|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Juhani Seppälä changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #46 from Juhani Seppälä ---
(In reply to Nick Clemens from comment #45)
> Could not apply on VM or sandbox
>
> Applying: Bug 8836 - Resurrect Rotating Collections - QA Followup
> Applying: Bug 8836 - Resurrect Rotating Col
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #47 from Juhani Seppälä ---
Created attachment 30921
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30921&action=edit
Bug 8836 - Resurrect Rotating Collections: additions
This is patch is an enchancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #23967|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Blocks||12807
--
You are receiving thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #49 from Kyle M Hall ---
The squashing was fine, except you removed my authorship from the patches! I've
uploaded a fixed version. In addition, your patch makes large changes, so I've
moved it to a separate bug and made thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #50 from Juhani Seppälä ---
(In reply to Kyle M Hall from comment #49)
> The squashing was fine, except you removed my authorship from the patches!
> I've uploaded a fixed version. In addition, your patch makes large change
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment #5
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #52 fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #31087|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #54 from Kyle M Hall ---
Created attachment 32362
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32362&action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported
--
You are receiving this mail b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #55 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #51)
> Hi Kyle, there have been lots of follow-ups on this, would you be ok with
> asking for another sign-off? This is a bigger one and I'd feel better with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Cindy Murdock Ames changed:
What|Removed |Added
CC||cmurd...@ccfls.org
--- C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #32361|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #58 from Kyle M Hall ---
Created attachment 32589
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32589&action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported
--
You are receiving this mail b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #32588|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #60 from Kyle M Hall ---
Created attachment 32691
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32691&action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported
--
You are receiving this mail b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Chris Cormack changed:
What|Removed |Added
Attachment #32691|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #62 from Cindy Murdock Ames ---
I was just about to sign off on them both--Chris you beat me to the punch!
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #63 from Katrin Fischer ---
Hi Cindy, if you want, we can add your sign off line in QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs m
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #64 from Cindy Murdock Ames ---
Yes, sounds good! Do I need to do it? Sorry, my git-fu is weak! Still
getting used to the signoff process.
--
You are receiving this mail because:
You are watching all bug changes.
_
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #65 from Katrin Fischer ---
I can do it - thx for testing :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
QA Contact||katrin.fisc...@bsz-bw.de
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Attachment #32690|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Medium patch
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #68 from Katrin Fischer ---
Created attachment 32774
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32774&action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported
Signed-off-by: Chris Cormack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #69 from Katrin Fischer ---
Just adding Cindy's sign-off line so we don't forget it :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #70 fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #71 from Cindy Murdock Ames ---
To address 2.1.1, I can write some documentation for it. Our libraries have
been using Rotating Collections for years.
--
You are receiving this mail because:
You are watching all bug chan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #72 from Katrin Fischer ---
Hi Cindy, thanks for the offer! Maybe you can also help with 2.6? I am not sure
there how it is intended to work.
--
You are receiving this mail because:
You are watching all bug changes.
_
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #32773|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Kyle M Hall changed:
What|Removed |Added
Attachment #32973|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #75 from Kyle M Hall ---
Created attachment 32975
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32975&action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported
Signed-off-by: Chris Cormack
Tr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #76 from Kyle M Hall ---
Created attachment 32976
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32976&action=edit
Bug 8836 [QA Followup 2]
--
You are receiving this mail because:
You are watching all bu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #77 from Kyle M Hall ---
I believe this followup should fix most all your issues. There is a small
visual bug with the alert divs that I'm hoping Owen can take a look at.
As far as the your functionality test, I think Cind
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #78 from Owen Leonard ---
Some issues I see:
- The list of collections should show a count of the
items in that collection
- Should collections require unique titles?
I was able to add multiple collections with the sa
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #79 from Owen Leonard ---
Another issue:
I happened to add to a collection an item which was already in mid-transfer
between two libraries. When I transferred that collection to another library
the in-progress transfer was
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #80 from Olli-Antti Kivilahti ---
Canceling an in-progress transport causes issues in real life.
When a book is being moved between cities, it is essential to know that the
item is on the move. When the Item in the rotating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #81 from Olli-Antti Kivilahti ---
(In reply to Owen Leonard from comment #78)
> Some issues I see:
>
> - The list of collections should show a count of the
> items in that collection
>
true
> - Should collections requi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #82 from Owen Leonard ---
(In reply to Olli-Antti Kivilahti from comment #81)
> > - Why are descriptions required?
> If we have a special rotating collection we want to tell about.
Yes, I can see why a description is a use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #83 from Owen Leonard ---
Created attachment 32994
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32994&action=edit
Bug 8836 [Template follow-up] Resurrect Rotating Collections
This follow-up makes drasti
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Brendan Gallagher changed:
What|Removed |Added
Attachment #32974|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Brendan Gallagher changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Brendan Gallagher changed:
What|Removed |Added
Attachment #32975|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Brendan Gallagher changed:
What|Removed |Added
Attachment #32994|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Brendan Gallagher changed:
What|Removed |Added
Attachment #32976|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #88 from Katrin Fischer ---
Kivilahti, please keep in mind that Juhani's work is on a separate bug 12807
and not included here. I'd suggest to break it into well documented easily
testable parts when rebasing for the change
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
--- Comment #89 from Katrin Fischer ---
I have gathered some information from reading through the comments on this bug,
could you confirm if the following assumptions are correct?
1) If I create a collection and transfer it, all avail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Katrin Fischer changed:
What|Removed |Added
Blocks||13177
--
You are receiving
1 - 100 of 164 matches
Mail list logo
