http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Chris Cormack changed:
What|Removed |Added
Keywords|Academy |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Tomás Cohen Arazi tomasco...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #58 from Fridolin SOMERS fridolin.som...@biblibre.com ---
(In reply to Tomás Cohen Arazi from comment #57)
But I'm not happy with this patchset, as it seems to touch CanBookBeIssued
This code has the same problem as
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Tomás Cohen Arazi tomasco...@gmail.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #56 from David Cook dc...@prosentient.com.au ---
(In reply to Nick Clemens from comment #55)
Not sure what needs to be done here, more than a signoff? Failing because of
Mark's test request
I think Katrin just rebased
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Status|Needs Signoff |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I've rebased the patches - could someone please take another look and try to
unravel any confusion? Thx!
--
You are receiving this mail because:
You are watching all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #50 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39456
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39456action=edit
Bug 9351 - item type not recorded correctly in statistics for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #35712|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39458
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39458action=edit
Bug 9351 - item type not recorded correctly in statistics for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39457
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39457action=edit
Bug 9351 - sql update on existing statistics
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #35713|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #35714|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #49 from David Cook dc...@prosentient.com.au ---
(In reply to Katrin Fischer from comment #48)
Hm, are you sure?
This patch corrects this problem by getting itemtype from $item-{'itype'}
which comes from item or
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #48 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, are you sure?
This patch corrects this problem by getting itemtype from $item-{'itype'}
which comes from item or biblio level in GetItem().
Maybe the reason is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #47 from David Cook dc...@prosentient.com.au ---
(In reply to Katrin Fischer from comment #46)
Ok, it works now alright for item-level itypes = specific item, but setting
the syspref to bibio level it still takes the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Attachment #34995|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Attachment #35578|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Attachment #34994|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #41 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 35578
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35578action=edit
Bug 9351 - item type not recorded correctly in statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #42 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to David Cook from comment #40)
(In reply to Katrin Fischer from comment #39)
Hm, bit confused.
I tested checkouts and returns with itemtype on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #40 from David Cook dc...@prosentient.com.au ---
(In reply to Katrin Fischer from comment #39)
Hm, bit confused.
I tested checkouts and returns with itemtype on the item level.
For returns the itype column in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
R. Crago ridingthegravytr...@yahoo.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #34818|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34995
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34995action=edit
[SIGNED-OFF] Bug 9351 - sql update on existing statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #23692|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #34 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 34819
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34819action=edit
Bug 9351 - sql update on existing statistics
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Depends on|11463
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
David Cook dc...@prosentient.com.au changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #32 from David Cook dc...@prosentient.com.au ---
I just tried out the following:
UPDATE statistics
SET itemtype =
(select u.itype from
(select itype,itemnumber from items
UNION ALL
select itype,itemnumber from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
How could we move things forward here?
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #29 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to Jonathan Druart from comment #28)
How could we move things forward here?
In my opinion, this bug opened a big discussion but the main purpose was to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
And what about updating existing DB values (comment 26)?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #27 from mathieu saby mathsaby...@gmail.com ---
(In reply to Fridolin SOMERS from comment #25)
(In reply to mathieu saby from comment #23)
I did not read all the comments, but for some libraries, what is needed in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #25 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to mathieu saby from comment #23)
I did not read all the comments, but for some libraries, what is needed in
statistical table is BOTH items.itype and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Maybe a configurable statistics field and itemtype according to the pref could
work too? This would give more flexibility to more uses cases and could be
solved outside
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #22 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I have set 11463 as dependency, but actually, other operations like checkout
uses GetItem() and then $item-{itype} in UpdateStats().
So this patch simply sets return
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #23 from mathieu saby mathsaby...@gmail.com ---
I did not read all the comments, but for some libraries, what is needed in
statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a
clear indication (a 3rd
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Depends on|9352
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #19 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to Chris Cormack from comment #17)
Without 9352 (which is failed QA) we cant push this as GetItem does not
respect the systempreference
I bet you meen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #20 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Fridolin SOMERS from comment #18)
(In reply to Chris Cormack from comment #16)
Comment on attachment 23692 [details] [review] [review]
Bug 9351 - item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz ---
Comment on attachment 23692
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23692
Bug 9351 - item type not recorded correctly in statistics for returns and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Depends on||9352
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #18699|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #14 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 23692
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23692action=edit
Bug 9351 - item type not recorded correctly in statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Pierre Angot tredok.pie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #18627|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #9)
And do you agree with the patch ?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|In Discussion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #18545|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #18626|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Patch complexity|Trivial patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|NEW
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Patch complexity|---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Severity|normal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
I set the importance to major because statistics are very important for
libraries.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #2)
Created attachment 18545 [details] [review]
Proposed patch
See commit message
Upon reading the patch, I think there's a problem -- it doesn't take
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |In
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
Fortunately, after the code is fixed, the statistics table can be readily
corrected. The following two statements should do it when item-level item
types are in effect:
UPDATE
82 matches
Mail list logo