http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 changed:
What|Removed |Added
Resolution|FIXED |---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Katrin Fischer changed:
What|Removed |Added
Resolution|---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Passed QA |Pushed to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #76 from Galen Charlton gmcha...@gmail.com ---
(In reply to Kyle M Hall from comment #68)
I could easily see the
Currency being Brazilian real while the ISO code would be BRL.
Note that currency.currency is only a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #27391|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #73 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27658
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27658action=edit
[PASSED QA] Bug 9593 [QA Followup]
Signed-off-by: Katrin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #74 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am still a bit torn about this patch and the new column. I think we need a
follow up to clean up the sample files at least.
Also the new field being mandatory means
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #27124|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #71 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 27392
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27392action=edit
Bug 9593 [QA Followup]
--
You are receiving this mail because:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #68 from Kyle M Hall k...@bywatersolutions.com ---
- I think the note on the currency page is misplaced. It would be better
using a diferent styling (similar to other hints) below the table.
I agree with this. In
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #69 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I wanted to note it - adding the column is ok with me.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #67 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Just 2 notes about this, leaving final QA to Kyle:
- I think the note on the currency page is misplaced. It would be better using
a diferent styling (similar to other
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #27006|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #27123|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #26125|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #63 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 27009
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27009action=edit
Bug 9593 - Additional Unit Tests
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Signed Off |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:
What|Removed |Added
Attachment #25984|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #24086|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Patch doesn't apply |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff |Patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #23580|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathsaby...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #22820|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #54 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
oups ! I meant in order that any currency sign COULD BE captured
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #52 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hello Olivier
I think it's the idea...
But the idea of UT is also to test different configuraton. So, you should not
only test
my $PRICE_STRING='25.5 EUR, $32, $LD35';
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #51 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I know very few about unit test. Would something like that do the trick ?
#!/usr/bin/perl
use strict;
use warnings;
use C4::Biblio;
use Test::More tests=1;
# start
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Signed Off |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #22541|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #50 from mathieu saby mathieu.s...@univ-rennes2.fr ---
It was signed off the 26th september by C.Croullebois, in comment 41,
(attachment 21477), but a new patch was added the 21st october
'attachment.cgi?id=22151) without
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
I'm just a bot git...@bugs.koha-community.org changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #22151|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Patch doesn't apply |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #21477|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Christophe Croullebois christophe.croulleb...@biblibre.com changed:
What|Removed |Added
Attachment #21274|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #42 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hey Christophe
I posted this one the same minute as yours and there was a collision !. I saw
you just signed off but here is my comment nevertheless :
I tested the string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Christophe Croullebois christophe.croulleb...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
I'm just a bot git...@bugs.koha-community.org changed:
What|Removed |Added
When did the bot|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #18640|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Patch doesn't apply |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
I'm just a bot git...@bugs.koha-community.org changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Version|3.14|master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|In Discussion |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #18070|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #34 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I made again test D, but WITHOUT your patch.
GB Pound as active currency ; rates : 1 £ = 10 $ = 5 € ; selecting Euro
currency in addorderiso2709.pl (in Accounting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #31 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hello.
I tested your 2d patch.
It needs to be rebased (conflict in updatedatabse, and need to remplace
3.11.XXX by 3.13.XXX)
The result is the same, except for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #32 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Olivier,
With your 2d patch, I made 4 tests, with a batch of 19 records (I join them)
tva: 0
discount : 5%
test A : Euro as active currency, all currency rates = 1 ;
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #33 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18405
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18405action=edit
19records-testSaby-20130425
the records I used for testing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #29 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18265
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18265action=edit
Bug 9593 Prices not imported correctly (plus conversion)
My opinion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #30 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I will take a look tomorrow.
we don't use it either in Rennes2, and I think no french library is using it.
Maybe you can ask the question on koha list.
Mathieu
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
Status|Needs Signoff |In
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #25 from mathieu saby mathieu.s...@univ-rennes2.fr ---
My 1st test, just to check the new behavior of currency module
= seems ok
My test plan:
1. $perl installer/data/mysql/updatedatabase.pl
Upgrade to 3.11.00.XXX done
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Following of my test :
add currencies matching codes and symbols in your records
CANADA 1.0 $ CAN
DOLLAR 1.0 $ USD
EGYPT 1.0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #27 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hey Mathieu,
My god, you are everywhere !
fallen in a magic potion barrel when a baby ?
As for Chateaubriand case, it's a normal result with euro as active currency
because
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #28 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I did not read all your description, I must confess ;-)
Not sure to agree with this behavior if it is a new one.
I think it should be :
- in Koha, 3 currencies =
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #17949|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #24 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18075
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18075action=edit
sample_multicurrencies
--
You are receiving this mail because:
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Version|master |3.14
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #17923|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #17948|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Olivier, could you be more explicit in your commit message about what exactly
your patch is supposed to do, and add a test plan ?
Mathieu
--
You are receiving this
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #15615|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #19 from Kyle M Hall kyle.m.h...@gmail.com ---
Comment on attachment 17923
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17923
Bug 9593 Prices not imported correctly from a staged file
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #16 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I wanted to make some tests to see how your patch is dealing exactly with $ and
€.
But I got a nasty error in master when I wanted to add orders : 'Can't use
string ()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #15 from mathieu saby mathieu.s...@univ-rennes2.fr ---
This is a VERY annoying bug for us. So does something be done to pass QA, or
not ?
M. Saby
--
You are receiving this mail because:
You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #14 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hello,
I'm not sure to understand. This new patch actually handles prices like $2 and
$€ : if you have a '$2' input price, it returns '2'. Is it not what is expected
?
I add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 15615
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15615action=edit
Bug 9593 Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
Attachment #15587|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #15270|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #9 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 15569
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15569action=edit
some records to test
--
You are receiving this mail because:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Status|In Discussion |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hello Sonia
Biblibre told me they were working on a patch, and that your solution was maybe
not the best. But they don't seem to take part in the discussion...
I am
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #4 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
(En réponse au commentaire 3)
My solution was changing these lines in MungeMarcPrice routine:
- ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/;
+ ( $price ) = $price
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hello
Your solution will not work on prices with such pattern as :
1 000 EUR :
To get it work you must add a space in first alternative here
( $price ) = $price
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 15270
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15270action=edit
Bug 9593 Prices not imported correctly from a staged file
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
Koha Team Lyon 3 k...@univ-lyon3.fr changed:
What|Removed |Added
Attachment #15269|Prices not imported
1 - 100 of 103 matches
Mail list logo