http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #42 from M. de Rooy ---
(In reply to comment #40)
> Still found a little issue with my change: sometimes supplier contains the
> search string, but sometimes the bookseller id numeric already.
Resolved: added both ways in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Attachment #18214|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #40 from M. de Rooy ---
Still found a little issue with my change: sometimes supplier contains the
search string, but sometimes the bookseller id numeric already.
Will have a quick look :)
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Jared Camins-Esakov changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Jared Camins-Esakov changed:
What|Removed |Added
Status|Pushed to Master|In Discussion
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #38 from M. de Rooy ---
This *trick* would not really involve a string change (for emphasis).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #37 from M. de Rooy ---
Created attachment 18214
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18214&action=edit
Bug 9824: Followup for removing filter
Adds allbaskets parameter to GetBasketsInfosByBooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #36 from M. de Rooy ---
Default should probably include the open baskets too, that could be excluded in
the current change (as noted in the QA comment) if they have no order lines or
if it is reopened but everything is rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #35 from mathieu saby ---
In Rennes 2, we agree the default behavior MUST be changed, and we are fine
with this patch being pushed in master.
The only remark is that MAYBE it could be useful for a lib, or the chief
librari
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #34 from Koha Team Lyon 3 ---
I'm sorry but using acquistions module for gift is a sort of diversion, no ?
If this change is introduced not for the proper use, i'm not sure it's a good
idea..
Sonia
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #33 from Koha Team Lyon 3 ---
"no one who upgraded from 3.6 noticed the change until this March"
I can say that my colleagues noticed and come to complain very often !!
I know that Lyon2 university had to change all the ven
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #32 from Jared Camins-Esakov ---
(In reply to comment #31)
> (In reply to comment #26)
> Am I missing something ?
> Koha > Acquisitions > Order search > Advanced search > enter basket # in
> basket field, and you'll get all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #31 from Paul Poulain ---
(In reply to comment #26)
> This patch has been pushed to master and 3.12.x.
>
> I have serious reservations about this patch, but am pushing it anyway as it
> simply reverts Koha to its previous
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #30 from Jared Camins-Esakov ---
(In reply to comment #27)
> I have been thinking about this for a while now and I can see that it's
> problematic because the old behaviour has been broken quite a while ago and
> now it cou
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #29 from Katrin Fischer ---
That sounds nice - as long as we get something. I think having the shorter list
(limited to 'unfinished' baskets) might be a good default, but have an option
to show all/pending/open/closed baske
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #28 from mathieu saby ---
For 3.12.1, what about a filter on the left of the page, giving ability to
choose to display received/pending/closed/open baskets, according to the whish
of the librarians ?
M. Saby
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #27 from Katrin Fischer ---
I have been thinking about this for a while now and I can see that it's
problematic because the old behaviour has been broken quite a while ago and now
it could be a problematic change for other
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Jared Camins-Esakov changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Attachment #18168|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #24 from M. de Rooy ---
QA Comment:
Works fine. My only question was: How to find back this basket if it is no
longer on that list. But with Order search or its Advanced Search, you can
still find it.
Small patch. No compla
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
QA Contact|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
M. de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Owen Leonard changed:
What|Removed |Added
Attachment #16639|0 |1
is patch|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #22 from Owen Leonard ---
Created attachment 18168
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18168&action=edit
[SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by
bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #21 from Katrin Fischer ---
Hm I have done some research. The change discussed here was made when the
result list for vendors was redone and GetBasketsInfosByBookseller was
introduced
(http://git.koha-community.org/gitweb/?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #20 from mathieu saby ---
Sorry, Firefox is playing with me this morning...
So, in my opinion, the goal of Lyon 3 patch is good - showing only useful
information in basket lists - , but I am not sure to like the way it is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #19 from mathieu saby ---
In my opinion,
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #18 from Katrin Fischer ---
Hi Owen, reading your comments I see you tested this - is this ready for sign
off or is there a problem?
--
You are receiving this mail because:
You are watching all bug changes.
__
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #17 from Katrin Fischer ---
Hi Owen,
I'd really like to see the regression here fixed so that we are only showing
baskets with outstanding orders by default, but a link to show more would
certainly not hurt. Maybe we could
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Owen Leonard changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Owen Leonard changed:
What|Removed |Added
Version|3.10|master
--- Comment #16 from Ow
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #15 from Owen Leonard ---
This patch doesn't apply for me through git-bz, but did apply using "git am
-i3u" after saving the patch. I just wanted to mention it if others are testing
too.
It works correctly to hide baskets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Koha Team Lyon 3 changed:
What|Removed |Added
Attachment #16639|application/octet-stream|text/plain
mime t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Koha Team Lyon 3 changed:
What|Removed |Added
Attachment #16168|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Paul Poulain changed:
What|Removed |Added
Severity|enhancement |normal
--
You are receiving t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Paul Poulain changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Sophie MEYNIEUX changed:
What|Removed |Added
CC||neng...@gmail.com
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #12 from Koha Team Lyon 3 ---
It's always booksellers.pl which is called whatever you go in result list or
you choose "baskets" in vendor page.
In order search, you can search by vendor and you will find all the orders with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #11 from Pierre Angot ---
I'm anticipating some questions from our librarian colleagues. They might ask
us how to see all baskets from a vendor. I think it would be difficult for them
to use acquisition module.
If all recev
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #10 from Katrin Fischer ---
I had no time looking for it, but I think this is actually fixing a regression.
It used to be so that you won't see any baskets that had been fully received in
the vendor result list. Then that g
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Pierre Angot changed:
What|Removed |Added
CC||tredok.pie...@gmail.com
--- Co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #7 from Koha Team Lyon 3 ---
In reply of comment 3 : Mathieu I don't understand your "death by
overbasketing" (we should talk about this yesterday...)
For basketgroups, we can do another patch...
Sonia
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Koha Team Lyon 3 changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #6 from Koha Team Lyon 3 ---
Created attachment 16639
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16639&action=edit
Hide-basket-with-no-expected-items-in-basqket
--
You are receiving this mail because
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #5 from Blain Laurence ---
tested on sandbox biblibre
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs m
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Blain Laurence changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
mathieu saby changed:
What|Removed |Added
CC||mathieu.saby@univ-rennes2.f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #2 from Koha Team Lyon 3 ---
Before patch you will see in acqui/booksellers.pl all the baskets ever created.
After the patch you will see in acqui/booksellers.pl only the basket with
expected items.
Test plan :
* Create a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
Koha Team Lyon 3 changed:
What|Removed |Added
Status|NEW |Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824
--- Comment #1 from Koha Team Lyon 3 ---
Created attachment 16168
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16168&action=edit
change sql query in GetBasketsInfosByBookseller
--
You are receiving this mail becau
55 matches
Mail list logo
