Bernardo,
It's ok that some test of
>
> prove t/
> prove t/db_dependent
> prove xt/author
>
> fail even in a clean master?
>
No unit tests should be failing on master. However, since they're passing
on both jenkins and my server it is probably just a data issue, which means
you can probably sign
Le 11/01/2013 18:08, Bernardo Gonzalez Kriegel a écrit :
> Hello,
> just trying to do a sign-off following
> http://wiki.koha-community.org/wiki/Sign_off_on_patches
>
> It's ok that some test of
>
> prove t/
> prove t/db_dependent
those one probably fail because you don't have the expected datas.
Paul,
OTOH: signing-off is checking that the feature works fine. It's the QA
> team that will be in charge to check unit tests.
> (Of course, if a patch contains a unit test itself, you should not
> signoff until you've successfully run it ;-) )
>
Signing off is both checking that a feature works
Paul and Jared,
It seems that my 'clean' master was not that clean.
I do a new clone, and the errors I found on master can be attributed to
some missing sample data and a problem I have with Test::Pod::Spelling
So now I know what to expect.
Anyway, I was just trying to obey the rules.
Thank you
Hi,
On Fri, Jan 11, 2013 at 9:37 AM, Jared Camins-Esakov <
jcam...@cpbibliography.com> wrote:
> Signing off is both checking that a feature works and -- hopefully --
> considering whether there are any bigger problems with it, such as
> regressions, to the extent that the developer is able to do
Many +1s here as well.
Kind Regards,
Chris
On Fri, Jan 11, 2013 at 1:36 PM, Galen Charlton wrote:
> Hi,
>
> On Fri, Jan 11, 2013 at 9:37 AM, Jared Camins-Esakov <
> jcam...@cpbibliography.com> wrote:
>
>> Signing off is both checking that a feature works and -- hopefully --
>> considering wheth
+1 :)
-Original Message-
From: koha-devel-boun...@lists.koha-community.org on behalf of Chris Nighswonger
Sent: Fri 11.01.2013 19:45
To: Galen Charlton
Cc: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Failed unit test
Many +1s here as well.
Kind Regards,
Chris
On Fri,
Dear Koha kommunitarians,
I'm harvesting news for this month's newsletter. Please send me by the 20th
anything you think your fellow community members might like to know about.
"News" can be as short as a sentence or as long as a paper. I especially
encourage you to send me a line or two for the
