+1 for using 'Patch complexity'
'Patch complexity' gives a hint for singing off as well. While signing
off I fill it in most of the cases. Sometimes I forget it, though...
Marc
Am 30.03.2017 um 08:34 schrieb Marcel de Rooy:
I always fill patch complexity. Also for patches that I qa.
And not
> A one line patch can be much more complex than a 1k lines patch
¯\_(ツ)_/¯
Now you got me curious. Can you provide an example of this? For
research purposes :-)
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community
Hi,
it looks like I am done submitting and backporting dependencies for
Koha and Elasticsearch 5.x. I ran it in a test repo and it works as
far as I can see.
Adding them to the unstable repository may or may not break
Kohadevbox and other setups, so I thought I'd give you a warning
before I do th
Bug 15760, 13690 are about Koha::Schema. They are very small but they fix
global problems and can have big side effects.
Patches that add external JS libs, move files, update less/css, or thing
like bug 9978 are huge but are easy to review
On Thu, 30 Mar 2017 at 08:58 Cab Vinton wrote:
> > A one
Awesome. It will get simpler then.
El jue., 30 mar. 2017 a las 12:29, Mirko Tietgen ()
escribió:
> Hi,
>
> it looks like I am done submitting and backporting dependencies for
> Koha and Elasticsearch 5.x. I ran it in a test repo and it works as
> far as I can see.
>
> Adding them to the unstable
> Bug 15760, 13690 are about Koha::Schema. They are very small but they fix
> global problems and can have big side effects.
> Patches that add external JS libs, move files, update less/css, or thing
> like bug 9978 are huge but are easy to review
Ah, OK. Makes sense. Thank you, Jonathan!
Thanks, Barton. As Jonathan pointed out, other people noticed this far before
me, but I’m not sure it’s really been discussed much.
I’ve filed a bug at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336.
I haven’t checked Zebra, but I assume that it’s OK. That’s a good ques
