Re: [Koha-devel] Fixing perltidy in ktd

2023-03-09 Thread David Cook
riginal Message- From: Mason James Sent: Tuesday, 14 February 2023 1:41 PM To: Kyle Hall ; David Cook Cc: koha-devel@lists.koha-community.org; Tomas Cohen Arazi Subject: Re: [Koha-devel] Fixing perltidy in ktd hi David, i ran perltidy -nopro on debian/scripts/koha-log4perl the brackets and whitespa

Re: [Koha-devel] Fixing perltidy in ktd

2023-02-13 Thread Mason James
hi David, i ran perltidy -nopro on debian/scripts/koha-log4perl the brackets and whitespace changes look 'as expected' to me... https://git.kohaaloha.com/?p=ktd_koha/.git;a=commit;h=c3324709c9c86e8241b7010e99e6628ac9677345 https://git.kohaaloha.com/?p=ktd_koha/.git;a=commitdiff;h=c3324709c9c

Re: [Koha-devel] Fixing perltidy in ktd

2023-02-13 Thread Kyle Hall
I believe we use the default perltidy settings ( https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy ). I'm not aware of KTD having an installed perltidyrc ( there is one in git in xt that's been in there since 2008 presumably unused ). Kyle --- http://www.kylehall.info ByWater

[Koha-devel] Fixing perltidy in ktd

2023-02-12 Thread David Cook
Hi Tomas, I saw you, Katrin, and Jonathan writing in #koha about perltidy. When I've tried previously to perltidy in ktd using the ":Tidy" command, it seemed to change the style to something incompatible with https://wiki.koha-community.org/wiki/Coding_Guidelines If I type "vi Koha.pm", the