On 2012-11-2, at 10:34 PM, Jonathan Druart wrote:
> Hi!
>
> Looks good to me in the principle.
>
> But are you sure there is a space at the end of the following string?
> +s/^Subroutine .* redefined $// for @errors;
yes, there is a trailing space
>
> I still don't see the point in using
Hi!
Looks good to me in the principle.
But are you sure there is a space at the end of the following string?
+s/^Subroutine .* redefined $// for @errors;
I still don't see the point in using Smart::Comments. For me it is just
debug messages and it is not intended to be in the master branch
On 2012-11-2, at 8:15 AM, Chris Cormack wrote:
> There is now a repository on git.koha-community.org too
>
> http://git.koha-community.org/gitweb/?p=qa-test-tools.git;a=summary
>
> Chris
thanks Chris, i'll start pushing to there, from today
(i;ll probably leave the github/kc.org repo up, as
There is now a repository on git.koha-community.org too
http://git.koha-community.org/gitweb/?p=qa-test-tools.git;a=summary
Chris
--
Chris Cormack
Catalyst IT Ltd.
+64 4 803 2238
PO Box 11-053, Manners St, Wellington 6142, New Zealand
signature.asc
Description: Digital signature
__
On 2012-10-25, at 3:56 PM, Mason James wrote:
>
> heya Jonathan
>
> thanks for this, ill do some testing then push your changes up to the kc.org
> github repo
fyi: I've done this, and changed the repo name as promised
its now 'koha-qa-test', not 'koha-qa-tool'
-> https://github.com/Koha-Co
On 2012-10-25, at 7:45 PM, Paul Poulain wrote:
> Le 25/10/2012 04:58, Chris Cormack a écrit :
>>>
>>> thanks for this, ill do some testing then push your changes up to the kc.rg
>>> github repo
>>> https://github.com/Koha-Community/koha-qa-tools
>>>
>> Can we get Galen to set up a repo at the
Le 25/10/2012 04:58, Chris Cormack a écrit :
>>
>> thanks for this, ill do some testing then push your changes up to the kc.rg
>> github repo
>> https://github.com/Koha-Community/koha-qa-tools
>>
> Can we get Galen to set up a repo at the official Koha community git
> repo (git.koha-community.org)
>
> thanks for this, ill do some testing then push your changes up to the kc.rg
> github repo
> https://github.com/Koha-Community/koha-qa-tools
>
Can we get Galen to set up a repo at the official Koha community git
repo (git.koha-community.org) and have these tools there too?
github is nice for a
On 2012-10-25, at 1:40 AM, Jonathan Druart wrote:
> Hi Mason,
>
> I did not rebase my qa-tools repo and I found a bug in the check of
> perlcritic.
> So I fixed it and ... I was not able to push, I was not up-to-date :)
>
> In fact you already tried to fix it in the commit "fixed perlcritic te
