Re: [Koha-devel] French sysprefs file encoding

On Sat, Dec 13, 2008 at 8:41 PM, Jesse Weaver wrote: > Hello, > > I noticed that various patches to the systempreferences creation SQL script > for French have been in the Latin-1 encoding. The base encoding for the file > is UTF-8. Hi Jesse - Thanks for the notice. So, what do we need to do goi

Re: [Koha-devel] Git whitespace whining

On Thu, Dec 4, 2008 at 3:25 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > I propose we disable it. I think: "git-config core.whitespace=nowarn" will do that for you. if not, something really similar will. hope it helps. -Andy ___ Koha-devel mailin

Re: [Koha-devel] Koha PEOPLE Efficiency [WAS: RFC: Koha : Merge biblio & biblioitems tables]

On Wed, Nov 26, 2008 at 7:06 AM, Andrew Moore <[EMAIL PROTECTED]> wrote: > * We have a growing test suite which is run nightly by a cronjob. The > reports are sent to a smolder server for easy viewing > <http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=blob;f=xt/perltid

Re: [Koha-devel] Koha PEOPLE Efficiency [WAS: RFC: Koha : Merge biblio & biblioitems tables]

On Tue, Nov 25, 2008 at 5:40 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > > > I am *VERY* concerned about people performance. To wit: Hi Rick - I'm thankful for your rant. Not only do I agree that we're suffering from some technical debt that makes contributions more difficult, time consuming,

Re: [Koha-devel] mod_perl (was: DBIx::Class stuff)

On Sat, Nov 22, 2008 at 7:24 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Joshua Ferraro wrote: > >> Speed is definitely a major concern here ... and I believe it's one of >> the reasons that Koha originally wasn't written with an ORM. Andy, any >> thoughts about what this choice will mean w/res

Re: [Koha-devel] [RFC ver2 4/4] DBIx::Class - Changes to C4::Members to start using DBIx::Class

On Sat, Nov 22, 2008 at 12:16 PM, Chris Cormack <[EMAIL PROTECTED]> wrote: >>> I donot want to slow down things. But I want to be sure that what we >>> choose is the best alternative to fit our requirements. >> Speed is definitely a major concern here ... and I believe it's one of >> the reasons th

Re: [Koha-devel] [RFC ver2 4/4] DBIx::Class - Changes to C4::Members to start using DBIx::Class

On Sat, Nov 22, 2008 at 1:04 AM, Henri-Damien LAURENT <[EMAIL PROTECTED]> wrote: > Hi > you are doing a great job documenting and investigating. Thank you. I > still had no time investigating or testing. But I am very glad of such a > plan to get an ORM in Koha. > > Looking at the page you link to

Re: [Koha-devel] [RFC ver2 4/4] DBIx::Class - Changes to C4::Members to start using DBIx::Class

On Tue, Nov 11, 2008 at 10:24 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Oh .. where are these RFCs and how may I contribute? So far, they have consisted only of these emails I've been sending out from git. They contain a "0" patch that contains no code, but just documentation. Then the patch

Re: [Koha-devel] Tab stops in source code

On Thu, Nov 13, 2008 at 12:45 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > > As far as a standardised .perltidyrc, my only comment is "please > explain!" Hi again, Rick - perltidy is a tool that attempts to format perl code in a consistent way. That .perltidyrc file sets most things to the def

Re: [Koha-devel] Tab stops in source code

On Thu, Nov 13, 2008 at 12:45 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > May I assume then that the answer to tab stops is: > > (*) yes, use them to indent That doesn't seem to be historically the most preferred method. Here are some statistics (that are probably lying in some way): number o

Re: [Koha-devel] Tab stops in source code

On Wed, Nov 12, 2008 at 8:15 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Hi all > > In the file abort.pl in Koha 3 I see the follow cryptic comment: > > # Please use 8-character tabs for this file (indents are every 4 characters) > > Does this mean that tabs should not be used for indentation,

Re: [Koha-devel] Class::DBI vs DBIx::Class

On Thu, Nov 6, 2008 at 6:32 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > It seems that DBIx::Class grew out of Class::DBI and might be more > sophisticated for our purposes. > > There is a perl monks comparison of these two here: > > http://www.perlmonks.org/?node_id=700283 > > with some pros an

[Koha-devel] [RFC ver2 3/4] DBix::Class - moving C4::ClassSource over to using DBIx::Class

This is an example of replacing the SQL calls in the first half of the C4/ClassSource.pm file with calls to the DBIx::Class schema object. I used this module as an example because it's rather simple and you can see how the more simple SQL operations can get replaced by calls to the schema object.

[Koha-devel] [RFC ver2 1/4] DBIx::Class - new C4::Schema object and program to manage C4::Schema::* objects

This patch includes a misc/bin/make_schema.pl program that uses DBIx::Class::Schema::Loader to read the database and produce some modules that act as an interface to it. This program is designed to be run each time we change the schema definition in kohastructure.sql and updatedatabase.pl. It manag

[Koha-devel] [RFC ver2 0/4] use DBIx::Class ORM for database access

etd in hearing about how we could use DBIx::Class differently, other alternatives to it, or why we should not persue this type of tool at all. Thanks! -Andy Andrew Moore (5): DBIx::Class - ACM-DEVELOPMENT: adjusting t/Makefile to find private library - DO NOT COMMIT DBIx::Class - new C

[Koha-devel] [RFC ver2 4/4] DBIx::Class - Changes to C4::Members to start using DBIx::Class

Here are some changes that can be made to the C4::Members class to start moving away from writing our own SQL and towards using the C4::Schema object built with DBIx::Class. Though I haven't replaced many methods in this class, I'm chosing this one because it's more complex than the C4::ClassSourc

[Koha-devel] [RFC: DBIx::Class 2/3] DBix::Class - moving C4::ClassSource over to using DBIx::Class

This is an example of replacing the SQL calls in the first half of the C4/ClassSource.pm file with calls to the DBIx::Class schema object. I used this module as an example because it's rather simple and you can see how the more simple SQL operations can get replaced by calls to the schema object

[Koha-devel] [RFC: DBIx::Class 0/3] use DBIx::Class ORM for database access

me to make forward progress on this. I was hoping that I was not the only one looking for something like this. Andrew Moore (4): DBIx::Class - adjusting t/Makefile to find private library DBIx::Class - new C4::Schema object DBix::Class - moving C4::ClassSource over to using DBIx::Class

[Koha-devel] [RFC: DBIx::Class 3/3] DBIx::Class - Changes to C4::Members to start using DBIx::Class

Here are some changes that can be made to the C4::Members class to start moving away from writing our own SQL and towards using the C4::Schema object built with DBIx::Class. Though I haven't replaced many methods in this class, I'm chosing this one because it's more complex than the C4::ClassSourc

[Koha-devel] [RFC: DBIx::Class 1/3] DBIx::Class - new C4::Schema object

This first patch contains a C4::Schema object, which is a subclass of a DBIx::Class class that reads the database and figures out the schema from there. It can eventually be our interface into the database, replacing the SQL that we write. There are other ways to write this. Alternative suggestio

Re: [Koha-devel] RFC 3.2 - turn on warnings

On Fri, Aug 29, 2008 at 11:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > I agree, except for query logging. It has been proven many times to me > that it's usefull : the library tells you "I search this, and got no > results, there's a bug in koha". > You look in the logs, and see that the searc

[Koha-devel] [RFC] Using Log4perl to extend and improve logging and debugging

NOTE: This is an RFC patch. I don't expect it to be directly applied to your system, and please don't apply it to the main Koha repository! Here is an example of how we can use Log4perl to extend (and hopefully improve) our current logging methods. I'm hopeful that this does a few things for us:

Re: [Koha-devel] On the way to the Debian package

On Tue, Aug 19, 2008 at 6:26 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: >> Another problem of the current code is that all manpages generated from >> koha perl modules are invalid. They are missing the required head lines. >> I put in http://www-id.imag.fr/~danjean/lintian.txt the warnings of >>

Re: [Koha-devel] koha-3.00.00 make fails

On Sat, Aug 16, 2008 at 9:31 AM, Jesse Weaver <[EMAIL PROTECTED]> wrote: > It sounds like there might be problems with DNS (/etc/hosts not having your > hostname); could you report on the result of this command? > > $ perl -e 'use Sys::Hostname; use Socket; print hostname() . "\n"; print > gethostb

Re: [Koha-devel] RFC: setting up a test server

On Fri, Aug 8, 2008 at 3:56 PM, Andrew Moore <[EMAIL PROTECTED]> wrote: > I'm interested in setting up a system to run our test suite regularly > and alert us of the results. The results from this appear to be: 1 in favor, 0 opposed. I consider this a landslide victory! I'

Re: [Koha-devel] Email::Date module

Hi Clay - Based on the changelog for Emai::Date, I can't see anything immediately threatening: Email::Date is actually just a dependency because it's required by MIME::Lite. As long as that's happy, I think Koha will be, too. I recommend

Re: [Koha-devel] [Koha-translate] Call for Translation Manager

On Mon, Aug 11, 2008 at 3:49 PM, Chris Cormack <[EMAIL PROTECTED]> wrote: > I'd like to throw my name into the ring for this role. I have cleared > it with my boss, and I have the ok to use some of the infrastructure > at work for hosting etc. Thanks for volunteering, Chris. You get my vote. -And

Re: [Koha-devel] Call for volunteers - Koha Documentation Manager

On Tue, Aug 12, 2008 at 10:50 AM, Nicole Engard <[EMAIL PROTECTED]> wrote: > I'm throwing my hat into the ring since I've already done so much in this > arena. Having written the Koha 3.0 Manual (which is still a work in > progress), I have an intimate knowledge of our documentation needs and woul

Re: [Koha-devel] RFC 3.2 : Koha Offline Circulation

On Fri, Aug 8, 2008 at 11:45 AM, Kyle Hall <[EMAIL PROTECTED]> wrote: > Hello All, > This is a request for comments regarding the file format for the > offline circulation system. Now that we're getting close to taking enhancements for 3.2, I opened up bug 2503 to keep track of the work put into

[Koha-devel] RFC: setting up a test server

Hi Koha Developers - I'm interested in setting up a system to run our test suite regularly and alert us of the results. You may know this as a smoke tester or a continuous integration server, but essentially, it's a thing that runs the test suite regularly and lets us know when things pass and fai

Re: [Koha-devel] RFC 3.2 - turn on warnings

On Tue, Aug 5, 2008 at 12:07 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Ideally, all Perl scripts and modules should have warnings enabled by > the time 3.2 is released. I'm surprised we haven't done this yet. I hadn't worked on code that didn't use strict and warnings in years before I start

Re: [Koha-devel] warnings (was: [Koha-patches] [PATCH] kohabug 2345: bad comparisons pervade reports)

On Thu, Jul 31, 2008 at 11:11 PM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > More thoughts on error_log: I have had great trouble finding > "interesting" errors and warnings in the Koha error log due > to the excessive amount of DEBUG messages from Koha and > warnings from Perl and the MySQL DBI.

Re: [Koha-devel] patches & bugs.koha.org

>> Who or what is JOOI? > > Just Out Of Interest. STFW. ;-) I did search the fucking web, and I didn't come up with anything useful in the small amount of time I was interested in spending. http://www.google.com/search?hl=en&q=define%3AJOOI&btnG=Search I'm interested in adding something to the w

Re: [Koha-devel] patches & bugs.koha.org

On Thu, Jul 31, 2008 at 9:06 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > Yeah, please can people discuss such policy changes on -devel first? You bet. I should probably have discussed this more before editing. I'm still getting used to this concept where all edits of the wiki need to be vetted by the

Re: [Koha-devel] warnings (was: [Koha-patches] [PATCH] kohabug 2345: bad comparisons pervade reports)

On Thu, Jul 31, 2008 at 8:06 AM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Now imagine what would happen if we (as we should) turn on warnings in > Koha. I'll make a proper 3.2 RFC for it shortly, but IMO we really > need to start putting in 'use warnings' in a all scripts. Many bugs > have alr

Re: [Koha-devel] RFC 3.2: Autogeneration of Koha UML diagrams

On Thu, Jul 31, 2008 at 4:24 AM, Zeno Tajoli <[EMAIL PROTECTED]> wrote: > Hi to all, > > from first day of October 2008 CILEA is going to support a project > about Koha as student stage (followd by me). > We want to improve tecnical documentation about Koha 3.0 (I hope to > have a stable release fo

Re: [Koha-devel] patches & bugs.koha.org

Hi Paul - On Wed, Jul 30, 2008 at 8:54 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: >> It does sometimes seem like a long process, especially compared to a >> small patch. Could we make it easier by making bugzilla accept entries >> via email? > > mmm... maybe a good way to do so. I'll follow up o

Re: [Koha-devel] patches & bugs.koha.org

On Wed, Jul 30, 2008 at 8:32 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Everybody is against me it seems, so I think i'll accept & change my mind... I apologize, Paul. I was specifically trying to avoid having you feel that way. -Andy ___ Koha-devel

Re: [Koha-devel] patches & bugs.koha.org

On Wed, Jul 30, 2008 at 7:03 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > I fully agree with the idea of pointing the bug if there is one. But I > strongly disagree about adding a bug if there is none. Hi Paul - Thanks for the feedback. I'm glad you're on board with putting bug numbers in the gi

Re: [Koha-devel] [Koha-patches] [PATCH] BUG-2393: ENHANCEMENT: SearchMember() uses "cardnumber%" wildcard - if other search-types fail

(Note: moved to koha-devel from patches) Hi Paul - On Fri, Jul 25, 2008 at 1:57 AM, paul POULAIN <[EMAIL PROTECTED]> wrote: > Please note that the SQL "LIMIT" pragma is mySQL specific. So it must be > avoided. Is this a guideline we should be currently following? I'm not asking because i disagr

Re: [Koha-devel] New 'test suite' component for bugs database

ning up problems > identified by new tests (e.g., 2400); neither type of issue fits into > 'command-line utilities', and I consider the test suite to be separate > from installation. IMO, the default assignee should be Andrew Moore. > since he's taken the lead on improving

Re: [Koha-devel] formatting currencies (RFC for 3.2 ?)

On Tue, Jul 22, 2008 at 3:43 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > - use a package like Data::Currency. Not sure it's what we need > - add some sysprefs to define : display currency (EUR), some printf > schema (### ###,##CUR in France). This being managed by some > C4/Currencies.pm function

Re: [Koha-devel] Installation Instructions

On Tue, Jul 15, 2008 at 6:05 AM, H Cline <[EMAIL PROTECTED]> wrote: > I will be trying an installation later in the week, all things going to plan, > and the powers that be giving me some time to actually complete the task. If > someone has instructions I would appreciate either a copy or a link,

Re: [Koha-devel] install.debian and MIME::Lite

Hi Zeno - I think I understand now. I have opened an enhancement request for version 3.2 to improve the information about missing perl dependencies: http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2352 Please feel free to comment on it if you think I've left something out. We'll try to impro

Re: [Koha-devel] install.debian and MIME::Lite

On Tue, Jul 15, 2008 at 5:21 AM, Zeno Tajoli <[EMAIL PROTECTED]> wrote: > Hi to all, > > using the last git download, MIME::Lite is a module mandatory now. > I see this module in all the correct places but not in the file > install.debian. Aha! Thanks, Mime::Lite is available in the debian packag

Re: [Koha-devel] MIME::Lite issues

Great news. I'll presume that this is no longer a problem, then. Thanks for the update! -Andy On Fri, Jul 11, 2008 at 3:48 PM, Chadwick, John, DCA <[EMAIL PROTECTED]> wrote: > I downloaded the latest version via git this morning and I had no > problems with the MIME::Lite errors I had on the oth

Re: [Koha-devel] MIME::Lite issues

On Fri, Jul 11, 2008 at 8:18 AM, Chadwick, John, DCA <[EMAIL PROTECTED]> wrote: > There was nothing odd about the install. I do want to clarify that I > download via git yesterday. Hi John - Good, that removes some of the confusion. The patch to reduce the requirement from 3.01 to 3.00 was put i

Re: [Koha-devel] MIME::Lite issues

On Thu, Jul 10, 2008 at 8:04 PM, Joe Atzberger <[EMAIL PROTECTED]> wrote: > It seems like: > 3.021 installed vs. > 3.01 required > should already succeed, right? What is happening there that wouldn't happen > with 3.00 or 3.000 or 3? Hi Joe - thanks for helping. Yes, I find it very odd, too. Al

Re: [Koha-devel] MIME::Lite issues

Oh, one thing, John. Do you know what version of MIME::Lite you have installed? The command: perl -M'MIME::Lite 999' -e print Should fail and produce something like: MIME::Lite version 999 required--this is only version 3.01. I'm hoping that backing it off to 3.00 will be reasonable. Thanks,

Re: [Koha-devel] MIME::Lite issues

On Thu, Jul 10, 2008 at 2:03 PM, Chadwick, John, DCA <[EMAIL PROTECTED]> wrote: > I am trying to install Koha 3.0 RC1 on Ubuntu 8.04. When I do the > Makefile.PL I get a message that MIME::Lite 3.01 is missing. When I do a > cpan install MIME::Lite I feedback that MIME::Lite is up to date. Hi John

Re: [Koha-devel] [Koha-patches] [PATCH] Fix a bug affecting C4::Context and default context

On Thu, Jul 3, 2008 at 12:18 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > The assumption that a program, including the test suite, should be > able to change a system preference value and have the new value show > up in the context is not an inherently bad one. I'll create a setter > for syspre

Re: [Koha-devel] page size & speed display

Frederic - Thanks for your work on profiling the code. I haven't tried it myself, but I've heard great things about the NY Times Profiler. http://open.blogs.nytimes.com/2008/03/05/the-new-york-times-perl-profiler/ http://search.cpan.org/dist/Devel-NYTProf/ thought it might be a useful tool if

Re: [Koha-devel] [Koha-patches] [PATCH] Fix a bug affecting C4::Context and default context

On Wed, Jul 2, 2008 at 11:36 AM, Andrew Moore <[EMAIL PROTECTED]> wrote: > I can't quite track down the problems yet. Can you run the test suite, > or hunt for problems any other way? After some investigation with Frederic, it appears that the failures in the test suite are

[Koha-devel] How do I run the test suite? (was Re: Fix a bug affecting C4::Context and default context)

On Wed, Jul 2, 2008 at 11:45 AM, Frederic Demians <[EMAIL PROTECTED]> wrote: > Yes. It works for me. How can I run the appropriate test suite? There is some information about the test suite at http://wiki.koha.org/doku.php?id=en:development:unit_testing but that documentation certainly has room fo

Re: [Koha-devel] [Koha] koha 3 installation: make test fails

Hi Constantine, Thanks for reporting this problem. The test suite is greatly expanded in the 3.0 release, and is still very much a work in progress. It appears that we're trying to run some tests that depend on the database before the database is set up. I suggest that you ignore these known test

Re: [Koha-devel] [Koha-patches] [PATCH] Disable _remove_stopwords in Search.pm to improve performances

On Wed, Jul 2, 2008 at 7:28 AM, Frederic Demians <[EMAIL PROTECTED]> wrote: > _remove_stopwords takes 28% of all the time spent to do search. > This patch disable this function. Stop words should be handle > directly by Zebra, shouldn't it? Hi Frédéric - I'm all in favor of the current work to pr

Re: [Koha-devel] page size & speed display

On Wed, Jul 2, 2008 at 2:31 AM, Frederic Demians <[EMAIL PROTECTED]> wrote: > Yes, but context objects will be created 23 times, one per module using > C4::Context. I just send a patch which uses class variable for default > context. Good eye, Frédéric. Thanks! -Andy _

Re: [Koha-devel] RFC: plan to reorganize cronjobs for overdues, notices, and fines

t to send out a proposed patch by tomorrow and (depending on the amount of suggestions I receive from that) have a final version to [EMAIL PROTECTED] by Friday. I'll document this work at http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2274 Thanks, -Andy On Wed, Jun 4, 2008 at 11:11 AM,

Re: [Koha-devel] updates to patron messaging

Hi MJ - On Tue, Jul 1, 2008 at 6:42 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > The original message stated pretty clearly that they wouldn't be > applied as-is, then "essentially these same patches" were submitted > and apparently applied without question. That stung. I didn't get much feedback on

Re: [Koha-devel] memcached and v3.2

On Tue, Jul 1, 2008 at 3:06 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > I suggest that we add memcached option to Koha 3.2. I think this is a great idea. How will this interact with mod_perl if we were to add a mod_perl option for 3.2 (or beyond)? -Andy

Re: [Koha-devel] updates to patron messaging

Hi Paul - On Mon, Jun 30, 2008 at 8:05 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Those patches have been approved in HEAD if I don't mind, so I try to > understand how they work (& make them work for frenchies) > It seems that you use both new tables (message_queue, > message_transport_type, i

Re: [Koha-devel] code formatting (was: [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies)

On Fri, Jun 27, 2008 at 8:48 AM, Mason James <[EMAIL PROTECTED]> wrote: > i have recently found 2 nice vim macros that allow you to select a block of > text and perltidy it, and perltidy the whole file too Thanks, Mason. And for those of us on the Dark Side, here are instructions on getting perlti

Re: [Koha-devel] SMS::Send is mandatory now

On Fri, Jun 27, 2008 at 4:44 AM, Zeno Tajoli <[EMAIL PROTECTED]> wrote: > Hi to all, > > I'm testing a Koha 3.0 with the last update from git. > I see that now SMS:Send is, praticaly, mandatory. > It is used by catalogue/detail.pl, the pl that show the result of a search > in the intranet interface

Re: [Koha-devel] [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies

On Wed, Jun 25, 2008 at 7:10 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > I can confirm the above example because I experienced it yesterday. > SMS::Send also required three other perl modules which aren't packaged > for that target platform AFAIK (MacOS X 10.4 Intel). Fortunately, all > of them built

Re: [Koha-devel] [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies

Hi Henri - thanks for your input on this. On Mon, Jun 23, 2008 at 5:08 PM, Henri-Damien LAURENT <[EMAIL PROTECTED]> wrote: > For instance, I have been said that SMS::Send even if not used or not > desired would be required just becaus it was loaded in some core > modules. If not, then error 500 w

Re: [Koha-devel] code formatting (was: [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies)

Hi MJ - On Mon, Jun 23, 2008 at 4:18 AM, MJ Ray <[EMAIL PROTECTED]> wrote: >> > Why does this patch covertly reindent everything? >> >> I didn't intend for it to be covert. [...] > > OK. Please try to mention these things in comments. It'd be a bit of > a pain to cherry-pick a patch described as

Re: [Koha-devel] optional modules (was: [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies)

On Mon, Jun 23, 2008 at 4:18 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > I know no good way to indicate optional modules in Makefile.PL. > Three choices that I think are better than total omission:- > 3. switch on META.yml generation and add a recommends line > http://module-build.sourceforge.net/META

Re: [Koha-devel] updates to patron messaging (bug 2176)

I have submitted essentially these same patches. I made a new syspref "EnhancedMessagingPreferences" to turn them off. It defaults to off. I'm hopeful that once this feature becomes a little more complete and stable I can eliminate that. Thanks, -Andy On Fri, Jun 13, 2008 at

[Koha-devel] updates to patron messaging

Hi Koha contributors - I've prepared a few patches to start reworking the patron messaging stuff that we have that's not quite working as we hoped in 3.0. The patches still have some parts that still need to be cleaned up or improved in them, and I don't expect them to be applied as is, but I want

Re: [Koha-devel] Web Archives (pipermail) for Koha.org mailing lists not appearing for June 2008

On Mon, Jun 9, 2008 at 6:20 AM, Ricardo Dias Marques <[EMAIL PROTECTED]> wrote: > I just noticed that the Web Archives (run by the software pipermail) > for the Koha.org mailing lists are NOT appearing for the current month > (June 2008). Hi Ricardo - Here's a backup archive of koha-devel you can

Re: [Koha-devel] RFC: plan to reorganize cronjobs for overdues, notices, and fines

Hi MJ - On Thu, Jun 5, 2008 at 7:06 AM, MJ Ray <[EMAIL PROTECTED]> wrote: > Can we merge them further? Firstly, there's the similarilty between > the two notices that Henri notied. Secondly, it would be good to have > the option of only fining patrons if we've successfully sent a notice > (succe

Re: [Koha-devel] RFC: plan to reorganize cronjobs for overdues, notices, and fines

On Wed, Jun 4, 2008 at 2:21 PM, henridamien.laurent <[EMAIL PROTECTED]> wrote: > Andrew Moore a écrit : >> advance_notices.pl - will prepare notices for items that are not yet >> due, or have just become due. Patrons will have the option of >> receiving these or not. &

[Koha-devel] RFC: plan to reorganize cronjobs for overdues, notices, and fines

Hi Koha Developers - After a brief audit of some of the code in misc/cronjobs it looks to me that the cronjobs that handle things like overdues, notices, and fines could use some work. There's a lot of overlapping functionality in the scripts in that directory, and not everything that we need for

[Koha-devel] Re: [Koha-patches] [PATCH] calculate OPACBaseURL instead of using syspref

On Sun, Jun 1, 2008 at 9:43 PM, Galen Charlton <[EMAIL PROTECTED]> wrote: > Calculate OPACBaseURL from the > CGI environment variables instead of using the > system preference. As a result of this patch, > it should be possible to change the hostname, > protocol, or port of the OPAC without having

Re: [Koha-devel] Differences between English and French syspref

On Fri, May 23, 2008 at 1:40 AM, Frederic Demians <[EMAIL PROTECTED]> wrote: > I've noticed differences between English and French syspref: Hi Frédéric Thanks for doing that investigation. I opened up bug 2156 for this. -Andy

Re: [Koha-devel] RFC on ISBN sanitisations, was: [Koha-patches] [PATCH] Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

On Wed, May 14, 2008 at 2:43 PM, Jesse <[EMAIL PROTECTED]> wrote: > Eek. There's already a... plethora of modules in C4::. At the very least, we > would be adding C4::ISBN, C4::OCLC and C4::LCCN. If we really need an OOP > interface (seems like overkill for the simple reformatting this would be > d

Re: [Koha-devel] RFC on sanitisations

On Wed, May 14, 2008 at 2:41 PM, Henri-Damien LAURENT <[EMAIL PROTECTED]> wrote: > I am not really going in for that. > Having pieces written in OO and others in procedural mode is not really > good for me. > Unless we get into a work of rewriting the code into OO Programming, > which would be

Re: [Koha-devel] RFC on ISBN sanitisations, was: [Koha-patches] [PATCH] Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

On Wed, May 14, 2008 at 2:15 PM, MJ Ray <[EMAIL PROTECTED]> wrote: > I suspect C4::Normalize would have poor cohesion (probably logical > cohesion) so would prefer creating C4::ISBN and similar, with methods > like new($), raw(), normal(), display() and so on. If we're voting, I'm voting for an

Re: [Koha-devel] git, mails to patches ML & commit note

On Tue, May 13, 2008 at 8:47 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Hello, > > i've just commited a small patch with long comments, and see that the > comment has been wrapped by something. > Did someone realize that before, and did someone find a solution not to > have commit comment ea

Re: [Koha-devel] QA process (was: "freezing" koha 3.0)

On Wed, May 7, 2008 at 11:10 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > For instance, the role of QA > manager means almost nothing in real life. I'm sorry about that, we > should speak of how to introduce the QA role in the git process. I'm interested in opening up this topic a little bit m

Re: [Koha-devel] patches for #2047 broke scanindex searches (was: "freezing" koha 3.0)

Oh, I see now you've sent one already. Thanks and nevermind. -Andy ___ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel

[Koha-devel] patches for #2047 broke scanindex searches (was: "freezing" koha 3.0)

On Fri, May 2, 2008 at 9:47 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > sorry, but 1 other example of "better enemy of good" : the patches for > #2047 breaks scanindex searches, that badly fails : > Can't call method "field" on an undefined value at > /home/paul/koha.dev/frantiq/C4/Biblio.pm l

Re: [Koha-devel] missing commit(s) in RSS thread

On Mon, Apr 28, 2008 at 8:20 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Hello, > > I just realise that a commit I did, and kados has validated appears in > my working repo, appears on git.koha.org BUT don't appear on RSS thread. > > Did anyone saw that problem before ? > (not a big one, but

Re: [Koha-devel] .gitignore

On Fri, Apr 18, 2008 at 1:43 PM, Ryan Higgins <[EMAIL PROTECTED]> wrote: > > I'd like to suggest that the .gitignore recently pushed to the public repo > be removed, > and that Koha not enforce any conventions via .gitignore . Hi Ryan - We chatted a bit about this on IRC, but I'm not sure if I un

[Koha-devel] Re: interest in improving automated tests with a testing database

the opportunity to fix some of these before the code is committed, or fix them later. Thanks for your help. -Andy On Thu, Mar 27, 2008 at 1:43 PM, Andrew Moore <[EMAIL PROTECTED]> wrote: > Hi Koha developers - > > I have caught some of you on IRC and such, but for the rest of you, >