On Mon, 19 Jan 2009 08:57:29 +0100, Olivier Goffart <ogoff...@kde.org> wrote:
> Le dimanche 18 janvier 2009, Roman Jarosz a écrit : >> On Sun, 18 Jan 2009 21:13:12 +0100, Olivier Goffart <ogoff...@kde.org> > wrote: >> > Le dimanche 18 janvier 2009, Roman Jarosz a écrit : >> >> Hi, >> >> >> >> I'm trying to fix ICQ bug 171733: Invisible flag does not persist >> after >> >> a >> >> status change the attached patch allows user to change the status >> from >> >> account menu without changing the invisible flag in ICQ, the global >> menu >> >> still removes the invisible flag. >> >> >> >> I've added bool keepSpecialFlags into the Account::setOnlineStatus >> which >> >> tells if we should keep flags like invisible or for instance in ICQ >> >> xtraz >> >> status. >> >> >> >> This not so critical but the invisible flag is also cleared when auto >> >> away >> >> changes status and this is bad so I would like to commit it to 4.2 >> >> before >> >> it's released. >> >> >> >> If nobody objects I'll commit it tomorrow. >> > >> > You fall into the boolean trap :-) >> > http://techbase.kde.org/Policies/Library_Code_Policy#Flags >> > http://doc.trolltech.com/qq/qq13-apis.html#thebooleanparametertrap >> > >> > Consider using an enum / QFlags instead. >> >> Good point, This should be better. >> Otherwise you agree with this change? >> >> Roman > > Actually, i think that flag should maybe be part of the OnlineStatus > itself. > ( flag set invisible / set visible / do not change ) Well this isn't only for invisible, ICQ has xtraz status which we don't want to reset too. I'll leave it in setOnlineStatus as it is now because the data in OnlineStatus are shared and this would change it often. IMHO this one is nice from the code point of view. > In particular, i think that the main status menu should change the > invisible > flag. because when you go busy, you quit invisible to go busy. But > tht's > just my opinion. Yes that's how it works, main status change resets the invisible or any other flag, so wen you go busy your status is busy nothing else. The flags won't be reset in account menu and when auto away changes status. Roman _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
