Re: [PATCH 12/45] KVM: x86: Support for user space injected NMIs

2008-12-10 Thread Avi Kivity
Jan Kiszka wrote: Avi Kivity wrote: From: Jan Kiszka <[EMAIL PROTECTED]> Introduces the KVM_NMI IOCTL to the generic x86 part of KVM for injecting NMIs from user space and also extends the statistic report accordingly. Avi, please consider [1] again. You've already merged the related u

Re: [PATCH 2/5] KVM: New guest debug interface

2008-12-10 Thread Avi Kivity
Jan Kiszka wrote: btw, is it possible to emulate the old interface on top of the new implementation? I feel unconfortable with dropping an interface (albeit an unused one) without even a warning. Would be possible, I guess - but do we really have to care? It only worked for VMX, only on U

Re: [PATCH] kvm testsuite: Add test for 'shld' instruction

2008-12-10 Thread Guillaume Thouvenin
On Fri, 05 Dec 2008 19:17:17 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Guillaume Thouvenin wrote: > > Add 'shld' instruction test in real mode test harness. > > > > > Applied, thanks. > > > Avi, on my computer this test is broken but the problem seems to be > > elsewhere because test_shld

[ kvm-Bugs-2413430 ] CPU: Linux guests fails on emulated "core2duo" and "coreduo"

2008-12-10 Thread SourceForge.net
Bugs item #2413430, was opened at 2008-12-10 11:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2413430&group_id=180599 Please note that this message will contain a full copy

Re: KVM: MMU: check for present pdptr shadow page in walk_shadow

2008-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: walk_shadow assumes the caller verified validity of the pdptr pointer in question, which is not the case for the invlpg handler. Fixes oops during Solaris 10 install. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe f

Re: [PATCH 0/2] module_refcounting and anonymous inodes

2008-12-10 Thread Avi Kivity
Sheng Yang wrote: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28) But should it be 2,6,29?... Thanks, fixed. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTE

Re: KVM: MMU: optimize set_spte for page sync

2008-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: Do you have objections for submitting this patch for 2.6.28 ? The hash lookup kills performance of pagetable write + context switch intensive workloads. Can you quantify? 2.6.28 is out of the question, 2.6.28.stable is possible, depending on the actual performance di

Re: [PATCH 12/45] KVM: x86: Support for user space injected NMIs

2008-12-10 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> From: Jan Kiszka <[EMAIL PROTECTED]> >>> >>> Introduces the KVM_NMI IOCTL to the generic x86 part of KVM for >>> injecting NMIs from user space and also extends the statistic report >>> accordingly. >>> >> Avi, please consider

Re: [PATCH] KVM: fix handling of ACK from shared guest IRQ

2008-12-10 Thread Avi Kivity
Mark McLoughlin wrote: If an assigned device shares a guest irq with an emulated device then we currently interpret an ack generated by the emulated device as originating from the assigned device leading to e.g. "Unbalanced enable for IRQ 4347" from the enable_irq() in kvm_assigned_dev_ack_irq().

RE: How to use PCI-passthrough with kvm

2008-12-10 Thread Han, Weidong
Hi Kazushi, Make sure unload the driver of the device before assign it. Regards, Weidong w1ndoz wrote: > Hi > > I'm interested in PCI passthrough support. > > I downloaded Linux Kernel 2.6.28-rc7 and build and ran KVM (which > is KVM-79) on this kernel. > I started KVM with the following comm

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Avi Kivity
Joerg Roedel wrote: Hi, the two patchsets posted as reply to this email implement KVM device passthrough support for AMD IOMMU hardware. The changes to the previous posts are descibed below The first patchset is version 4 of the generic iommu api patchset which generalizes the VT-d functions ex

[PATCH 1/4] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq

2008-12-10 Thread Han, Weidong
Should pass &assigned_dev->dev to ipf_map_irq in while loop. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c |4 ++-- qemu/hw/pci.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/de

[PATCH 2/4] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
Free ioperm data in free_assigned_device. And also, define ioperm_data structure and declare related functions when USE_KVM_DEVICE_ASSIGNMENT is defined, because ioperm data is only used by device assignment. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c |2

[PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device

2008-12-10 Thread Han, Weidong
adev will be removed in free_assigned_device, shouldn't remove it in assigned_dev_update_irq. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assig

Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref

2008-12-10 Thread Mark McLoughlin
On Tue, 2008-12-09 at 19:16 +0100, Kay Sievers wrote: > On Tue, Dec 9, 2008 at 17:41, Mark McLoughlin <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-12-08 at 08:46 -0600, Anthony Liguori wrote: > >> Mark McLoughlin wrote: > >> > On Sun, 2008-12-07 at 18:52 +1030, Rusty Russell wrote: > >> >> On Saturd

[PATCH 4/4] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Han, Weidong
assign_dev_update_irq may not be invoked when hot add a device, so need to assign irq after assign device in init_assigned_device. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c | 99 -- 1 files changed, 66 insertions(+),

Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-12-10 Thread Avi Kivity
Joerg Roedel wrote: Hey Avi, do you plan to apply this patch? Or, if not, can you give a comment why not? sorry, accidentally dropped, not applied. Thanks for the remainder. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "un

Re: [PATCH 31/31] virt: Make static

2008-12-10 Thread Avi Kivity
Roel Kluin wrote: Sparse asked whether these could be static. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [patch 1/3] QEMU/KVM: x86: separate TSC load from kvm_arch_load_regs

2008-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: kvm_load_registers is a general interface to load registers, and is used by vmport, gdbstub, etc. The TSC MSR is continually counting, so it can't be simply read and written back as the other registers/MSR's (doing so overwrites the current count). Introduce kvm_load_tsc a

Re: [PATCH 3/4] kvm: qemu: Fix double LIST_REMOVE device

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 17:45 +0800, Han, Weidong wrote: > adev will be removed in free_assigned_device, shouldn't remove it in > assigned_dev_update_irq. Ouch, yes, good catch. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROT

Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref

2008-12-10 Thread Kay Sievers
On Wed, Dec 10, 2008 at 10:49, Mark McLoughlin <[EMAIL PROTECTED]> wrote: > On Tue, 2008-12-09 at 19:16 +0100, Kay Sievers wrote: >> On Tue, Dec 9, 2008 at 17:41, Mark McLoughlin <[EMAIL PROTECTED]> wrote: >> > On Mon, 2008-12-08 at 08:46 -0600, Anthony Liguori wrote: >> >> Mark McLoughlin wrote: >

RE: [PATCH 16/17] KVM: support device assignment

2008-12-10 Thread Han, Weidong
Avi Kivity wrote: > Han, Weidong wrote: >> Support device assignment, it can be used in device hotplug. >> >> > > device _de_assignment. Yes, it's device deassignment. Sorry tt's a typo. Regards, Weidong-- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message

[ kvm-Bugs-2413430 ] CPU: Linux guests fails on emulated "core2duo" and "coreduo"

2008-12-10 Thread SourceForge.net
Bugs item #2413430, was opened at 2008-12-10 11:00 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2413430&group_id=180599 Please note that this message will contain a full copy of the comme

kvm-userspace requires kvm capable kernel headers in default search path of the compiler

2008-12-10 Thread Christian Ehrhardt
Hi everyone, while running a test when updating kvm-userspace for powerpc I found that the current kvm userspace requires kvm kernel headers in the default search path of the used compilers. I used to update and build in the same kvm-userspace directory for a while and this one had an old stale

broken video in kvm-80 [was Re: [ANNOUNCE] kvm-80 release]

2008-12-10 Thread Tony Redstone
Hi, Broken video here too (winxp guest)... kvm-80 on Intel Core 2 Duo. kvm-80 module definitely loaded (dmesg shows "loaded kvm module (kvm-80)"). Any further suggestions on how to resolve this? Have had to revert to kvm-79 in the meantime. Regards, Tony. From: Avi Kivity redhat.com> Subject

[PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails

2008-12-10 Thread Mark McLoughlin
On Fri, 2008-11-28 at 17:10 +, Mark McLoughlin wrote: > It's standard practice in qemu to exit if command line parameter > fails, so do that here too. > > Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> > --- > qemu/hw/device-assignment.c |1 + > 1 files changed, 1 insertions(+), 0 del

Re: [PATCH 4/4] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 17:45 +0800, Han, Weidong wrote: > assign_dev_update_irq may not be invoked when hot add a device, so > need to assign irq after assign device in init_assigned_device. Makes sense, but ... > Signed-off-by: Weidong Han <[EMAIL PROTECTED]> > --- > qemu/hw/device-assignment.c

RE: [PATCH 2/4] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
Mark McLoughlin wrote: > On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote: > >> diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c >> index 067cf03..283bfa9 100644 >> --- a/qemu/qemu-kvm.c >> +++ b/qemu/qemu-kvm.c >> @@ -1145,6 +1145,18 @@ void kvm_add_ioperm_data(struct ioperm_data >> *data

Re: [PATCH 2/4] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote: > diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c > index 067cf03..283bfa9 100644 > --- a/qemu/qemu-kvm.c > +++ b/qemu/qemu-kvm.c > @@ -1145,6 +1145,18 @@ void kvm_add_ioperm_data(struct ioperm_data *data) > LIST_INSERT_HEAD(&ioperm_head,

[ kvm-Bugs-1673740 ] real mode: KVM-15 does not boot Ubuntu 6.10 i386 on Gentoo

2008-12-10 Thread SourceForge.net
Bugs item #1673740, was opened at 2007-03-05 03:36 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1673740&group_id=180599 Please note that this message will contain a full copy of the comme

[ kvm-Bugs-1783936 ] Kubuntu-7.04 install: screen blank only during grub menu

2008-12-10 Thread SourceForge.net
Bugs item #1783936, was opened at 2007-08-29 14:20 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1783936&group_id=180599 Please note that this message will contain a full copy of the comme

[PATCH 1/4] [v2] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq

2008-12-10 Thread Han, Weidong
Should pass &assigned_dev->dev to ipf_map_irq in while loop. And rename it to assigned_dev_update_irqs() because it updates irq on all assigned devices. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c |4 ++-- qemu/hw/pci.c |4 ++-- 2 files ch

[PATCH 2/4] [v2] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
Free ioperm data in free_assigned_device. And also, define ioperm_data structure and declare related functions when USE_KVM_DEVICE_ASSIGNMENT is defined, because ioperm data is only used by device assignment. Signed-off-by: Weidong Han <[EMAIL PROTECTED]> --- qemu/hw/device-assignment.c |2

[PATCH 3/4] [v2] kvm: qemu: Fix double LIST_REMOVE device

2008-12-10 Thread Han, Weidong
>From 614ef2e7027089a716fdccbb2da1d75630ef41f7 Mon Sep 17 00:00:00 2001 From: Weidong Han <[EMAIL PROTECTED]> Date: Wed, 10 Dec 2008 21:17:46 +0800 Subject: [PATCH] Fix double LIST_REMOVE device adev will be removed in free_assigned_device, shouldn't remove it in assigned_dev_update_irqs. Signed

[PATCH 4/4] [v2] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Han, Weidong
assign_dev_update_irqs may not be invoked when hot add a device, so need to assign irq after assign device in init_assigned_device. Additionally, clean up assign_dev_update_irqs code, and free the assigned device in init_assigned_device when it fails. Signed-off-by: Weidong Han <[EMAIL PROTECTE

RE: [PATCH 2/4] [v2] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
Mark McLoughlin wrote: > On Wed, 2008-12-10 at 21:22 +0800, Han, Weidong wrote: >> >> +void kvm_remove_ioperm_data(unsigned long start_port, unsigned long >> num) +{ +struct ioperm_data *data; >> + >> +data = LIST_FIRST(&ioperm_head); >> +while (data) { >> +if (data->start_port

RE: [PATCH 2/4] [v2] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
Mark McLoughlin wrote: > On Wed, 2008-12-10 at 21:22 +0800, Han, Weidong wrote: >> >> +void kvm_remove_ioperm_data(unsigned long start_port, unsigned long >> num) +{ +struct ioperm_data *data; >> + >> +data = LIST_FIRST(&ioperm_head); >> +while (data) { >> +if (data->start_port

[PATCH 2/4] [v3] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Han, Weidong
v2->v3: fixed "use after free bug" reported by Mark. Free ioperm data in free_assigned_device. And also, define ioperm_data structure and declare related functions when USE_KVM_DEVICE_ASSIGNMENT is defined, because ioperm data is only used by device assignment. Signed-off-by: Weidong Han <[EMA

[PATCH 4/4] [v3] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Han, Weidong
v2->v3: fixed "use after free bug" reported by Mark. assign_dev_update_irqs may not be invoked when hot add a device, so need to assign irq after assign device in init_assigned_device. Additionally, clean up assign_dev_update_irqs code, and free the assigned device in init_assigned_device when

Re: [PATCH 2/4] [v2] kvm: qemu: Fix leak of ioperm data

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 21:22 +0800, Han, Weidong wrote: > > +void kvm_remove_ioperm_data(unsigned long start_port, unsigned long num) > +{ > +struct ioperm_data *data; > + > +data = LIST_FIRST(&ioperm_head); > +while (data) { > +if (data->start_port == start_port && data->num ==

RE: [PATCH 4/4] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Han, Weidong
Mark McLoughlin wrote: > On Wed, 2008-12-10 at 17:45 +0800, Han, Weidong wrote: > >> assign_dev_update_irq may not be invoked when hot add a device, so >> need to assign irq after assign device in init_assigned_device. > > Makes sense, but ... > >> Signed-off-by: Weidong Han <[EMAIL PROTECTED]>

Re: [PATCH 4/4] [v2] kvm: qemu: Assign irq in init_assigned_device

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 21:23 +0800, Han, Weidong wrote: > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > index 03a52e6..160f001 100644 > --- a/qemu/hw/device-assignment.c > +++ b/qemu/hw/device-assignment.c > @@ -499,40 +561,13 @@ void assigned_dev_update_irqs() > >

Re: [PATCH] KVM: VMX: Fix pending NMI-vs.-IRQ race for user space irqchip

2008-12-10 Thread Avi Kivity
Jan Kiszka wrote: Push b55a50582030cf294a675492d7ab2e235b965cc8 and d3a2c20c9b850d92dae383fd6a64840de2687cd6 also to the user space irqchip path. Applied (belatedly...), thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: [patch 3/3] KVM: VMX: initialize TSC offset relative to vm creation time

2008-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: VMX initializes the TSC offset for each vcpu at different times, and also reinitializes it for vcpus other than 0 on APIC SIPI message. This bug causes the TSC's to appear unsynchronized in the guest, even if the host is good. Older Linux kernels don't handle the situatio

[ kvm-Bugs-2148182 ] kvm-76 cannot boot 2.6.27-rc6 and -rc8

2008-12-10 Thread SourceForge.net
Bugs item #2148182, was opened at 2008-10-05 21:00 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2148182&group_id=180599 Please note that this message will contain a full copy of the comme

Re: [PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails

2008-12-10 Thread Avi Kivity
Mark McLoughlin wrote: fprintf(stderr, "Could not add assigned device %s\n", devices[i]); continue; +exit(1); Um, that's a rather embarrassing thinko. For the reviewer as well; applied. -- error compiling committee.c: too many arguments to functi

Re: [PATCH 31/31] virt: Make static

2008-12-10 Thread Avi Kivity
Avi Kivity wrote: Roel Kluin wrote: Sparse asked whether these could be static. Applied, thanks. Er, actually I already had a patch in my queue for this. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in

Re: [PATCH 16/17] KVM: support device assignment

2008-12-10 Thread Avi Kivity
Han, Weidong wrote: Support device assignment, it can be used in device hotplug. device _de_assignment. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More major

RE: [PATCH 1/4] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq

2008-12-10 Thread Han, Weidong
Mark McLoughlin wrote: > On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote: >> Should pass &assigned_dev->dev to ipf_map_irq in while loop. >> >> Signed-off-by: Weidong Han <[EMAIL PROTECTED]> >> --- >> qemu/hw/device-assignment.c |4 ++-- >> qemu/hw/pci.c |4 ++-- >> 2

Re: [PATCH 1/4] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq

2008-12-10 Thread Mark McLoughlin
On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote: > Should pass &assigned_dev->dev to ipf_map_irq in while loop. > > Signed-off-by: Weidong Han <[EMAIL PROTECTED]> > --- > qemu/hw/device-assignment.c |4 ++-- > qemu/hw/pci.c |4 ++-- > 2 files changed, 4 insertions(+),

2003 x64 hangs on reboot on Intel E6750 CPU (Diffrent kernels, diffrent kvms)

2008-12-10 Thread Christian Nilsson
Hi, I have a problem with Windows Server 2003 x64 (Standard edition) installations in a kvm instance, different versions of kvm (first try was with kvm-76 and the problem have persisted) the kernel has also changed together with kvm, when the guest is about to reboot it just hangs (server 2003

Re: [PATCH] kvm: work around inability of older kvm modules to destroy memory regions

2008-12-10 Thread Christian Ehrhardt
Hi, this patch breaks all non x86 architectures as libkvm/libkvm-x86.c has the only implementation of the alias functionality. Until now only qemu-kvm-x86 has called that functions, but since this patch the generic qemu-kvm.c calls them which leads to unresolved symbols for powerpc, s390 and sur

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Joerg Roedel
On Wed, Dec 10, 2008 at 11:36:16AM +0200, Avi Kivity wrote: > Joerg Roedel wrote: > >Hi, > > > >the two patchsets posted as reply to this email implement KVM device > >passthrough support for AMD IOMMU hardware. The changes to the previous > >posts are descibed below > > > >The first patchset is ve

Re: Change P2P domain flags

2008-12-10 Thread Mike Day
On 09/12/08 00:02 +0800, Han, Weidong wrote: > +/* devices under the same p2p bridge are owned in one domain */ > +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0) Shouldn't that be (1 << 0 )? Mike -- Mike Day http://www.ncultra.org AIM: ncmikeday | Yahoo IM: ultra.runner PGP key: http://w

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread David Woodhouse
On Wed, 2008-12-10 at 15:11 +0100, Joerg Roedel wrote: > So now its open how this will be merged alltogether. We can merge it in > three steps (first from Dave's tree, then Avi and at last my IOMMU > updates which has to happen in that order). > The other option is to merge this all with one pull-r

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Avi Kivity
Joerg Roedel wrote: So now its open how this will be merged alltogether. We can merge it in three steps (first from Dave's tree, then Avi and at last my IOMMU updates which has to happen in that order). The other option is to merge this all with one pull-request I send to Linus. It should not con

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Joerg Roedel
On Wed, Dec 10, 2008 at 02:22:08PM +, David Woodhouse wrote: > On Wed, 2008-12-10 at 15:11 +0100, Joerg Roedel wrote: > > So now its open how this will be merged alltogether. We can merge it in > > three steps (first from Dave's tree, then Avi and at last my IOMMU > > updates which has to happe

Re: [RESEND] [PATCH v2] Accept password as an argument to 'change vnc password'

2008-12-10 Thread Anthony Liguori
Chris Webb wrote: Accept password as an argument to 'change vnc password' monitor command This allows easier use of the change vnc password monitor command from management scripts, without having to implement expect(1)-like behaviour. Signed-off-by: Chris Webb <[EMAIL PROTECTED]> Applied.

Re: [RESEND] [PATCH v2] Fix off-by-one bug limiting VNC passwords to 7 chars

2008-12-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori Chris Webb wrote: Fix off-by-one bug limiting VNC passwords to 7 characters instead of 8 monitor_readline expects buf_size to include the terminating \0, but do_change_vnc in monitor.c calls it as though it doesn't. The other site where monitor_readl

Re: [PATCH 1/4] LSI53C895A: Rename dmbs register to dbms

2008-12-10 Thread Anthony Liguori
Ryan Harper wrote: Register name should be: Dynamic Block Move Selector (dbms) according to page 215 of the LSI 53C895A Technical Manual[1]. 1. http://www.lsi.com/DistributionSystem/AssetDocument/files/docs/techdocs/storage_stand_prod/SCSIControllers/lsi53c895a_tech_manual.pdf Signed-off-by:

Re: [PATCH 2/4] Add 64-bit Block Move support (Direct & Table Indirect)

2008-12-10 Thread Anthony Liguori
Ryan Harper wrote: This patch adds support for 64-bit Block Move instructions. There are multiple modes for 64-bit Block moves, direct, indirect, and table indirect. This patch implements Direct and Table indirect moves which are needed by 64-bit windows and SYM_CONF_DMA_ADDRESSING_MODE=2 for t

[PATCH 1 of 6] [PATCH] kvm-userspace: ppc: fix compatfd build decision

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922788 -3600 # Node ID b41f0d6129f51fb86bf799a5fe7b14a9270eeca4 # Parent 3af3fa5e009e143e1167979e55d547c453661059 [PATCH] kvm-userspace: ppc: fix compatfd build decision From: Christian Ehrhardt <[EMAIL PROTECTED]> qem

[PATCH 5 of 6] [PATCH] kvm-userspace: ppc: use virtio-blk header

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922789 -3600 # Node ID 5adc6fbbd4a3b82e1bc8acbcb233c60e89715b61 # Parent 214485869c303ab81c9da30b6784d641f58585f4 [PATCH] kvm-userspace: ppc: use virtio-blk header From: Christian Ehrhardt <[EMAIL PROTECTED]> virtio_bl

[PATCH 4 of 6] [PATCH] kvm-userpace: ppc: align with upstream qemu - 4xxdevs

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922788 -3600 # Node ID 214485869c303ab81c9da30b6784d641f58585f4 # Parent c032d8555c9494f9812e4d4e0b5b511ae597 [PATCH] kvm-userpace: ppc: align with upstream qemu - 4xxdevs From: Christian Ehrhardt <[EMAIL PROTECTED]

[PATCH 3 of 6] [PATCH] kvm-userspace: ppc: align with upstream qemu - breakpoint reset

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922788 -3600 # Node ID c032d8555c9494f9812e4d4e0b5b511ae597 # Parent f100b1bfa5f3d084d68bd2c66244271db1f5d084 [PATCH] kvm-userspace: ppc: align with upstream qemu - breakpoint reset From: Christian Ehrhardt <[EMAIL

[PATCH 2 of 6] [PATCH] kvm-userspace: ppc: fix configure enabling kvm for ppc

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922788 -3600 # Node ID f100b1bfa5f3d084d68bd2c66244271db1f5d084 # Parent b41f0d6129f51fb86bf799a5fe7b14a9270eeca4 [PATCH] kvm-userspace: ppc: fix configure enabling kvm for ppc From: Christian Ehrhardt <[EMAIL PROTECTED

[PATCH 6 of 6] [PATCH] kvm-userspace: ppc: align with upstream qemu - pcibus

2008-12-10 Thread Christian Ehrhardt
# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228922789 -3600 # Node ID 9a7208ca1afab83913ee14c629bf27632ee6326b # Parent 5adc6fbbd4a3b82e1bc8acbcb233c60e89715b61 [PATCH] kvm-userspace: ppc: align with upstream qemu - pcibus From: Christian Ehrhardt <[EMAIL PROTECTED]

Re: KVM: MMU: optimize set_spte for page sync

2008-12-10 Thread Marcelo Tosatti
On Wed, Dec 10, 2008 at 11:14:42AM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: >> Do you have objections for submitting this patch for 2.6.28 ? The hash >> lookup kills performance of pagetable write + context switch intensive >> workloads. >> > > Can you quantify? > > 2.6.28 is out of the

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-10 Thread Andrea Arcangeli
On Tue, Dec 09, 2008 at 10:01:34AM -0600, Anthony Liguori wrote: > Yes, that's what I'm going to do before committing it. I've been hacking on this too, just to push out a full tested patchset without the _em badness... problem is if we use more than one thread, there's a thread race between lseek

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-10 Thread Anthony Liguori
Andrea Arcangeli wrote: On Tue, Dec 09, 2008 at 10:01:34AM -0600, Anthony Liguori wrote: Yes, that's what I'm going to do before committing it. I've been hacking on this too, just to push out a full tested patchset without the _em badness... problem is if we use more than one thread, t

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-10 Thread Gerd Hoffmann
>> To solve this in userland without kernel aio we'd need to open (not >> just dup) > > Why not just dup? I've implemented this and it seems to work. unix keeps the file pointer in the (global) file table. The (per-process) file descriptor table references the file table. opening twice gives y

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread David Woodhouse
On Wed, 2008-12-10 at 15:25 +0100, Joerg Roedel wrote: > I already did it on-top of your tree because Han Weidong's patches 1-17 > were rebased to your tree and my IOMMU-API patches apply on-top of his > patches. OK, thanks. Looks like you still need this though, as Mike Day pointed out: diff --g

Re: [PATCH] virtio_net: add link status handling

2008-12-10 Thread Mark McLoughlin
On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote: > Rusty Russell wrote: > > On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>> Allow the host to inform us that the link is down by adding > >>> a VIRTIO_NET_F_STATUS which indicat

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Joerg Roedel
On Wed, Dec 10, 2008 at 06:24:35PM +, David Woodhouse wrote: > On Wed, 2008-12-10 at 15:25 +0100, Joerg Roedel wrote: > > I already did it on-top of your tree because Han Weidong's patches 1-17 > > were rebased to your tree and my IOMMU-API patches apply on-top of his > > patches. > > OK, than

Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread David Woodhouse
On Wed, 2008-12-10 at 19:42 +0100, Joerg Roedel wrote: > Ok, I add it, thanks. Who is the author, Mike or you? Might as well attribute it to Mike; he spotted it. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-10 Thread Anthony Liguori
Gerd Hoffmann wrote: To solve this in userland without kernel aio we'd need to open (not just dup) Why not just dup? I've implemented this and it seems to work. unix keeps the file pointer in the (global) file table. The (per-process) file descriptor table references the file tab

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-10 Thread Andrea Arcangeli
On Wed, Dec 10, 2008 at 12:50:17PM -0600, Anthony Liguori wrote: > But opening twice means that you lose coherency with NFS. Not sure why. They're not running from different nfs clients. If this really isn't feasible, other ways to go would be to stick with a single thread and add kernel aio to fi

Re: [patch 3/3] KVM: VMX: initialize TSC offset relative to vm creation time

2008-12-10 Thread Marcelo Tosatti
On Wed, Dec 10, 2008 at 12:19:28PM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: >> VMX initializes the TSC offset for each vcpu at different times, and >> also reinitializes it for vcpus other than 0 on APIC SIPI message. >> >> This bug causes the TSC's to appear unsynchronized in the guest, e

[ kvm-Bugs-2351676 ] Guests hang periodically on Ubuntu-8.10

2008-12-10 Thread SourceForge.net
Bugs item #2351676, was opened at 2008-11-26 12:59 Message generated for change (Comment added) made by c_jones You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2351676&group_id=180599 Please note that this message will contain a full copy of the comment t

[PATCH] kvm-userspace: Fix a compiler warning

2008-12-10 Thread Andre Przywara
The following small patch fixes a compiler warning in KVM's vl.c Signed-off-by: Andre Przywara <[EMAIL PROTECTED]> --- diff --git a/qemu/vl.c b/qemu/vl.c index 7b58605..b489acd 100644 --- a/qemu/vl.c +++ b/qemu/vl.c @@ -4611,7 +4611,7 @@ static int gethugepagesize(void) { int ret, fd;

KVM: mmu_notifiers release method

2008-12-10 Thread Marcelo Tosatti
The destructor for huge pages uses the backing inode for adjusting hugetlbfs accounting. Hugepage mappings are destroyed by exit_mmap, after mmu_notifier_release, so there are no notifications through unmap_hugepage_range at this point. The hugetlbfs inode can be freed with pages backed by it re

RE: Change P2P domain flags

2008-12-10 Thread Han, Weidong
Mike Day wrote: > On 09/12/08 00:02 +0800, Han, Weidong wrote: > >> +/* devices under the same p2p bridge are owned in one domain */ >> +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0) > > Shouldn't that be (1 << 0 )? > > You are right. Thanks. Regards, Weidong -- To unsubscribe from this l

RE: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU

2008-12-10 Thread Han, Weidong
Joerg Roedel wrote: > On Wed, Dec 10, 2008 at 02:22:08PM +, David Woodhouse wrote: >> On Wed, 2008-12-10 at 15:11 +0100, Joerg Roedel wrote: >>> So now its open how this will be merged alltogether. We can merge >>> it in three steps (first from Dave's tree, then Avi and at last my >>> IOMMU upd

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-12-10 Thread Yu Zhao
On Fri, Nov 07, 2008 at 12:17:22PM +0800, Matthew Wilcox wrote: > On Fri, Nov 07, 2008 at 11:40:21AM +0800, Zhao, Yu wrote: > > Greg KH wrote: > > >We've thought about this in the past, and even Microsoft said it was > > >going to happen for Vista, but they realized in the end, like we did a > > >f

Re: How to use PCI-passthrough with kvm

2008-12-10 Thread w1ndoz
Hi Weidong, Thank you for your advice Finally, I could recognize a Intel NIC from the guest OS. But, I had a new problem. A guest os have been able to recognize the NIC with pci-passthrough. However the NIC could not get a IP address on a guest os The NIC causes the following errors and stops:

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-12-10 Thread Grant Grundler
On Thu, Dec 11, 2008 at 09:43:13AM +0800, Yu Zhao wrote: ... > I believe this is the only problem that preclude us having the run-time > resource rebalance. And I'm not sure how much effort we can fix it. Any > comments? Figure out the right sequence for driver resume so the probe function can cal

RE: How to use PCI-passthrough with kvm

2008-12-10 Thread Han, Weidong
Hi, This onboard NIC assignment works for me. I used RHEL5u1 guest and e1000e 0.2.9.5 driver. So I don't think this issue is caused by PCI passthrough on KVM. Is there any error messages of assigning device? Pls note that the device that shares IRQ with other devices in host cannot work by PCI