[PATCH] kvm: qemu: update call pci_nic_init

2009-01-15 Thread Avi Kivity
From: Yang yang.zh...@intel.com update call pci_nic_init in ipf_init1, changed by the recent merge. Signed-off-by: Yang Zhang yang.zh...@intel.com Signed-off-by: Xiantao Zhang xiantao.zh...@intel.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c index

[PATCH] kvm: qemu: Save ia64 nvram

2009-01-15 Thread Avi Kivity
From: Yang yang.zh...@intel.com Save nvram to a file given by a command line parameter. Signed-off-by: Yang Zhang yang.zh...@intel.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c index 74a7703..036cf46 100644 --- a/qemu/hw/ipf.c +++ b/qemu/hw/ipf.c @@

[PATCH] kvm: external module: replace msr-index.h by an empty file

2009-01-15 Thread Avi Kivity
From: Avi Kivity a...@redhat.com fixes duplicate definitions. Signed-off-by: Avi Kivity a...@redhat.com diff --git a/kernel/include-compat/asm-x86/msr-index.h b/kernel/include-compat/asm-x86/msr-index.h dissimilarity index 100% index e7625b1..1eb03c6 100644 ---

[PATCH] kvm: qemu: make qemu_alloc_physram() and alloc_mem_area() static

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/vl.c:4667: warning: no previous prototype for ‘alloc_mem_area’ qemu/vl.c:4710: warning: no previous prototype for ‘qemu_alloc_physram’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git

[PATCH] kvm: qemu: make lsi_scsi_uninit() static

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/hw/lsi53c895a.c:1964: warning: no previous prototype for ‘lsi_scsi_uninit’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/hw/lsi53c895a.c b/qemu/hw/lsi53c895a.c index

[PATCH] kvm: qemu: device-assignment: don't use libkvm's private get_slot()

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com get_slot() isn't exported by libkvm, so we shouldn't be using it. The worst thing that can happen because of this change is that libkvm will spew a warning. It looks to me like that can't happen though. Fixes: qemu/hw/device-assignment.c:161: warning:

[PATCH] kvm: libkvm: make get_slot() and co. static

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/libkvm/kvm-common.h b/libkvm/kvm-common.h index c5beacc..00fb16d 100644 --- a/libkvm/kvm-common.h +++ b/libkvm/kvm-common.h @@ -63,14 +63,6 @@ struct

[PATCH] kvm: qemu: kill unused variable

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/hw/pc.c: In function ‘pc_init1’: qemu/hw/pc.c:812: warning: unused variable ‘opt_rom_offset’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c index

[PATCH] kvm: qemu: Fix virtio_blk_init() calls

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com This QEMU commit: pci: virtio: use pci id defines (Gerd Hoffman) removed the vendor/device id parameters from virtio_blk_init(). Fixes: qemu/hw/device-hotplug.c: In function ‘qemu_system_hot_add_storage’: qemu/hw/device-hotplug.c:165: warning:

[PATCH] kvm: qemu: device-assignment: add assigned_dev_update_irq() prototype

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/hw/device-assignment.c:494: warning: no previous prototype for ‘assigned_dev_update_irq’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/hw/device-assignment.h

[PATCH] kvm: qemu: kill redundant declaration of smp_cpus and vm_running

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Defined in sysemu.h, included by qemu-kvm.c qemu/qemu-kvm.c:41: warning: redundant redeclaration of ‘smp_cpus’ qemu/sysemu.h:98: warning: previous declaration of ‘smp_cpus’ was here qemu/qemu-kvm.c:219: warning: redundant redeclaration of

[PATCH] kvm: qemu: kill redundant declarion of perror()

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com stdio.h is included by qemu-common.h Fixes: qemu/qemu-kvm.c:37: warning: redundant redeclaration of ‘perror’ /usr/include/stdio.h:817: warning: previous declaration of ‘perror’ was here Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by:

[PATCH] kvm: qemu: make qemu_kvm_system_reset() static

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/qemu-kvm.c:373: warning: no previous prototype for ‘qemu_kvm_system_reset’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index 7b81d0f..fe05f3e

[PATCH] kvm: qemu: kill unused variable in kvm_init_vcpu()

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com qemu/qemu-kvm.c: In function ‘kvm_init_vcpu’: qemu/qemu-kvm.c:460: warning: unused variable ‘cpu’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index

[PATCH] kvm: libkvm: Add a wrapper for an ioctl for the KVM_SET_CPUID2 interface

2009-01-15 Thread Avi Kivity
From: Amit Shah amit.s...@redhat.com kvm_set_cpuid2() builds on top of kvm_set_cpuid() and correctly populates cpuid functions that have sub-leaves. Signed-off-by: Amit Shah amit.s...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/libkvm/libkvm-x86.c b/libkvm/libkvm-x86.c

[PATCH] kvm: libkvm: Fix typo in the documentation header

2009-01-15 Thread Avi Kivity
From: Amit Shah amit.s...@redhat.com s/breif/brief Signed-off-by: Amit Shah amit.s...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h index 5728b1c..5c243b8 100644 --- a/libkvm/libkvm.h +++ b/libkvm/libkvm.h @@ -397,7 +397,7 @@ int

[PATCH] kvm: qemu: make another couple of functions static

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Fixes: qemu/qemu-kvm.c:1170: warning: no previous prototype for ‘kvm_get_dirty_pages_log_range’ qemu/qemu-kvm.c:1200: warning: no previous prototype for ‘kvm_get_dirty_bitmap_cb’ Signed-off-by: Mark McLoughlin mar...@redhat.com Signed-off-by: Avi

[PATCH] kvm: qemu: device-assignment: fix ROM writing

2009-01-15 Thread Avi Kivity
From: Mark McLoughlin mar...@redhat.com Cast the struct option_rom_header* to uint8_t* for write_rom(). Fixes: qemu/hw/device-assignment.c: In function ‘scan_option_rom’: qemu/hw/device-assignment.c:766: warning: passing argument 2 of ‘cpu_physical_memory_write_rom’ from incompatible

[PATCH] KVM: ia64: fix fp fault/trap handler

2009-01-15 Thread Avi Kivity
From: Yang Zhang yang.zh...@intel.com The floating-point registers f6-f11 is used by vmm and saved in kvm-pt-regs, so should set the correct bit mask and the pointer in fp_state, otherwise, fpswa may touch vmm's fp registers instead of guests'. In addition, for fp trap handling, since the

Re: how to assign partition as partition for KVM?

2009-01-15 Thread paolo pedaletti
Ciao Толя, Is there any way to assign single partition to KVM virtual machine (for example, i need to assign /dev/sda1 on my host as /dev/hda1 on VM) In XEN this assignment looks like disk=[ 'phy:/dev/lvm_dg-vol1,xvda1,w',]. with LVM, you can do that: kvm . -drive

Re: [PATCH] KVM : Qemu: update call pci_nic_init

2009-01-15 Thread Mark McLoughlin
Hi, On Thu, 2009-01-15 at 15:36 +0800, Zhang, Yang wrote: Hi As the definition pci_nic_init has modified, this patch update the corresponding calling in ipf_init1(). Yep, qemu/hw/ipf.c isn't upstream so it didn't get updated when the function was changed. Is there a plan to merge ia64 stuff

RE: [PATCH] KVM : Qemu: update call pci_nic_init

2009-01-15 Thread Zhang, Xiantao
Mark McLoughlin wrote: Hi, On Thu, 2009-01-15 at 15:36 +0800, Zhang, Yang wrote: Hi As the definition pci_nic_init has modified, this patch update the corresponding calling in ipf_init1(). Yep, qemu/hw/ipf.c isn't upstream so it didn't get updated when the function was changed. Is

Re: [PATCH] KVM : Qemu: update call pci_nic_init

2009-01-15 Thread Avi Kivity
Zhang, Yang wrote: Hi As the definition pci_nic_init has modified, this patch update the corresponding calling in ipf_init1(). From 53a66f524a6c2215d61da797cca4b7b1acbb1266 Mon Sep 17 00:00:00 2001 From: Yang yang.zh...@intel.com Date: Thu, 15 Jan 2009 13:09:43 +0800 Subject: [PATCH] KVM :

Re: e500 KVM build fixes for 2.6.29

2009-01-15 Thread Avi Kivity
Hollis Blanchard wrote: Avi, these patches fix build issues in the new e500 code. Please apply for 2.6.29. Thanks! Applied for 2.6.30, but e500 isn't in 2.6.29? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH] KVM: x86: Fix typos and whitespace errors

2009-01-15 Thread Avi Kivity
Amit Shah wrote: Some typos, comments, whitespace errors corrected in the cpuid code Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: Support for cpuid functions with subleaves

2009-01-15 Thread Avi Kivity
Amit Shah wrote: Hello, v3 of the patch uses the KVM_SET_CPUID2 interface to not cause any userspace and kernel incompatibilities. With these patches applied, I can run a VM with a newer CPU type (core2duo). Fixes bug #2413430 Please apply Applied both, thanks. -- error compiling

Re: [PATCH] kvm: libkvm: Fix typo in the documentation header

2009-01-15 Thread Avi Kivity
Amit Shah wrote: s/breif/brief Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd

2009-01-15 Thread Avi Kivity
Amit Shah wrote: These patches add support for cpuid functions that take a 'count' parameter in addition to the function number. With these patches, KVM can run a VM started with a newer CPU type (coreduo, core2duo). These patches also pave way for a host CPU type, where we could pass the CPU

Re: FW: [PATCH] Kvm: Qemu: save nvram

2009-01-15 Thread Avi Kivity
Zhang, Yang wrote: Hi This is refreshed patch. Please review it. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/2] kvm: libkvm: support for irq routing

2009-01-15 Thread Avi Kivity
Sheng Yang wrote: On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com Do we need a lock for the table? No, that's up to the caller. libkvm is just a silly wrapper for the ioctls. In practice, the table will be protected by

Re: [PATCH 1/2] kvm: libkvm: support for irq routing

2009-01-15 Thread Avi Kivity
Sheng Yang wrote: On Thursday 15 January 2009 14:17:16 Sheng Yang wrote: On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com Do we need a lock for the table? And kvm_add_irq_route/kvm_del_irq_route should be generic used, how

Re: [PATCH 1/2] kvm: libkvm: support for irq routing

2009-01-15 Thread Sheng Yang
On Thursday 15 January 2009 17:59:43 Avi Kivity wrote: Sheng Yang wrote: On Thursday 15 January 2009 14:17:16 Sheng Yang wrote: On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com Do we need a lock for the table? And

Re: [PATCH 1/2] kvm: libkvm: support for irq routing

2009-01-15 Thread Avi Kivity
Sheng Yang wrote: On Thursday 15 January 2009 17:59:43 Avi Kivity wrote: Sheng Yang wrote: On Thursday 15 January 2009 14:17:16 Sheng Yang wrote: On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com Do we need a

Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd

2009-01-15 Thread Amit Shah
On Thu, Jan 15, 2009 at 11:54:09AM +0200, Avi Kivity wrote: Amit Shah wrote: These patches add support for cpuid functions that take a 'count' parameter in addition to the function number. With these patches, KVM can run a VM started with a newer CPU type (coreduo, core2duo). These patches

pci device assignment as non-root?

2009-01-15 Thread Michael Tokarev
Hello! I'm - finally - experimenting with PCI device assignment in kvm-83, starting with something as simple as an internal dialup modem (not softmodem) which uses no DMA and does not share IRQ with other devices. The thing works just fine, but only when run as root. When running as non-root,

Re: [Qemu-devel] Re: [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config

2009-01-15 Thread Jamie Lokier
Paul Brook wrote: What I meant is that if we allow the guest to change his mac address, it can deliberately change it to other hosts/guests mac and thus create networking problems. Although guest can always mangle packets, maybe it worth enforcing these macs for the guest. This

Re: [Qemu-devel] Re: [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config

2009-01-15 Thread Jamie Lokier
Dor Laor wrote: What I meant is that if we allow the guest to change his mac address, it can deliberately change it to other hosts/guests mac and thus create networking problems. Although guest can always mangle packets, maybe it worth enforcing these macs for the guest. Although it can

[PATCH] Allow to call vm_stop from vcpu thread

2009-01-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index e4fba78..484a232 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -296,11 +296,15 @@ static void pause_all_threads(void) { CPUState *penv = first_cpu; -assert(!cpu_single_env); -

Re: pci device assignment as non-root?

2009-01-15 Thread Avi Kivity
Michael Tokarev wrote: Hello! I'm - finally - experimenting with PCI device assignment in kvm-83, starting with something as simple as an internal dialup modem (not softmodem) which uses no DMA and does not share IRQ with other devices. The thing works just fine, but only when run as root.

Re: [PATCH] Allow to call vm_stop from vcpu thread

2009-01-15 Thread Jan Kiszka
Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index e4fba78..484a232 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -296,11 +296,15 @@ static void pause_all_threads(void) { CPUState *penv = first_cpu; -

[PATCH 02/18] kvm: qemu: make qemu_alloc_physram() and alloc_mem_area() static

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/vl.c:4667: warning: no previous prototype for ‘alloc_mem_area’ qemu/vl.c:4710: warning: no previous prototype for ‘qemu_alloc_physram’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 13/18] kvm: qemu: kill redundant declaration of smp_cpus and vm_running

2009-01-15 Thread Mark McLoughlin
Defined in sysemu.h, included by qemu-kvm.c qemu/qemu-kvm.c:41: warning: redundant redeclaration of ‘smp_cpus’ qemu/sysemu.h:98: warning: previous declaration of ‘smp_cpus’ was here qemu/qemu-kvm.c:219: warning: redundant redeclaration of ‘vm_running’ qemu/sysemu.h:9: warning: previous

[PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing

2009-01-15 Thread Mark McLoughlin
Use write() instead of write_rom() to write the device number. Cast the struct option_rom_header* to uint8_t* for write_rom(). Fixes: qemu/hw/device-assignment.c: In function ‘scan_option_rom’: qemu/hw/device-assignment.c:766: warning: passing argument 2 of ‘cpu_physical_memory_write_rom’

[PATCH 09/18] kvm: qemu: device-assignment: add assigned_dev_update_irq() prototype

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/hw/device-assignment.c:494: warning: no previous prototype for ‘assigned_dev_update_irq’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/hw/device-assignment.h |1 + qemu/hw/pci.c |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH 06/18] kvm: qemu: device-assignment: don't use libkvm's private get_slot()

2009-01-15 Thread Mark McLoughlin
get_slot() isn't exported by libkvm, so we shouldn't be using it. The worst thing that can happen because of this change is that libkvm will spew a warning. It looks to me like that can't happen though. Fixes: qemu/hw/device-assignment.c:161: warning: implicit declaration of function

[PATCH 04/18] kvm: qemu: make lsi_scsi_uninit() static

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/hw/lsi53c895a.c:1964: warning: no previous prototype for ‘lsi_scsi_uninit’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/hw/lsi53c895a.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu/hw/lsi53c895a.c b/qemu/hw/lsi53c895a.c index

[PATCH 08/18] kvm: qemu: device-assignment: add kvm_add_ioperm_data() prototype

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/hw/device-assignment.c:205: warning: implicit declaration of function ‘kvm_add_ioperm_data’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/qemu-kvm.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu/qemu-kvm.h b/qemu/qemu-kvm.h index

[PATCH 14/18] kvm: qemu: make qemu_kvm_system_reset() static

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/qemu-kvm.c:373: warning: no previous prototype for ‘qemu_kvm_system_reset’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/qemu-kvm.c |2 +- qemu/qemu-kvm.h |2 -- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c

[PATCH 07/18] kvm: libkvm: make get_slot() and co. static

2009-01-15 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- libkvm/kvm-common.h |8 libkvm/libkvm.c | 12 ++-- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/libkvm/kvm-common.h b/libkvm/kvm-common.h index c5beacc..00fb16d 100644 --- a/libkvm/kvm-common.h +++

[PATCH 05/18] kvm: qemu: Fix virtio_blk_init() calls

2009-01-15 Thread Mark McLoughlin
This QEMU commit: pci: virtio: use pci id defines (Gerd Hoffman) removed the vendor/device id parameters from virtio_blk_init(). Fixes: qemu/hw/device-hotplug.c: In function ‘qemu_system_hot_add_storage’: qemu/hw/device-hotplug.c:165: warning: implicit declaration of function

[PATCH 03/18] kvm: qemu: kill some redundant declarations

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/vl.c:5295: warning: redundant redeclaration of ‘kvm_pit’ qemu/vl.c:5289: warning: previous declaration of ‘kvm_pit’ was here qemu/vl.c:5541: warning: redundant redeclaration of ‘kvm_allowed’ qemu/qemu-kvm.h:144: warning: previous declaration of ‘kvm_allowed’ was here

[PATCH 11/18] kvm: qemu: kill unused variable

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/hw/pc.c: In function ‘pc_init1’: qemu/hw/pc.c:812: warning: unused variable ‘opt_rom_offset’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/hw/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c index

[PATCH 12/18] kvm: qemu: kill redundant declarion of perror()

2009-01-15 Thread Mark McLoughlin
stdio.h is included by qemu-common.h Fixes: qemu/qemu-kvm.c:37: warning: redundant redeclaration of ‘perror’ /usr/include/stdio.h:817: warning: previous declaration of ‘perror’ was here Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/qemu-kvm.c |2 -- 1 files changed, 0

[PATCH 17/18] kvm: qemu: fix update_vbios_real_tpr declaration

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/kvm-tpr-opt.c:119: warning: function declaration isn’t a prototype Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/kvm-tpr-opt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu/kvm-tpr-opt.c b/qemu/kvm-tpr-opt.c index 3aaa8a4..85fbbbc

[PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init()

2009-01-15 Thread Mark McLoughlin
NIC init functions don't return a PCIDevice pointer in upstream QEMU but they do in KVM for hotplug. Fixes: qemu/hw/pci.c:740: warning: initialization from incompatible pointer type Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/hw/virtio-net.c |6 -- qemu/hw/virtio-net.h

[PATCH 15/18] kvm: qemu: kill unused variable in kvm_init_vcpu()

2009-01-15 Thread Mark McLoughlin
qemu/qemu-kvm.c: In function ‘kvm_init_vcpu’: qemu/qemu-kvm.c:460: warning: unused variable ‘cpu’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/qemu-kvm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index

[PATCH 16/18] kvm: qemu: make another couple of functions static

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/qemu-kvm.c:1170: warning: no previous prototype for ‘kvm_get_dirty_pages_log_range’ qemu/qemu-kvm.c:1200: warning: no previous prototype for ‘kvm_get_dirty_bitmap_cb’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/qemu-kvm.c | 12 ++-- 1 files changed, 6

[PATCH 18/18] kvm: qemu: kill unused variable in enable_vapic()

2009-01-15 Thread Mark McLoughlin
Fixes: qemu/kvm-tpr-opt.c:22: warning: redundant redeclaration of ‘kvm_context’ Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu/kvm-tpr-opt.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu/kvm-tpr-opt.c b/qemu/kvm-tpr-opt.c index 85fbbbc..44b453f

Re: [PATCH] Allow to call vm_stop from vcpu thread

2009-01-15 Thread Gleb Natapov
On Thu, Jan 15, 2009 at 02:43:49PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index e4fba78..484a232 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -296,11 +296,15 @@ static void

Re: [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing

2009-01-15 Thread Avi Kivity
Mark McLoughlin wrote: Use write() instead of write_rom() to write the device number. Cast the struct option_rom_header* to uint8_t* for write_rom(). Fixes: qemu/hw/device-assignment.c: In function ‘scan_option_rom’: qemu/hw/device-assignment.c:766: warning: passing argument 2 of

Re: [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init()

2009-01-15 Thread Avi Kivity
Mark McLoughlin wrote: NIC init functions don't return a PCIDevice pointer in upstream QEMU but they do in KVM for hotplug. Fixes: qemu/hw/pci.c:740: warning: initialization from incompatible pointer type I should have caught this while merging, argh. Applied all patches except #10,

Re: [PATCH] Allow to call vm_stop from vcpu thread

2009-01-15 Thread Jan Kiszka
Gleb Natapov wrote: On Thu, Jan 15, 2009 at 02:43:49PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index e4fba78..484a232 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -296,11 +296,15 @@

Re: [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing

2009-01-15 Thread Mark McLoughlin
On Thu, 2009-01-15 at 15:54 +0200, Avi Kivity wrote: Mark McLoughlin wrote: Use write() instead of write_rom() to write the device number. Cast the struct option_rom_header* to uint8_t* for write_rom(). Fixes: qemu/hw/device-assignment.c: In function ‘scan_option_rom’:

Re: [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init()

2009-01-15 Thread Mark McLoughlin
On Thu, 2009-01-15 at 15:58 +0200, Avi Kivity wrote: Mark McLoughlin wrote: NIC init functions don't return a PCIDevice pointer in upstream QEMU but they do in KVM for hotplug. Fixes: qemu/hw/pci.c:740: warning: initialization from incompatible pointer type I should have

Re: [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing

2009-01-15 Thread Avi Kivity
Mark McLoughlin wrote: Why drop _rom? The memory region is registered as a rom, a few lines earlier? My mistake, can you just apply the change to the first line? Sure, applied with _rom. -- error compiling committee.c: too many arguments to function -- To unsubscribe from

Re: [PATCH] KVM: IA64: fix fp fault/trap handler

2009-01-15 Thread Avi Kivity
Zhang, Yang wrote: Hi Please help me to review it. Best Regards --yang From 9035b13377119cd7019f7e27624491dcb5e1c2d0 Mon Sep 17 00:00:00 2001 From: Yang Zhang yang.zh...@intel.com Date: Thu, 8 Jan 2009 15:13:31 +0800 Subject: [PATCH] KVM: IA64: fix fp fault/trap handler The floating-point

Re: is vmx_vcpu_run deprecated in kvm-77?

2009-01-15 Thread Avi Kivity
Steven Stovall wrote: I am porting an app from kvm-33 to kvm-77 (the app is also known to work on kvm-60 i believe). But so far I havent seen a KVM_EXIT_IO, only KVM_EXIT_INTRs. This means the app never changes state. Also, I never see vmx_vcpu_run called -- does x86/x86.c:__vcpu_run

Re: Guest Hang Bugs

2009-01-15 Thread Avi Kivity
James Thomason wrote: Hello, I am able to reliably reproduce a condition where a guest goes into a tight loop or spinlock on all running cores. The scenario is exactly as described in bug 2351676, though my environment differs as detailed below. My observation is that the issue is correlated

[ kvm-Bugs-2487340 ] Possible memory corruption when file RAM

2009-01-15 Thread SourceForge.net
Bugs item #2487340, was opened at 2009-01-05 21:09 Message generated for change (Comment added) made by jaketmuss You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2487340group_id=180599 Please note that this message will contain a full copy of the comment

Re: [PATCH] qemu/configure: correctly detect -lrt ldflag on uclibc

2009-01-15 Thread Avi Kivity
Natanael Copa wrote: Hi, I managed to build kvm on/for my uclibc distro, Alpine linux. The qemu configure script failed to detect if it needed the -lrt ldflag. the attatched patch fixes the test. It applies to the just released 83 release as well. Please submit this to

Re: how to assign partition as partition for KVM?

2009-01-15 Thread Javier Guerra
On Thu, Jan 15, 2009 at 3:05 AM, paolo pedaletti paolo.pedale...@gmail.com wrote: Ciao Толя, Is there any way to assign single partition to KVM virtual machine (for example, i need to assign /dev/sda1 on my host as /dev/hda1 on VM) In XEN this assignment looks like disk=[

[PATCH] virtio-net: Fix save/load

2009-01-15 Thread Alex Williamson
We can't rely on build switches to tell us if a save image includes a given field. We also need to save status since it's visible to the guest. Draw another line in the sand for broken save versions. The version number should always be updated when new values are saved and load should make an

Re: [PATCH] virtio-net: Fix save/load

2009-01-15 Thread Mark McLoughlin
Hi Alex, On Thu, 2009-01-15 at 11:05 -0700, Alex Williamson wrote: We can't rely on build switches to tell us if a save image includes a given field. Uggh, good point. We also need to save status since it's visible to the guest. Actually, we really need to handle VLANClientState:link_down

Re: [PATCH] virtio-net: Fix save/load

2009-01-15 Thread Alex Williamson
Hi Mark, On Thu, 2009-01-15 at 18:21 +, Mark McLoughlin wrote: Actually, we really need to handle VLANClientState:link_down for all vlan clients, not just virtio-net and then update status on load according to link_down. It's not critically important, though - if we neglect to save/load

Re: [PATCH] virtio-net: Fix save/load

2009-01-15 Thread Mark McLoughlin
On Thu, 2009-01-15 at 11:39 -0700, Alex Williamson wrote: version_id) { VirtIONet *n = opaque; -if (version_id != 2) +if (version_id 3 || version_id VIRTIO_NET_VM_VERSION) This bit isn't right - how can this code load e.g. version 4? It can't. There's no

Re: [ANNOUNCE] kvm-83 release

2009-01-15 Thread Farkas Levente
Avi Kivity wrote: Farkas Levente wrote: Avi Kivity wrote: The biggest change this time around is support for the AMD IOMMU for device assignment. As it requires extensive core kernel support, it is only available on Linux 2.6.29rc1 or higher hosts. status report on rhel/centos-5.2

Re: [PATCH 1/2] KVM: CPUID takes ecx as input value for some functions

2009-01-15 Thread Anthony Liguori
Amit Shah wrote: The CPUID instruction takes the value of ECX as an input parameter in addition to the value of EAX as the count for functions 4, 0xb and 0xd. Make sure we pass the value to the instruction. Also convert to the qemu-style whitespace for the surrounding code. Signed-off-by: Amit

Re: [PATCH] Always return latest pmsts instead of the old one.

2009-01-15 Thread Anthony Liguori
Zhang, Xiantao wrote: For get_pmsts of acpi, it should always return latest value instead of the old one. Xiantao From: Xiantao Zhang xiantao.zh...@intel.com Date: Tue, 13 Jan 2009 17:42:16 +0800 Subject: [PATCH] Always return latest pmsts instead of the old one. It may lead to the issue

Re: [PATCH] qemu: report issues causing the kvm probe to fail v3

2009-01-15 Thread Anthony Liguori
This applies to qemu upstream already when not specifying -p or -p 2 (as I already tested yesterday before submission). Well I removed the leading qemu dir manually and updated the -51 lines offset (attached), should I change more than that (add the leading trunk maybe, atm I'm just not

Re: Guest Hang Bugs

2009-01-15 Thread James Thomason
On 1/15/09 7:27 AM, Avi Kivity a...@redhat.com wrote: Cam you try adding clocksource=acpi_pm to the _guest_ kernel command line? Avi, I booted the guest with clocksource=acpi_pm and it has been running under heavy load for about 4 hours with kvm -smp 12. Considering that the guest

Re: BUG: Guest lockup and 100% CPU load on host

2009-01-15 Thread James Thomason
Jan, I spent some time with the same problem over the last two days. Avi Kivity suggested adding clocksource=acpi_pm to the guest kernel boot line, and that seems to have resolved the issue. Would you give that a try and let me know the result? Also I believe the following bugs might be

Re: Guest Hang Bugs

2009-01-15 Thread James Thomason
Avi and others, The system under load finally panicked and all cores hit 100%, so I spoke too soon. Unfortunately my console was garbled and I was not able to get the text of that panic. Afterwards I am unable to boot the guest with kvm -smp 2 because the guest panics at boot time. The text

Re: e500 KVM build fixes for 2.6.29

2009-01-15 Thread Avi Kivity
Hollis Blanchard wrote: Avi, these patches fix build issues in the new e500 code. Please apply for 2.6.29. Thanks! Applied for 2.6.30, but e500 isn't in 2.6.29? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe

[PATCH 0/9] powerpc/kvm: Add MPC85xx platform support

2009-01-15 Thread Liu Yu
This patchset enable the support of MPC85xx platform in qemu/kvm. patch 1,2: bug fix patch 3: enable mpic for E500 core. patch 4: enable E500 mmu in kvm mode. patch 5: add E500 pci controller emulation. patch 6: add E500 irq support patch 7: add E500 core emulation patch 8: extern one function

[PATCH 7/9] powerpc/kvm: Add E500 core emulation

2009-01-15 Thread Liu Yu
Signed-off-by: Liu Yu yu@freescale.com --- Makefile.target |1 + hw/ppce500.c| 49 + hw/ppce500.h| 44 3 files changed, 94 insertions(+), 0 deletions(-) create mode 100644

[PATCH 6/9] powerpc/kvm: Add E500 irq support

2009-01-15 Thread Liu Yu
Signed-off-by: Liu Yu yu@freescale.com --- hw/ppc.c| 89 +++ hw/ppc.h|1 + target-ppc/cpu.h| 12 ++ target-ppc/translate_init.c |6 ++- 4 files changed, 106 insertions(+), 2

Re: [PATCH 7/9] powerpc/kvm: Add E500 core emulation

2009-01-15 Thread Hollis Blanchard
On Thu, 2009-01-15 at 20:34 +0800, Liu Yu wrote: Signed-off-by: Liu Yu yu@freescale.com --- Makefile.target |1 + hw/ppce500.c| 49 + hw/ppce500.h| 44 3 files changed, 94

Re: [PATCH 0/9] powerpc/kvm: Add MPC85xx platform support

2009-01-15 Thread Hollis Blanchard
On Thu, 2009-01-15 at 20:34 +0800, Liu Yu wrote: This patchset enable the support of MPC85xx platform in qemu/kvm. patch 1,2: bug fix patch 3: enable mpic for E500 core. patch 4: enable E500 mmu in kvm mode. patch 5: add E500 pci controller emulation. patch 6: add E500 irq support patch