Re: With -vnc option, can I still use "ctrl+alt + n"?

2009-02-18 Thread Tomasz Chmielewski
Neo Jia schrieb: hi, I am trying kvm-84 and with -vnc option I can't use "ctrl + alt + n" key to get the qemu system console. Is there anyway to make this work? Use Qemu/KVM monitor and it's "sendkey" function. For example: sendkey alt-f3 -- Tomasz Chmielewski http://wpkg.org -- To unsubsc

With -vnc option, can I still use "ctrl+alt + n"?

2009-02-18 Thread Neo Jia
hi, I am trying kvm-84 and with -vnc option I can't use "ctrl + alt + n" key to get the qemu system console. Is there anyway to make this work? Thanks, Neo -- I would remember that if researchers were not ambitious probably today we haven't the technology we are using! -- To unsubscribe from th

RE: [PATCH 7/8] kvm: qemu: deassign device from guest

2009-02-18 Thread Han, Weidong
Marcelo Tosatti wrote: > Weidong, > > Does this set fix > > http://sourceforge.net/tracker2/?func=detail&aid=2432316&group_id=180599&atid=893831 > I found above bug was already gone even without my patch. I guess it's fixed by Mark: commit: 02874f4272b6787ff94ee7256ef083257b9d1eb1 Author: Mar

Re: Running KVM on a Laptop

2009-02-18 Thread TJ
On Wed, 2009-02-18 at 08:45 +0100, Louis-David Mitterrand wrote: > > Is it not as simple as checking for the svm or vt flags? > > No, one must also check that the bios allows enabling virtualization > support. My sony laptop has the right processor but no bios option. > Check that first! Louis-Da

RE: [PATCH 01/02] ia64: Move the macro definitions related to MSI to one header file.

2009-02-18 Thread Zhang, Xiantao
Agree, it should go to Tony's Tree in theory, but we have to push it into Avi's tree first to fix an build issue. So please help to commit the patch to kvm.git with Tony's Ack, Thanks! Xiantao -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Thursday, Februar

RE: copyless virtio net thoughts?

2009-02-18 Thread Dong, Eddie
Simon Horman wrote: > On Wed, Feb 18, 2009 at 10:08:00PM +1030, Rusty Russell > wrote: >> >> 2) Direct NIC attachment This is particularly >> interesting with SR-IOV or other multiqueue nics, but >> for boutique cases or benchmarks, could be for normal >> NICs. So far I have some very sketched-o

Re: copyless virtio net thoughts?

2009-02-18 Thread Simon Horman
On Wed, Feb 18, 2009 at 10:08:00PM +1030, Rusty Russell wrote: > > 2) Direct NIC attachment This is particularly interesting with SR-IOV or > other multiqueue nics, but for boutique cases or benchmarks, could be for > normal NICs. So far I have some very sketched-out patches: for the > attached n

Re: Recent kvm and vmware server comparisons?

2009-02-18 Thread Thomas Fjellstrom
On Wednesday 18 February 2009, Martin Maurer wrote: > > I suppose no-one has any? > > VMware includes in its EULA (End User License Agreement) a prohibition for > any licensee to publish benchmark results without VMware's approval. (see > https://www.vmware.com/tryvmware/eula.php) > > Maybe this is

Re: [PATCH 01/02] ia64: Move the macro definitions related to MSI to one header file.

2009-02-18 Thread Marcelo Tosatti
Looks good, should go through Tony's tree I believe. On Wed, Feb 18, 2009 at 10:17:56AM +0800, Zhang, Xiantao wrote: > Thanks, Tony! It should not break anything due to no changes about code > logic. :) > > Avi, > Could you help to commit the patches with Tony's Ack ? Thanks! > Xiantao >

[ kvm-Bugs-2556746 ] FreeBSD/PC-BSD text screen corruption

2009-02-18 Thread SourceForge.net
Bugs item #2556746, was opened at 2009-02-02 13:19 Message generated for change (Comment added) made by aurel32 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2556746&group_id=180599 Please note that this message will contain a full copy of the comment t

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Anthony Liguori
Avi Kivity wrote: Tomasz Chmielewski wrote: Looks I'm a bad, bad, anti-environment CO2 contributor then. From a technical perspective, what are the problems with my CPU that it scales down on the host just fine, but makes the guests "return to the past"? What kvm version are you using? kvm

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 09:02:31PM +0100, Tomasz Chmielewski wrote: > Marcelo Tosatti schrieb: >> On Wed, Feb 18, 2009 at 08:18:50PM +0100, Tomasz Chmielewski wrote: >>> Marcelo Tosatti schrieb: >>> > - what CPU frequency will the guests show? Current host > frequency? Host frequency from

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Marcelo Tosatti schrieb: On Wed, Feb 18, 2009 at 08:18:50PM +0100, Tomasz Chmielewski wrote: Marcelo Tosatti schrieb: - what CPU frequency will the guests show? Current host frequency? Host frequency from the moment the guest booted (i.e. right now the guest will show 1GHz even if the host

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 08:18:50PM +0100, Tomasz Chmielewski wrote: > Marcelo Tosatti schrieb: > >>> - what CPU frequency will the guests show? Current host frequency? >>> Host frequency from the moment the guest booted (i.e. right now the >>> guest will show 1GHz even if the host is running at

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Marcelo Tosatti schrieb: - what CPU frequency will the guests show? Current host frequency? Host frequency from the moment the guest booted (i.e. right now the guest will show 1GHz even if the host is running at 2GHz, or the way around)? Host frequency from the moment the guest booted, sinc

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 08:07:48PM +0100, Tomasz Chmielewski wrote: > Marcelo Tosatti schrieb: > >>> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca >>> cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt >>> rdtscp lm 3dnowext 3dnow rep_good pni cx16

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Marcelo Tosatti schrieb: flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy bogomips: 3993.20 TLB size

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 07:53:11PM +0100, Tomasz Chmielewski wrote: > processor : 2 > vendor_id : AuthenticAMD > cpu family : 15 model : 65 model name > : Dual-Core AMD Opteron(tm) Processor 2212 > stepping: 2

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Marcelo Tosatti schrieb: On Wed, Feb 18, 2009 at 03:51:22PM +0100, Tomasz Chmielewski wrote: Is using cpufreq (i.e. with ondemand governor) on KVM host safe for guests? I enabled cpufreq on the host, it scaled down the host CPU (Dual-Core AMD Opteron(tm) Processor 2212) to 1 GHz from 2 GHz.

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 03:51:22PM +0100, Tomasz Chmielewski wrote: > Is using cpufreq (i.e. with ondemand governor) on KVM host safe for guests? > > I enabled cpufreq on the host, it scaled down the host CPU (Dual-Core > AMD Opteron(tm) Processor 2212) to 1 GHz from 2 GHz. > > Guest (using 1 CPU

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Marcelo Tosatti
On Wed, Feb 18, 2009 at 02:54:37PM +0100, Joerg Roedel wrote: > > Adding __GFP_ZERO here will cause us to clear the page twice, which is > > wasteful. > > The assertion which the attached patch removes fails sometimes. Removing > this assertion is the alternative solution to this problem ;-) >

Re: [PATCH 2/3] kvm mmu: remove redundant check in mmu_set_spte

2009-02-18 Thread Marcelo Tosatti
The following code flow is unnecessary: if (largepage) was_rmapped = is_large_pte(*shadow_pte); else was_rmapped = 1; The is_large_pte() function will always evaluate to one here because the (largepage && !is_large_pte) case is already handled in

Re: [PATCH 1/3] kvm mmu: handle compound pages in kvm_is_mmio_pfn

2009-02-18 Thread Marcelo Tosatti
BTW some page bits are erroneously transferred to the struct page's within the compound page. We've got away with that so far because these bits (such as dirty and accessed) are not used by the limited hugetlb/hugetlbfs implementation ATM. Acked-by: Marcelo Tosatti On Wed, Feb 18, 2009 at 02:0

Re: [PATCH 7/8] kvm: qemu: deassign device from guest

2009-02-18 Thread Marcelo Tosatti
Weidong, Does this set fix http://sourceforge.net/tracker2/?func=detail&aid=2432316&group_id=180599&atid=893831 On Wed, Feb 18, 2009 at 03:13:05PM +0800, Han, Weidong wrote: > free_assigned_device just frees device from qemu, it should also > deassign the device from guest when guest exits or h

Re: [PATCH 3/8] kvm: qemu: fix hot assign device

2009-02-18 Thread Marcelo Tosatti
Acked-by: Marcelo Tosatti On Wed, Feb 18, 2009 at 03:12:31PM +0800, Han, Weidong wrote: > Last qemu merge broke device assignment hotplug. Call > qemu_pci_hot_assign_device in pci_device_hot_add for > hot assign device, and add the command for it. > for example hot assign 01:00.0, can use follo

Re: Current KVM head crashes on startup

2009-02-18 Thread Avi Kivity
Brian Kress wrote: When I try to run KVM built off the current head, it crashes with a Segmentation fault. KVM-84 does not. Seems to be dealing with the CPUID changes: 0x081a5c70 in host_cpuid () at /home/kressb/kvm/src/qemu/target-i386/helper.c:1426 1426asm volatile("pu

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Avi Kivity schrieb: Tomasz Chmielewski wrote: Looks I'm a bad, bad, anti-environment CO2 contributor then. From a technical perspective, what are the problems with my CPU that it scales down on the host just fine, but makes the guests "return to the past"? What kvm version are you using? k

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Avi Kivity
Tomasz Chmielewski wrote: Looks I'm a bad, bad, anti-environment CO2 contributor then. From a technical perspective, what are the problems with my CPU that it scales down on the host just fine, but makes the guests "return to the past"? What kvm version are you using? kvm-84 should fix this

Re: copyless virtio net thoughts?

2009-02-18 Thread Arnd Bergmann
On Wednesday 18 February 2009, Rusty Russell wrote: > 2) Direct NIC attachment > This is particularly interesting with SR-IOV or other multiqueue nics, > but for boutique cases or benchmarks, could be for normal NICs. So > far I have some very sketched-out patches: for the attached nic > dev_all

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Anthony Liguori schrieb: Tomasz Chmielewski wrote: Is using cpufreq (i.e. with ondemand governor) on KVM host safe for guests? I enabled cpufreq on the host, it scaled down the host CPU (Dual-Core AMD Opteron(tm) Processor 2212) to 1 GHz from 2 GHz. Not with your processor. Intel processor

Re: Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Anthony Liguori
Tomasz Chmielewski wrote: Is using cpufreq (i.e. with ondemand governor) on KVM host safe for guests? I enabled cpufreq on the host, it scaled down the host CPU (Dual-Core AMD Opteron(tm) Processor 2212) to 1 GHz from 2 GHz. Not with your processor. Intel processors should be fine and any A

Houston, we have May 15, 1953 (says guest when host uses cpufreq, and dies)

2009-02-18 Thread Tomasz Chmielewski
Is using cpufreq (i.e. with ondemand governor) on KVM host safe for guests? I enabled cpufreq on the host, it scaled down the host CPU (Dual-Core AMD Opteron(tm) Processor 2212) to 1 GHz from 2 GHz. Guest (using 1 CPU) was still showing that it has a 2 GHz CPU in /proc/cpuinfo (I guess this v

Re: [PATCH 1/4] KVM: Fix wrong usage of _IOR in assigned device interface

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: _IOR for copy_to_user and _IOW for copy_from_user... Noticed by Avi. Signed-off-by: Sheng Yang --- include/linux/kvm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/kvm.h b/include/linux/kvm.h index 2163b3d..d742cbf 100644 --- a/in

[PATCH 1/4] KVM: Fix wrong usage of _IOR in assigned device interface

2009-02-18 Thread Sheng Yang
_IOR for copy_to_user and _IOW for copy_from_user... Noticed by Avi. Signed-off-by: Sheng Yang --- include/linux/kvm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/kvm.h b/include/linux/kvm.h index 2163b3d..d742cbf 100644 --- a/include/linux/kvm.h ++

[PATCH 3/4] KVM: Add MSI-X interrupt injection logic

2009-02-18 Thread Sheng Yang
We have to handle more than one interrupt with one handler for MSI-X. Avi suggested to use a flag to indicate the pending. So here is it. Signed-off-by: Sheng Yang --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c | 66 +- 2 files chang

[PATCH 4/4] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Sheng Yang
This patch finally enable MSI-X. What we need for MSI-X: 1. Intercept one page in MMIO region of device. So that we can get guest desired MSI-X table and set up the real one. Now this have been done by guest, and transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY. 2. Informatio

[PATCH 2/4] KVM: Ioctls for init MSI-X entry

2009-02-18 Thread Sheng Yang
Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls. This two ioctls are used by userspace to specific guest device MSI-X entry number and correlate MSI-X entry with GSI during the initialization stage. MSI-X should be well initialzed before enabling. Don't support change MSI-X entry num

[PATCH 0/3 v4] MSI-X enabling

2009-02-18 Thread Sheng Yang
-- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: Recent kvm and vmware server comparisons?

2009-02-18 Thread Martin Maurer
> I suppose no-one has any? > VMware includes in its EULA (End User License Agreement) a prohibition for any licensee to publish benchmark results without VMware's approval. (see https://www.vmware.com/tryvmware/eula.php) Maybe this is a reason why all published VMWare benchmarks looks quite si

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Avi Kivity
Joerg Roedel wrote: sp->spt is allocated using mmu_memory_cache_alloc(), which zeros the page. How can the assertion fail? In the code I see (current kvm-git) mmu_memory_cache_alloc() does zero nothing. It takes the page from the preallocated pool and returns it. The pool itself is fille

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Joerg Roedel
On Wed, Feb 18, 2009 at 02:03:34PM +, Avi Kivity wrote: > Joerg Roedel wrote: > >The assertion which the attached patch removes fails sometimes. Removing > >this assertion is the alternative solution to this problem ;-) > > > >From ca45f3a2e45cd7e76ca624bb1098329db8ff83ab Mon Sep 17 00:00:00 20

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Joerg Roedel
On Wed, Feb 18, 2009 at 01:47:04PM +, Avi Kivity wrote: > Joerg Roedel wrote: > >Not using __GFP_ZERO when allocating shadow pages triggers the > >assertion in the kvm_mmu_alloc_page() when MMU debugging is enabled. > > > >Signed-off-by: Joerg Roedel > >--- > > arch/x86/kvm/mmu.c |2 +- > >

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Avi Kivity
Joerg Roedel wrote: The assertion which the attached patch removes fails sometimes. Removing this assertion is the alternative solution to this problem ;-) From ca45f3a2e45cd7e76ca624bb1098329db8ff83ab Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Wed, 18 Feb 2009 14:51:13 +0100 Subject: [P

Re: [PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Avi Kivity
Joerg Roedel wrote: Not using __GFP_ZERO when allocating shadow pages triggers the assertion in the kvm_mmu_alloc_page() when MMU debugging is enabled. Signed-off-by: Joerg Roedel --- arch/x86/kvm/mmu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.

[PATCH 3/3] kvm mmu: alloc shadow pages with __GFP_ZERO

2009-02-18 Thread Joerg Roedel
Not using __GFP_ZERO when allocating shadow pages triggers the assertion in the kvm_mmu_alloc_page() when MMU debugging is enabled. Signed-off-by: Joerg Roedel --- arch/x86/kvm/mmu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c

[PATCH 1/3] kvm mmu: handle compound pages in kvm_is_mmio_pfn

2009-02-18 Thread Joerg Roedel
The function kvm_is_mmio_pfn is called before put_page is called on a page by KVM. This is a problem when when this function is called on some struct page which is part of a compund page. It does not test the reserved flag of the compound page but of the struct page within the compount page. This i

[PATCH 2/3] kvm mmu: remove redundant check in mmu_set_spte

2009-02-18 Thread Joerg Roedel
The following code flow is unnecessary: if (largepage) was_rmapped = is_large_pte(*shadow_pte); else was_rmapped = 1; The is_large_pte() function will always evaluate to one here because the (largepage && !is_large_pte) case is already handled in t

[PATCH 0/3] KVM SoftMMU fixes

2009-02-18 Thread Joerg Roedel
Hi Avi, Marcelo, this small patch series fixes two issues and include one cleanup I ran into hacking in the KVM SoftMMU code. Please consider to apply. Joerg diffstat: arch/x86/kvm/mmu.c | 10 +++--- virt/kvm/kvm_main.c |6 -- 2 files changed, 7 insertions(+), 9 deletions(-)

Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Sheng Yang
On Wednesday 18 February 2009 20:36:10 Avi Kivity wrote: > Sheng Yang wrote: > >>> struct kvm_assigned_msix_nr { > >>> __u32 assigned_dev_id; > >>> __u16 entry_nr; > >>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > >>> index 4010802..d3acb37 100644 > >>> --- a/virt/kvm/kvm_main.c

Re: Recent kvm and vmware server comparisons?

2009-02-18 Thread Thomas Fjellstrom
On Tuesday 10 February 2009, Thomas Fjellstrom wrote: > I've temporarily got vmware server running on my new "server", and intend > to migrate over to kvm as soon as possible, if it provides enough incentive > (extra performance, features). Currently I'm waiting for full iommu support > in the kern

Re: [PATCH 7/7] [V3] kvm: qemu: fix hot remove assigned device with iommu

2009-02-18 Thread Avi Kivity
Han, Weidong wrote: device assignment hotplug doesn't work on current tree. I had a quick glance, found device assignment didn't be considered, qemu_system_hot_assign_device is not used at all. I will fix it. I noticed that during the merge, but wasn't familiar in the code to fix it mysel

Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: struct kvm_assigned_msix_nr { __u32 assigned_dev_id; __u16 entry_nr; diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 4010802..d3acb37 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -280,13 +280,33 @@ static void kvm_free_assigned_i

Re: Current KVM head crashes on startup

2009-02-18 Thread Avi Kivity
Amit Shah wrote: I don't recall, it probably depends on whether frame pointers are used or not as well. As far as I know, kvm-userspace build arguments have remained the same for quite some time. Also, we still pass the -g flag for userspace compilations. Some distros change CFLAGS.

Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Sheng Yang
On Wed, Feb 18, 2009 at 10:45:19AM +, Avi Kivity wrote: > Sheng Yang wrote: >> index a2dfbe0..78480d0 100644 >> --- a/include/linux/kvm.h >> +++ b/include/linux/kvm.h >> @@ -440,6 +440,9 @@ struct kvm_irq_routing { >> }; >> #endif >> +#if defined(CONFIG_X86) >> +#define KVM_CAP_DEVICE_MSIX 2

Re: Current KVM head crashes on startup

2009-02-18 Thread Amit Shah
On (Wed) Feb 18 2009 [11:26:42], Avi Kivity wrote: > Amit Shah wrote: >>> I don't see why it would change, unless you can destroy all copies of >>> the compilers that fail with it. >>> >> >> I'd like to know which compilers fail to compile it > > I don't recall, it probably dep

Re: copyless virtio net thoughts?

2009-02-18 Thread Herbert Xu
On Wed, Feb 18, 2009 at 10:08:00PM +1030, Rusty Russell wrote: > > 4) Multiple queues > This is Herbert's. Should be fairly simple to add; it was in the back of my > mind when we started. Not sure whether the queues should be static or > dynamic (imagine direct interguest networking, one queue

Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X

2009-02-18 Thread Sheng Yang
On Wednesday 18 February 2009 19:29:28 Avi Kivity wrote: > Sheng Yang wrote: > > On Wednesday 18 February 2009 19:00:53 Avi Kivity wrote: > >> Sheng Yang wrote: > >>> We have to handle more than one interrupt with one handler for MSI-X. > >>> So we need a bitmap to track the triggered interrupts. >

Re: copyless virtio net thoughts?

2009-02-18 Thread Rusty Russell
On Thursday 05 February 2009 12:37:32 Chris Wright wrote: > There's been a number of different discussions re: getting copyless virtio > net (esp. for KVM). This is just a poke in that general direction to > stir the discussion. I'm interested to hear current thoughts? This thread seems to have

Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: On Wednesday 18 February 2009 19:00:53 Avi Kivity wrote: Sheng Yang wrote: We have to handle more than one interrupt with one handler for MSI-X. So we need a bitmap to track the triggered interrupts. Can you explain why? Or how can we know which interrup

Re: Current KVM head crashes on startup

2009-02-18 Thread Avi Kivity
Amit Shah wrote: I don't see why it would change, unless you can destroy all copies of the compilers that fail with it. I'd like to know which compilers fail to compile it I don't recall, it probably depends on whether frame pointers are used or not as well. -- maintainin

Re: Current KVM head crashes on startup

2009-02-18 Thread Amit Shah
On (Wed) Feb 18 2009 [10:19:44], Avi Kivity wrote: > Amit Shah wrote: > > > >>> The first version generates too much register pressure for some >>> compilers on i386, leading to compilation failures. The second >>> version >> >> Is it still valid? I tried with gcc-4.1.2 and that worked

Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X

2009-02-18 Thread Sheng Yang
On Wednesday 18 February 2009 19:00:53 Avi Kivity wrote: > Sheng Yang wrote: > > We have to handle more than one interrupt with one handler for MSI-X. So > > we need a bitmap to track the triggered interrupts. > > Can you explain why? Or how can we know which interrupt happened? Current we schedul

Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: We have to handle more than one interrupt with one handler for MSI-X. So we need a bitmap to track the triggered interrupts. Can you explain why? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from th

Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: This patch finally enable MSI-X. What we need for MSI-X: 1. Intercept one page in MMIO region of device. So that we can get guest desired MSI-X table and set up the real one. Now this have been done by guest, and transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_E

Re: [PATCH 1/3] KVM: Ioctls for init MSI-X entry

2009-02-18 Thread Avi Kivity
Sheng Yang wrote: Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls. This two ioctls are used by userspace to specific guest device MSI-X entry number and correlate MSI-X entry with GSI during the initialization stage. MSI-X should be well initialzed before enabling. Don't support ch

Re: Current KVM head crashes on startup

2009-02-18 Thread Avi Kivity
Amit Shah wrote: The first version generates too much register pressure for some compilers on i386, leading to compilation failures. The second version Is it still valid? I tried with gcc-4.1.2 and that worked fine with the first version. Should we just use that version instead?

[PATCH 1/3] KVM: Ioctls for init MSI-X entry

2009-02-18 Thread Sheng Yang
Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls. This two ioctls are used by userspace to specific guest device MSI-X entry number and correlate MSI-X entry with GSI during the initialization stage. MSI-X should be well initialzed before enabling. Don't support change MSI-X entry num

[PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X

2009-02-18 Thread Sheng Yang
We have to handle more than one interrupt with one handler for MSI-X. So we need a bitmap to track the triggered interrupts. Signed-off-by: Sheng Yang --- include/linux/kvm_host.h |5 +- virt/kvm/kvm_main.c | 102 - 2 files changed, 102 inser

[PATCH 0/3 v3] MSI-X enabling

2009-02-18 Thread Sheng Yang
Updated the patchset followed Marcelo and Avi's comments. Please also review MSI/MSI-X userspace patch as well. Thanks! -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

[PATCH 3/3] KVM: Enable MSI-X for KVM assigned device

2009-02-18 Thread Sheng Yang
This patch finally enable MSI-X. What we need for MSI-X: 1. Intercept one page in MMIO region of device. So that we can get guest desired MSI-X table and set up the real one. Now this have been done by guest, and transfer to kernel using ioctl KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY. 2. Informatio

Re: Current KVM head crashes on startup

2009-02-18 Thread Amit Shah
On (Wed) Feb 18 2009 [08:49:33], Avi Kivity wrote: > Amit Shah wrote: >> On (Wed) Feb 18 2009 [13:21:26], Amit Shah wrote: >> >>> On (Tue) Feb 17 2009 [12:47:10], Brian Kress wrote: >>> When I try to run KVM built off the current head, it crashes with a Segmentation fault. KVM-

Re: Current KVM head crashes on startup

2009-02-18 Thread Avi Kivity
Amit Shah wrote: On (Wed) Feb 18 2009 [13:21:26], Amit Shah wrote: On (Tue) Feb 17 2009 [12:47:10], Brian Kress wrote: When I try to run KVM built off the current head, it crashes with a Segmentation fault. KVM-84 does not. Seems to be dealing with the CPUID changes: 0x081a5c70

Re: Current KVM head crashes on startup

2009-02-18 Thread Amit Shah
On (Wed) Feb 18 2009 [13:21:26], Amit Shah wrote: > On (Tue) Feb 17 2009 [12:47:10], Brian Kress wrote: > > When I try to run KVM built off the current head, it crashes with a > > Segmentation fault. KVM-84 does > > not. Seems to be dealing with the CPUID changes: > > > > > >0x081a5c70 in h