Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 01:37:18PM -0700, Matthew Wilcox wrote: > On Fri, Feb 20, 2009 at 02:54:45PM +0800, Yu Zhao wrote: > > + virtfn->sysdata = dev->bus->sysdata; > > + virtfn->dev.parent = dev->dev.parent; > > + virtfn->dev.bus = dev->dev.bus; > > + virtfn->devfn = devfn; > > + virtfn

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 12:44:11PM -0700, Matthew Wilcox wrote: > > Physical Function driver patches for Intel 82576 NIC are available: > > http://patchwork.kernel.org/patch/8063/ > > http://patchwork.kernel.org/patch/8064/ > > http://patchwork.kernel.org/patch/8065/ > > http://patchwork.ke

Re: [PATCH v10 1/7] PCI: initialize and release SR-IOV capability

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 01:08:10PM -0700, Matthew Wilcox wrote: > On Fri, Feb 20, 2009 at 02:54:42PM +0800, Yu Zhao wrote: > > + list_for_each_entry(pdev, &dev->bus->devices, bus_list) > > + if (pdev->sriov) > > + break; > > + if (list_empty(&dev->bus->devices) || !p

RE: [PATCH v10 1/7] PCI: initialize and release SR-IOV capability

2009-03-06 Thread Duyck, Alexander H
Randy Dunlap wrote: > Matthew Wilcox wrote: >> On Fri, Feb 20, 2009 at 02:54:42PM +0800, Yu Zhao wrote: >> PCI MSI can also be disabled at runtime (and Fedora do by default). >> Since SR-IOV really does require MSI, we need to put in a runtime >> check to see if pci_msi_enabled() is false. >> >> W

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-03-06 Thread Filip Navara
On Wed, Feb 11, 2009 at 5:48 PM, Jamie Lokier wrote: > Kevin Wolf wrote: >> Besides reviewing the code over and over again, I think the only real >> chance is that you can get a non-productive copy of your image and add >> some debug code so that we can see at least which code path is causing >> p

Re: [PATCH v10 6/7] PCI: document SR-IOV sysfs entries

2009-03-06 Thread Randy Dunlap
Matthew Wilcox wrote: > Randy, can you wordsmith this one? I'll try. > I think I'm starting to understand the difference between physfn and > dep_link, but an example would definitely help. It may or may not be > appropriate to put it in. > > On Fri, Feb 20, 2009 at 02:54:47PM +0800, Yu Zhao wr

Re: [PATCH v10 1/7] PCI: initialize and release SR-IOV capability

2009-03-06 Thread Randy Dunlap
Matthew Wilcox wrote: > On Fri, Feb 20, 2009 at 02:54:42PM +0800, Yu Zhao wrote: >> +config PCI_IOV >> +bool "PCI IOV support" >> +depends on PCI >> +select PCI_MSI > > My understanding is that having 'select' of a config symbol that the > user can choose is bad. I think we should pro

Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-06 Thread Randy Dunlap
Matthew Wilcox wrote: > On Fri, Feb 20, 2009 at 02:54:45PM +0800, Yu Zhao wrote: > >> +if (nres != iov->nres) { >> +dev_err(&dev->dev, "no enough MMIO for SR-IOV\n"); >> +return -ENOMEM; >> +} "not enough MMIO BARs for SR-IOV" or

Re: [PATCH v10 7/7] PCI: manual for SR-IOV user and driver developer

2009-03-06 Thread Matthew Wilcox
I think we'll need to go a few rounds on sorting this one out. I don't have time right now, but I think having this document is important. On Fri, Feb 20, 2009 at 02:54:48PM +0800, Yu Zhao wrote: > Signed-off-by: Yu Zhao > --- > Documentation/DocBook/kernel-api.tmpl |1 + > Documentation/P

Re: [PATCH v10 6/7] PCI: document SR-IOV sysfs entries

2009-03-06 Thread Matthew Wilcox
Randy, can you wordsmith this one? I think I'm starting to understand the difference between physfn and dep_link, but an example would definitely help. It may or may not be appropriate to put it in. On Fri, Feb 20, 2009 at 02:54:47PM +0800, Yu Zhao wrote: > Signed-off-by: Yu Zhao > --- > Docu

Re: [PATCH v10 5/7] PCI: handle SR-IOV Virtual Function Migration

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:46PM +0800, Yu Zhao wrote: > +static int sriov_migration(struct pci_dev *dev) > +{ > + u16 status; > + struct pci_sriov *iov = dev->sriov; > + > + if (!iov->nr_virtfn) > + return 0; > + > + if (!(iov->cap & PCI_SRIOV_CAP_VFM)) > +

Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:45PM +0800, Yu Zhao wrote: > + virtfn->sysdata = dev->bus->sysdata; > + virtfn->dev.parent = dev->dev.parent; > + virtfn->dev.bus = dev->dev.bus; > + virtfn->devfn = devfn; > + virtfn->hdr_type = PCI_HEADER_TYPE_NORMAL; > + virtfn->cfg_size = PC

Re: [PATCH v10 3/7] PCI: reserve bus range for SR-IOV device

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:44PM +0800, Yu Zhao wrote: > +static inline void virtfn_bdf(struct pci_dev *dev, int id, u8 *busnr, u8 > *devfn) > +{ > + u16 bdf; > + > + bdf = (dev->bus->number << 8) + dev->devfn + > + dev->sriov->offset + dev->sriov->stride * id; > + *busnr =

Re: [PATCH v10 2/7] PCI: restore saved SR-IOV state

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:43PM +0800, Yu Zhao wrote: > Signed-off-by: Yu Zhao It needs a changelog ... > +static void sriov_restore_state(struct pci_dev *dev) > +{ [...] > +} > + [...] > +/** > + * pci_restore_iov_state - restore the state of the IOV capability > + * @dev: the PCI device > +

Re: [PATCH v10 1/7] PCI: initialize and release SR-IOV capability

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:42PM +0800, Yu Zhao wrote: > +config PCI_IOV > + bool "PCI IOV support" > + depends on PCI > + select PCI_MSI My understanding is that having 'select' of a config symbol that the user can choose is bad. I think we should probably make this 'depends on PCI

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-06 Thread Matthew Wilcox
On Fri, Feb 20, 2009 at 02:54:41PM +0800, Yu Zhao wrote: > Following patches are intended to support SR-IOV capability in the > Linux kernel. With these patches, people can turn a PCI device with > the capability into multiple ones from software perspective, which > will benefit KVM and achieve oth

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-06 Thread Matthew Wilcox
On Tue, Feb 24, 2009 at 12:47:38PM +0200, Avi Kivity wrote: > Do those patches allow using a VF on the host (in other words, does the > kernel emulate config space accesses)? SR-IOV hardware handles config space accesses to virtual functions. No kernel changes needed for that aspect of it. --

Re: kvm-84 kernel panic

2009-03-06 Thread Johannes Baumann
i installed esxi, same error in ipmi after a while, talking to dell.. Marcelo Tosatti schrieb: > On Fri, Mar 06, 2009 at 06:02:00AM +0100, Johannes Baumann wrote: >> Marcelo Tosatti schrieb: >>> On Thu, Mar 05, 2009 at 11:31:35PM +0100, Johannes Baumann wrote: Ryan Harper schrieb: > * Jo

Re: does anyone run guests for more than 5 minutes? (virtio-net perf anomaly)

2009-03-06 Thread Alex Williamson
On Fri, 2009-03-06 at 14:17 -0300, Marcelo Tosatti wrote: > On Fri, Mar 06, 2009 at 08:26:33AM -0700, Alex Williamson wrote: > > On Thu, 2009-03-05 at 21:25 -0700, Alex Williamson wrote: > > > On Thu, 2009-03-05 at 21:04 -0300, Marcelo Tosatti wrote: > > > > On Tue, Mar 03, 2009 at 01:13:41PM -0700

Re: does anyone run guests for more than 5 minutes? (virtio-net perf anomaly)

2009-03-06 Thread Marcelo Tosatti
On Fri, Mar 06, 2009 at 08:26:33AM -0700, Alex Williamson wrote: > On Thu, 2009-03-05 at 21:25 -0700, Alex Williamson wrote: > > On Thu, 2009-03-05 at 21:04 -0300, Marcelo Tosatti wrote: > > > On Tue, Mar 03, 2009 at 01:13:41PM -0700, Alex Williamson wrote: > > > > Any guesses as to what might be g

Re: does anyone run guests for more than 5 minutes? (virtio-net perf anomaly)

2009-03-06 Thread Alex Williamson
On Thu, 2009-03-05 at 21:25 -0700, Alex Williamson wrote: > On Thu, 2009-03-05 at 21:04 -0300, Marcelo Tosatti wrote: > > On Tue, Mar 03, 2009 at 01:13:41PM -0700, Alex Williamson wrote: > > > Any guesses as to what might be going on? Can anyone reproduce? I'm > > > hoping that I'm doing somethin

Re: [PATCH 4/6] kvm/x86/mmu: handle invlpg on large pages

2009-03-06 Thread Joerg Roedel
On Thu, Mar 05, 2009 at 06:11:22PM -0300, Marcelo Tosatti wrote: > On Thu, Mar 05, 2009 at 01:12:31PM +0100, Joerg Roedel wrote: > > Signed-off-by: Joerg Roedel > > --- > > arch/x86/kvm/paging_tmpl.h | 12 +--- > > 1 files changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/a

Re: [PATCH 0/6] various x86 kvm fixes

2009-03-06 Thread Joerg Roedel
On Thu, Mar 05, 2009 at 06:50:37PM -0300, Marcelo Tosatti wrote: > On Thu, Mar 05, 2009 at 01:12:27PM +0100, Joerg Roedel wrote: > > Hi Avi, Marcelo, > > > > this small series of patches collects some fixes I have collected during > > the last days of KVM hacking. Please review and comment or appl

problem with www.linux-kvm.com

2009-03-06 Thread Paolo Pedaletti
ciao, I hope that some admin/webmaster of www.linux-kvm.com read this ml. I have tried to login to the website, but: 1) after login adn password, appears: Access denied You are not authorized to access this page. 2) the mail-form at http://www.linux-kvm.com/contact has a captcha that doesn't wor