Re: [PATCH -tip 0/6 V4] tracing: kprobe-based event tracer

2009-04-05 Thread Pekka Paalanen
On Fri, 03 Apr 2009 09:52:09 -0400 Masami Hiramatsu wrote: > Vegard Nossum wrote: > > 2009/4/3 Ingo Molnar : > >> * Avi Kivity wrote: > >> > >>> Ingo Molnar wrote: > > kvm has three requirements not needed by kprobes: > > - it wants to execute instructions, not just decode them, includin

Re: [PATCH] Fix display breakage when resizing the screen (v2)

2009-04-05 Thread Anthony Liguori
Avi Kivity wrote: When the vga resolution changes, a new display surface is not allocated immediately; instead that is deferred until the next update. However, if we're running without a display client attached, that won't happen and the next bitblt is likely to cause a segfault by overflowing t

[patch 2/2] KVM: MMU: remove global page optimization logic

2009-04-05 Thread Marcelo Tosatti
Complexity to fix it not worthwhile the gains, as discussed in http://article.gmane.org/gmane.comp.emulators.kvm.devel/28649. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/include/asm/kvm_host.h === --- kvm.orig/arch/x86/includ

[patch 0/2] disable unsync global page optimization

2009-04-05 Thread Marcelo Tosatti
-- -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/2] KVM: MMU: disable global page optimization

2009-04-05 Thread Marcelo Tosatti
Complexity to fix it not worthwhile the gains, as discussed in http://article.gmane.org/gmane.comp.emulators.kvm.devel/28649. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/mmu.c === --- kvm.orig/arch/x86/kvm/mmu.c +++ kvm/a

Re: IOMMU setting

2009-04-05 Thread Muli Ben-Yehuda
On Sun, Apr 05, 2009 at 05:14:44PM +, Eric Liu wrote: > > Yes it is AMD system, however KVM website does mention AMD iommu > support KVM device passthrough. I want to make sure my system has > this capability. That's 'AMD IOMMU', as opposed to AMD GART, which is not an isolation-capable IOMM

Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid

2009-04-05 Thread Uri Lublin
Avi Kivity wrote: Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost --- client/tests/kvm_runtest_2/stepeditor.py | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm_runtest_2/stepeditor.py b/client/tests/kvm_runtest_2/stepeditor.py inde

Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid

2009-04-05 Thread Eduardo Habkost
On Sun, Apr 05, 2009 at 03:31:03PM +0300, Avi Kivity wrote: > Eduardo Habkost wrote: >> SPACE_RGB, False, 8, w, h, w*3) >> >>> Traceback (most recent call last): >>> File "", line 1, in ? >>> MemoryError >>> >> >> >> > > Instead of returning an empty image here, we sh

RE: IOMMU setting

2009-04-05 Thread Eric Liu
Yes it is AMD system, however KVM website does mention AMD iommu support KVM device passthrough. I want to make sure my system has this capability. Regards Eric > Date: Sat, 4 Apr 2009 21:18:23 +0300 > From: m...@il.ibm.com > To: ericliu2...@hotmail.co

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: What we need is: 1) Lockless MMIO/PIO dispatch (there should be two IO registration interfaces, a new lockless one and the legacy one) Not sure exactly how much this is needed, since when there is no contention, locks are almost free (there's the at

Re: AHCI?

2009-04-05 Thread tsuraan
> If you want that and good performance too write a virtio driver, and use > virtio disk instead of IDE or SCSI. Is there a place where the interface types are documented? The man page lists ide, scsi, sd, mtd, floppy, pflash, and virtio. There's a virtio page on the kvm wiki, and I think I can

Re: [PATCH] extboot: silence compiler warning

2009-04-05 Thread Avi Kivity
Jan Kiszka wrote: Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Update .gitignore

2009-04-05 Thread Avi Kivity
Jan Kiszka wrote: Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Avi Kivity
Anthony Liguori wrote: What we need is: 1) Lockless MMIO/PIO dispatch (there should be two IO registration interfaces, a new lockless one and the legacy one) Not sure exactly how much this is needed, since when there is no contention, locks are almost free (there's the atomic and cacheline

Re: AHCI?

2009-04-05 Thread Avi Kivity
tsuraan wrote: I see. That sucks. Yeah... Is there any reason that kvm is hard-coded to only allow 4 IDE devices? Is it an issue with the BIOS implementation, or is it just a random limit? If there's some macro somewhere that defines NUM_IDE to 2, and I could change that to 5, then I'd

Re: AHCI?

2009-04-05 Thread tsuraan
> I see. That sucks. Yeah... Is there any reason that kvm is hard-coded to only allow 4 IDE devices? Is it an issue with the BIOS implementation, or is it just a random limit? If there's some macro somewhere that defines NUM_IDE to 2, and I could change that to 5, then I'd be perfectly happy; I

Re: AHCI?

2009-04-05 Thread Avi Kivity
tsuraan wrote: No plan that I know of. Is the LSI scsi device not supported by Solaris? Yeah, there was a short thread about it last July (http://www.mail-archive.com/kvm@vger.kernel.org/msg01633.html). The jist of it is that 64-bit OpenSolaris no longer supports the 53c895a SCSI control

[PATCH] Fix display breakage when resizing the screen (v2)

2009-04-05 Thread Avi Kivity
When the vga resolution changes, a new display surface is not allocated immediately; instead that is deferred until the next update. However, if we're running without a display client attached, that won't happen and the next bitblt is likely to cause a segfault by overflowing the display surface.

Re: [Qemu-devel] Re: [PATCH] Fix display breakage when resizing the screen

2009-04-05 Thread Avi Kivity
Anthony Liguori wrote: This patch breaks VC switching with -curses. The attached incremental fixes it, by basically replicating the previous behaviour. I'll follow up with a new combined patch. -- error compiling committee.c: too many arguments to function diff --git a/hw/vga.c b/hw/vga.

Re: [Qemu-devel] Re: [PATCH] Fix display breakage when resizing the screen

2009-04-05 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: When the vga resolution changes, a new display surface is not allocated immediately; instead that is deferred until the next update. However, if we're running without a display client attached, that won't happen and the next bitblt is likely to cause a s

Re: AHCI?

2009-04-05 Thread tsuraan
> No plan that I know of. Is the LSI scsi device not supported by Solaris? Yeah, there was a short thread about it last July (http://www.mail-archive.com/kvm@vger.kernel.org/msg01633.html). The jist of it is that 64-bit OpenSolaris no longer supports the 53c895a SCSI controller. According to th

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Anthony Liguori
Rusty Russell wrote: On Thursday 02 April 2009 02:40:29 Anthony Liguori wrote: Rusty Russell wrote: As you point out, 350-450 is possible, which is still bad, and it's at least partially caused by the exit to userspace and two system calls. If virtio_net had a backend in the kernel, we

[PATCH 9/9] [AMD] Skip instruction on a task switch only when appropriate.

2009-04-05 Thread Gleb Natapov
If a task switch was initiated because off a task gate in IDT and IDT was accessed because of an external even the instruction should not be skipped. Signed-off-by: Gleb Natapov --- arch/x86/kvm/svm.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/x86/kv

[PATCH 8/9] Add new mode of instruction emulation: skip.

2009-04-05 Thread Gleb Natapov
In the new mode instruction is decoded, but not executed. The EIP is moved to point after the instruction. Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/x86.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/

[PATCH 7/9] Decode soft interrupt instructions.

2009-04-05 Thread Gleb Natapov
Do not emulate them yet. Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index cf27e62..fcaad4b 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kv

[PATCH 5/9] Complete decoding of call near in decode stage.

2009-04-05 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 1790933..3c23af0 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x86_emulate

[PATCH 6/9] Completely decode in/out at decoding stage.

2009-04-05 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 3c23af0..cf27e62 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x86_emulate.c @@

[PATCH 3/9] Complete ljmp decoding at decode stage.

2009-04-05 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c | 25 + 1 files changed, 5 insertions(+), 20 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index fe0dec2..e7e4db1 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x

[PATCH 4/9] Complete short/near jcc decoding in decode stage.

2009-04-05 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c | 50 1 files changed, 18 insertions(+), 32 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index e7e4db1..1790933 100644 --- a/arch/x86/kvm/x86_emulate.c

[PATCH 2/9] Add lcall decoding.

2009-04-05 Thread Gleb Natapov
No emulation yet. Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index c015063..fe0dec2 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x86_e

[PATCH 1/9] Add decoding of 16bit second immediate argument.

2009-04-05 Thread Gleb Natapov
Such as segment number in lcall/ljmp Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index d7c9f6f..c015063 100644 --- a/arch/x86/kvm/x86_emulate.c +

Re: [PATCH] Fix display breakage when resizing the screen

2009-04-05 Thread Anthony Liguori
Avi Kivity wrote: When the vga resolution changes, a new display surface is not allocated immediately; instead that is deferred until the next update. However, if we're running without a display client attached, that won't happen and the next bitblt is likely to cause a segfault by overflowing t

Re: virtio_net: MAC address releated breakage if there is no MAC area in config

2009-04-05 Thread Rusty Russell
On Sunday 05 April 2009 09:10:31 David Miller wrote: > > Acked-by: Christian Borntraeger > > Applied, thanks! Hmm, doesn't really matter, but it's unnecessary. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] test long JMP emulation

2009-04-05 Thread Avi Kivity
Gleb Natapov wrote: Goes on top of Jcc tests patch. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH] add tests for short/near Jcc and call instruction emulation

2009-04-05 Thread Avi Kivity
Gleb Natapov wrote: Signed-off-by: Gleb Natapov Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH] fix call near emulation

2009-04-05 Thread Avi Kivity
Gleb Natapov wrote: The length of pushed on to the stack return address depends on operand size not address size. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to m

Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid

2009-04-05 Thread Avi Kivity
Eduardo Habkost wrote: SPACE_RGB, False, 8, w, h, w*3) Traceback (most recent call last): File "", line 1, in ? MemoryError Signed-off-by: Eduardo Habkost --- client/tests/kvm_runtest_2/stepeditor.py | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-)

Re: persistent tun & different virtual NICs & dead guest network

2009-04-05 Thread Avi Kivity
Avi Kivity wrote: I think all the settings should be reset to 0 when opening the tun device. This should definitely be fixed. I'll look at writing a patch. Okay, that's not in upstream qemu, so I committed a fix to kvm-userspace.git. Attached if you want to test it. -- error compiling c

Re: persistent tun & different virtual NICs & dead guest network

2009-04-05 Thread Avi Kivity
(cc qemu-devel) Michael Tokarev wrote: Hello. 2 days debugging an.. issue here, and finally got it. To make the long and painful (it was for me anyway) story short... kvm provides a way to control various offload settings on the "host side" of the tun network device (I mean the `-net tap' setu

Re: Can't boot guest with more than 3585MB when using large pages

2009-04-05 Thread Avi Kivity
Alex Williamson wrote: On Fri, 2009-04-03 at 20:28 -0300, Marcelo Tosatti wrote: Can you please try the following Thanks Marcelo, this seems to fix it. I tested up to a 30G guest with large pages. I've applied the patch, thanks. I keep thinking we need to do additional rounding

Re: AHCI?

2009-04-05 Thread Avi Kivity
tsuraan wrote: Is there any plan to add AHCI support to kvm? It seems like it would be an ideal alternative to the LSI SCSI driver, since AHCI is supported by 64-bit Solaris as well as nearly every other modern OS. No plan that I know of. Is the LSI scsi device not supported by Solaris? -

Re: cr3 OOS optimisation breaks 32-bit GNU/kFreeBSD guest

2009-04-05 Thread Avi Kivity
Marcelo Tosatti wrote: Here's one way to make this work: - add a hash of global pagetables, indexed by virtual address instead of the pagetable's gfn - invlpg checks this hash in addition to the recursive walk We'd need to make the virtual address part of sp->role to avoid needing to lin

Re: cr3 OOS optimisation breaks 32-bit GNU/kFreeBSD guest

2009-04-05 Thread Marcelo Tosatti
On Sun, Apr 05, 2009 at 11:41:39AM +0300, Avi Kivity wrote: > Marcelo Tosatti wrote: >> The problem is when the page is unreachable due to a higher level path >> being unlinked. Say: >> >> level 4 -> level 3 . level 2 -> level 1 (global unsync) >> >> The dot there means level 3 is not linked to lev

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Avi Kivity
Gregory Haskins wrote: You don't gain simplicity by adding things. But you are failing to account for the fact that we still have to add something for PCI if we go with something like the in-kernel model. Its nice for the userspace side because a) it was already in qemu, and b) we need it

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Avi Kivity
Gregory Haskins wrote: 2) the vbus-proxy and kvm-guest patch go away 3) the kvm-host patch changes to work with coordination from the userspace-pci emulation for things like MSI routing 4) qemu will know to create some MSI shim 1:1 with whatever it instantiates on the bus (and can communicate

[ kvm-Bugs-2733678 ] network problems

2009-04-05 Thread SourceForge.net
Bugs item #2733678, was opened at 2009-04-05 10:51 Message generated for change (Tracker Item Submitted) made by lacsap2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2733678&group_id=180599 Please note that this message will contain a full copy of the

Re: cr3 OOS optimisation breaks 32-bit GNU/kFreeBSD guest

2009-04-05 Thread Avi Kivity
Marcelo Tosatti wrote: The problem is when the page is unreachable due to a higher level path being unlinked. Say: level 4 -> level 3 . level 2 -> level 1 (global unsync) The dot there means level 3 is not linked to level 2, so invlpg can't reach the global unsync at level 1. kvm_mmu_get_page

Re: [RFC PATCH 00/17] virtual-bus

2009-04-05 Thread Avi Kivity
Rusty Russell wrote: On Thursday 02 April 2009 02:40:29 Anthony Liguori wrote: Rusty Russell wrote: As you point out, 350-450 is possible, which is still bad, and it's at least partially caused by the exit to userspace and two system calls. If virtio_net had a backend in the kernel, we

[PATCH 3/3] [AMD] Skip instruction on a task switch only when appropriate.

2009-04-05 Thread Gleb Natapov
If a task switch was initiated because off a task gate in IDT and IDT was accessed because of an external even the instruction should not be skipped. Signed-off-by: Gleb Natapov --- arch/x86/kvm/svm.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/x86/kv

[PATCH 2/3] Add new mode of instruction emulation: skip.

2009-04-05 Thread Gleb Natapov
In the new mode instruction is decoded, but not executed. The EIP is moved to point after the instruction. Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/x86.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/

[PATCH 1/3] Completely decode instruction in decoding stage.

2009-04-05 Thread Gleb Natapov
After instruction decoding decode_cache.eip should point after instruction. Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86_emulate.c | 107 1 files changed, 38 insertions(+), 69 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/

[PATCH] test long JMP emulation

2009-04-05 Thread Gleb Natapov
Goes on top of Jcc tests patch. Signed-off-by: Gleb Natapov diff --git a/user/test/x86/realmode.c b/user/test/x86/realmode.c index 336ba1c..755b5d1 100644 --- a/user/test/x86/realmode.c +++ b/user/test/x86/realmode.c @@ -451,6 +451,23 @@ void test_jcc_near(void) print_serial("JMP