Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-20 Thread Gregory Haskins
Davide Libenzi wrote: > On Sat, 20 Jun 2009, Davide Libenzi wrote: > > >> On Sat, 20 Jun 2009, Davide Libenzi wrote: >> >> >>> How about the one below? >>> >> Maybe with an interface that can be undone w/out a file* :) >> > > This is another alternative, based on a low-carb diet

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-20 Thread Gregory Haskins
Davide Libenzi wrote: > On Fri, 19 Jun 2009, Gregory Haskins wrote: > > >>> In the POLLIN event, you schedule_work(&irqfd->inject) and there are no >>> races there AFAICS (you basically do not care of anything eventfd memory >>> related at all). >>> For POLLHUP, you do: >>> >>> spin_lock(i

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-20 Thread Davide Libenzi
On Sat, 20 Jun 2009, Davide Libenzi wrote: > On Sat, 20 Jun 2009, Davide Libenzi wrote: > > > How about the one below? > > Maybe with an interface that can be undone w/out a file* :) This is another alternative, based on a low-carb diet of your notifier patch. Same concept of de-coupling VFS r

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-20 Thread Davide Libenzi
On Sat, 20 Jun 2009, Davide Libenzi wrote: > How about the one below? Maybe with an interface that can be undone w/out a file* :) - Davide --- fs/eventfd.c| 34 +- include/linux/eventfd.h |8 2 files changed, 41 insertions(+), 1 dele

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-20 Thread Davide Libenzi
On Fri, 19 Jun 2009, Gregory Haskins wrote: > > In the POLLIN event, you schedule_work(&irqfd->inject) and there are no > > races there AFAICS (you basically do not care of anything eventfd memory > > related at all). > > For POLLHUP, you do: > > > > spin_lock(irqfd->slock); > > if (irqf

[PATCH] virtio_blk: ioctl return value fix

2009-06-20 Thread Christoph Hellwig
Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if they expect the block layer to handle generic ioctls. This triggered a BLKROSET failure in xfsqa #200. Signed-off-by: Christoph Hellwig Index: linux-2.6/drivers/block/virtio_blk.c

Re: [PATCH] virtio_blk: don't bounce highmem requests

2009-06-20 Thread Christoph Hellwig
Looks like I sent a patch that doesn't actually compile because qui decided to apply those fixes to a different one. Here's the correc one: -- Subject: virtio_blk: don't bounce highmem requests From: Christoph Hellwig By default a block driver bounces highmem requests, but virtio-blk is perfec

Re: [PATCH 6/8] kvm/mmu: add support for another level to page walker

2009-06-20 Thread Avi Kivity
On 06/19/2009 04:16 PM, Joerg Roedel wrote: The page walker may be used with nested paging too when accessing mmio areas. Make it support the additional page-level too. Signed-off-by: Joerg Roedel --- arch/x86/kvm/mmu.c |6 ++ arch/x86/kvm/paging_tmpl.h | 16

Re: [PATCH 0/8 v3] KVM support for 1GB pages

2009-06-20 Thread Avi Kivity
On 06/19/2009 04:16 PM, Joerg Roedel wrote: Hi, this is the third version of the patches for KVM to support 1GB pages. Changes to the last version include: - changed reporting of 1GB page support to userspace to use SUPPORTED_CPUID ioctl - added support for 1GB pages t

[KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static

2009-06-20 Thread Jaswinder Singh Rajput
toggle_interruptibility() is used only by same file, it should be static. Fixed following sparse warning : arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static? Signed-off-by: Jaswinder Singh Rajput --- arch/x86/kvm/x86_emulate.