Re: [Qemu-devel] Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden

2009-06-24 Thread Gleb Natapov
On Wed, Jun 24, 2009 at 10:20:41PM +0100, Jamie Lokier wrote: > Avi Kivity wrote: > > On 06/23/2009 02:31 PM, Paul Brook wrote: > > >On Tuesday 23 June 2009, Avi Kivity wrote: > > > > > >>On 06/23/2009 12:47 AM, Andre Przywara wrote: > > >> > > >>>KVM defaults to the hypervisor CPUID bit to

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [20:20:27], Jamie Lokier wrote: > Amit Shah wrote: > > > > I think the interface from the guest POV stays the same: reads / writes > > to char devices. With virtio-serial, though, we can add a few other > > interesting things like names to ports, ability to hot-add ports on >

Re: ESX on KVM requirements

2009-06-24 Thread Ben Sanders
I applied the patch I found here: http://thread.gmane.org/gmane.comp.emulators.qemu/35419 and here are my new debug results: http://pastebin.com/m60d53e9d It looks like it is still crashing in the same place, so I double checked that the patch was applied correctly. I also didn't have the "npt=1"

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Andrew Morton
On Wed, 24 Jun 2009 16:52:06 -0700 (PDT) Davide Libenzi wrote: > > umm, yes please, I believe the patches should be split. And I'm still > > not seeing the justification for forcing CONFIG_EVENTFD onto all > > CONFIG_AIO users! > > Eventfd notifications became part of the AIO API (it's not even

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-24 Thread Davide Libenzi
On Tue, 23 Jun 2009, Davide Libenzi wrote: > On Tue, 23 Jun 2009, Rusty Russell wrote: > > > The first 'struct eventfd_ctx;' line is not required. > > Will repost dropping that. Almost forgot. While fixing lg.h to drop the fwd declaration, I noticed there's another one ;) - Davide --- a/dr

[patch] eventfd - revised interface and cleanups (4th rev)

2009-06-24 Thread Davide Libenzi
The following patch changes the eventfd interface to de-couple the eventfd memory context, from the file pointer instance. Without such change, there is no clean way to racely free handle the POLLHUP event sent when the last instance of the file* goes away. Also, now the internal eventfd APIs are

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Davide Libenzi
On Wed, 24 Jun 2009, Andrew Morton wrote: > Split what? My skull? Heh :) > umm, yes please, I believe the patches should be split. And I'm still > not seeing the justification for forcing CONFIG_EVENTFD onto all > CONFIG_AIO users! Eventfd notifications became part of the AIO API (it's not e

[PATCH] Only compile KVM support for matching CPU types (v2)

2009-06-24 Thread Anthony Liguori
I don't know why this is disabled for qemu-kvm.git. Signed-off-by: Anthony Liguori -- v1 -> v2 Fix typo --- configure |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4bad3c3..0e65edb 100755 --- a/configure +++ b/configure @@ -2117,13 +

Re: [PATCH] Only compile KVM support for matching CPU types

2009-06-24 Thread Anthony Liguori
Dustin Kirkland wrote: On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote: I don't know why this is disabled for qemu-kvm.git. Signed-off-by: Anthony Liguori --- configure |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 4bad3c3

Re: [PATCH] Only compile KVM support for matching CPU types

2009-06-24 Thread Dustin Kirkland
On Wed, 2009-06-24 at 18:09 -0500, Dustin Kirkland wrote: > On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote: > > # Make sure the target and host cpus are compatible > > if test ! \( "$target_cpu" = "$cpu" -o \ > >\( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \ > >\( "$targe

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Andrew Morton
On Wed, 24 Jun 2009 15:47:47 -0700 (PDT) Davide Libenzi wrote: > On Tue, 23 Jun 2009, Andrew Morton wrote: > > > Maybe there is such a reason, and it hasn't yet been beaten into my > > skull. But I still think it should be done in a separate patch. One > > which comes with a full description o

Re: [PATCH] Only compile KVM support for matching CPU types

2009-06-24 Thread Dustin Kirkland
On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote: > I don't know why this is disabled for qemu-kvm.git. > > Signed-off-by: Anthony Liguori > --- > configure |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/configure b/configure > index 4bad3c3..1b73eaf 1

Re: [patch] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Davide Libenzi
On Tue, 23 Jun 2009, Andrew Morton wrote: > Maybe there is such a reason, and it hasn't yet been beaten into my > skull. But I still think it should be done in a separate patch. One > which comes with a full description of the reasons for the change, btw. Since your skull seems pretty hard to b

Re: [PATCH 3/3] eventfd: add internal reference counting to fix notifier race conditions

2009-06-24 Thread Davide Libenzi
On Wed, 24 Jun 2009, Rusty Russell wrote: > On Tue, 23 Jun 2009 03:33:22 am Davide Libenzi wrote: > > What you're doing there, is setting up a kernel-to-kernel (since > > userspace only role is to create the eventfd) communication, using a file* > > as accessory. That IMO is plain wrong. > > The

[PATCH] Only compile KVM support for matching CPU types

2009-06-24 Thread Anthony Liguori
I don't know why this is disabled for qemu-kvm.git. Signed-off-by: Anthony Liguori --- configure |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 4bad3c3..1b73eaf 100755 --- a/configure +++ b/configure @@ -2117,13 +2117,12 @@ configure_kvm(

Re: [Qemu-devel] Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden

2009-06-24 Thread Jamie Lokier
Avi Kivity wrote: > On 06/23/2009 02:31 PM, Paul Brook wrote: > >On Tuesday 23 June 2009, Avi Kivity wrote: > > > >>On 06/23/2009 12:47 AM, Andre Przywara wrote: > >> > >>>KVM defaults to the hypervisor CPUID bit to be set, whereas pure QEMU > >>>clears it. On some occasions one want to set

[PATCH] Use upstream guard for kvm support in ppcemb-softmmu

2009-06-24 Thread Anthony Liguori
ppcemb-softmmu uses upstream KVM support so put an appropriate guard around it. This fixes the non-KVM ppcemb-softmmu build. Signed-off-by: Anthony Liguori --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 420e101..4bad3c3 100755

[KVM PATCH v4 2/4] eventfd - revised interface and cleanups (2nd rev)

2009-06-24 Thread Gregory Haskins
From: Davide Libenzi The following patch changes the eventfd interface to de-couple the eventfd memory context, from the file pointer instance. Without such change, there is no clean way to racely free handle the POLLHUP event sent when the last instance of the file* goes away. Also, now the inte

[KVM PATCH v4 4/4] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-06-24 Thread Gregory Haskins
This patch fixes all known races in irqfd, and paves the way to restore DEASSIGN support. For details of the eventfd races, please see the header for patch 2/4, or the thread on which it was based on: http://www.mail-archive.com/kvm@vger.kernel.org/msg17767.html In a nutshell, we use eventfd_ctx

[KVM PATCH v4 1/4] kvm: prepare irqfd for having interrupts disabled during eventfd->release

2009-06-24 Thread Gregory Haskins
We need to plug some race conditions on eventfd shutdown. In order to do this, we need to change the context in which the release notification is delivered so that the wqh lock is now held. However, there is currently code in the release callback that assumes it can sleep. We have a slight chick

[KVM PATCH v4 0/4] irqfd fixes

2009-06-24 Thread Gregory Haskins
(Applies to kvm.git/master:4631e094) The following is the latest attempt to fix the remaining races in irqfd/eventfd. For more details, please read the patch headers. This series has been tested against the kvm-eventfd unit test, and appears to be functioning properly. You can download this tes

[KVM PATCH v4 3/4] slow-work: add (module*)work->owner to fix races with module clients

2009-06-24 Thread Gregory Haskins
The slow_work facility was designed to use reference counting instead of barriers for synchronization. The reference counting mechanism is implemented as a vtable op (->get_ref, ->put_ref) callback. This is problematic for module use of the slow_work facility because it is impossible to synchroni

[PATCH] Fix ppc-softmmu build

2009-06-24 Thread Anthony Liguori
This gets ppc-softmmu building when KVM is not enabled. It may be enough to get it working with KVM enabled but I haven't checked. Signed-off-by: Anthony Liguori --- hw/ppc440.c|1 + hw/ppc440_bamboo.c |1 + hw/ppce500_mpc8544ds.c |1 + qemu-kvm.h |1

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Jamie Lokier
Amit Shah wrote: > On (Wed) Jun 24 2009 [18:50:02], Jamie Lokier wrote: > > Amit Shah wrote: > > > On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > > > > Amit Shah wrote: > > > > > A few sample uses for a vmchannel are to share the host and guest > > > > > clipboards (to allow copy/paste betw

Re: [PATCH] Fix non-KVM build

2009-06-24 Thread Dustin Kirkland
On Wed, Jun 24, 2009 at 1:13 PM, Anthony Liguori wrote: > This introduces some #ifdefs in pcspk to fix the build when KVM isn't enabled. > > Signed-off-by: Anthony Liguori > --- >  hw/pcspk.c |   15 +-- >  1 files changed, 9 insertions(+), 6 deletions(-) ... Thanks, Anthony. This pat

Re: [PATCH] support colon in filenames

2009-06-24 Thread Balbir Singh
* Ram Pai [2009-06-24 10:30:00]: > On Wed, 2009-06-24 at 22:38 +0530, Balbir Singh wrote: > > * Ram Pai [2009-06-24 09:58:59]: > > > > > Problem: It is impossible to feed filenames with the character colon > > > because > > > qemu interprets such names as a protocol. For example a filename s

[PATCH] Fix non-KVM build

2009-06-24 Thread Anthony Liguori
This introduces some #ifdefs in pcspk to fix the build when KVM isn't enabled. Signed-off-by: Anthony Liguori --- hw/pcspk.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/pcspk.c b/hw/pcspk.c index 9e1b59a..236995a 100644 --- a/hw/pcspk.c +++ b/hw/pcsp

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [18:50:02], Jamie Lokier wrote: > Amit Shah wrote: > > On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > > > Amit Shah wrote: > > > > A few sample uses for a vmchannel are to share the host and guest > > > > clipboards (to allow copy/paste between a host and a guest), to >

Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Filip Navara
On Wed, Jun 24, 2009 at 7:46 PM, Avi Kivity wrote: > On 06/24/2009 08:37 PM, Filip Navara wrote: >> >> On Wed, Jun 24, 2009 at 11:54 AM, Avi Kivity  wrote: >> >>> >>> On 06/23/2009 12:47 AM, Andre Przywara wrote: >>> Should we ignore unhandled MSRs like QEMU or Xen do? >>> >>> I

Re: [PATCH] support colon in filenames

2009-06-24 Thread Ram Pai
Copying the qemu-devel mailing list too. On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example a filename scsi:0, > is interpreted as a protocol by name "scsi". > >

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Jamie Lokier
Amit Shah wrote: > On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > > Amit Shah wrote: > > > A few sample uses for a vmchannel are to share the host and guest > > > clipboards (to allow copy/paste between a host and a guest), to > > > lock the screen of the guest session when the vnc viewer i

Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Avi Kivity
On 06/24/2009 08:37 PM, Filip Navara wrote: On Wed, Jun 24, 2009 at 11:54 AM, Avi Kivity wrote: On 06/23/2009 12:47 AM, Andre Przywara wrote: Should we ignore unhandled MSRs like QEMU or Xen do? Ignoring unhandled msrs is dangerous. If a write has some effect the guest dep

Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Filip Navara
On Wed, Jun 24, 2009 at 11:54 AM, Avi Kivity wrote: > On 06/23/2009 12:47 AM, Andre Przywara wrote: >> >> Should we ignore unhandled MSRs like QEMU or Xen do? >> > > Ignoring unhandled msrs is dangerous.  If a write has some effect the guest > depends on, and we're not emulating that effect, the gu

Re: [PATCH] support colon in filenames

2009-06-24 Thread Ram Pai
On Wed, 2009-06-24 at 22:38 +0530, Balbir Singh wrote: > * Ram Pai [2009-06-24 09:58:59]: > > > Problem: It is impossible to feed filenames with the character colon > > because > > qemu interprets such names as a protocol. For example a filename scsi:0, > > is interpreted as a protocol by name

Re: [PATCH] support colon in filenames

2009-06-24 Thread Amit Shah
(Actually add Eduardo to CC) On (Wed) Jun 24 2009 [22:56:59], Amit Shah wrote: > On (Wed) Jun 24 2009 [09:58:59], Ram Pai wrote: > > Problem: It is impossible to feed filenames with the character colon > > because > > qemu interprets such names as a protocol. For example a filename scsi:0, > >

Re: [PATCH] support colon in filenames

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [09:58:59], Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example a filename scsi:0, > is interpreted as a protocol by name "scsi". > > This patch allows users to espace colon cha

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [17:40:49], Jamie Lokier wrote: > Amit Shah wrote: > > A few sample uses for a vmchannel are to share the host and guest > > clipboards (to allow copy/paste between a host and a guest), to > > lock the screen of the guest session when the vnc viewer is closed, > > to find out w

Re: [PATCH] support colon in filenames

2009-06-24 Thread Balbir Singh
* Ram Pai [2009-06-24 09:58:59]: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example a filename scsi:0, > is interpreted as a protocol by name "scsi". > > This patch allows users to espace colon characters. For

[PATCH] support colon in filenames

2009-06-24 Thread Ram Pai
Problem: It is impossible to feed filenames with the character colon because qemu interprets such names as a protocol. For example a filename scsi:0, is interpreted as a protocol by name "scsi". This patch allows users to espace colon characters. For example the above filename can now be expres

Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Jamie Lokier
Andre Przywara wrote: > Even worse, most of them cannot be properly emulated (like disable > Lock prefix). Disable Lock prefix should be easy to emulate by ignoring it, shouldn't it? :-) -- Jamie -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord.

Re: [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Jamie Lokier
Amit Shah wrote: > A few sample uses for a vmchannel are to share the host and guest > clipboards (to allow copy/paste between a host and a guest), to > lock the screen of the guest session when the vnc viewer is closed, > to find out which applications are installed on a guest OS even when > the g

ia64: why is mmio bus access lockless?

2009-06-24 Thread Michael S. Tsirkin
Hi, arch/ia64/kvm/kvm-ia64.c does this: mmio_dev = vcpu_find_mmio_dev(vcpu, p->addr, p->size, !p->dir); if (mmio_dev) { if (!p->dir) kvm_iodevice_write(mmio_dev, p->addr, p->size, &p->data);

BUG: using smp_processor_id() in preemptible

2009-06-24 Thread Johannes Berg
Hi, I'm trying to run a test environment in kvm (because uml doesn't have lockdep), and am running into the following problems: 1) I get the $subject warning a lot, when starting kvm: [85763.262707] BUG: using smp_processor_id() in preemptible [] code: kvm/13877 [85763.262719] caller is

[PATCH 3/4] ignore PCI ECS I/O enablement

2009-06-24 Thread Andre Przywara
Linux guests will try to enable access to the extended PCI config space via the I/O ports 0xCF8/0xCFC on AMD Fam10h CPU. Since we (currently?) don't use ECS, simply ignore write and read attempts. Signed-off-by: Andre Przywara --- arch/x86/kvm/x86.c |3 +++ 1 files changed, 3 insertions(+),

Re: [PATCH 4/4] dont trim the guest's hypervisor CPUID bit in KVM if the guest requests it

2009-06-24 Thread Andre Przywara
Andre Przywara wrote: Avi Kivity wrote: --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1415,7 +1415,7 @@ static void do_cpuid_ent(struct -0 /* Reserved, XSAVE, OSXSAVE */; +0 /* Reserved, XSAVE, OSXSAVE */ | F(HYPERVISOR); I think this should be handled in qemu, since

Re: virtio-serial: A guest <-> host interface for simple communication

2009-06-24 Thread Amit Shah
On (Wed) Jun 24 2009 [13:45:01], Rusty Russell wrote: > On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > > Hello, > > > > Here are two patches. One implements a virtio-serial device in qemu > > and the other is the driver for a guest kernel. > > > > While working on a vmchannel interface that is

Re: [PATCH 4/4] dont trim the guest's hypervisor CPUID bit in KVM if the guest requests it

2009-06-24 Thread Andre Przywara
Avi Kivity wrote: On 06/24/2009 01:44 PM, Andre Przywara wrote: Signed-off-by: Andre Przywara --- arch/x86/kvm/x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index e6e61ee..6ad0f93 100644 --- a/arch/x86/kvm/x86.c +++ b/a

[ kvm-Bugs-2811454 ] CPU ID Emulation bug: AMD Athlon

2009-06-24 Thread SourceForge.net
Bugs item #2811454, was opened at 2009-06-24 14:40 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2811454&group_id=180599 Please note that this message will contain a full copy of the comme

[ kvm-Bugs-2811454 ] CPU ID Emulation bug: AMD Athlon

2009-06-24 Thread SourceForge.net
Bugs item #2811454, was opened at 2009-06-24 14:40 Message generated for change (Comment added) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2811454&group_id=180599 Please note that this message will contain a full copy of the comme

[ kvm-Bugs-2811454 ] CPU ID Emulation bug: AMD Athlon

2009-06-24 Thread SourceForge.net
Bugs item #2811454, was opened at 2009-06-24 14:40 Message generated for change (Tracker Item Submitted) made by technologov You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2811454&group_id=180599 Please note that this message will contain a full copy of

Re: [PATCH 1/4] ignore AMDs HWCR register access to set the FFDIS bit

2009-06-24 Thread Avi Kivity
On 06/24/2009 01:44 PM, Andre Przywara wrote: Linux tries to disable the flush filter on all AMD K8 CPUs. Since KVM does not handle the needed MSR, the injected #GP will panic the Linux kernel. Ignore setting of the HWCR.FFDIS bit in this MSR to let Linux boot with an AMD K8 family guest CPU.

Re: [PATCH 3/4] ignore PCI ECS I/O enablement

2009-06-24 Thread Avi Kivity
On 06/24/2009 01:44 PM, Andre Przywara wrote: Linux guests will try to enable access to the extended PCI config space via the I/O ports 0xCF8/0xCFC on AMD Fam10h CPU. Since we (currently?) don't use ECS, simply ignore this write attempt. diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index

Re: [PATCH 4/4] dont trim the guest's hypervisor CPUID bit in KVM if the guest requests it

2009-06-24 Thread Avi Kivity
On 06/24/2009 01:44 PM, Andre Przywara wrote: Signed-off-by: Andre Przywara --- arch/x86/kvm/x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index e6e61ee..6ad0f93 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @

Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Avi Kivity
On 06/24/2009 02:04 PM, Andre Przywara wrote: Avi Kivity wrote: On 06/23/2009 12:47 AM, Andre Przywara wrote: Should we ignore unhandled MSRs like QEMU or Xen do? Ignoring unhandled msrs is dangerous. If a write has some effect the guest depends on, and we're not emulating that effect, the

Re: [PATCH/RFC] virtio_test: A module for testing virtio via userspace

2009-06-24 Thread Christian Bornträger
Am Mittwoch 24 Juni 2009 05:40:34 schrieb Rusty Russell: > > o the general idea of a virtio_test module > > o the user interface ioctls > > o further ideas and comments > > Not mugging real drivers would be a requirement, I think. Ok, I try to find a proper way to avoid that virtio_test binds t

Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Andre Przywara
Avi Kivity wrote: On 06/23/2009 12:47 AM, Andre Przywara wrote: Should we ignore unhandled MSRs like QEMU or Xen do? Ignoring unhandled msrs is dangerous. If a write has some effect the guest depends on, and we're not emulating that effect, the guest will fail. Similarly if you don't k

[PATCH 1/4] ignore AMDs HWCR register access to set the FFDIS bit

2009-06-24 Thread Andre Przywara
Linux tries to disable the flush filter on all AMD K8 CPUs. Since KVM does not handle the needed MSR, the injected #GP will panic the Linux kernel. Ignore setting of the HWCR.FFDIS bit in this MSR to let Linux boot with an AMD K8 family guest CPU. Signed-off-by: Andre Przywara --- arch/x86/kvm/s

[PATCH 4/4] dont trim the guest's hypervisor CPUID bit in KVM if the guest requests it

2009-06-24 Thread Andre Przywara
Signed-off-by: Andre Przywara --- arch/x86/kvm/x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index e6e61ee..6ad0f93 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1415,7 +1415,7 @@ static void do_cpuid_ent(str

[PATCH 3/4] ignore PCI ECS I/O enablement

2009-06-24 Thread Andre Przywara
Linux guests will try to enable access to the extended PCI config space via the I/O ports 0xCF8/0xCFC on AMD Fam10h CPU. Since we (currently?) don't use ECS, simply ignore this write attempt. Signed-off-by: Andre Przywara --- arch/x86/kvm/x86.c |2 ++ 1 files changed, 2 insertions(+), 0 dele

[PATCH 2/4] ignore reads from AMDs C1E enabled MSR

2009-06-24 Thread Andre Przywara
If the Linux kernel detects an C1E capable AMD processor (K8 RevF and higher), it will access a certain MSR on every attempt to go to halt. Explicitly handle this read and return 0 to let KVM run a Linux guest with the native AMD host CPU propagated to the guest. Signed-off-by: Andre Przywara ---

Re: [PATCH v2] Cleanup cpu loop

2009-06-24 Thread Avi Kivity
On 06/22/2009 05:27 PM, Gleb Natapov wrote: Rearrange cpu loop to be (hopefully) more readable. Put difference between kernel/userspace irqchip in one place. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "u

Re: KVM: x86: verify MTRR/PAT validity

2009-06-24 Thread Avi Kivity
On 06/22/2009 09:27 PM, Marcelo Tosatti wrote: This in the BIOS is writing 1's into the reserved address bits into variable MTRR: wrmsr_smp(MTRRphysMask_MSR(0), ~(0x2000ull - 1) | 0x800); So i'll leave just memory type validity checking and MSR_MTRRdefType valid bit checks in for now:

Re: [PATCH 1/2] ignore AMDs HWCR register access to set the FFDIS bit

2009-06-24 Thread Avi Kivity
On 06/23/2009 01:20 AM, Andre Przywara wrote: Linux tries to disable the flush filter on all AMD K8 CPUs. Since KVM does not handle the needed MSR, the injected #GP will panic the Linux kernel. Ignore setting of the HWCR.FFDIS bit in this MSR to let Linux boot with an AMD K8 family guest CPU. Si

Re: [PATCH 2/2] introduce -cpu host target

2009-06-24 Thread Avi Kivity
On 06/23/2009 12:47 AM, Andre Przywara wrote: Should we ignore unhandled MSRs like QEMU or Xen do? Ignoring unhandled msrs is dangerous. If a write has some effect the guest depends on, and we're not emulating that effect, the guest will fail. Similarly if you don't know what a register

Re: virtio_blk fails for rhel5.3 guest with LVM: kernel panic

2009-06-24 Thread sudhir kumar
initrd does not contain these modules. My kernel contains the above modules. Is it mandatory for the initrd to contain these modules? It does not contain virtio-net and the guest boots fine with virtio. On Wed, Jun 24, 2009 at 2:04 PM, Avi Kivity wrote: > On 06/23/2009 08:21 PM, sudhir kumar wrote

Re: virtio_blk fails for rhel5.3 guest with LVM: kernel panic

2009-06-24 Thread Avi Kivity
On 06/24/2009 12:41 PM, sudhir kumar wrote: initrd does not contain these modules. My kernel contains the above modules. Is it mandatory for the initrd to contain these modules? It does not contain virtio-net and the guest boots fine with virtio. virtio-net isn't used for locating the disks

Re: [patch 0/3] fixes for kvm on s390

2009-06-24 Thread Christian Bornträger
Am Mittwoch 24 Juni 2009 11:18:32 schrieb Avi Kivity: > On 06/24/2009 11:18 AM, Christian Bornträger wrote: > > Yes, the stfle issue is present on linus git and should go to Linus. > > Fixes 1 and 3 are only for your kvm.git-tree. They should go to Linus in > > as soon as you push the referenced co

Re: [patch 0/3] fixes for kvm on s390

2009-06-24 Thread Avi Kivity
On 06/24/2009 11:18 AM, Christian Bornträger wrote: Yes, the stfle issue is present on linus git and should go to Linus. Fixes 1 and 3 are only for your kvm.git-tree. They should go to Linus in as soon as you push the referenced commits to Linus. That'll be 2.6.32. I generally fold commit

Re: KVM: x86: missing locking in PIT/IRQCHIP/SET_BSP_CPU ioctl paths

2009-06-24 Thread Avi Kivity
On 06/23/2009 09:05 PM, Marcelo Tosatti wrote: Correct missing locking in a few places in x86's vm_ioctl handling path. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a messa

Re: [PATCH] kvm: remove in_range from kvm_io_device

2009-06-24 Thread Michael S. Tsirkin
On Tue, Jun 23, 2009 at 09:43:31PM -0400, Gregory Haskins wrote: > Michael S. Tsirkin wrote: > > Remove in_range from kvm_io_device and ask read/write callbacks, if > > supplied, to perform range checks internally. This allows aliasing > > (mostly for in-kernel virtio), as well as better error hand

Re: [PATCH 0/8 v3] KVM support for 1GB pages

2009-06-24 Thread Avi Kivity
On 06/19/2009 04:16 PM, Joerg Roedel wrote: Hi, this is the third version of the patches for KVM to support 1GB pages. Changes to the last version include: - changed reporting of 1GB page support to userspace to use SUPPORTED_CPUID ioctl - added support for 1GB pages t

Re: virtio_blk fails for rhel5.3 guest with LVM: kernel panic

2009-06-24 Thread Avi Kivity
On 06/23/2009 08:21 PM, sudhir kumar wrote: I see that Rhel5.3 32 and 64 bit guests fail to boot with virtio for block device. The guest can not find the root filesystem. The guest is using LVM. As per the linux-kvm wiki instructions I did change device.map and booted with if=virtio. The wiki li

Re: [patch 0/3] fixes for kvm on s390

2009-06-24 Thread Christian Bornträger
Am Mittwoch 24 Juni 2009 10:09:18 schrieben Sie: > On 06/23/2009 06:24 PM, Christian Borntraeger wrote: > > Hello Avi, > > > > here are three patches against kvm.git that fix several issues in our > > kvm port. Please review and consider all patches for 2.6.31. > > Applied all, and queued the stfle

Re: [patch 0/3] fixes for kvm on s390

2009-06-24 Thread Avi Kivity
On 06/23/2009 06:24 PM, Christian Borntraeger wrote: Hello Avi, here are three patches against kvm.git that fix several issues in our kvm port. Please review and consider all patches for 2.6.31. Applied all, and queued the stfle patch for 2.6.31. The commits referenced in patch 1 and 3