Re: [Qemu-devel] Re: Extending virtio_console to support multiple ports

2009-08-28 Thread Jamie Lokier
Alan Cox wrote: > > - Then, are we certain that there's no case where the tty layer will > > call us with some lock held or in an atomic context ? To be honest, > > I've totally lost track of the locking rules in tty land lately so it > > might well be ok, but something to verify. > > Some of the

vhost_net_init returned -7

2009-08-28 Thread Brian Jackson
I'm trying to tinker with vhost_net. I have a 2.6.31-rc4 host kernel patched to support vhost_net (v5) (along with ksm if it matters). The guest is a debian-5.0.2 (2.6.26) install CD for now. When the guest tries to load the virtio-net drivers, kvm closes and prints "vhost_net_init returned -7".

Re: Poor network performance with cable modem assigned to guest

2009-08-28 Thread Brian Jackson
On Friday 28 August 2009 01:14:42 pm Jon Fairbairn wrote: > I'm experimenting with a virtual router. I did this a few years ago with > Xen and it worked well enough, but then fedora changed and it stopped > working, so I gave up for a while. Now I have a machine that supports > hardware virtualisat

Poor network performance with cable modem assigned to guest

2009-08-28 Thread Jon Fairbairn
I'm experimenting with a virtual router. I did this a few years ago with Xen and it worked well enough, but then fedora changed and it stopped working, so I gave up for a while. Now I have a machine that supports hardware virtualisation, I thought I'd try again. The setup was done through virt-man

Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: kvm_tests: fix a litte bug in timedrift()

2009-08-28 Thread Lucas Meneghel Rodrigues
Ok, applied, thanks! On Fri, Aug 28, 2009 at 6:55 AM, Cao, Chen wrote: > the original version compared a wrong drift value with given threshold. > > Signed-off-by: Cao, Chen > --- >  client/tests/kvm/kvm_tests.py |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/clien

Re: Extending virtio_console to support multiple ports

2009-08-28 Thread Anthony Liguori
Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. The code has been updated to reuse the virtio-console device instead of creating a new virtio-serial devic

Re: [PATCHv5 1/3] mm: export use_mm/unuse_mm to modules

2009-08-28 Thread Gregory Haskins
Michael S. Tsirkin wrote: > vhost net module wants to do copy to/from user from a kernel thread, > which needs use_mm (like what fs/aio has). Move that into mm/ and > export to modules. Michael, Andrew, I am just curious: Is there any technical reason why a kthread cannot have a long-term use_m

[PATCH 3/3] VMX: Enhance invalid guest state emulation

2009-08-28 Thread Mohammed Gamal
- Change returned handle_invalid_guest_state() to return relevant exit codes - Move triggering the emulation from vmx_vcpu_run() to vmx_handle_exit() - Return to userspace instead of repeatedly trying to emulate instructions that have already failed Signed-off-by: Mohammed Gamal --- arch/x86/kvm

[PATCH 2/2] Handle emulation failure in userspace

2009-08-28 Thread Mohammed Gamal
Since we return to userspace from KVM on invalid state emulation failure, let qemu handle it. Signed-off-by: Mohammed Gamal --- qemu-kvm.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index b59e403..a1648e0 100644 --- a/qemu-kvm.c +++ b/

[PATCH 1/2] Update kvm.h in qemu-kvm tree

2009-08-28 Thread Mohammed Gamal
Update struct kvm_run and KVM_EXIT_* constants to match the one in the kernel-space tree Signed-off-by: Mohammed Gamal --- kvm/include/linux/kvm.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h index ff1025d..80186

[PATCH] x86 emulator: Add missing decoder flags for 'or' instructions

2009-08-28 Thread Mohammed Gamal
Add missing decoder flags for or instructions (0xc-0xd) Signed-off-by: Mohammed Gamal --- arch/x86/kvm/emulate.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 0644d3d..db0820d 100644 --- a/arch/x86/kvm/emulate.c +

kvm-88: KVM_APIC_READ: read reserved register b0

2009-08-28 Thread Christoph Lechner
Hi all, running kvm-88 on a 2.6.26-1-amd64 kernel (stock Debian 5.0 kernel), I get the syslog on the host system flooded with the message: Aug 28 11:49:40 reactor kernel: [124035.611782] KVM_APIC_READ: read reserved register b0 The guest is running Debian 5.0 as well. Kernel 2.6.26-2-486. qemu i

[KVM-AUTOTEST PATCH] KVM test: kvm_tests: fix a litte bug in timedrift()

2009-08-28 Thread Cao, Chen
the original version compared a wrong drift value with given threshold. Signed-off-by: Cao, Chen --- client/tests/kvm/kvm_tests.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index b100269..4e3391e 100644

Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code

2009-08-28 Thread Avi Kivity
On 08/28/2009 10:06 AM, Avi Kivity wrote: Why do we need both, btw? Set your vcpu->requests bit, if guest_mode is true, clear it and IPI. So guest_mode=false means, we might be in guest mode but if so we're due for a kick anyway. No, this introduces a race. -- I have a truly marvellous pa

Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code

2009-08-28 Thread Avi Kivity
On 08/27/2009 05:07 PM, Marcelo Tosatti wrote: On Thu, Aug 27, 2009 at 04:24:58PM +0300, Avi Kivity wrote: On 08/27/2009 03:45 PM, Marcelo Tosatti wrote: Why not bool guest_mode? Saves two atomics per exit. It must be atomic since GUEST_MODE / VCPU_KICKED bits are manipul