[PATCH] kvm-kmod cpufreq_get fix

2009-10-09 Thread Zachary Amsden
Define cpufreq_get for kernels which don't export it when not config'd. Signed-off-by: Zachary Amsden diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h index 47fdc86..6fe7d87 100644 --- a/external-module-compat-comm.h +++ b/external-module-compat-comm.h @@ -993,3 +993,12

[PATCH] KVM: Harden against cpufreq

2009-10-09 Thread Zachary Amsden
If cpufreq can't determine the CPU khz, or cpufreq is not compiled in, we should fallback to the measured TSC khz. Signed-off-by: Zachary Amsden diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 11a6f2f..6604f4c 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1345,8 +13

[PATCH] cpufreq: Make cpufreq_get always defined

2009-10-09 Thread Zachary Amsden
Even if not using cpufreq, there is little justification for exporting cpufreq_quick_get and not cpufreq_get, especially when it is so easy and harmless to do. Signed-off-by: Zachary Amsden diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 44717eb..684fc4b 100644 --- a/inc

Re: [was: mmotm 2009-10-09-01-07 uploaded]

2009-10-09 Thread Andrew Morton
On Fri, 9 Oct 2009 08:30:28 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > When CONFIG_CPU_FREQ is disabled, cpufreq_get() needs a stub. > Used by kvm (although it looks like a bit of the kvm code could > be omitted when CONFIG_CPU_FREQ is disabled). > > arch/x86/built-in.o: In function `k

Re: sharing host infiniband between VMs

2009-10-09 Thread Javier Guerra
On Fri, Oct 9, 2009 at 4:11 PM, Cameron Macdonell wrote: > I'm trying to set up a number of VMs on a host that uses IP over infiniband > to its NFS server.  I've been googling, but can't find any mention of > sharing a single IB interface between multiple VMs.  Since its IPoIB, I was > wondering i

Re: kvm guest: hrtimer: interrupt too slow

2009-10-09 Thread Michael Tokarev
Frederic Weisbecker wrote: On Sat, Oct 10, 2009 at 01:22:16AM +0400, Michael Tokarev wrote: Marcelo Tosatti wrote: [snip] Would be useful to collect sar (sar -B -b -u) output every one second in both host/guest. You already mentioned load was low, but this should give more details. Here we go

Re: kvm guest: hrtimer: interrupt too slow

2009-10-09 Thread Frederic Weisbecker
On Sat, Oct 10, 2009 at 01:22:16AM +0400, Michael Tokarev wrote: > Marcelo Tosatti wrote: > [snip] > >> Would be useful to collect sar (sar -B -b -u) output every one second >> in both host/guest. You already mentioned load was low, but this should >> give more details. > > Here we go: http://www.

sharing host infiniband between VMs

2009-10-09 Thread Cameron Macdonell
Hi, I'm trying to set up a number of VMs on a host that uses IP over infiniband to its NFS server. I've been googling, but can't find any mention of sharing a single IB interface between multiple VMs. Since its IPoIB, I was wondering if something there is some similar to bridged ethern

Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Glauber Costa
On Fri, Oct 09, 2009 at 09:55:13PM +0200, Juan Quintela wrote: > Jamie Lokier wrote: > > Glauber Costa wrote: > >> On Thu, Oct 08, 2009 at 06:22:48PM +0200, Gleb Natapov wrote: > >> > On Thu, Oct 08, 2009 at 06:17:57PM +0200, Avi Kivity wrote: > >> > > On 10/08/2009 06:07 PM, Jamie Lokier wrote: >

Re: kvm guest: hrtimer: interrupt too slow

2009-10-09 Thread Michael Tokarev
Marcelo Tosatti wrote: [snip] Would be useful to collect sar (sar -B -b -u) output every one second in both host/guest. You already mentioned load was low, but this should give more details. Here we go: http://www.corpit.ru/mjt/hrtimer-interrupt-too-slow/ Two incindents - cases when hrtimer:

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Jan Kiszka
Zachary Amsden wrote: > On 10/09/2009 10:47 AM, Jan Kiszka wrote: >> Zachary Amsden wrote: >> >>> On 10/09/2009 10:36 AM, Jan Kiszka wrote: >>> Zachary Amsden wrote: > On 10/08/2009 01:18 PM, Jan Kiszka wrote: > > >> Zachary Amsden wrote: >

Re: [Autotest] [PATCH 1/6] KVM test: Added floppy and tftp options to qemu command

2009-10-09 Thread Lucas Meneghel Rodrigues
FYI, patchset applied! On Fri, Oct 9, 2009 at 5:40 PM, Lucas Meneghel Rodrigues wrote: > This allows you to not specify the full path in the > config file, appends to the image dir. > > Signed-off-by: David Huff > --- >  client/tests/kvm/kvm_vm.py |   12 >  1 files changed, 12 inse

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Zachary Amsden
On 10/09/2009 10:47 AM, Jan Kiszka wrote: Zachary Amsden wrote: On 10/09/2009 10:36 AM, Jan Kiszka wrote: Zachary Amsden wrote: On 10/08/2009 01:18 PM, Jan Kiszka wrote: Zachary Amsden wrote: They are globals, not clearly protected by any ordering

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Jan Kiszka
Zachary Amsden wrote: > On 10/09/2009 10:36 AM, Jan Kiszka wrote: >> Zachary Amsden wrote: >> >>> On 10/08/2009 01:18 PM, Jan Kiszka wrote: >>> Zachary Amsden wrote: > They are globals, not clearly protected by any ordering or locking, > and > vulnerable to

[PATCH 6/6] KVM test: kvm_tests.cfg.sample changes for unattended

2009-10-09 Thread Lucas Meneghel Rodrigues
This patch introduces unattended install on the sample config file: * introduced the needed variables for the unattended install test * Created 2 test sets, winxp_unattended and fc11_unattended. * Makes fc11_unattended the default test set Signed-off-by: Lucas Meneghel Rodrigues --- client/t

[PATCH 5/6] KVM test: Utility to make windows guests ACK end of install

2009-10-09 Thread Lucas Meneghel Rodrigues
In order to make windows guests to tell the unattended install server that the install process ended, a simple C++ program using the winsock 2 API had to be developed. The program was based on an MSDN article. Its usage is finish.exe [host-ip] The test expect this to be compiled under deps. This

[PATCH 4/6] KVM test: Add unattended install script

2009-10-09 Thread Lucas Meneghel Rodrigues
In order to make it possible to prepare the environment for the guests installation, we have to: * Prepare a boot floppy for both windows and linux. The boot floppy contains the unattended file, and in case of windows, it will also hold a program that can send to the server a ACK message. For Kic

[PATCH 3/6] KVM test: Add unattended install files for F11 and WinXP

2009-10-09 Thread Lucas Meneghel Rodrigues
This patch adds unattended install files for two Operating Systems: * Fedora 11: Fedora-11.ks * Win XP: winnt.bat and winxp32.sif Attention: Those files work great in case we use user mode networking. For TAP mode networking, kickstart templating needs to be implemented, and I will leave that f

[PATCH 2/6] KVM test: Introducing unattended install subtest

2009-10-09 Thread Lucas Meneghel Rodrigues
In order to resolve the question, 'how will the guest operating system tell the host operating system that the unattended install process finish', we took the simple approach and created a simple socket communication ack process: The test instantiates a server tcp socket on port 12323, and waits du

[PATCH 1/6] KVM test: Added floppy and tftp options to qemu command

2009-10-09 Thread Lucas Meneghel Rodrigues
This allows you to not specify the full path in the config file, appends to the image dir. Signed-off-by: David Huff --- client/tests/kvm/kvm_vm.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index d

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Zachary Amsden
On 10/09/2009 10:36 AM, Jan Kiszka wrote: Zachary Amsden wrote: On 10/08/2009 01:18 PM, Jan Kiszka wrote: Zachary Amsden wrote: They are globals, not clearly protected by any ordering or locking, and vulnerable to various startup races. Instead, for variable TSC machines, r

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Jan Kiszka
Zachary Amsden wrote: > On 10/08/2009 01:18 PM, Jan Kiszka wrote: >> Zachary Amsden wrote: >> >>> They are globals, not clearly protected by any ordering or locking, and >>> vulnerable to various startup races. >>> >>> Instead, for variable TSC machines, register the cpufreq notifier and >>> get

Re: [PATCH v4: kvm 2/4] Kill the confusing tsc_ref_khz and ref_freq variables.

2009-10-09 Thread Zachary Amsden
On 10/08/2009 01:18 PM, Jan Kiszka wrote: Zachary Amsden wrote: They are globals, not clearly protected by any ordering or locking, and vulnerable to various startup races. Instead, for variable TSC machines, register the cpufreq notifier and get the TSC frequency directly from the cpufreq

kernel bug in kvm_intel

2009-10-09 Thread Andrew Theurer
This is on latest master branch on kvm.git and qemu-kvm.git, running 12 Windows Server2008 VMs, and using oprofile. I ran again without oprofile and did not get the BUG. I am wondering if anyone else is seeing this. Thanks, -Andrew Oct 9 11:55:13 virtvictory-eth0 kernel: BUG: unable to h

Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Juan Quintela
Jamie Lokier wrote: > Glauber Costa wrote: >> On Thu, Oct 08, 2009 at 06:22:48PM +0200, Gleb Natapov wrote: >> > On Thu, Oct 08, 2009 at 06:17:57PM +0200, Avi Kivity wrote: >> > > On 10/08/2009 06:07 PM, Jamie Lokier wrote: >> > > >Haven't we already confirmed that it *isn't* just an ioapic accele

Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic

2009-10-09 Thread Anthony Liguori
Jamie Lokier wrote: Glauber Costa wrote: On Fri, Oct 09, 2009 at 11:06:41AM +0100, Jamie Lokier wrote: Glauber Costa wrote: It ensures the two models are compatible. Since they're the same device from the point of view of the guest, there's no reason for them to have differe

Re: sync guest calls made async on host - SQLite performance

2009-10-09 Thread Matthew Tippett
Thanks Duncan for reproducing the behavior outside myself and Phoronix. I dug deeper into the actual syscalls being made by sqlite. The salient part of the behaviour is small sequential writes followed by a fdatasync (effectively a metadata-free fsync). As Dustin indicates, if scsi is us

Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic

2009-10-09 Thread Glauber Costa
On Fri, Oct 09, 2009 at 05:48:31PM +0100, Jamie Lokier wrote: > Glauber Costa wrote: > > On Fri, Oct 09, 2009 at 11:06:41AM +0100, Jamie Lokier wrote: > > > Glauber Costa wrote: > > > > > It ensures the two models are compatible. Since they're the same > > > > > device > > > > > from the point

[PATCH 10/10] remove id field from vcpu context structure

2009-10-09 Thread Glauber Costa
qemu already stores id information in a couple of places. No need to do it here too. Signed-off-by: Glauber Costa --- qemu-kvm.c |2 -- qemu-kvm.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 8257dd3..06c1226 100644 --- a/qemu-kvm.c +

[PATCH 08/10] use env in kvm_arch_run

2009-10-09 Thread Glauber Costa
kvm_arch_run() takes a vcpu context parameter, but CPUState should do. Convert it, as well as the functions that it end up calling Signed-off-by: Glauber Costa --- qemu-kvm-x86.c | 12 ++-- qemu-kvm.c |2 +- qemu-kvm.h |3 ++- 3 files changed, 9 insertions(+), 8 deletio

[PATCH 09/10] remove kvm_run from vcpu_context

2009-10-09 Thread Glauber Costa
There are no more users of kvm_run inside vcpu context. Remove it, and leave the one inside CPUState for the job. Signed-off-by: Glauber Costa --- qemu-kvm.c |4 +--- qemu-kvm.h |1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index fb50bb4..8

[PATCH 07/10] use env as parameter for functions that access kvm_run

2009-10-09 Thread Glauber Costa
Convert header of public functions that access kvm_run, so they can use CPUState version instead. Signed-off-by: Glauber Costa --- qemu-kvm-x86.c |4 ++-- qemu-kvm.c |8 qemu-kvm.h |4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/qemu-kvm-x86.c

[PATCH 06/10] make some functions static

2009-10-09 Thread Glauber Costa
Some functions that uses kvm_run are not static, but should be. Make them static, and make them get a CPUState parameter in the process. Signed-off-by: Glauber Costa --- qemu-kvm-x86.c | 18 +- qemu-kvm.h | 33 - 2 files changed, 9 insertio

[PATCH 04/10] remove kvm_context from vpcu structure

2009-10-09 Thread Glauber Costa
It is not used anywhere, so just blow it away. Signed-off-by: Glauber Costa --- qemu-kvm.c |4 +--- qemu-kvm.h |1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index b92a68e..5c7376d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -441,9 +441,7 @@

[PATCH 05/10] Use kvm_run inside CPUState.

2009-10-09 Thread Glauber Costa
There is no need to replicate kvm_run inside vcpu context, since there is already a field dedicated to that in CPUState. For now, keep both on, so function can be converted slowly, since a lot of function headers will be changed to take an env parameter, instead of a vcpu one. This patch also conv

[PATCH 03/10] remove unneded opaque.

2009-10-09 Thread Glauber Costa
kvm_debug() and kvm_arch_halt() both take an opaque field for no reason, since it is totally unused. kvm_halt() itself is just a wrapper around kvm_arch_halt(), and is removed. Signed-off-by: Glauber Costa --- qemu-kvm-ia64.c |2 +- qemu-kvm-x86.c |2 +- qemu-kvm.c | 13 +++--

[PATCH 01/10] use a more upstream friendly version of irqchip-in-kernel test

2009-10-09 Thread Glauber Costa
Upstream now has tests for irqchip_in_kernel. It differs from our signature, as it does not take any parameter. For consistency, convert our usage. Also, use a field in KVMState to store it, so we can have the exact same function as qemu upstream does. Signed-off-by: Glauber Costa --- exec.c

[PATCH 02/10] drop kvm_mmio_read and write

2009-10-09 Thread Glauber Costa
they are just a tiny wrapper around qemu memory functions. Drop' em Signed-off-by: Glauber Costa --- qemu-kvm-x86.c |7 +-- qemu-kvm.c | 24 2 files changed, 5 insertions(+), 26 deletions(-) diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index a44ae67..e8ec5

[PATCH 00/10] Clean up vcpu context structure

2009-10-09 Thread Glauber Costa
This series aims at cleanin up vcpu_context structure. I am not removing yet the fd field, because it is used in the ioctls, and I want to do it separadedly. But after this series, this structure exists only as a way to hold the file descriptor, and is, much cleaner, and much closer to upstream q

[PATCH 3/9] KVM: SVM: Add tracepoint for nested vmrun

2009-10-09 Thread Joerg Roedel
This patch adds a dedicated kvm tracepoint for a nested vmrun. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c |6 ++ arch/x86/kvm/trace.h | 33 + arch/x86/kvm/x86.c |1 + 3 files changed, 40 insertions(+), 0 deletions(-) diff --git a/arch/x8

[PATCH 5/9] KVM: SVM: Add tracepoint for injected #vmexit

2009-10-09 Thread Joerg Roedel
This patch adds a tracepoint for a nested #vmexit that gets re-injected to the guest. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c |6 ++ arch/x86/kvm/trace.h | 33 + arch/x86/kvm/x86.c |1 + 3 files changed, 40 insertions(+), 0 deletions(-

[PATCH 9/9] KVM: SVM: Remove nsvm_printk debugging code

2009-10-09 Thread Joerg Roedel
With all important informations now delivered through tracepoints we can savely remove the nsvm_printk debugging code for nested svm. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/arch

Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Jamie Lokier
Glauber Costa wrote: > On Thu, Oct 08, 2009 at 06:22:48PM +0200, Gleb Natapov wrote: > > On Thu, Oct 08, 2009 at 06:17:57PM +0200, Avi Kivity wrote: > > > On 10/08/2009 06:07 PM, Jamie Lokier wrote: > > > >Haven't we already confirmed that it *isn't* just an ioapic accelerator > > > >because you ca

Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic

2009-10-09 Thread Jamie Lokier
Glauber Costa wrote: > On Fri, Oct 09, 2009 at 11:06:41AM +0100, Jamie Lokier wrote: > > Glauber Costa wrote: > > > > It ensures the two models are compatible. Since they're the same > > > > device > > > > from the point of view of the guest, there's no reason for them to have > > > > > > >

[PATCH] KVM test: Adding Windows 7 guests and step files

2009-10-09 Thread Lucas Meneghel Rodrigues
After a bit of struggle, here goes the inclusion of windows 7 to our guest testing party. Step files included, unattended install files will follow. It seems to me that is better to keep the ISO names the same as the MSDN names, hence I am keeping the ISO names. Signed-off-by: Lucas Meneghel Rodr

Re: [libvirt] dynamic scsi disk attach seems to be broken in qemu(-kvm)-0.11, libvirt-0.7.1

2009-10-09 Thread Dustin Kirkland
On Fri, Oct 9, 2009 at 3:18 AM, Daniel P. Berrange wrote: > On Thu, Oct 08, 2009 at 10:57:55PM -0500, Dustin Kirkland wrote: >> Now, all of that said, it is actually possible to hot-add a second >> scsi device. However, as far as I can tell, this method is not yet >> supported by libvirt.  It look

Re: kvm build failure [was: mmotm 2009-10-09-01-07 uploaded]

2009-10-09 Thread Jiri Slaby
On 10/09/2009 05:30 PM, Randy Dunlap wrote: > I submitted a patch for that several days ago, against > linux-next-20091006. (below again) Thanks! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [was: mmotm 2009-10-09-01-07 uploaded]

2009-10-09 Thread Randy Dunlap
On Fri, 09 Oct 2009 12:00:55 +0200 Jiri Slaby wrote: > On 10/09/2009 10:07 AM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to > > Hi, build fails with: > ERROR: "cpufreq_get" [arch/x86/kvm/kvm.ko] undefined! > because of > CONFIG_KVM=m > .

Re: [Qemu-devel] Re: [libvirt] dynamic scsi disk attach seems to be broken in qemu(-kvm)-0.11, libvirt-0.7.1

2009-10-09 Thread Dustin Kirkland
On Fri, Oct 9, 2009 at 9:38 AM, Anthony Liguori wrote: >>> I would like some advice on how to proceed with this bug, and where >>> the solution lies...in qemu or in libvirt.  Ultimately, I would like >>> the behavior we had in our previous release with kvm-84 and >>> libvirt-0.6.1, where we could

Re: sync guest calls made async on host - SQLite performance

2009-10-09 Thread Dustin Kirkland
On Fri, Oct 9, 2009 at 6:25 AM, Matthew Tippett wrote: > Can I ask you to do the following... > >  1) Re-affirm that Ubuntu does not carry any non-stream patches and > the build command and possibly any other unusual patches or > commandline options.  This should push it back onto Avi and Anthony'

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Gleb Natapov
On Fri, Oct 09, 2009 at 02:59:29PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 09, 2009 at 01:49:03PM +0200, Gleb Natapov wrote: > > On Fri, Oct 09, 2009 at 12:13:00PM +0200, Michael S. Tsirkin wrote: > > > On Fri, Oct 09, 2009 at 09:00:49AM +0200, Gleb Natapov wrote: > > > > On Fri, Oct 09, 200

Re: [Qemu-devel] Re: [libvirt] dynamic scsi disk attach seems to be broken in qemu(-kvm)-0.11, libvirt-0.7.1

2009-10-09 Thread Anthony Liguori
I would like some advice on how to proceed with this bug, and where the solution lies...in qemu or in libvirt. Ultimately, I would like the behavior we had in our previous release with kvm-84 and libvirt-0.6.1, where we could dynamically add scsi devices without a problem, using: pci_add 1 st

Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Glauber Costa
On Thu, Oct 08, 2009 at 06:22:48PM +0200, Gleb Natapov wrote: > On Thu, Oct 08, 2009 at 06:17:57PM +0200, Avi Kivity wrote: > > On 10/08/2009 06:07 PM, Jamie Lokier wrote: > > >Haven't we already confirmed that it *isn't* just an ioapic accelerator > > >because you can't migrate between in-kernel i

Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic

2009-10-09 Thread Glauber Costa
On Fri, Oct 09, 2009 at 11:06:41AM +0100, Jamie Lokier wrote: > Glauber Costa wrote: > > > It ensures the two models are compatible. Since they're the same device > > > from the point of view of the guest, there's no reason for them to have > > > different representations or to be incompatible

[PATCH 0/9 v3] KVM: Nested SVM fixes and tracepoint conversion

2009-10-09 Thread Joerg Roedel
Hi Avi, Marcelo, this series of patches contains bugfixes for the Nested SVM code and the conversion of Nested SVM debugging to tracepoints. The fixes are: 1) A patch Alex already sent (1/9) but which was not yet applied. It fixes a lost event_inj problem when we emulate a

[PATCH 8/9] KVM: SVM: Add tracepoint for skinit instruction

2009-10-09 Thread Joerg Roedel
This patch adds a tracepoint for the event that the guest executed the SKINIT instruction. This information is important because SKINIT is an SVM extenstion not yet implemented by nested SVM and we may need this information for debugging hypervisors that do not yet run on nested SVM. Signed-off-by

[PATCH 4/9] KVM: SVM: Add tracepoint for nested #vmexit

2009-10-09 Thread Joerg Roedel
This patch adds a tracepoint for every #vmexit we get from a nested guest. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c |6 ++ arch/x86/kvm/trace.h | 36 arch/x86/kvm/x86.c |1 + 3 files changed, 43 insertions(+), 0 deletions(-) diff

[PATCH 6/9] KVM: SVM: Add tracepoint for #vmexit because intr pending

2009-10-09 Thread Joerg Roedel
This patch adds a special tracepoint for the event that a nested #vmexit is injected because kvm wants to inject an interrupt into the guest. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c |2 +- arch/x86/kvm/trace.h | 18 ++ arch/x86/kvm/x86.c |1 + 3 files cha

[PATCH 7/9] KVM: SVM: Add tracepoint for invlpga instruction

2009-10-09 Thread Joerg Roedel
This patch adds a tracepoint for the event that the guest executed the INVLPGA instruction. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm.c |3 +++ arch/x86/kvm/trace.h | 23 +++ arch/x86/kvm/x86.c |1 + 3 files changed, 27 insertions(+), 0 deletions(-) diff

[PATCH 2/9] KVM: SVM: Move INTR vmexit out of atomic code

2009-10-09 Thread Joerg Roedel
The nested SVM code emulates a #vmexit caused by a request to open the irq window right in the request function. This is a bug because the request function runs with preemption and interrupts disabled but the #vmexit emulation might sleep. This can cause a schedule()-while-atomic bug and is fixed w

[PATCH 1/9] KVM: SVM: Notify nested hypervisor of lost event injections

2009-10-09 Thread Joerg Roedel
From: Alexander Graf If event_inj is valid on a #vmexit the host CPU would write the contents to exit_int_info, so the hypervisor knows that the event wasn't injected. We don't do this in nested SVM by now which is a bug and fixed by this patch. Signed-off-by: Alexander Graf Signed-off-by: Joe

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Michael S. Tsirkin
On Fri, Oct 09, 2009 at 01:49:03PM +0200, Gleb Natapov wrote: > On Fri, Oct 09, 2009 at 12:13:00PM +0200, Michael S. Tsirkin wrote: > > On Fri, Oct 09, 2009 at 09:00:49AM +0200, Gleb Natapov wrote: > > > On Fri, Oct 09, 2009 at 08:43:59AM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Oct 08, 200

Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Gleb Natapov
On Fri, Oct 09, 2009 at 11:02:31AM +0100, Jamie Lokier wrote: > Gleb Natapov wrote: > > On Thu, Oct 08, 2009 at 06:42:07PM +0200, Avi Kivity wrote: > > > On 10/08/2009 06:34 PM, Gleb Natapov wrote: > > > >So suppose I have simple watchdog device that required to be poked every > > > >second, otherw

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Gleb Natapov
On Fri, Oct 09, 2009 at 12:37:38PM +0100, Jamie Lokier wrote: > Michael S. Tsirkin wrote: > > More long-term, we have duplication between reset and init > > routines. Maybe devices really should have init and cleanup, > > and on reset we'd cleanup all devices and then init them again? > > It sound

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Gleb Natapov
On Fri, Oct 09, 2009 at 12:13:00PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 09, 2009 at 09:00:49AM +0200, Gleb Natapov wrote: > > On Fri, Oct 09, 2009 at 08:43:59AM +0200, Michael S. Tsirkin wrote: > > > On Thu, Oct 08, 2009 at 07:40:12PM +0100, Jamie Lokier wrote: > > > > Avi Kivity wrote: >

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Jamie Lokier
Michael S. Tsirkin wrote: > More long-term, we have duplication between reset and init > routines. Maybe devices really should have init and cleanup, > and on reset we'd cleanup all devices and then init them again? It sounds look a good idea to me. That is, after all, what hardware reset often d

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Michael S. Tsirkin
On Fri, Oct 09, 2009 at 09:00:49AM +0200, Gleb Natapov wrote: > On Fri, Oct 09, 2009 at 08:43:59AM +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 08, 2009 at 07:40:12PM +0100, Jamie Lokier wrote: > > > Avi Kivity wrote: > > > > On 10/08/2009 06:06 PM, Michael S. Tsirkin wrote: > > > > >On Thu, Oc

Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic

2009-10-09 Thread Jamie Lokier
Glauber Costa wrote: > > It ensures the two models are compatible. Since they're the same device > > from the point of view of the guest, there's no reason for them to have > > different representations or to be incompatible. > > live migration between something that has in-kernel irqchip and

Re: [PATCH] [RESEND] KVM:VMX: Add support for Pause-Loop Exiting

2009-10-09 Thread Zhai, Edwin
Tosatti, See attached patch. Avi, Could you pls. do the check in if no any other comments. Thanks, Marcelo Tosatti wrote: On Wed, Sep 30, 2009 at 01:22:49PM -0300, Marcelo Tosatti wrote: On Wed, Sep 30, 2009 at 09:01:51AM +0800, Zhai, Edwin wrote: Avi, I modify it according your comm

Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic

2009-10-09 Thread Jamie Lokier
Gleb Natapov wrote: > On Thu, Oct 08, 2009 at 06:42:07PM +0200, Avi Kivity wrote: > > On 10/08/2009 06:34 PM, Gleb Natapov wrote: > > >So suppose I have simple watchdog device that required to be poked every > > >second, otherwise it resets a computer. On migration we have to migrate > > >time elap

[was: mmotm 2009-10-09-01-07 uploaded]

2009-10-09 Thread Jiri Slaby
On 10/09/2009 10:07 AM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to Hi, build fails with: ERROR: "cpufreq_get" [arch/x86/kvm/kvm.ko] undefined! because of CONFIG_KVM=m ... # CONFIG_CPU_FREQ is not set Should cpufreq_get be defined as inli

Re: [libvirt] dynamic scsi disk attach seems to be broken in qemu(-kvm)-0.11, libvirt-0.7.1

2009-10-09 Thread Daniel P. Berrange
On Thu, Oct 08, 2009 at 10:57:55PM -0500, Dustin Kirkland wrote: > Now, all of that said, it is actually possible to hot-add a second > scsi device. However, as far as I can tell, this method is not yet > supported by libvirt. It looks to me that with modern qemu, you have > to do it this way: >

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-09 Thread Mark McLoughlin
On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: > On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: > > On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: > > > linux 2.6.32 includes UDP fragmentation offload support in software. > > > So we can enable UFO on the host

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-09 Thread Gleb Natapov
On Fri, Oct 09, 2009 at 08:43:59AM +0200, Michael S. Tsirkin wrote: > On Thu, Oct 08, 2009 at 07:40:12PM +0100, Jamie Lokier wrote: > > Avi Kivity wrote: > > > On 10/08/2009 06:06 PM, Michael S. Tsirkin wrote: > > > >On Thu, Oct 08, 2009 at 05:29:29PM +0200, Avi Kivity wrote: > > > > > > > >>On

Re: [Qemu-devel] [PATCHv2] seabios: enable io/memory unconditionally

2009-10-09 Thread Michael S. Tsirkin
On Thu, Oct 08, 2009 at 10:29:53PM -0400, Kevin O'Connor wrote: > Hi Michael, > > On Thu, Oct 08, 2009 at 05:53:46PM +0200, Michael S. Tsirkin wrote: > > VGA adapters need to claim memory and i/o > > transactions even if they do not have any > > i/o or memory bars. E.g. PCI spec, page 297, > > giv