Re: I/O performance of VirtIO

2009-10-13 Thread Jan Kiszka
Michael Tokarev wrote: René Pfeiffer wrote: Hello! I just tested qemu-kvm-0.11.0 with the KVM module of kernel 2.6.31.1. I noticed that the I/O performance of an unattended stock Debian Lenny install dropped somehow. The test machines ran with kvm-88 and 2.6.30.x before. The difference is

Re: kernel bug in kvm_intel

2009-10-13 Thread Avi Kivity
On 10/12/2009 08:42 PM, Andrew Theurer wrote: On Sun, 2009-10-11 at 07:19 +0200, Avi Kivity wrote: On 10/09/2009 10:04 PM, Andrew Theurer wrote: This is on latest master branch on kvm.git and qemu-kvm.git, running 12 Windows Server2008 VMs, and using oprofile. I ran again without

RE: Biweekly KVM Test report, kernel 94252... qemu 5cc3c...

2009-10-13 Thread Xu, Jiajun
On Monday, October 05, 2009 7:00 PM Avi Kivity wrote: On 09/29/2009 05:34 AM, Xu, Jiajun wrote: Hi All, This Weekly KVM Testing Report against lastest kvm.git 94252a58662dc4ca6191eac479efb40e0716865c and qemu-kvm.git 5cc3cfb6c2254483ae324da407a13307fe7355f3. Qemu-kvm tree build issue is

Re: QemuOpts changes breaks multiple nic options

2009-10-13 Thread Mark McLoughlin
Hi Tom, On Mon, 2009-10-12 at 17:05 -0500, Tom Lendacky wrote: The recent change to QemuOpts for the -net nic option breaks specifying -net nic,... more than once. The net_init_nic function's return value in net.c is a table index, which is non-zero after the first time it is called. The

[PATCH] Little bug fix in pci_hotplug.py

2009-10-13 Thread Yolkfull Chow
If command executed timeout, the return value of status could be None, which is missed in judge statement: if s: ... Thanks Jason Wang for pointing this out. Signed-off-by: Yolkfull Chow yz...@redhat.com --- client/tests/kvm/tests/pci_hotplug.py |2 +- 1 files changed, 1 insertions(+),

Re: [PATCH 1/1] virtio: adding __devexit to virtballoon_remove

2009-10-13 Thread Rusty Russell
Thanks, I already have this from Uwe. Cheers, Rusty. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[KVM-AUTOTEST PATCH 1/3] KVM test: kvm_subprocess.py: do not start tail thread by default

2009-10-13 Thread Michael Goldish
Start the tail thread only if the user specifies a non-None output_func or termination_func. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git

[KVM-AUTOTEST PATCH 2/3] KVM test: kvm_subprocess.py: use only unbound methods as close() hooks

2009-10-13 Thread Michael Goldish
close() will pass 'self' as a parameter to the hook functions, i.e. it will call hook(self) instead of just hook(), thus allowing the use of unbound methods rather than bound ones. This allows us to avoid self referencing: if a bound method is used, a reference to it is kept in the class

[KVM-AUTOTEST PATCH 3/3] KVM test: kvm_subprocess.py: automatically close unreferenced shell sessions

2009-10-13 Thread Michael Goldish
Note that if a session has a tracking thread (i.e. if output_func or termination_func are set to something other than None) then the session will not be garbage collected (it must be closed explicitly by the test). Signed-off-by: Michael Goldish mgold...@redhat.com ---

[PATCH 1/2] Complete cpu initialization before signaling main thread.

2009-10-13 Thread Gleb Natapov
Otherwise some cpus may start executing code before others are fully initialized. Signed-off-by: Gleb Natapov g...@redhat.com --- qemu-kvm.c | 26 -- 1 files changed, 12 insertions(+), 14 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 62ca050..3765818 100644

Re: [KVM-AUTOTEST,01/17] Add new module kvm_subprocess

2009-10-13 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: On Mon, Oct 12, 2009 at 09:07:45AM -0400, Michael Goldish wrote: You're right, currently the sessions must be closed explicitly. This is due to the fact that both qemu and ssh/telnet are handled by the same code, and qemu has to keep running in the

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
On Mon, Oct 12, 2009 at 10:53:26AM +0200, Avi Kivity wrote: On 10/06/2009 07:24 PM, Glauber Costa wrote: When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts

[PATCH 2/2] Don't sync mpstate to/from kernel when unneeded.

2009-10-13 Thread Gleb Natapov
mp_state, unlike other cpu state, can be changed not only from vcpu context it belongs to, but by other vcpus too. That makes its loading from kernel/saving back not safe if mp_state value is changed inside kernel between load and save. For example vcpu 1 loads mp_sate into user-space and the

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Avi Kivity
On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment? What exactly do you mean? Absolute adjustment: clock = t Relative adjustment: clock += t -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
On Tue, Oct 13, 2009 at 03:31:08PM +0300, Avi Kivity wrote: On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment? What exactly do you mean? Absolute adjustment: clock = t Relative adjustment: clock += t The delta is absolute, but the

Re: [Autotest] [PATCH] Little bug fix in pci_hotplug.py

2009-10-13 Thread Lucas Meneghel Rodrigues
Applied, thanks! On Tue, Oct 13, 2009 at 6:13 AM, Yolkfull Chow yz...@redhat.com wrote: If command executed timeout, the return value of status could be None, which is missed in judge statement: if s:   ... Thanks Jason Wang for pointing this out. Signed-off-by: Yolkfull Chow

[PATCH] v2: allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger monotonic time starts running the guest, the view of time will be

Re: kernel bug in kvm_intel

2009-10-13 Thread Andrew Theurer
On Tue, 2009-10-13 at 08:50 +0200, Avi Kivity wrote: On 10/12/2009 08:42 PM, Andrew Theurer wrote: On Sun, 2009-10-11 at 07:19 +0200, Avi Kivity wrote: On 10/09/2009 10:04 PM, Andrew Theurer wrote: This is on latest master branch on kvm.git and qemu-kvm.git, running 12

Re: kernel bug in kvm_intel

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 08:50:07AM +0200, Avi Kivity wrote: On 10/12/2009 08:42 PM, Andrew Theurer wrote: On Sun, 2009-10-11 at 07:19 +0200, Avi Kivity wrote: On 10/09/2009 10:04 PM, Andrew Theurer wrote: This is on latest master branch on kvm.git and qemu-kvm.git, running 12

[PATCH] device assignment rom fixups

2009-10-13 Thread Gerd Hoffmann
Use new rom loading infrastructure. Devices can simply register option roms now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/device-assignment.c | 144 --- hw/device-assignment.h |1 - hw/pc.c|3 - 3 files changed, 61

[PATCH] fix quoting in configure

2009-10-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 2341772..b0d5bd9 100755 --- a/configure +++ b/configure @@ -1414,7 +1414,7 @@ if test $kvm_cap_pit != no ; then #endif int

Re: Problem booting guest with Linux 2.6.3x

2009-10-13 Thread Daniel Bareiro
Hi Michael. On Saturday, 10 October 2009 20:10:16 +0400, Michael Tokarev wrote: But according to it seems, I could verify that the disks that are passed with -hdX in KVM-88 are mapped in 2.6.31.2 guests like SATA/SCSI devices. With Linux stock 2.6.26 these are mapped like IDE disks. Can it

[PATCH 3/4] KVM: x86: Add support for KVM_GET/SET_VCPU_STATE

2009-10-13 Thread Jan Kiszka
Add support for getting/setting MSRs, CPUID tree, and the LACPIC via the new VCPU state interface. Also in this case we convert the existing IOCTLs to use the new infrastructure internally. The MSR interface has to be extended to pass back the number of processed MSRs via the header structure

[PATCH 4/4] KVM: x86: Add VCPU substate for NMI states

2009-10-13 Thread Jan Kiszka
This plugs an NMI-related hole in the VCPU synchronization between kernel and user space. So far, neither pending NMIs nor the inhibit NMI mask was properly read/set which was able to cause problems on vmsave/restore, live migration and system reset. Fix it by making use of the new VCPU substate

[PATCH 1/4] KVM: Reorder IOCTLs in main kvm.h

2009-10-13 Thread Jan Kiszka
Obviously, people tend to extend this header at the bottom - more or less blindly. Ensure that deprecated stuff gets its own corner again by moving things to the top. Also add some comments and reindent IOCTLs to make them more readable and reduce the risk of number collisions. Signed-off-by: Jan

[PATCH 0/4] Extensible VCPU state IOCTL

2009-10-13 Thread Jan Kiszka
As you may have noticed, we are constantly adding IOCTLs as yet another state field has to be exchanged between kernel and user space. I was about to add one for the missing hidden NMI states (pending and masked), but Avi suggested to take this chance, inventing a more easily extensible interface.

[PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-13 Thread Jan Kiszka
Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. More precisely, the IOCTL is able to process a list of substates to be read or written. This list is easily extensible without breaking the existing ABI, thus we will no longer have to add new IOCTLs when we discover a missing

[RFC][PATCH] kvm: x86: Add support for KVM_GET/PUT_VCPU_STATE

2009-10-13 Thread Jan Kiszka
This is a demonstration patch for the new KVM IOCTLs proposed in [1]. It converts upstream kvm to use this in favor of the individual IOCTLs to get/set VCPU registers and related states. It works, fixes the missing NMI state handling but, of course, only makes sense if the interface is accepted by

Re: [PATCH] include stdlib.h in qemu-kvm.h

2009-10-13 Thread Marcelo Tosatti
On Thu, Oct 08, 2009 at 03:53:59PM -0300, Glauber Costa wrote: abort() needs it. Build with kvm disabled breaks without it. Signed-off-by: Glauber Costa glom...@redhat.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-13 Thread Marcelo Tosatti
On Fri, Oct 09, 2009 at 08:11:28AM +0100, Mark McLoughlin wrote: On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: linux 2.6.32 includes UDP fragmentation

Re: Modifying RAM during runtime on guest

2009-10-13 Thread Daniel Bareiro
Hi Jim. On Wednesday, 07 October 2009 14:21:15 -0400, Jim Paris wrote: I noticed no-one answered this, and I just ran into the same thing myself. As Avi pointed out earlier, it is a guest bug, and upgrading the guest to 2.6.27 should fix it:

Re: [PATCH 00/10] Clean up vcpu context structure

2009-10-13 Thread Marcelo Tosatti
On Fri, Oct 09, 2009 at 03:03:08PM -0300, Glauber Costa wrote: This series aims at cleanin up vcpu_context structure. I am not removing yet the fd field, because it is used in the ioctls, and I want to do it separadedly. But after this series, this structure exists only as a way to hold the

Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-13 Thread Marcelo Tosatti
javier, This is fixed in the -next branch of kvm.git. Thanks. On Sun, Oct 11, 2009 at 02:28:23AM -0400, javier martinez canillas wrote: I got this compile warning with today linux-next: arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’: arch/x86/kvm/mmu.c:770: warning: cast to pointer

Re: [PATCH] KVM: x86: Drop unneeded CONFIG_HAS_IOMEM check

2009-10-13 Thread Marcelo Tosatti
On Mon, Oct 12, 2009 at 08:51:40AM +0200, Jan Kiszka wrote: This (broken) check dates back to the days when this code was shared across architectures. x86 has IOMEM, so drop it. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] Complete cpu initialization before signaling main thread.

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 02:17:19PM +0200, Gleb Natapov wrote: Otherwise some cpus may start executing code before others are fully initialized. Signed-off-by: Gleb Natapov g...@redhat.com --- qemu-kvm.c | 26 -- 1 files changed, 12 insertions(+), 14 deletions(-)

Re: [PATCH 1/2] Complete cpu initialization before signaling main thread.

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 03:19:08PM -0300, Marcelo Tosatti wrote: @@ -2003,15 +1991,25 @@ static void *ap_main_loop(void *_env) on_vcpu(env, kvm_arch_do_ioperm, data); #endif -/* signal VCPU creation */ +setup_kernel_sigmask(env); +

Re: [PATCH 1/2] Complete cpu initialization before signaling main thread.

2009-10-13 Thread Gleb Natapov
On Tue, Oct 13, 2009 at 03:19:08PM -0300, Marcelo Tosatti wrote: On Tue, Oct 13, 2009 at 02:17:19PM +0200, Gleb Natapov wrote: Otherwise some cpus may start executing code before others are fully initialized. Signed-off-by: Gleb Natapov g...@redhat.com --- qemu-kvm.c | 26

Re: [PATCH 2/2] Don't sync mpstate to/from kernel when unneeded.

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 02:17:20PM +0200, Gleb Natapov wrote: mp_state, unlike other cpu state, can be changed not only from vcpu context it belongs to, but by other vcpus too. That makes its loading from kernel/saving back not safe if mp_state value is changed inside kernel between load and

Re: [PATCH 2/2] Don't sync mpstate to/from kernel when unneeded.

2009-10-13 Thread Gleb Natapov
On Tue, Oct 13, 2009 at 03:36:13PM -0300, Marcelo Tosatti wrote: On Tue, Oct 13, 2009 at 02:17:20PM +0200, Gleb Natapov wrote: mp_state, unlike other cpu state, can be changed not only from vcpu context it belongs to, but by other vcpus too. That makes its loading from kernel/saving back

Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-13 Thread Javier Martinez Canillas
Thank you. Sorry for the noise. Best regards - Javier Martínez Canillas +595 981 88 66 58 On Tue, Oct 13, 2009 at 1:10 PM, Marcelo Tosatti mtosa...@redhat.com wrote: javier, This is fixed in the -next branch of kvm.git. Thanks. On Sun, Oct 11, 2009

[PATCH v2] qemu-kvm: Fix configure to respect --kerneldir

2009-10-13 Thread Jan Kiszka
This simplifies working with new features without having to update the locally mirrored headers. It also reduces the diff to upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- v2: Rebase over git head configure | 46 -- 1 files changed,

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-13 Thread Lucas Meneghel Rodrigues
Hi Yolkfull and Chen: Thanks for your test! I have some comments and doubts to clear, most of them are about content of the messages delivered for the user and some other details. On Sun, Sep 27, 2009 at 6:11 AM, Yolkfull Chow yz...@redhat.com wrote: For this case, Ken Cao wrote the linux part

Re: [Autotest] [PATCH 4/6] KVM test: Add unattended install script

2009-10-13 Thread Ryan Harper
* Lucas Meneghel Rodrigues l...@redhat.com [2009-10-09 15:41]: In order to make it possible to prepare the environment for the guests installation, we have to: +class UnattendedInstall(object): + +Creates a floppy disk image that will contain a config file for unattended +

[PATCH] v3: allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger monotonic time starts running the guest, the view of time will be

Re: [PATCH] v3: allow userspace to adjust kvmclock offset

2009-10-13 Thread Frederik Deweerdt
On Tue, Oct 13, 2009 at 04:55:05PM -0400, Glauber Costa wrote: + case KVM_SET_CLOCK: { + struct timespec now; + struct kvm_clock_data user_ns; + u64 now_ns; + long delta; Should'nt that read s64? I guess such a large

Re: [Autotest] [PATCH 4/6] KVM test: Add unattended install script

2009-10-13 Thread Lucas Meneghel Rodrigues
On Tue, Oct 13, 2009 at 5:52 PM, Ryan Harper ry...@us.ibm.com wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-09 15:41]: In order to make it possible to prepare the environment for the guests installation, we have to: +class UnattendedInstall(object): +     +    Creates a

Re: [PATCH] device assignment rom fixups

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 05:20:34PM +0200, Gerd Hoffmann wrote: Use new rom loading infrastructure. Devices can simply register option roms now. Signed-off-by: Gerd Hoffmann kra...@redhat.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH v2] qemu-kvm: Fix configure to respect --kerneldir

2009-10-13 Thread Marcelo Tosatti
On Tue, Oct 13, 2009 at 09:01:09PM +0200, Jan Kiszka wrote: This simplifies working with new features without having to update the locally mirrored headers. It also reduces the diff to upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied, thanks. -- To unsubscribe from this

Re: sync guest calls made async on host - SQLite performance

2009-10-13 Thread Christoph Hellwig
On Sun, Oct 11, 2009 at 11:16:42AM +0200, Avi Kivity wrote: if scsi is used, you incur the cost of virtualization, if virtio is used, your guests fsyncs incur less cost. So back to the question to the kvm team. It appears that with the stock KVM setup customers who need higher data

Re: sync guest calls made async on host - SQLite performance

2009-10-13 Thread Anthony Liguori
Matthew Tippett wrote: Thanks Duncan for reproducing the behavior outside myself and Phoronix. I dug deeper into the actual syscalls being made by sqlite. The salient part of the behaviour is small sequential writes followed by a fdatasync (effectively a metadata-free fsync). As Dustin

Re: sync guest calls made async on host - SQLite performance

2009-10-13 Thread Matthew Tippett
No, it's an absurd assessment. You have additional layers of caching happening because you're running a guest from a filesystem on the host. Comments below. A benchmark running under a guest that happens do be faster than the host does not indicate anything. It could be that the

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-13 Thread Yolkfull Chow
On Tue, Oct 13, 2009 at 05:29:40PM -0300, Lucas Meneghel Rodrigues wrote: Hi Yolkfull and Chen: Thanks for your test! I have some comments and doubts to clear, most of them are about content of the messages delivered for the user and some other details. On Sun, Sep 27, 2009 at 6:11 AM,

Re: sync guest calls made async on host - SQLite performance

2009-10-13 Thread Dustin Kirkland
On Tue, Oct 13, 2009 at 9:09 PM, Matthew Tippett tippe...@gmail.com wrote: I believe that I have removed the benchmark from discussion, we are now looking at semantics of small writes followed by ... And quoting from Dustin === I have tried this, exactly as you have described.  The tests

[PATCH][RFC] Xen PV-on-HVM guest support

2009-10-13 Thread Ed Swierk
As we discussed a while back, support for Xen PV-on-HVM guests can be implemented almost entirely in userspace, except for handling one annoying MSR that maps a Xen hypercall blob into guest address space. A generic mechanism to delegate MSR writes to userspace seems overkill and risks

Added VM Exit on RDTSC, trouble handling in userspace

2009-10-13 Thread Kurt Kiefer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, In short, I have a need for trapping RDTSC with a VM Exit and this works, but I'm having trouble handling it in userspace. I have added the hooks I need (I only care about VMX right now), but a piece of the puzzle is missing and I