Re: kvm problem: bonding network interface breaks dhcp

2009-11-03 Thread Harald Dunkel
Hi Matt, Matthew Palmer wrote: > > The output of brctl show, ip addr list, and cat /proc/net/bonding/bond* > might be helpful. > Sure. Using the bridge on the bonding interface (while the guest was running) I got: # brctl show bridge name bridge id STP enabled interfaces

Re: xp guest, blue screen c0000221 on boot

2009-11-03 Thread Avi Kivity
On 11/04/2009 05:45 AM, Andrew Olney wrote: OK, if I convert the raw image to qcow2, it boots fine. Why should a raw image give a blue screen? Sounds like a serious bug. What is the host filesystem? Did you upgrade the host kernel or qemu? -- Do not meddle in the internals of kernels, for

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-11-03 Thread Yolkfull Chow
On Wed, Oct 28, 2009 at 02:04:59PM -0400, Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > > > On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish > > wrote: > > > Sounds great, except it won't allow you to debug your configuration > > > using kvm_config.py.  So the question no

Re: vga_arb warning [was: mmotm 2009-11-01-10-01 uploaded]

2009-11-03 Thread Andrew Morton
Please cc me on mmotm bug reports! On Sun, 01 Nov 2009 22:47:05 +0100 Jiri Slaby wrote: > On 11/01/2009 07:07 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2009-11-01-10-01 has been uploaded to > > Hi, I got the following warning while booting an image in qemu-kvm: >

Re: xp guest, blue screen c0000221 on boot

2009-11-03 Thread Andrew Olney
OK, if I convert the raw image to qcow2, it boots fine. Why should a raw image give a blue screen? Avi Kivity wrote: On 10/28/2009 05:27 PM, Andrew Olney wrote: Thanks. In pursuing this suggestion I discovered that I also can't make new XP VMs. Setup fails with "the disk may be damaged". The

Re: xp guest, blue screen c0000221 on boot

2009-11-03 Thread Andrew Olney
Thanks for the suggestion. I've successfully installed on a new qcow2 image. Strangely all of my xp raw images no longer work. That makes me think that this is more than just a corrupt image. I've been using kvm for several years with raw images, so I don't think the BIOS could be a factor ei

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Paul E. McKenney
On Tue, Nov 03, 2009 at 01:14:06PM -0500, Gregory Haskins wrote: > Gregory Haskins wrote: > > Eric Dumazet wrote: > >> Michael S. Tsirkin a écrit : > >>> +static void handle_tx(struct vhost_net *net) > >>> +{ > >>> + struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; > >>> + unsigned head

Re: 2.6.31.4 panic: CRED: put_cred_rcu() sees ffff880204e58c00 with usage 82150912

2009-11-03 Thread Nikola Ciprich
Hello Marcelo, well, my report might have been a bit misleading, 2.6.31.2 has been running there for almost 3 weeks. So the problem didn't occur JUST after the upgrade. But it never occured before it, while we were using older kernels (varius 2.6.30.x, 2.6.29.x and older). I've updated machine to

Re: [PATCH 14/27] Add book3s_64 specific opcode emulation

2009-11-03 Thread Benjamin Herrenschmidt
On Tue, 2009-11-03 at 10:06 +0100, Alexander Graf wrote: > > DCBZ zeroes out a cache line, not 32 bytes; except on 970, where there > > are HID bits to make it work on 32 bytes only, and an extra DCBZL insn > > that always clears a full cache line (128 bytes). > > Yes. We only come here when we p

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Eric Dumazet
Michael S. Tsirkin a écrit : > > Paul, you acked this previously. Should I add you acked-by line so > people calm down? If you would rather I replace > rcu_dereference/rcu_assign_pointer with rmb/wmb, I can do this. > Or maybe patch Documentation to explain this RCU usage? > So you believe I am

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Gregory Haskins
Eric Dumazet wrote: > Gregory Haskins a écrit : >> Gregory Haskins wrote: >>> Eric Dumazet wrote: Michael S. Tsirkin a écrit : using rcu_dereference() and mutex_lock() at the same time seems wrong, I suspect that your use of RCU is not correct. 1) rcu_dereference() s

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-11-03 Thread Gerd Hoffmann
On 10/30/09 09:12, Hannes Reinecke wrote: Gerd Hoffmann wrote: http://repo.or.cz/w/qemu/kraxel.git?a=shortlog;h=refs/heads/scsi.v1 It is far from being completed, will continue tomorrow. Should give a idea of the direction I'm heading to though. Comments welcome. Yep, this looks good. Mor

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Michael S. Tsirkin
On Tue, Nov 03, 2009 at 07:03:55PM +0100, Eric Dumazet wrote: > Michael S. Tsirkin a écrit : > > +static void handle_tx(struct vhost_net *net) > > +{ > > + struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; > > + unsigned head, out, in, s; > > + struct msghdr msg = { > > +

Re: libvirt bug #532480

2009-11-03 Thread Vadim Rozenfeld
On 11/03/2009 06:48 PM, Brian Jackson wrote: On Tuesday 03 November 2009 06:02:42 am roma1390 wrote: Lib virt thinks that bug #532480 must be addressed to quemu/kvm team. https://bugzilla.redhat.com/show_bug.cgi?id=532480 For future reference adding some overview to your email i

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Michael S. Tsirkin
On Tue, Nov 03, 2009 at 07:51:35PM +0100, Eric Dumazet wrote: > Gregory Haskins a écrit : > > Gregory Haskins wrote: > >> Eric Dumazet wrote: > >>> Michael S. Tsirkin a écrit : > +static void handle_tx(struct vhost_net *net) > +{ > +struct vhost_virtqueue *vq = &net->dev.vqs[

Re: XP blue screen with qemu-kvm-0.11.0

2009-11-03 Thread Ross Boylan
On Sat, 2009-10-31 at 15:21 +0300, Michael Tokarev wrote: > Ross Boylan wrote: > > My XP VM was working OK, and then started crashing shortly after it > > logged me in. There were no obvious changes at the time. I built the > > latest qemu-kvm, but the problem persists. > > > > I am running 32 b

Re: [Linux-fbdev-devel] [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Paolo Bonzini
On 11/03/2009 05:05 PM, Avi Kivity wrote: On 11/03/2009 05:29 PM, Ondrej Zajicek wrote: On Tue, Nov 03, 2009 at 11:38:18AM +0200, Avi Kivity wrote: On 11/03/2009 01:25 PM, Vincent Hanquez wrote: not sure if i'm missing the point here, but couldn't it be hypothetically extended to stuff 3d (or

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Eric Dumazet
Gregory Haskins a écrit : > Gregory Haskins wrote: >> Eric Dumazet wrote: >>> Michael S. Tsirkin a écrit : +static void handle_tx(struct vhost_net *net) +{ + struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; + unsigned head, out, in, s; + struct msghdr msg = {

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Gregory Haskins
Eric Dumazet wrote: > Michael S. Tsirkin a écrit : >> +static void handle_tx(struct vhost_net *net) >> +{ >> +struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; >> +unsigned head, out, in, s; >> +struct msghdr msg = { >> +.msg_name = NULL, >> +.msg_name

[PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Michael S. Tsirkin
What it is: vhost net is a character device that can be used to reduce the number of system calls involved in virtio networking. Existing virtio net code is used in the guest without modification. There's similarity with vringfd, with some differences and reduced scope - uses eventfd for signallin

Re: [RFC] make cpu creation happen inside the right thread.

2009-11-03 Thread Marcelo Tosatti
On Tue, Nov 03, 2009 at 12:35:08PM -0200, Glauber Costa wrote: > Right now, we issue cpu creation from the i/o thread, and then shoot a thread > from inside that code. Over the last months, a lot of subtle bugs were > reported, > usually arising from the very fragile order of that initialization.

Re: [RFC] make cpu creation happen inside the right thread.

2009-11-03 Thread Glauber Costa
On Tue, Nov 03, 2009 at 03:46:07PM -0200, Marcelo Tosatti wrote: > On Tue, Nov 03, 2009 at 12:35:08PM -0200, Glauber Costa wrote: > > Right now, we issue cpu creation from the i/o thread, and then shoot a > > thread > > from inside that code. Over the last months, a lot of subtle bugs were > > re

[PATCH 2/2] qemu-kvm: x86: Add support for event states

2009-11-03 Thread Jan Kiszka
This patch extends the qemu-kvm state sync logic with the event substate from the new VCPU state interface, giving access to yet missing exception, interrupt and NMI states. The patch does not switch the rest of qemu-kvm's code to the new interface as it is expected to be morphed into upstream's

[PATCH 1/2] qemu-kvm: x86: Refactor use of interrupt_bitmap

2009-11-03 Thread Jan Kiszka
Drop interrupt_bitmap from the cpustate and solely rely on the integer interupt_injected. This prepares us for the new injected-interrupt interface, which will deprecate the bitmap, while preserving compatibility. Signed-off-by: Jan Kiszka --- Note: A corresponding version for upstream is on the

Re: [PATCHv7 2/3] mm: export use_mm/unuse_mm to modules

2009-11-03 Thread Gregory Haskins
Michael S. Tsirkin wrote: > vhost net module wants to do copy to/from user from a kernel thread, > which needs use_mm. Export it to modules. > > Acked-by: Andrea Arcangeli > Signed-off-by: Michael S. Tsirkin I need this too: Acked-by: Gregory Haskins > --- > mm/mmu_context.c |3 +++ > 1

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Gregory Haskins
Gregory Haskins wrote: > Eric Dumazet wrote: >> Michael S. Tsirkin a écrit : >>> +static void handle_tx(struct vhost_net *net) >>> +{ >>> + struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; >>> + unsigned head, out, in, s; >>> + struct msghdr msg = { >>> + .msg_name = NUL

Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Eric Dumazet
Michael S. Tsirkin a écrit : > +static void handle_tx(struct vhost_net *net) > +{ > + struct vhost_virtqueue *vq = &net->dev.vqs[VHOST_NET_VQ_TX]; > + unsigned head, out, in, s; > + struct msghdr msg = { > + .msg_name = NULL, > + .msg_namelen = 0, > +

Re: kvm problem: bonding network interface breaks dhcp

2009-11-03 Thread Matthew Palmer
On Tue, Nov 03, 2009 at 04:45:48PM +0100, Harald Dunkel wrote: > I am trying to use a bonding network interface as a bridge > for a virtual machine (kvm). Host and guest are both running > 2.6.31.5. Problem: The guest does not receive the DHCPOFFER > reply sent by my dhcp server. There is no such p

Re: [Linux-fbdev-devel] [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Ondrej Zajicek
On Tue, Nov 03, 2009 at 06:05:13PM +0200, Avi Kivity wrote: >>> cirrus has pretty good 2d acceleration. 3D is a mega-project though. >>> >> Cirrus has no blending/compositing hardware support. >> Paravirtualized graphics can easily support full XRender-style >> 2D acceleration. > > What do t

Re: libvirt bug #532480

2009-11-03 Thread Brian Jackson
On Tuesday 03 November 2009 06:02:42 am roma1390 wrote: > Lib virt thinks that bug #532480 must be addressed to quemu/kvm team. > >https://bugzilla.redhat.com/show_bug.cgi?id=532480 For future reference adding some overview to your email instead of making all the devs with arguably limited

[RFC] make cpu creation happen inside the right thread.

2009-11-03 Thread Glauber Costa
Right now, we issue cpu creation from the i/o thread, and then shoot a thread from inside that code. Over the last months, a lot of subtle bugs were reported, usually arising from the very fragile order of that initialization. I propose we rethink that a little. This is a patch that received basic

kvm problem: bonding network interface breaks dhcp

2009-11-03 Thread Harald Dunkel
Hi folks, I am trying to use a bonding network interface as a bridge for a virtual machine (kvm). Host and guest are both running 2.6.31.5. Problem: The guest does not receive the DHCPOFFER reply sent by my dhcp server. There is no such problem if the host uses just a single network interface inst

Re: [Linux-fbdev-devel] [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Avi Kivity
On 11/03/2009 05:29 PM, Ondrej Zajicek wrote: On Tue, Nov 03, 2009 at 11:38:18AM +0200, Avi Kivity wrote: On 11/03/2009 01:25 PM, Vincent Hanquez wrote: not sure if i'm missing the point here, but couldn't it be hypothetically extended to stuff 3d (or video& more 2d accel ?) command

Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Avi Kivity
On 11/03/2009 05:14 PM, Anthony Liguori wrote: Avi Kivity wrote: On 11/03/2009 10:26 AM, Alexander Graf wrote: Exactly. In fact, I'm even scared to reboot mine because I might end up in a 3270 terminal. The whole text only crap keeps people from using this platform! And that's what I want to c

Re: CPU change causes hanging of .NET apps

2009-11-03 Thread Avi Kivity
On 11/03/2009 05:11 PM, Timur Safin wrote: My totally noob in QEMU guess - my bet it's CR4.OSFXSR which is controlled by presence of cpuid.1.edx[24] - FXSR bit (FXSAVE and FXRSTOR) instructions. That would affect floating point as well. I'm curious - is there any way in QEMU to redefine

RE: vhost-net patches

2009-11-03 Thread Shirley Ma
Hello Xiaohui, On Tue, 2009-11-03 at 09:06 +0800, Xin, Xiaohui wrote: > Hi, Michael, > What's your deferring skb allocation patch mentioned here, may you > elaborate it a little more detailed? That's my patch. It was submitted a few month ago. Here is the link to this RFC patch: http://www.mail-a

Re: [RFC] allow userspace to set MSR no-ops

2009-11-03 Thread Marcelo Tosatti
On Wed, Oct 28, 2009 at 01:23:07PM -0400, David Windsor wrote: > Hi, > > I've encountered a situation in which I would like to allow userspace > to set the MSRs which KVM should not emulate and instead implement > these as no-ops. > > I have not seen any work in this space, furthermore there is a

Re: [Linux-fbdev-devel] [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Ondrej Zajicek
On Tue, Nov 03, 2009 at 11:38:18AM +0200, Avi Kivity wrote: > On 11/03/2009 01:25 PM, Vincent Hanquez wrote: > > not sure if i'm missing the point here, but couldn't it be hypothetically > > extended to stuff 3d (or video& more 2d accel ?) commands too ? I can't > > imagine the cirrus or stdvga dr

Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Anthony Liguori
Avi Kivity wrote: On 11/03/2009 10:26 AM, Alexander Graf wrote: Exactly. In fact, I'm even scared to reboot mine because I might end up in a 3270 terminal. The whole text only crap keeps people from using this platform! And that's what I want to change here. Ok. I oppose paravirtualization f

Re: CPU change causes hanging of .NET apps

2009-11-03 Thread Timur Safin
2009/11/3 Avi Kivity : > On 11/03/2009 04:56 PM, Erik Rull wrote: >> >> I took all flags, same effect as without all of these flags.  :( >> >> Any other idea? > > It's probably the cache size query. > > Does -cpu host work? > My totally noob in QEMU guess - my bet it's CR4.OSFXSR which is controll

Re: CPU change causes hanging of .NET apps

2009-11-03 Thread Avi Kivity
On 11/03/2009 04:56 PM, Erik Rull wrote: I took all flags, same effect as without all of these flags. :( Any other idea? It's probably the cache size query. Does -cpu host work? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: CPU change causes hanging of .NET apps

2009-11-03 Thread Erik Rull
Avi Kivity wrote: On 11/02/2009 01:45 AM, Erik Rull wrote: Hi Avi, Please don't top-post. the Host CPU is a Intel Core2Duo - VT capable and enabled! The problem is that one of the flags that -cpu core2duo enables is implemented incorrectly, so it leads to .net breakage. These flags are

Re: 2.6.31.4 panic: CRED: put_cred_rcu() sees ffff880204e58c00 with usage 82150912

2009-11-03 Thread Marcelo Tosatti
On Fri, Oct 30, 2009 at 12:15:34PM +0100, Nikola Ciprich wrote: > Ouch, typo in subject, it's 2.6.31.1 of course. sorry about that. > also CCing kvm. > n. > > On Fri, Oct 30, 2009 at 12:06:32PM +0100, Nikola Ciprich wrote: > > Hi, > > some time ago, I updated my KVM hosting machine to 2.6.31.1 and

Re: [PATCH 03/11] Handle asynchronous page fault in a PV guest.

2009-11-03 Thread Avi Kivity
On 11/03/2009 04:32 PM, Marcelo Tosatti wrote: Any attempt to access the swapped out data will cause a #PF vmexit, since the translation is marked as not present. If there's swapin in progress, you wait for that swapin, otherwise start swapin and wait. Its not as efficient as paravirt because yo

Re: [PATCH 03/11] Handle asynchronous page fault in a PV guest.

2009-11-03 Thread Marcelo Tosatti
On Tue, Nov 03, 2009 at 04:25:33PM +0200, Gleb Natapov wrote: > On Tue, Nov 03, 2009 at 12:14:23PM -0200, Marcelo Tosatti wrote: > > On Sun, Nov 01, 2009 at 01:56:22PM +0200, Gleb Natapov wrote: > > > Asynchronous page fault notifies vcpu that page it is trying to access > > > is swapped out by a h

Re: [PATCH 03/11] Handle asynchronous page fault in a PV guest.

2009-11-03 Thread Gleb Natapov
On Tue, Nov 03, 2009 at 12:14:23PM -0200, Marcelo Tosatti wrote: > On Sun, Nov 01, 2009 at 01:56:22PM +0200, Gleb Natapov wrote: > > Asynchronous page fault notifies vcpu that page it is trying to access > > is swapped out by a host. In response guest puts a task that caused the > > fault to sleep

Re: [PATCH 03/11] Handle asynchronous page fault in a PV guest.

2009-11-03 Thread Marcelo Tosatti
On Sun, Nov 01, 2009 at 01:56:22PM +0200, Gleb Natapov wrote: > Asynchronous page fault notifies vcpu that page it is trying to access > is swapped out by a host. In response guest puts a task that caused the > fault to sleep until page is swapped in again. When missing page is > brought back into

Re: [PATCH] tests: The order of the fields are in reverse one isr stack.

2009-11-03 Thread Marcelo Tosatti
Applied both, thanks. On Thu, Oct 29, 2009 at 11:12:57AM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > diff --git a/kvm/user/test/x86/apic.c b/kvm/user/test/x86/apic.c > index 4e89c77..b6718ec 100644 > --- a/kvm/user/test/x86/apic.c > +++ b/kvm/user/test/x86/apic.c -- To unsubscri

Re: [PATCH] KVM: x86: Polish exception injection via KVM_SET_GUEST_DEBUG

2009-11-03 Thread Marcelo Tosatti
On Fri, Oct 30, 2009 at 12:46:59PM +0100, Jan Kiszka wrote: > Decouple KVM_GUESTDBG_INJECT_DB and KVM_GUESTDBG_INJECT_BP from > KVM_GUESTDBG_ENABLE, their are actually orthogonal. At this chance, > avoid triggering the WARN_ON in kvm_queue_exception if there is already > an exception pending and re

Re: [PATCH] KVM: x86: Fix KVM_GET_CLOCK

2009-11-03 Thread Marcelo Tosatti
On Tue, Nov 03, 2009 at 12:49:05PM +0100, Jan Kiszka wrote: > The flags field of kvm_clock_data is supposed to indicate the > availability of additional fields one day. There are none yet, so clear > it. Moreover, drop the bogus check of this field and return 0 on > success. > > Signed-off-by: Jan

KVM Live Migration

2009-11-03 Thread Gilberto Nunes Ferreira
hi all Is this my first post... I sucess migrate a VM with this command: (on kvm-0 ) r...@kvm-0:~# virsh list --all Connecting to uri: qemu:///system Id Name State -- 1 win2003 running r...@kvm-0:~:# visrh migrate --live win2003 qem

Re: [PATCHv6 1/3] tun: export underlying socket

2009-11-03 Thread Arnd Bergmann
On Tuesday 03 November 2009, Michael S. Tsirkin wrote: > > What was your reason for changing? > > It turns out socket structure is really bound to specific a file, so we > can not have 2 files referencing the same socket. Instead, as I say > above, it's possible to make sendmsg/recvmsg work on ta

Re: [PATCHv6 1/3] tun: export underlying socket

2009-11-03 Thread Michael S. Tsirkin
On Tue, Nov 03, 2009 at 01:12:33PM +0100, Arnd Bergmann wrote: > On Monday 02 November 2009, Michael S. Tsirkin wrote: > > Tun device looks similar to a packet socket > > in that both pass complete frames from/to userspace. > > > > This patch fills in enough fields in the socket underlying tun dri

Re: [KVM-AUTOTEST][PATCH] Fix kvm_config.py -f mode

2009-11-03 Thread Lucas Meneghel Rodrigues
Ooops, fixed. Thanks Ryan! On Mon, Nov 2, 2009 at 9:28 PM, Ryan Harper wrote: > kvm_config.py supports specifying a different filename for > test config.  This patch fixes the option parsing parameters. > Currently it uses 'store_true' which stores the value True into > the filename variable; we

Re: [PATCHv6 1/3] tun: export underlying socket

2009-11-03 Thread Arnd Bergmann
On Monday 02 November 2009, Michael S. Tsirkin wrote: > Tun device looks similar to a packet socket > in that both pass complete frames from/to userspace. > > This patch fills in enough fields in the socket underlying tun driver > to support sendmsg/recvmsg operations, and message flags > MSG_TRUN

Re: [PATCHv6 3/3] vhost_net: a kernel-level virtio server

2009-11-03 Thread Michael S. Tsirkin
On Mon, Nov 02, 2009 at 04:05:58PM -0800, Daniel Walker wrote: > > Random style issues below .. Part of this is just stuff checkpatch > found. Thanks very much, I'll fix these. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org

[PATCH] KVM: x86: Fix KVM_GET_CLOCK

2009-11-03 Thread Jan Kiszka
The flags field of kvm_clock_data is supposed to indicate the availability of additional fields one day. There are none yet, so clear it. Moreover, drop the bogus check of this field and return 0 on success. Signed-off-by: Jan Kiszka --- Note: This replaces "Clear flags field on return from KVM_

Re: [PATCHv4 0/6] qemu-kvm: vhost net support

2009-11-03 Thread Michael S. Tsirkin
On Mon, Nov 02, 2009 at 04:58:39PM -0600, Anthony Liguori wrote: > Hi Michael, > > I'll reserve individual patch review until they're in a mergable state, > but I do have some comments about the overall integration architecture. > > Generally speaking, I think the integration unnecessarily invasi

Re: error while loading state for instance 0x0 of device 'kvmclock'

2009-11-03 Thread Glauber Costa
On Mon, Nov 02, 2009 at 04:37:15PM +0100, Jan Kiszka wrote: > Avi Kivity wrote: > > On 11/02/2009 12:28 PM, Jan Kiszka wrote: > >> Jan Kiszka wrote: > >> > >>> Hi, > >>> > >>> current qemu-kvm.git gives me the message "qemu: warning: error while > >>> loading state for instance 0x0 of device 'k

Re: [PATCH] KVM: x86: Clear flags field on return from KVM_GET_CLOCK

2009-11-03 Thread Glauber Costa
On Mon, Nov 02, 2009 at 04:41:54PM +0100, Jan Kiszka wrote: > This field is supposed to indicate the availability of additional fields > one day. There are none yet, so clear it - and drop the bogus check, > too. > > Signed-off-by: Jan Kiszka Makes sense. Acked-by: Glauber Costa -- To unsubsc

Re: [PATCHv4 1/6] qemu/virtio: move features to an inline function

2009-11-03 Thread Michael S. Tsirkin
On Mon, Nov 02, 2009 at 04:33:53PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> devices should have the final say over which virtio features they >> support. E.g. indirect entries may or may not make sense in the context >> of virtio-console. In particular, for vhost, we do not want

Re: [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Vincent Hanquez
On Tue, Nov 03, 2009 at 07:39:34AM +0100, Alexander Graf wrote: > > On 03.11.2009, at 07:34, Avi Kivity wrote: > >> On 11/03/2009 08:27 AM, Alexander Graf wrote: >>> How does it work today? >>> >>> You boot into a TERM=dumb line based emulation on 3270 (worst thing >>> haunting people's nigh

Re: [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Avi Kivity
On 11/03/2009 01:25 PM, Vincent Hanquez wrote: not sure if i'm missing the point here, but couldn't it be hypothetically extended to stuff 3d (or video& more 2d accel ?) commands too ? I can't imagine the cirrus or stdvga driver be able to do that ever ;) cirrus has pretty good 2d accelera

Re: [PATCH 14/27] Add book3s_64 specific opcode emulation

2009-11-03 Thread Alexander Graf
On 03.11.2009, at 09:47, Segher Boessenkool wrote: Nice patchset. Some comments on the emulation part: Cool, thanks for looking though them! +#define OP_31_XOP_EIOIO854 You mean EIEIO. Probably, yeah. + case 19: + switch (get_xop(inst)) { +

Re: [PATCH 0/9] S390x KVM support

2009-11-03 Thread Avi Kivity
On 11/02/2009 10:23 PM, Alexander Graf wrote: Any progress on the patch? This is really important to make KVM work properly on S390. I'd even go as far as suggesting it for linux-stable. I forgot all about it, sorry. Marcelo, can you commit it? -- error compiling committee.c: too many ar

Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Avi Kivity
On 11/03/2009 10:26 AM, Alexander Graf wrote: Exactly. In fact, I'm even scared to reboot mine because I might end up in a 3270 terminal. The whole text only crap keeps people from using this platform! And that's what I want to change here. Ok. I oppose paravirtualization for its own sake and

Re: [PATCH 14/27] Add book3s_64 specific opcode emulation

2009-11-03 Thread Segher Boessenkool
Nice patchset. Some comments on the emulation part: +#define OP_31_XOP_EIOIO854 You mean EIEIO. + case 19: + switch (get_xop(inst)) { + case OP_19_XOP_RFID: + case OP_19_XOP_RFI: + vcpu->arch.pc = vcpu->ar

Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Alexander Graf
On 03.11.2009, at 09:20, Avi Kivity wrote: On 11/03/2009 09:50 AM, Alexander Graf wrote: Ok, imagine this was not this unloved S390 odd architecture but X86. The only output choices you have are: 1) virtio-console 2) VNC / SSH over network 3) virtio-fb Now you want to configure a server,

Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-03 Thread Avi Kivity
On 11/03/2009 09:50 AM, Alexander Graf wrote: Ok, imagine this was not this unloved S390 odd architecture but X86. The only output choices you have are: 1) virtio-console 2) VNC / SSH over network 3) virtio-fb Now you want to configure a server, probably using yast and all those nice graphi