Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 09:34:25 +0200 > Implicitly, I guess. He said "if there's an issue Michael Tsirkin is the > best person to resolve it", this was wrt merging his virtio&lguest tree. > He didn't mention vhost, I wrote all of vhost though, there shouldn't be > an is

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2010 at 11:04:28PM -0800, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 24 Feb 2010 07:37:37 +0200 > > > Dave, so while Rusty's on vacation, what's the best way to get vhost > > infrastructure fixes in? Are you ok with getting pull requests and > > merging them int

RE: How to disable KVM start at boot

2010-02-23 Thread Hao, Xudong
chkconfig --level 35 kvm off sati...@pacific.net.hk wrote: > Hi folks, > > Host - Fedora 12 64bit > > I need to start KVM manually after booting Fedora. Please advise how > to disable KVM start at booting. TIA > > B.R. > Stephen L Thanks, Xudong-- To unsubscribe from this list: send the line

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 24 Feb 2010 07:37:37 +0200 > Dave, so while Rusty's on vacation, what's the best way to get vhost > infrastructure fixes in? Are you ok with getting pull requests and > merging them into net-next? That should keep the clutter in your inbox > to the minimum.

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2010 at 02:42:35PM -0800, David Miller wrote: > > Just for the record I'm generally not interested in vhost > patches. > > If it's a specific network one that will be merged via > the networking tree, yes please CC: me. > > But if it's a bunch of changes to vhost.c and other piec

How to disable KVM start at boot

2010-02-23 Thread satimis
Hi folks, Host - Fedora 12 64bit I need to start KVM manually after booting Fedora. Please advise how to disable KVM start at booting. TIA B.R. Stephen L -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [Autotest] [PATCH] KVM test: Add support for ipv6 addresses

2010-02-23 Thread Lucas Meneghel Rodrigues
H i Yogi, I have read and rebased your patch against current trunk. I have one doubt: I noticed that the tcpdump command you use to monitor traffic is basically all traffic that goes to network routers /usr/sbin/tcpdump -npv ip6 -i any 'dst net ff02::2' However, the IPv4 implementation filters th

[PATCH] KVM test: Add support for ipv6 addresses

2010-02-23 Thread Lucas Meneghel Rodrigues
This patch enables ipv6 address support in kvm-autotest. The patch adds a new dictionary called "address6_cache" for ip6 address. Tcpdump is used to create this cache of link-local ipv6 address. Link-local ipv6 address is used because it eliminates to need to create complex configuration on both

[PATCH] KVM test: Adding KSM overcommit test

2010-02-23 Thread Lucas Meneghel Rodrigues
This is an implementation of KSM testing. The basic idea behind the test is to start guests, copy the script allocator.py to them. Once executed, the process accepts input commands on its main loop. The script will allow to fill up memory pages of the guests, according to patterns, this way it's

Re: [Autotest][PATCH] KVM Test: Add check_image script as post_command script of qcow2 variant.-V2

2010-02-23 Thread Lucas Meneghel Rodrigues
Hi Feng, I've tested your patch, and have some additional comments to make: On Mon, Feb 22, 2010 at 6:30 AM, Feng Yang wrote: > Signed-off-by: Feng Yang > --- >  client/tests/kvm/scripts/check_image.py |   85 > +++ >  client/tests/kvm/tests_base.cfg.sample  |    4 ++

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Ryan Harper
* Aurelien Jarno [2010-02-23 11:37]: > Ryan Harper a écrit : > > Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize. > > This patch adds a simple check and error message (much like the 2047 limit > > on > > 32-bit hosts) on ram_size in the control path after we determine

PCI Device Assignment without VT-d?

2010-02-23 Thread Erik Rull
Hi all, I've "only" a core2duo with VT, is it somehow possible to use the PCI device assignment without VT-d? That would be great because I cannot upgrade the Mainboard for my system. If yes, what other prerequisites must be fulfilled? Thanks! Best regards, Erik -- To unsubscribe from this

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
Just for the record I'm generally not interested in vhost patches. If it's a specific network one that will be merged via the networking tree, yes please CC: me. But if it's a bunch of changes to vhost.c and other pieces of infrastructure, feel free to leave me out of it. It just clutters my al

Re: [patch] x86: kvm: Convert i8254/i8259 locks to raw_spinlocks

2010-02-23 Thread Thomas Gleixner
On Tue, 23 Feb 2010, Jan Kiszka wrote: > Thomas Gleixner wrote: > > The i8254/i8259 locks need to be real spinlocks on preempt-rt. Convert > > them to raw_spinlock. No change for !RT kernels. > > Doesn't fly for -rt anymore: pic_irq_update runs under this raw lock and > calls kvm_vcpu_kick which

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Aurelien Jarno
On Tue, Feb 23, 2010 at 03:07:20PM -0600, Anthony Liguori wrote: > On 02/23/2010 02:30 PM, Alexander Graf wrote: > >On 23.02.2010, at 18:02, Aurelien Jarno wrote: > > > >>Ryan Harper a écrit : > >>>Currently, x86_64-softmmu qemu segfaults when trying to use> 4095M > >>>memsize. > >>>This patch ad

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Anthony Liguori
On 02/23/2010 02:30 PM, Alexander Graf wrote: On 23.02.2010, at 18:02, Aurelien Jarno wrote: Ryan Harper a écrit : Currently, x86_64-softmmu qemu segfaults when trying to use> 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts)

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Alexander Graf
On 23.02.2010, at 18:02, Aurelien Jarno wrote: > Ryan Harper a écrit : >> Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize. >> This patch adds a simple check and error message (much like the 2047 limit on >> 32-bit hosts) on ram_size in the control path after we determi

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > get_user_pages_fast returns number of pages on success, negative value > on failure, but never 0. Fix vhost code to match this logic. It can return 0 if you ask for 0 pages :) >From the comment: * Returns number of pages pinned. This may be fewer than the number *

Re: [PATCH 2/3] vhost: initialize log eventfd context pointer

2010-02-23 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > vq log eventfd context pointer needs to be initialized, otherwise > operation may fail or oops if log is enabled but log eventfd not set by > userspace. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Juan Quintela When log_ctx for device is created, it is copi

Re: [PATCH 1/3] vhost: logging math fix

2010-02-23 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > vhost was dong some complex math to get > offset to log at, and got it wrong by a couple of bytes, > while in fact it's simple: get address where we write, > subtract start of buffer, add log base. > > Do it this way. > > Signed-off-by: Michael S. Tsirkin Reviewed-b

Re: [patch] x86: kvm: Convert i8254/i8259 locks to raw_spinlocks

2010-02-23 Thread Jan Kiszka
Thomas Gleixner wrote: > The i8254/i8259 locks need to be real spinlocks on preempt-rt. Convert > them to raw_spinlock. No change for !RT kernels. Doesn't fly for -rt anymore: pic_irq_update runs under this raw lock and calls kvm_vcpu_kick which tries to wake_up some thread -> scheduling while ato

Re: KSM not working on 2.6.28.7 and qemu-kvm 0.12.2 ?

2010-02-23 Thread Gilles PIETRI
Le 22/02/2010 22:02, Gilles PIETRI a écrit : Le 22/02/2010 06:40, Nikola Ciprich a écrit : Hi Gilles, maybe You have the same problem I experienced? see http://www.mail-archive.com/kvm@vger.kernel.org/msg28572.html nik Hi, The linux headers do include the MADV_MERGEABLE settings, and the lib

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 07:39:08PM +0200, Michael S. Tsirkin wrote: > On Tue, Feb 23, 2010 at 07:39:52PM +0200, Gleb Natapov wrote: > > On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote: > > > > On Tue, Feb 23, 201

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2010 at 07:39:52PM +0200, Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote: > > > On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote: > > > > get_user_pages_fast

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote: > On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote: > > On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote: > > > get_user_pages_fast returns number of pages on success, negative value > > > on failure,

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote: > > get_user_pages_fast returns number of pages on success, negative value > > on failure, but never 0. Fix vhost code to match this logic. > > > > Signed-off-by: Mic

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote: > get_user_pages_fast returns number of pages on success, negative value > on failure, but never 0. Fix vhost code to match this logic. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c |3 ++- > 1 files ch

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Aurelien Jarno
Ryan Harper a écrit : > Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize. > This patch adds a simple check and error message (much like the 2047 limit on > 32-bit hosts) on ram_size in the control path after we determine we're > not using kvm > > Upstream qemu-kvm is aff

[PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread Michael S. Tsirkin
get_user_pages_fast returns number of pages on success, negative value on failure, but never 0. Fix vhost code to match this logic. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/vhost/vhost.c b/drive

[PATCH 2/3] vhost: initialize log eventfd context pointer

2010-02-23 Thread Michael S. Tsirkin
vq log eventfd context pointer needs to be initialized, otherwise operation may fail or oops if log is enabled but log eventfd not set by userspace. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/vhost/

[PATCH 1/3] vhost: logging math fix

2010-02-23 Thread Michael S. Tsirkin
vhost was dong some complex math to get offset to log at, and got it wrong by a couple of bytes, while in fact it's simple: get address where we write, subtract start of buffer, add log base. Do it this way. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 10 ++ 1 files

[PATCH 0/3] vhost: logging fixes

2010-02-23 Thread Michael S. Tsirkin
The following patches on top of net-next fix issues related to write logging in vhost. This fixes all known to me logging issues, migration now works for me while under stress in both TX and RX directions. Rusty's going on vacation, I am guessing he won't have time to review this: Gleb, Juan, Herbe

[PATCH v2 5/7] KVM: x86: Add KVM_CAP_X86_ROBUST_SINGLESTEP

2010-02-23 Thread Jan Kiszka
This marks the guest single-step API improvement of 94fe45da and 91586a3b with a capability flag to allow reliable detection by user space. Signed-off-by: Jan Kiszka --- arch/x86/kvm/x86.c |1 + include/linux/kvm.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arc

[PATCH v2 7/7] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Jan Kiszka
Call directly into the vendor services for getting/setting rflags in emulate_instruction to ensure injected TF survives the emulation. Signed-off-by: Jan Kiszka --- arch/x86/kvm/x86.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x8

[PATCH v2 6/7] KVM: x86: Drop RF manipulation for guest single-stepping

2010-02-23 Thread Jan Kiszka
RF is not required for injecting TF as the latter will trigger only after an instruction execution anyway. So do not touch RF when arming or disarming guest single-step mode. Signed-off-by: Jan Kiszka --- arch/x86/kvm/x86.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v2 4/7] KVM: SVM: Emulate nRIP feature when reinjecting INT3

2010-02-23 Thread Jan Kiszka
When in guest debugging mode, we have to reinject those #BP software exceptions that are caused by guest-injected INT3. As older AMD processors do not support the required nRIP VMCB field, try to emulate it by moving RIP past the instruction on exception injection. Fix it up again in case the injec

[PATCH v2 1/7] KVM: VMX: Update instruction length on intercepted BP

2010-02-23 Thread Jan Kiszka
We intercept #BP while in guest debugging mode. As VM exits due to intercepted exceptions do not necessarily come with valid idt_vectoring, we have to update event_exit_inst_len explicitly in such cases. At least in the absence of migration, this ensures that re-injections of #BP will find and use

[PATCH v2 2/7] KVM: SVM: Move svm_queue_exception

2010-02-23 Thread Jan Kiszka
Move svm_queue_exception past skip_emulated_instruction to allow calling it later on. Signed-off-by: Jan Kiszka --- arch/x86/kvm/svm.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 1d76899

[PATCH v2 3/7] KVM: x86: Add kvm_is_linear_rip

2010-02-23 Thread Jan Kiszka
Based on Gleb's suggestion: Add a helper kvm_is_linear_rip that matches a given linear RIP against the current one. Use this for guest single-stepping, more users will follow. Signed-off-by: Jan Kiszka --- arch/x86/include/asm/kvm_host.h |4 +++- arch/x86/kvm/x86.c | 21 ++

[PATCH v2 0/7] KVM: Enhancements and fixes around guest debugging

2010-02-23 Thread Jan Kiszka
Changes in v2: - Retreat TF emulation patch, waiting for emulator rework - Spilt out svm_queue_exception moving - Factor out kvm_is_linear_rip ("Saved linear RIP == current RIP?") - Fixed breakage in INT3 emulation code and addressed review comments Patch 5 targets also 2.6.33., patch 1 should

[PATCH] Fix segfault with ram_size > 4095M without kvm

2010-02-23 Thread Ryan Harper
Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts) on ram_size in the control path after we determine we're not using kvm Upstream qemu-kvm is affected if using the -no-kvm option;

[PATCH 0/1] kvm stable updates for qemu 0.12.3

2010-02-23 Thread Avi Kivity
Just one patch, fixing eflags corruption. Also available from git: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/stable-0.12 Please pull. Jan Kiszka (1): kvm: Fix eflags corruption in kvm mode cpu-exec.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) -- To

[PATCH 1/1] kvm: Fix eflags corruption in kvm mode

2010-02-23 Thread Avi Kivity
From: Jan Kiszka This should explain a lot of the weird breakages of upstream KVM we've seen recently (actually we should have seen it much earlier): Stop translating eflags into TCG format when in kvm mode as we never translate it back and rather sync this broken state into the kernel. Signed-

[PATCH][uq/master] KVM: Rework of guest debug state writing

2010-02-23 Thread Jan Kiszka
So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a tribute to a deficit in x86 kernels before KVM_CAP_X86_ROBUST_SINGLESTEP. But as this is an arch-dependent issue, it is better handle in the x86 part of KVM and remove the writeback po

[PATCH] qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness

2010-02-23 Thread Jan Kiszka
This add-on patch to recent guest debugging refactorings adds the requested awareness for KVM_CAP_X86_ROBUST_SINGLESTEP to both the upstream as well as qemu-kvm's own code. Fortunately, code sharing increased once again. Signed-off-by: Jan Kiszka --- Note: Due to missing VCPU events synchronizat

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 01:41:44PM +0200, Avi Kivity wrote: > On 02/23/2010 01:30 PM, Jan Kiszka wrote: > >> > >>How to detect that emulation is complete? emulate_instruction() should > >>return EMULATE_DONE in this case. > >...*and* RIP moved forward. > > A branch or rep instruction can successfu

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Jan Kiszka
Avi Kivity wrote: > On 02/23/2010 01:30 PM, Jan Kiszka wrote: >>> How to detect that emulation is complete? emulate_instruction() should >>> return EMULATE_DONE in this case. >>> >> ...*and* RIP moved forward. >> > > A branch or rep instruction can successfully execute and not change rip

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 12:30:27PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Tue, Feb 23, 2010 at 11:37:21AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Feb 22, 2010 at 06:

Re: [PATCH] KVM-Test: Add private bridge to use for communication

2010-02-23 Thread Lucas Meneghel Rodrigues
On Tue, 2010-02-23 at 16:56 +0800, sshang wrote: > Add private bridge to use for communication between host and guest. >Config of parameter: >bridge = private >private_bridge_name = private(default) >private_bridge_addr = 192.168.0.1(default) >private_bridge_mask

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Avi Kivity
On 02/23/2010 01:30 PM, Jan Kiszka wrote: How to detect that emulation is complete? emulate_instruction() should return EMULATE_DONE in this case. ...*and* RIP moved forward. A branch or rep instruction can successfully execute and not change rip. Btw, do we expect a #DB on every i

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 11:37:21AM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: > On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: >> Support both guest- as well as h

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Avi Kivity
On 02/23/2010 01:00 PM, Gleb Natapov wrote: They will not trigger before that. They will be queued for the next entry and queuing another one will either overwrite the previous one, or will queue double fault (depending on what what the first exception). The will not stack as the instru

Re: [PATCH 5/6] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 11:40:56AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Tue, Feb 23, 2010 at 11:13:13AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Mon, Feb 22, 2010 at 06:51:22PM +0100, Jan Kiszka wrote: > Call directly into the vendor services for getting/sett

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 11:37:21AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: > Support both guest- as well as host-owned EFLAGS.TF whi

Re: [PATCH 5/6] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 11:13:13AM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Mon, Feb 22, 2010 at 06:51:22PM +0100, Jan Kiszka wrote: Call directly into the vendor services for getting/setting rflags in emulate_instruction to ensure injected TF survives

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Avi Kivity
On 02/23/2010 12:32 PM, Gleb Natapov wrote: Emulator currently is a total mess. It is not a good time to add more mess there right now IMO. Then let's clean up what you consider "mess" in this feature. Unless there are plans to clean up the emulator for the next or next-but-one kern

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: Support both guest- as well as host-owned EFLAGS.TF while emulating instructions. For guest-owned TF, we simply inject D

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 12:29:25PM +0200, Avi Kivity wrote: > On 02/23/2010 12:26 PM, Gleb Natapov wrote: > >On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: > >>Gleb Natapov wrote: > >>>On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: > Support both guest- as well as host

Re: [PATCH 5/6] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 11:13:13AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Feb 22, 2010 at 06:51:22PM +0100, Jan Kiszka wrote: > >> Call directly into the vendor services for getting/setting rflags in > >> emulate_instruction to ensure injected TF survives the emulation. > >> > >

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Avi Kivity
On 02/23/2010 12:26 PM, Gleb Natapov wrote: On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: Support both guest- as well as host-owned EFLAGS.TF while emulating instructions. For guest-

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: > >> Support both guest- as well as host-owned EFLAGS.TF while emulating > >> instructions. For guest-owned TF, we simply inject DB and update DR6.BS > >

Re: [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3

2010-02-23 Thread Avi Kivity
On 02/23/2010 12:17 PM, Jan Kiszka wrote: Why have you moved svm_queue_exception() function? To avoid adding a prototype. It's often better to do this in a separate patch: the changelog answers the question above, and the following patch is smaller. -- error compiling committee.

Re: [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, Feb 22, 2010 at 06:51:19PM +0100, Jan Kiszka wrote: >> When in guest debugging mode, we have to reinject those #BP software >> exceptions that are caused by guest-injected INT3. As older AMD >> processors to not support the required nRIP VMCB field, try to emulate >> i

Re: [PATCH 5/6] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, Feb 22, 2010 at 06:51:22PM +0100, Jan Kiszka wrote: >> Call directly into the vendor services for getting/setting rflags in >> emulate_instruction to ensure injected TF survives the emulation. >> >> Signed-off-by: Jan Kiszka >> --- >> arch/x86/kvm/x86.c |4 ++-- >

Re: [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3

2010-02-23 Thread Gleb Natapov
On Mon, Feb 22, 2010 at 06:51:19PM +0100, Jan Kiszka wrote: > When in guest debugging mode, we have to reinject those #BP software > exceptions that are caused by guest-injected INT3. As older AMD > processors to not support the required nRIP VMCB field, try to emulate > it by moving RIP by one on

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: >> Support both guest- as well as host-owned EFLAGS.TF while emulating >> instructions. For guest-owned TF, we simply inject DB and update DR6.BS >> after completing an instruction that has TF set on entry. To support

Re: [PATCH 5/6] KVM: x86: Preserve injected TF across emulation

2010-02-23 Thread Gleb Natapov
On Mon, Feb 22, 2010 at 06:51:22PM +0100, Jan Kiszka wrote: > Call directly into the vendor services for getting/setting rflags in > emulate_instruction to ensure injected TF survives the emulation. > > Signed-off-by: Jan Kiszka > --- > arch/x86/kvm/x86.c |4 ++-- > 1 files changed, 2 insert

Re: [PATCH 6/6] KVM: x86: Emulator support for TF

2010-02-23 Thread Gleb Natapov
On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: > Support both guest- as well as host-owned EFLAGS.TF while emulating > instructions. For guest-owned TF, we simply inject DB and update DR6.BS > after completing an instruction that has TF set on entry. To support > guest single-stepping

Re: [PATCH 1/2] qemu-kvm: extboot: Keep variables in RAM

2010-02-23 Thread Stefan Hajnoczi
On Mon, Feb 22, 2010 at 7:42 PM, H. Peter Anvin wrote: > Typically a disk device would use a BCV, not a BEV. Laurent Vivier's virtio-blk patchset has BCV support. It is not yet merged into gPXE: http://markmail.org/message/oq2et3t3kzjzts7i Stefan -- To unsubscribe from this list: send the line

[PATCH] KVM-Test: Add private bridge to use for communication

2010-02-23 Thread sshang
Add private bridge to use for communication between host and guest. Config of parameter: bridge = private private_bridge_name = private(default) private_bridge_addr = 192.168.0.1(default) private_bridge_mask = 255.255.255.0(default) pre_command = scripts/pri