Re: qemu fail to parse command line with "-pcidevice 00:19.0"

2010-06-24 Thread Hidetoshi Seto
(2010/06/24 15:08), Markus Armbruster wrote: > Note to qemu-devel: this issue is qemu-kvm only. > > "Hao, Xudong" writes: > >> When assign one PCI device, qemu fail to parse the command line: >> qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 >> Error: >> qemu-system-x86

RE: qemu fail to parse command line with "-pcidevice 00:19.0"

2010-06-24 Thread Hao, Xudong
Thanks, Mark. -Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: 2010年6月25日 12:58 To: Hao, Xudong Cc: qemu-de...@nongnu.org; aligu...@us.ibm.com; kvm@vger.kernel.org Subject: Re: qemu fail to parse command line with "-pcidevice 00:19.0" "Hao, Xudong" writes: >

Re: [RFC] virtio: Support releasing lock during kick

2010-06-24 Thread Stefan Hajnoczi
On Fri, Jun 25, 2010 at 4:09 AM, Rusty Russell wrote: > On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote: >> On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori >> wrote: >> > Shouldn't it be possible to just drop the lock before invoking >> > virtqueue_kick() and reacquire it afterwards?  Th

Re: qemu fail to parse command line with "-pcidevice 00:19.0"

2010-06-24 Thread Markus Armbruster
"Hao, Xudong" writes: >>Work-around: -device pci-assign,host=00:19.1 > OK, this new way can work when create guest with static assignment. > But how to hot add a pci device to guest? the old hot add command "pci_add > pci_addr=auto host host=00:19.0" has the same parse error. Command line's -de

Re: [RFC] virtio: Support releasing lock during kick

2010-06-24 Thread Rusty Russell
On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote: > On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori > wrote: > > Shouldn't it be possible to just drop the lock before invoking > > virtqueue_kick() and reacquire it afterwards? There's nothing in that > > virtqueue_kick() path that the lock

Re: [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices

2010-06-24 Thread Rusty Russell
On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote: > Using Rusty's suggestion I've respun the patch removing the special copy > function. I've tested this patch in a guest kernel with and without qemu > supplying serial numbers for the block devices and it's working as expected. > When qemu suppli

RE: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-24 Thread Xin, Xiaohui
Herbert, That's why I have sent you the patch for guest virtio-net driver. I reserved 512 bytes in each page, then I can always have the space to copy and avoid the backend memory used up issue. Thanks Xiaohui >-Original Message- >From: Herbert Xu [mailto:herb...@gondor.apana.org.au] >S

RE: qemu fail to parse command line with "-pcidevice 00:19.0"

2010-06-24 Thread Hao, Xudong
>Work-around: -device pci-assign,host=00:19.1 OK, this new way can work when create guest with static assignment. But how to hot add a pci device to guest? the old hot add command "pci_add pci_addr=auto host host=00:19.0" has the same parse error. BTW: if we use add "-net none" in qemu command, g

Handling page faults in KVM

2010-06-24 Thread Khaled Ibrahim
Apparently, not all page faults on the guest result in a page fault in the host. I would like to intercept page faults on the guest that are not handled by the host. I am not quite sure where (in the source code) can I monitor that? Can any one give me code pointers to look at?

RE: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-24 Thread Dong, Eddie
Herbert Xu wrote: > On Wed, Jun 23, 2010 at 06:05:41PM +0800, Dong, Eddie wrote: >> >> I mean once the frontend side driver post the buffers to the backend >> driver, the backend driver will "immediately" use that buffers to >> compose skb or gro_frags and post them to the assigned host NIC >> dri

[PATCH] KVM test: Modify the build.git method to build and link unittests

2010-06-24 Thread Lucas Meneghel Rodrigues
If we have a certain file that has information about running unit tests, let's build the unittests on the build.git mode. This feature depends on a qemu-kvm patch that is still not upstream, but I am sending anyways so people can comment. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/

[PATCH 5/5] KVM test: Make it possible to run VMs without NICs

2010-06-24 Thread Lucas Meneghel Rodrigues
For unittesting, for example, is interesting that we run the VM with the bare mininum number of parameters. This fix allows that. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/kvm_vm.py |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/k

[PATCH 4/5] KVM test: add sample RHEL-6 style unittest config file

2010-06-24 Thread Lucas Meneghel Rodrigues
From: Michael Goldish Based on Naphtali Sprei's patches. Changes from v1: - Remove reference_output parameter Signed-off-by: Michael Goldish --- client/tests/kvm/unittests.cfg.sample | 56 + 1 files changed, 56 insertions(+), 0 deletions(-) create mode 10064

[PATCH 3/5] KVM test: add wrapper for RHEL-6 style unittests

2010-06-24 Thread Lucas Meneghel Rodrigues
From: Michael Goldish Based on Naphtali Sprei's patches. Changes from v2: - Determine dynamically what tests are available and what are the options for them, based on the unittest directory (that is supposed to be linked during the build test) Changes from v1: - Determine success/failure by exi

[PATCH 2/5] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests

2010-06-24 Thread Lucas Meneghel Rodrigues
Should be set to "yes" to enable testdev. Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 87b037f..7b1fc05 100755 --- a/client/tests/kvm/kvm_

[PATCH 1/5] KVM test: support kernel -append command line options

2010-06-24 Thread Lucas Meneghel Rodrigues
Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 966fb3c..87b037f 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -

[PATCH] qemu-kvm tests: Create make target for install tests

2010-06-24 Thread Lucas Meneghel Rodrigues
In order to make it convenient to run unit tests on KVM autotest, add rules to install the flat files to $(PREFIX)/share/qemu/tests. Also, add a unittests.cfg file, a simple .ini file that contains unittest definitions. The unittest definitions work like this: [unittest_name] file = foo.flat # Na

Re: [PATCH 3/3] vhost: apply cpumask and cgroup to vhost pollers

2010-06-24 Thread Sridhar Samudrala
On Thu, 2010-06-24 at 11:11 +0300, Michael S. Tsirkin wrote: > On Sun, May 30, 2010 at 10:25:01PM +0200, Tejun Heo wrote: > > Apply the cpumask and cgroup of the initializing task to the created > > vhost poller. > > > > Based on Sridhar Samudrala's patch. > > > > Cc: Michael S. Tsirkin > > Cc:

Re: Graphical virtualisation management system

2010-06-24 Thread Javier Guerra Giraldez
On Thu, Jun 24, 2010 at 1:32 PM, Freddie Cash wrote: >  * virt-manager which requires X and seems to be more desktop-oriented; don't know about the others, but virt-manager runs only on the admin station. on the VM hosts you run only libvirtd, which doesn't need X in fact, that's what you get w

Graphical virtualisation management system

2010-06-24 Thread Freddie Cash
What is everyone using to manage their virtualisation setup? Anyone using a pre-packaged management system like ConVirt, oVirt, Virt-Manager, etc? Everyone rolling their own management scripts? Something else? Right now, we're using our home-grown kvmctl script (as seen in the KVM wiki) to manag

[PATCHv2] make-release: fix mtime on rhel6 beta

2010-06-24 Thread Michael S. Tsirkin
With recent git versions (like one in rhel6 beta), git prints out tag info in addition to requested format, if passed a tag name. This breaks make-release. To get just the time as we want, we need to pass something that is not a tag name but matches same commit. $commit^{commit} does this. Signed

Re: [PATCH] make-release: fix mtime on rhel6 beta

2010-06-24 Thread Eduardo Habkost
On Thu, Jun 24, 2010 at 07:09:15PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 24, 2010 at 01:12:04PM -0300, Eduardo Habkost wrote: > > On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote: > > > With recent git versions (like one in rhel6 beta), > > > git prints out tag info in ad

Re: [PATCH] make-release: fix mtime on rhel6 beta

2010-06-24 Thread Michael S. Tsirkin
On Thu, Jun 24, 2010 at 01:12:04PM -0300, Eduardo Habkost wrote: > On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote: > > With recent git versions (like one in rhel6 beta), > > git prints out tag info in addition to > > requested format, if passed a tag name. > > This breaks make-r

Re: [PATCH] make-release: fix mtime on rhel6 beta

2010-06-24 Thread Eduardo Habkost
On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote: > With recent git versions (like one in rhel6 beta), > git prints out tag info in addition to > requested format, if passed a tag name. > This breaks make-release. > To get just the time as we want, we need to > pass something that

[PATCH] make-release: fix mtime on rhel6 beta

2010-06-24 Thread Michael S. Tsirkin
With recent git versions (like one in rhel6 beta), git prints out tag info in addition to requested format, if passed a tag name. This breaks make-release. To get just the time as we want, we need to pass something that is not a tag name but matches same commit. $commit~0 does this. Signed-off-by

Re: Slow vmalloc in 2.6.35-rc3

2010-06-24 Thread Nick Piggin
On Thu, Jun 24, 2010 at 12:19:32PM +0300, Avi Kivity wrote: > I see really slow vmalloc performance on 2.6.35-rc3: Can you try this patch? http://userweb.kernel.org/~akpm/mmotm/broken-out/mm-vmap-area-cache.patch > # tracer: function_graph > # > # CPU DURATION FUNCTION CALLS >

Re: [RFC v4][PATCH 0/3] Monitor support for Qemu tracing

2010-06-24 Thread Stefan Hajnoczi
On Thu, Jun 24, 2010 at 04:49:30PM +0530, Prerna Saxena wrote: > This set of patches enables trace visualization & control > via the QEMU monitor. It is based on trace infrastructure posted > upstream : > ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) > > This patchset ad

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-24 Thread Michael S. Tsirkin
On Thu, Jun 24, 2010 at 02:22:19PM +0200, Joerg Roedel wrote: > On Thu, Jun 17, 2010 at 02:14:00PM -0700, Tom Lyon wrote: > > On Sunday 13 June 2010 03:23:39 am Michael S. Tsirkin wrote: > > > OK, after more investigation, I realize you are right. > > We definitely need the IOMMU protection for in

About sound problem on guests

2010-06-24 Thread satimis
Hi folks, KVM - 1:0.12.4+dfsg-1~bpo50+1 0 host - Debian 5.0 I have been suffering sound problem on guests for sometimes. Please advise whether the same has been solved. If YES please advice how to solve it. TIA B.R. Stephen L -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 0/3][RFC] NUMA: add host side pinning

2010-06-24 Thread Andi Kleen
Anthony Liguori writes: > > If we extended integrated -mem-path with -numa such that a different > path could be used with each numa node (and we let an explicit file be > specified instead of just a directory), then if I understand > correctly, we could use numactl without any specific integratio

Re: Looking at using KVM for embedded product

2010-06-24 Thread Avi Kivity
On 06/24/2010 03:21 PM, Tom Shoes wrote: The userspace part - qemu-kvm - is released independently (and has its own stable branch). Does a certain version of qemu-kvm go hand in hand with a certain version of KVM code in the Linux kernel release? No. Does the KVM community recomme

Re: Looking at using KVM for embedded product

2010-06-24 Thread Tom Shoes
Thanks you for the suggestions and the link (a neat one). Cheers ../Tom -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [KVM-AUTOTEST PATCH] [RFC] KVM test: rss.cpp: add file transfer support

2010-06-24 Thread Michael Goldish
On 06/24/2010 02:25 PM, Yaniv Kaul wrote: > On 6/24/2010 2:03 PM, Michael Goldish wrote: >> Enable RSS to send/receive files and directory trees (recursively). > > Are you slowly developing a competitor to STAF > (http://staf.sourceforge.net/) ? I think STAF offers much more stuff. However, rss

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-24 Thread Joerg Roedel
On Thu, Jun 17, 2010 at 02:14:00PM -0700, Tom Lyon wrote: > On Sunday 13 June 2010 03:23:39 am Michael S. Tsirkin wrote: > OK, after more investigation, I realize you are right. > We definitely need the IOMMU protection for interrupts, and > if we have it, a lot of the code for config space protec

Re: Looking at using KVM for embedded product

2010-06-24 Thread Tom Shoes
On Wed, Jun 23, 2010 at 7:33 AM, Avi Kivity wrote: Thanks for your response Avi. > The userspace part - qemu-kvm - is released independently (and has its own > stable branch). Does a certain version of qemu-kvm go hand in hand with a certain version of KVM code in the Linux kernel release? Doe

Re: [PATCH] qemu-kvm: Remove old kvm-kmod traces from build system

2010-06-24 Thread Avi Kivity
On 06/24/2010 02:48 PM, Jan Kiszka wrote: Wow. Are you idling over the commit button? Send me moar patches! -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.

Re: [PATCH] qemu-kvm: Remove old kvm-kmod traces from build system

2010-06-24 Thread Jan Kiszka
Avi Kivity wrote: > On 06/24/2010 02:45 PM, Jan Kiszka wrote: >> This became a separate package long ago. >> >> > > Applied, thanks. > Wow. Are you idling over the commit button? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubsc

Re: [PATCH] qemu-kvm: Remove old kvm-kmod traces from build system

2010-06-24 Thread Avi Kivity
On 06/24/2010 02:45 PM, Jan Kiszka wrote: This became a separate package long ago. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More

[PATCH] qemu-kvm: Remove old kvm-kmod traces from build system

2010-06-24 Thread Jan Kiszka
This became a separate package long ago. Signed-off-by: Jan Kiszka --- Makefile | 15 --- configure | 22 -- 2 files changed, 0 insertions(+), 37 deletions(-) diff --git a/Makefile b/Makefile index 2cd87be..49e2a3f 100644 --- a/Makefile +++ b/Makefile @@ -72

Re: [PATCH 0/3][RFC] NUMA: add host side pinning

2010-06-24 Thread Avi Kivity
On 06/24/2010 02:34 PM, Andre Przywara wrote: Non-anonymous memory doesn't work well with ksm and transparent hugepages. Is it possible to use anonymous memory rather than file backed? I'd prefer non-file backed, too. But that is how the current huge pages implementation is done. We could us

Re: [PATCH 0/3][RFC] NUMA: add host side pinning

2010-06-24 Thread Andre Przywara
Avi Kivity wrote: On 06/24/2010 01:58 PM, Andre Przywara wrote: So who would create the /dev/shm/nodeXX files? Currently it is QEMU. It creates a somewhat unique filename, opens and unlinks it. The difference would be to name the file after the option and to not unlink it. I can imagine sta

Re: [KVM-AUTOTEST PATCH] [RFC] KVM test: rss.cpp: add file transfer support

2010-06-24 Thread Lucas Meneghel Rodrigues
On Thu, 2010-06-24 at 14:25 +0300, Yaniv Kaul wrote: > On 6/24/2010 2:03 PM, Michael Goldish wrote: > > Enable RSS to send/receive files and directory trees (recursively). > > Are you slowly developing a competitor to STAF > (http://staf.sourceforge.net/) ? > And re. the file transfer protocol, w

[RFC v4][PATCH 3/3] Support for dynamically enabling/disabling trace events.

2010-06-24 Thread Prerna Saxena
This patch adds support for dynamically enabling/disabling of trace events. This is done by internally maintaining each trace event's state, and permitting logging of data from a trace event only if it is in an 'active' state. Monitor commands added : 1) info trace-events: to view al

[RFC v4][PATCH 2/3] Monitor command 'info trace'

2010-06-24 Thread Prerna Saxena
Monitor command 'info trace' to display contents of trace buffer Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 12 tracetool |1 + 5 files changed, 32 insertions(+), 0 dele

[RFC v4][PATCH 1/3] Change type declarations

2010-06-24 Thread Prerna Saxena
Change type 'TraceEvent' to 'TraceEventID' Signed-off-by: Prerna Saxena --- simpletrace.c | 12 ++-- tracetool | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/simpletrace.c b/simpletrace.c index 2fec4d3..b488380 100644 --- a/simpletrace.c +++ b

Re: [KVM-AUTOTEST PATCH] [RFC] KVM test: rss.cpp: add file transfer support

2010-06-24 Thread Yaniv Kaul
On 6/24/2010 2:03 PM, Michael Goldish wrote: Enable RSS to send/receive files and directory trees (recursively). Are you slowly developing a competitor to STAF (http://staf.sourceforge.net/) ? And re. the file transfer protocol, why not use TFTP, instead of creating your own protocol? Y.

[RFC v4][PATCH 0/3] Monitor support for Qemu tracing

2010-06-24 Thread Prerna Saxena
This set of patches enables trace visualization & control via the QEMU monitor. It is based on trace infrastructure posted upstream : ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This patchset adds monitor commands : - info trace : to view current contents of the trace

Re: [PATCH 0/3][RFC] NUMA: add host side pinning

2010-06-24 Thread Avi Kivity
On 06/24/2010 01:58 PM, Andre Przywara wrote: So who would create the /dev/shm/nodeXX files? Currently it is QEMU. It creates a somewhat unique filename, opens and unlinks it. The difference would be to name the file after the option and to not unlink it. > I can imagine starting numactl be

[PATCH v2] KVM: Document KVM specific review items

2010-06-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- Documentation/kvm/review-checklist.txt | 38 1 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 Documentation/kvm/review-checklist.txt diff --git a/Documentation/kvm/review-checklist.txt b/Documentation/kvm/revi

[KVM-AUTOTEST PATCH] [RFC] KVM test: add python client for rss file transfer services

2010-06-24 Thread Michael Goldish
For usage details see docstrings in rss_file_transfer.py. For protocol details see deps/rss.cpp. Signed-off-by: Michael Goldish --- client/tests/kvm/rss_file_transfer.py | 412 + 1 files changed, 412 insertions(+), 0 deletions(-) create mode 100644 client/tests/

[KVM-AUTOTEST PATCH] [RFC] KVM test: rss.cpp: add file transfer support

2010-06-24 Thread Michael Goldish
Enable RSS to send/receive files and directory trees (recursively). See protocol details in rss.cpp. Signed-off-by: Michael Goldish --- client/tests/kvm/deps/rss.cpp | 1429 - 1 files changed, 970 insertions(+), 459 deletions(-) diff --git a/client/tests

Re: [PATCH 0/3][RFC] NUMA: add host side pinning

2010-06-24 Thread Andre Przywara
Alexander Graf wrote: On 24.06.2010, at 00:21, Anthony Liguori wrote: On 06/23/2010 04:09 PM, Andre Przywara wrote: Hi, these three patches add basic NUMA pinning to KVM. According to a user provided assignment parts of the guest's memory will be bound to different host nodes. This should inc

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-24 Thread Herbert Xu
On Wed, Jun 23, 2010 at 06:05:41PM +0800, Dong, Eddie wrote: > > I mean once the frontend side driver post the buffers to the backend driver, > the backend driver will "immediately" use that buffers to compose skb or > gro_frags and post them to the assigned host NIC driver as receive buffers.

Slow vmalloc in 2.6.35-rc3

2010-06-24 Thread Avi Kivity
I see really slow vmalloc performance on 2.6.35-rc3: # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | | | | | | 3) 3.581 us| vfree(); 3) | msr_io() { 3) ! 523.880 us |vmalloc(); 3) 1.702 us|vf

Re: [PATCH 3/3] vhost: apply cpumask and cgroup to vhost pollers

2010-06-24 Thread Michael S. Tsirkin
On Sun, May 30, 2010 at 10:25:01PM +0200, Tejun Heo wrote: > Apply the cpumask and cgroup of the initializing task to the created > vhost poller. > > Based on Sridhar Samudrala's patch. > > Cc: Michael S. Tsirkin > Cc: Sridhar Samudrala I wanted to apply this, but modpost fails: ERROR: "sched

Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()

2010-06-24 Thread Avi Kivity
On 06/24/2010 03:58 AM, Marcelo Tosatti wrote: Well yes, I expect that not using rcu_dereference() (and srcu_read_lock()) is a bug here. Marcelo? No because slots_lock is held which serializes with memslot updates. Right, I need to reread Documentation/kvm/locking.txt. -- error c

Re: [PATCH V2 3/5] ara virt interface of perf to support kvm guest os statistics collection in guest os

2010-06-24 Thread Avi Kivity
On 06/24/2010 06:36 AM, Zhang, Yanmin wrote: If the perf event is bound to the vm, not a vcpu, then on guest process migration you will have to disable it on one vcpu and enable it on the other, no? I found we start from different points. This patch is to implement a para virt interface