Re: [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-22 Thread Christoph Hellwig
On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Greetings hch, tomo and Co, What tree is this against? I can't see any specificc BSG support in qemu. Even more I think all this in the wrong place. The only reason SG_IO support was shoe-hor

Re: [PATCH v2] KVM: x86 emulator: add LDS/LES/LFS/LGS/LSS instruction emulation

2010-08-22 Thread Avi Kivity
On 08/20/2010 06:17 AM, Wei Yongjun wrote: > Add LDS/LES/LFS/LGS/LSS instruction emulation. > (opcode 0xc4, 0xc5, 0x0f 0xb2, 0x0f 0xb4~0xb5) > The patch looks good, but did I miss the test cases? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: s

Re: vhost-net unreleased?

2010-08-22 Thread Avi Kivity
On 08/19/2010 11:19 PM, John Bellessa wrote: vhost-net will be supported by qemu-kvm 0.13 which is on track for release soon. I'm a little confused. The vhost-net page (http://www.linux-kvm.org/page/VhostNet) indicates that it is fully functional. Could you clarify that a bit? It's fu

Re: [BUG?] can not writeback more then 8 bytes memory

2010-08-22 Thread Avi Kivity
On 08/20/2010 12:12 PM, Wei Yongjun wrote: > Hi all: > > I have the following patch to SIDT emulation instruction, but it > does not work because we can not writeback more then 8 bytes > memory, the SIDT under PROTO64 is 10 bytes. > > I change the code to write twice, first time write limit, then

Re: Receiving delayed packets from RTL8139 card in KVM

2010-08-22 Thread Avi Kivity
On 08/20/2010 04:01 AM, Karthik Vadambacheri Manian wrote: Hi All, I am running a light weight kernel named kitten in QEMU-KVM which uses LWIP (Light Weight TCP/IP) stack for networking. I am trying to fine tune this LWIP but I am now facing an issue regarding delayed packet reception. Basicall

Re: [PATCH non-atomic-injection] x86 emulator: Add cwd/cdq/cqo instruction (opcode 0x99)

2010-08-22 Thread Avi Kivity
On 08/19/2010 05:25 PM, Mohammed Gamal wrote: Signed-off-by: Mohammed Gamal --- arch/x86/kvm/emulate.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index ee4bb69..fddf76d 100644 --- a/arch/x86/kvm/emul

[PATCH 01/14] KVM: x86 emulator: pass destination type to ____emulate_2op()

2010-08-22 Thread Avi Kivity
We'll need it later so we can use a register for the destination. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index c37fb01..49bfcc7 100644 --- a/arch/x86/

[PATCH 03/14] KVM: x86 emulator: implement DAS (opcode 2F)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index f6f93b9..4cbc884 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.

[PATCH 02/14] KVM: x86 emulator: Use a register for ____emulate_2op() destination

2010-08-22 Thread Avi Kivity
Most x86 two operand instructions allow the destination to be a memory operand, but IMUL (for example) requires that the destination be a register. Change emulate_2op() to take a register for both source and destination so we can invoke IMUL. Signed-off-by: Avi Kivity --- arch/x86/kvm/emula

[PATCH 07/14] KVM: x86 emulator: implement IMUL REG, R/M, imm8 (opcode 6B)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 6ef4b22..ae72835 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2260,6 +2260,15 @@

[PATCH 13/14] KVM: x86 emulator: implement IMUL REG, R/M, IMM (opcode 69)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 3365511..d4ec010 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2398,7 +2398,8 @@ static stru

[PATCH 00/14] More instruction emulations

2010-08-22 Thread Avi Kivity
Add a bunch of instructions to the emulator. These are sufficient to make the BIOS boot. Avi Kivity (14): KVM: x86 emulator: pass destination type to emulate_2op() KVM: x86 emulator: Use a register for emulate_2op() destination KVM: x86 emulator: implement DAS (opcode 2F) KVM: x86

[PATCH 08/14] KVM: x86 emulator: implement IMUL REG, R/M (opcode 0F AF)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index ae72835..7574d1e 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2260,15 +2260,22 @

[PATCH 09/14] KVM: x86 emulator: remove SrcImplicit

2010-08-22 Thread Avi Kivity
Useless. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 7574d1e..e83b9fc 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -58,7 +58,6 @@ #def

[PATCH 10/14] KVM: x86 emulator: implement RDTSC (opcode 0F 31)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index e83b9fc..09bec0c 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2275,6 +2275

[PATCH 06/14] KVM: x86 emulator: implement RET imm16 (opcode C2)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 67e8eed..6ef4b22 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2245,6 +2245

[PATCH 05/14] KVM: x86 emulator: add SrcImmU16 operand type

2010-08-22 Thread Avi Kivity
Used for RET NEAR instructions. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 34c4196..67e8eed 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/e

[PATCH 12/14] KVM: x86 emulator: add Src2Imm decoding

2010-08-22 Thread Avi Kivity
Needed for 3-operand IMUL. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 3cf9c02..3365511 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -

[PATCH 14/14] KVM: x86 emulator: implement CWD (opcode 99)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index d4ec010..f512ba7 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2276,6 +2276,18

[PATCH 3/6] Add IMUL tests

2010-08-22 Thread Avi Kivity
IMUL REG, R/M IMUL REG, R/M, IMM8 IMUL REG, R/M, IMM Signed-off-by: Avi Kivity --- x86/emulator.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/x86/emulator.c b/x86/emulator.c index d30ca8e..b0d15c0 100644 --- a/x86/emulator.c

[PATCH 6/6] Test RET IMM instruction

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- x86/realmode.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 42b6760..60c6212 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@ -627,6 +627,7 @@ void test_call(void)

[PATCH 11/14] KVM: x86 emulator: consolidate immediate decode into a function

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 109 1 files changed, 64 insertions(+), 45 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 09bec0c..3cf9c02 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/

[PATCH 5/6] Test CALL FAR R/M instrucion (opcode FF /3)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- x86/realmode.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 77fc1e1..42b6760 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@ -604,10 +604,14 @@ void test_io(void) prin

[PATCH 2/6] Add DAS test

2010-08-22 Thread Avi Kivity
test 1024 combinations of AL, CF and AF. Signed-off-by: Avi Kivity --- x86/realmode.c | 284 1 files changed, 284 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index c15e532..7c358f9 100644 --- a/x86/realmode

[PATCH 04/14] KVM: x86 emulator: implement CALL FAR (FF /3)

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 4cbc884..34c4196 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.

[PATCH 4/6] Add test for cwd/cdq/cqo instruction

2010-08-22 Thread Avi Kivity
From: Mohammed Gamal Signed-off-by: Mohammed Gamal Signed-off-by: Avi Kivity --- x86/realmode.c | 58 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 7c358f9..77fc1e1 100644 --- a/x

[PATCH 0/6] Some more emulator tests

2010-08-22 Thread Avi Kivity
Add emulator tests for recently implemented instructions: DAS IMUL (several variants) CALL FAR r/m RET imm16 Avi Kivity (5): Load flags register before running real-mode test Add DAS test Add IMUL tests Test CALL FAR R/M instrucion (opcode FF /3) Test RET IMM instruction Mohamm

[PATCH 1/6] Load flags register before running real-mode test

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- x86/realmode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index ccf3645..c15e532 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@ -78,6 +78,7 @@ static void exec_in_big_real_mode(const struct regs *inre

Re: [PATCH 03/14] KVM: x86 emulator: implement DAS (opcode 2F)

2010-08-22 Thread Avi Kivity
On 08/22/2010 03:18 PM, Avi Kivity wrote: Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index f6f93b9..4cbc884 100644 --- a/arch

[PATCH 0/5] Realmode unit-tests clean up

2010-08-22 Thread Avi Kivity
This patch set cleans up the real mode unit tests and makes it significantly easier to add and review new tests. Avi Kivity (5): Simplify exec_in_big_real_mode() calling convention Introduce report() function for realmode test to simplify result reporting realmode: make inregs, outregs g

[PATCH 4/5] realmode: fix esp in long jump test

2010-08-22 Thread Avi Kivity
esp needs to point at the end of the stack, or it will corrupt memory. Signed-off-by: Avi Kivity --- x86/realmode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 5c62ec4..50eaa5e 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@

[PATCH 2/5] Introduce report() function for realmode test to simplify result reporting

2010-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity --- x86/realmode.c | 585 +++- 1 files changed, 198 insertions(+), 387 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 183eb06..ef424dd 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@ -138,6 +138,1

[PATCH 3/5] realmode: make inregs, outregs global

2010-08-22 Thread Avi Kivity
This removes a lot of parameter passing. Signed-off-by: Avi Kivity --- x86/realmode.c | 430 +--- 1 files changed, 221 insertions(+), 209 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index ef424dd..5c62ec4 100644 --- a/x86/realmo

[PATCH 1/5] Simplify exec_in_big_real_mode() calling convention

2010-08-22 Thread Avi Kivity
Instead of passing both the address and size of the instruction to be executed, pass the address of a descriptor containing both. The label denoting the end of the instruction is eliminated, reducing aliases which confuse objdump. Signed-off-by: Avi Kivity --- x86/realmode.c | 415

[PATCH 5/5] realmode: fold register comparison test into report()

2010-08-22 Thread Avi Kivity
This makes is easier to test registers. Signed-off-by: Avi Kivity --- x86/realmode.c | 301 +--- 1 files changed, 113 insertions(+), 188 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index 50eaa5e..b69e474 100644 --- a/x86/realmod

Re: [PATCH 0/4 v2] kvm: rework KVM mmu_shrink() code

2010-08-22 Thread Avi Kivity
On 08/20/2010 04:10 AM, Tim Pepper wrote: The following series is the four patches Dave Hansen had queued for test as mentioned last week in the thread: "[PATCH] kvm: make mmu_shrink() fit shrinker's requirement" Last week just before leaving for vacation Dave had noted in that thread that th

Re: [PATCH 13/26] KVM: PPC: Add feature bitmap for magic page

2010-08-22 Thread Avi Kivity
On 08/17/2010 04:57 PM, Alexander Graf wrote: We will soon add SR PV support to the shared page, so we need some infrastructure that allows the guest to query for features KVM exports. This patch adds a second return value to the magic mapping that indicated to the guest which features are avai

Re: [PATCH 00/26] KVM: PPC: Mid-August patch queue

2010-08-22 Thread Avi Kivity
On 08/17/2010 04:57 PM, Alexander Graf wrote: Howdy, This is my local patch queue with stuff that has accumulated over the last weeks on KVM for PPC with some last minute fixes, speedups and debugging help that I needed for the KVM Forum ;-). The highlights of this set are: - Converted mos

[GIT PULL] KVM fixes for 2.6.36-rc1

2010-08-22 Thread Avi Kivity
Linus, please pull from r&b: git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.36 to get a few regression fixes for KVM: Xiao Guangrong (1): KVM: PIT: free irq source id in handling error path Xiaotian Feng (2): KVM: fix poison overwritten caused by using wrong xstat

[PATCH] lsi53c895a: Fix breakage v0.12.5 merge for SGL passthrough qemu-kvm.git tree

2010-08-22 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Greetings hch, Paul and other lsi53c895a folks, This patch merges the remaining changes from upstream v0.12.5 for hw/lsi53c895a.c to function with the existing SGL passthrough code. This includes the following: *) conversion of lsi_request->finished to lsi_request-

Re: [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-22 Thread Nicholas A. Bellinger
On Sun, 2010-08-22 at 10:31 +0200, Christoph Hellwig wrote: > On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Greetings hch, tomo and Co, > > What tree is this against? I can't see any specificc BSG support in qemu. > The Megasas / S

[PATCH 1/2] PCI: define max devices number on PCIBus as PCIBus_MAX_DEVICES in pci.h

2010-08-22 Thread Ken CC
Signed-off-by: Ken CC --- hw/pci.c |2 +- hw/pci.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a98d6f3..a09fbac 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -44,7 +44,7 @@ struct PCIBus { pci_hotplug_fn hotplug; DeviceState *hotplug

[PATCH] pci init: Check if devfn exceeding the max devices number supported on bus

2010-08-22 Thread Ken CC
Check before trying subindexing. Signed-off-by: Ken CC --- hw/pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a09fbac..f6f00c6 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -675,6 +675,10 @@ static PCIDevice *do_pci_register_device(PCIDevice

[PATCH 2/2] pci init: Check if devfn exceeding the max devices number supported on bus

2010-08-22 Thread Ken CC
Check before trying subindexing. Signed-off-by: Ken CC --- hw/pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a09fbac..f6f00c6 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -675,6 +675,10 @@ static PCIDevice *do_pci_register_device(PCIDevice

Re: vhost-net unreleased?

2010-08-22 Thread rukhsana ansari
In case, it helps, vhost functionality has been patched into and available in the src rpm - qemu-0.12.3-8.fc13.src.rpm at http://rpm.pbone.net/index.php3/stat/4/idpl/14076054/dir/fedora_13/com/qemu-system-x86-0.12.3-8.fc13.x86_64.rpm.html On Fri, Aug 20, 2010 at 1:49 AM, John Bellessa wrote: > >

Re: [qemu-kvm PATCH 0/3] small qemu-kvm cleanups

2010-08-22 Thread Paolo Bonzini
On 08/17/2010 01:29 PM, Avi Kivity wrote: On 08/12/2010 06:29 PM, Paolo Bonzini wrote: Nothing earth shattering. :) Paolo Bonzini (3): move kvm_set_irqfd to kvm-stub.c This touches kvm-all.c, so should be against uq/master. kvm_set_irqfd is not in upstream qemu, should I add it there even t

[PATCH] Add realmode test for LDS/LES/LFS/LGS/LSS instruction

2010-08-22 Thread Wei Yongjun
Signed-off-by: Wei Yongjun --- x86/realmode.c | 59 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/x86/realmode.c b/x86/realmode.c index b69e474..8c771fc 100644 --- a/x86/realmode.c +++ b/x86/realmode.c @@ -1184,6 +1184,6

Re: [qemu-kvm PATCH 0/3] small qemu-kvm cleanups

2010-08-22 Thread Avi Kivity
On 08/23/2010 09:45 AM, Paolo Bonzini wrote: On 08/17/2010 01:29 PM, Avi Kivity wrote: On 08/12/2010 06:29 PM, Paolo Bonzini wrote: Nothing earth shattering. :) Paolo Bonzini (3): move kvm_set_irqfd to kvm-stub.c This touches kvm-all.c, so should be against uq/master. kvm_set_irqfd is not

[PATCH v3] KVM: x86 emulator: add LDS/LES/LFS/LGS/LSS instruction emulation

2010-08-22 Thread Wei Yongjun
Add LDS/LES/LFS/LGS/LSS instruction emulation. (opcode 0xc4, 0xc5, 0x0f 0xb2, 0x0f 0xb4~0xb5) Signed-off-by: Wei Yongjun --- v2 -> v3: no changes, just porting to today's git tree --- arch/x86/kvm/emulate.c | 50 --- 1 files changed, 46 insertions(+)