Re: [PATCH 07/15] ftrace: fix event alignment: kvm:kvm_hv_hypercall

2010-12-04 Thread Avi Kivity
On 12/04/2010 02:13 AM, David Sharp wrote: Signed-off-by: David Sharpdhsh...@google.com --- arch/x86/kvm/trace.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h index a6544b8..ab41fb0 100644 --- a/arch/x86/kvm/trace.h

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)

2010-12-04 Thread Avi Kivity
On 12/04/2010 12:45 AM, Anthony Liguori wrote: hlt exiting doesn't leave vcpu in the halted state (since hlt has not been executed). So currently we never see a vcpu in halted state. Right, you mean the guest activity state being halt. My understanding is that it just needs to be cleared on

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)

2010-12-04 Thread Avi Kivity
On 12/04/2010 12:42 AM, Anthony Liguori wrote: In v3, I set the activity state to ACTIVE if the state is currently HLT when injecting an exception into a guest. The effect is that after the exception is handled, if iret is executed, the hlt instruction will be restarted. The seems like the

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)

2010-12-04 Thread Avi Kivity
On 12/03/2010 07:33 PM, Srivatsa Vaddagiri wrote: On Fri, Dec 03, 2010 at 09:29:06AM -0800, Chris Wright wrote: That's what Marcelo's suggestion does w/out a fill thread. Are we willing to add that to KVM sources? I'd rather avoid it. I was working under the constraints of not modifying

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)

2010-12-04 Thread Avi Kivity
On 12/03/2010 08:12 PM, Srivatsa Vaddagiri wrote: On Fri, Dec 03, 2010 at 12:07:15PM -0600, Anthony Liguori wrote: My first reaction is that it's not terribly important to account the non-idle time in the guest because of the use-case for this model. Agreed ...but I was considering the

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v3)

2010-12-04 Thread Joerg Roedel
On Fri, Dec 03, 2010 at 05:38:06PM -0600, Anthony Liguori wrote: On 12/03/2010 05:32 PM, Joerg Roedel wrote: On Fri, Dec 03, 2010 at 04:39:22PM -0600, Anthony Liguori wrote: + if (yield_on_hlt) + min |= CPU_BASED_HLT_EXITING; This approach won't work out on AMD because

Re: [PATCH 0/5] KVMgenirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-04 Thread Thomas Gleixner
On Sat, 4 Dec 2010, Jan Kiszka wrote: Besides 3 cleanup patches, this series consists of two major changes. The first introduces an interrupt sharing notifier to the genirq subsystem. It fires when an interrupt line is about to be use by more than one driver or the last but one user called

Re: [PATCH 0/5] KVMgenirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-04 Thread Jan Kiszka
Am 04.12.2010 11:37, Thomas Gleixner wrote: On Sat, 4 Dec 2010, Jan Kiszka wrote: Besides 3 cleanup patches, this series consists of two major changes. The first introduces an interrupt sharing notifier to the genirq subsystem. It fires when an interrupt line is about to be use by more than

Re: [RFC PATCH 2/3] sched: add yield_to function

2010-12-04 Thread Rik van Riel
On 12/03/2010 04:23 PM, Peter Zijlstra wrote: On Fri, 2010-12-03 at 19:40 +0530, Srivatsa Vaddagiri wrote: On Fri, Dec 03, 2010 at 07:36:07PM +0530, Srivatsa Vaddagiri wrote: On Fri, Dec 03, 2010 at 03:03:30PM +0100, Peter Zijlstra wrote: No, because they do receive service (they spend some

Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)

2010-12-04 Thread Anthony Liguori
On 12/04/2010 02:13 AM, Avi Kivity wrote: On 12/04/2010 12:45 AM, Anthony Liguori wrote: hlt exiting doesn't leave vcpu in the halted state (since hlt has not been executed). So currently we never see a vcpu in halted state. Right, you mean the guest activity state being halt. My

Re: [PATCH 2/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-04 Thread Paolo Bonzini
On 12/03/2010 11:49 AM, Glauber Costa wrote: +/* This has to happen after vcpu setup*/ +void kvmclock_register_savevm(void) +{ +#ifdef KVM_CAP_ADJUST_CLOCK +if (kvmclock_enabled kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) { +printf(registering kvmclock savevm section\n);

Re: [PATCH 2/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-04 Thread Paolo Bonzini
On 12/03/2010 11:49 AM, Glauber Costa wrote: +/* This has to happen after vcpu setup*/ +void kvmclock_register_savevm(void) +{ +#ifdef KVM_CAP_ADJUST_CLOCK +if (kvmclock_enabled kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) { +printf(registering kvmclock savevm section\n);

Re: [PATCH 0/5] KVMgenirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-04 Thread Thomas Gleixner
Jan, On Sat, 4 Dec 2010, Jan Kiszka wrote: Am 04.12.2010 11:37, Thomas Gleixner wrote: On Sat, 4 Dec 2010, Jan Kiszka wrote: If interrupt is shared, then you want to keep the current behaviour: disable at line level (IRQF_ONESHOT) run handler thread (PCI level masking)

[PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v4)

2010-12-04 Thread Anthony Liguori
In certain use-cases, we want to allocate guests fixed time slices where idle guest cycles leave the machine idling. There are many approaches to achieve this but the most direct is to simply avoid trapping the HLT instruction which lets the guest directly execute the instruction putting the

Re: [PATCH 0/5] KVMgenirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-04 Thread Jan Kiszka
Am 04.12.2010 15:41, Thomas Gleixner wrote: Jan, On Sat, 4 Dec 2010, Jan Kiszka wrote: Am 04.12.2010 11:37, Thomas Gleixner wrote: On Sat, 4 Dec 2010, Jan Kiszka wrote: If interrupt is shared, then you want to keep the current behaviour: disable at line level (IRQF_ONESHOT) run

Re: [PATCH 0/5] KVMgenirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-04 Thread Thomas Gleixner
On Sat, 4 Dec 2010, Jan Kiszka wrote: Am 04.12.2010 15:41, Thomas Gleixner wrote: Also there is a pretty simple solution for this: The core code knows, that there is an ONESHOT interrupt in flight, so it simply can call It doesn't synchronize the tail part against the masking in the

Re: [PATCH 1/2] vhost test module

2010-12-04 Thread Paul E. McKenney
On Thu, Dec 02, 2010 at 03:56:56PM -0800, Paul E. McKenney wrote: On Fri, Dec 03, 2010 at 01:18:18AM +0200, Michael S. Tsirkin wrote: On Thu, Dec 02, 2010 at 03:13:03PM -0800, Paul E. McKenney wrote: On Thu, Dec 02, 2010 at 09:47:09PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 02, 2010

Re: [PATCH v4 1/3] KVM: MMU: rename 'no_apf' to 'prefault'

2010-12-04 Thread Marcelo Tosatti
On Thu, Dec 02, 2010 at 05:44:43PM +0800, Xiao Guangrong wrote: It's the speculative path if 'no_apf = 1' and we will specially handle this speculative path in the later patch, so 'prefault' is better to fit the sense Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com ---

buildbot failure in qemu-kvm on disable_kvm_x86_64_debian_5_0

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_debian_5_0/builds/663 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on disable_kvm_i386_debian_5_0

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/664 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on disable_kvm_i386_out_of_tree

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_out_of_tree/builds/612 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/673 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_1

buildbot failure in qemu-kvm on default_x86_64_out_of_tree

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of default_x86_64_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_out_of_tree/builds/614 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on default_i386_debian_5_0

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of default_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_debian_5_0/builds/675 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_2

buildbot failure in qemu-kvm on default_i386_out_of_tree

2010-12-04 Thread qemu-kvm
The Buildbot has detected a new failure of default_i386_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_out_of_tree/builds/612 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_2

buildbot failure in kvm on ppc44x

2010-12-04 Thread kvm
The Buildbot has detected a new failure of ppc44x on kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/ppc44x/builds/23 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly scheduler named 'nightly_master'

buildbot failure in kvm on s390

2010-12-04 Thread kvm
The Buildbot has detected a new failure of s390 on kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/s390/builds/16 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly scheduler named 'nightly_master'

buildbot failure in kvm on ia64

2010-12-04 Thread kvm
The Buildbot has detected a new failure of ia64 on kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/ia64/builds/21 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly scheduler named 'nightly_master'

buildbot failure in kvm on ppc64

2010-12-04 Thread kvm
The Buildbot has detected a new failure of ppc64 on kvm. Full details are available at: http://buildbot.b1-systems.de/kvm/builders/ppc64/builds/20 Buildbot URL: http://buildbot.b1-systems.de/kvm/ Buildslave for this Build: b1_kvm_1 Build Reason: The Nightly scheduler named 'nightly_master'

Re: [PATCH 3/3] Provide control over unmapped pages

2010-12-04 Thread Balbir Singh
* KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com [2010-12-02 11:50:36]: On Thu, 2 Dec 2010 10:22:16 +0900 (JST) KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com wrote: On Tue, 30 Nov 2010, Andrew Morton wrote: +#define UNMAPPED_PAGE_RATIO 16 Well. Giving 16 a name didn't