Re: [PATCH v6 0/4] rbd improvements

2011-05-26 Thread Kevin Wolf
Am 27.05.2011 01:07, schrieb Josh Durgin: > This patchset moves the complexity of the rbd format into librbd and > adds truncation support. > > Changes since v5: > * compare full string, not prefix, with "conf" in 2/4 > * when truncate fails, just return librbd's error > > Changes since v4: >

Graphics card pass-through working with two pass pci-initialization

2011-05-26 Thread André Weidemann
Hi Gerd, I managed to pass through a graphics card to a Windows7 VM using your kraxel.q35 seabios branch (http://www.kraxel.org/cgit/seabios/log/?h=kraxel.q35). Here is my setup: Intel DX58SO Core i7 920 Radeon HD 6950 Kernel 2.6.35.7 qemu-kvm git pull from May 26th The gfx card is working we

[PATCH 6/6] external_packages: Bump version number requirements for web deps

2011-05-26 Thread Lucas Meneghel Rodrigues
With the previous patchset that fixes the frontend running under Django 1.3, tested the frontend code compilation with the latest versions of gwt and gwt-incubator with success. The interface looks pretty good, and therefore, let's bump version numbers for: * Django * gwt * gwt-incubator On build

[PATCH 5/6] Removing get_from_clause() from custom query class

2011-05-26 Thread Lucas Meneghel Rodrigues
Signed-off-by: Lucas Meneghel Rodrigues --- frontend/afe/model_logic.py | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/frontend/afe/model_logic.py b/frontend/afe/model_logic.py index 0ddcefe..38bcabe 100644 --- a/frontend/afe/model_logic.py +++ b/frontend/

[PATCH 4/6] Change web app to use new DB engine

2011-05-26 Thread Lucas Meneghel Rodrigues
Signed-off-by: Lucas Meneghel Rodrigues --- frontend/settings.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/frontend/settings.py b/frontend/settings.py index 3ac7f80..79b2a70 100644 --- a/frontend/settings.py +++ b/frontend/settings.py @@ -15,7 +15,8 @@ ADMINS = (

[PATCH 3/6] Adding afe custom database engine

2011-05-26 Thread Lucas Meneghel Rodrigues
Turns out that we rely on custom code to generate joins that does some trickery with Django ORM system, and was using a method calling get_from_clause, that was present on the Query class on Django 1.1. Now, the method was moved to a class upper in the hierarchy, called SQLCompiler, and SQLCompiler

[PATCH 2/6] afe/readonly connection: Catch AttributeError exceptions

2011-05-26 Thread Lucas Meneghel Rodrigues
On Django 1.3, the DB connection object does not have some of the attributes we are trying to compare on the __neq__ method, resulting on an AttributeError. Let's catch that error so the application works under 1.3. Signed-off-by: Lucas Meneghel Rodrigues --- frontend/afe/readonly_connection.py

[PATCH 1/6] Update admin site URL dispatcher to Django 1.3

2011-05-26 Thread Lucas Meneghel Rodrigues
admin.site.root does not exist under Django 1.3 anymore. Use, therefore, the current idiom to specify the admin URL. Signed-off-by: Lucas Meneghel Rodrigues --- frontend/urls.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/frontend/urls.py b/frontend/urls.py index 7f

[PATCH 0/6] Update the web interface to the latest versions of foundation components

2011-05-26 Thread Lucas Meneghel Rodrigues
Update the web interface to use Django 1.3, fixed the remaining problems with custom SQL injection code, resolving problems with the scheduler. Also, tested the latest versions of gwt and gwt incubator, bumping the requirements on the build_externals code, making the web interface to run on the lat

RE: [Patch v3] Enable CPU SMEP feature for KVM

2011-05-26 Thread Tian, Kevin
> From: Yang, Wei Y > Sent: Thursday, May 26, 2011 9:29 PM > > This patchset enables a new CPU feature SMEP (Supervisor Mode Execution > Protection) in KVM. SMEP prevents kernel from executing code in application. > Updated Intel SDM describes this CPU feature. The document will be published > soo

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Paul E. McKenney
On Thu, May 26, 2011 at 07:05:08PM -0400, Mathieu Desnoyers wrote: > * Ingo Molnar (mi...@elte.hu) wrote: > > > > * Pekka Enberg wrote: > > > > > On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > > > > On 05/26/2011 09:05 PM, Ingo Molnar wrote: > > > >> > > > >> > > > > >> >  I've added some

[PATCH v6 4/4] rbd: Add bdrv_truncate implementation

2011-05-26 Thread Josh Durgin
Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin --- block/rbd.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f4da6ab..bdc448a 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -688,6 +688,19 @@ static int64_t qemu_rb

[PATCH v6 3/4] rbd: check return values when scheduling aio

2011-05-26 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reviewed-by: Christian Brunner Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 in

[PATCH v6 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-26 Thread Josh Durgin
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster to be used by speci

[PATCH v6 1/4] rbd: use the higher level librbd instead of just librados

2011-05-26 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c

[PATCH v6 0/4] rbd improvements

2011-05-26 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. Changes since v5: * compare full string, not prefix, with "conf" in 2/4 * when truncate fails, just return librbd's error Changes since v4: * fixed cosmetic issues pointed out by Christian Brunner Ch

Re: [PATCH v5 4/4] rbd: Add bdrv_truncate implementation

2011-05-26 Thread Josh Durgin
On 05/26/2011 01:05 AM, Kevin Wolf wrote: Am 25.05.2011 22:34, schrieb Josh Durgin: Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a44d160..b95b1eb 100644 --- a/block/rbd.c +++

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On Thu, 2011-05-26 at 21:21 +0300, Pekka Enberg wrote: > > On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > > > On 05/26/2011 09:05 PM, Ingo Molnar wrote: > > >> > > >> > > > >> > I've added some rwlocks because of what Ingo said yesterday abou

Re: [PATCH v5 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-26 Thread Josh Durgin
On 05/26/2011 01:13 AM, Kevin Wolf wrote: Am 25.05.2011 22:34, schrieb Josh Durgin: The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration fil

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Mathieu Desnoyers
* Ingo Molnar (mi...@elte.hu) wrote: > > * Pekka Enberg wrote: > > > On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > > > On 05/26/2011 09:05 PM, Ingo Molnar wrote: > > >> > > >> > > > >> >  I've added some rwlocks because of what Ingo said yesterday about > > >> >  adding/removing devices

Re: Setting up network for KVM guests

2011-05-26 Thread David Mair
On 05/26/2011 03:40 PM, c.mo...@web.de wrote: Hello! I have installed KVM/QEMU on my LMDE (Linux Mint Debian Edition) system. On this webpage I found some instructions howto setup the network: http://www.linux-kvm.org/page/Networking My first question is: For a public bridge, should I configure

Setting up network for KVM guests

2011-05-26 Thread c . monty
Hello! I have installed KVM/QEMU on my LMDE (Linux Mint Debian Edition) system. On this webpage I found some instructions howto setup the network: http://www.linux-kvm.org/page/Networking My first question is: For a public bridge, should I configure /etc/network/interfaces in order to create the

Re: [PATCH V6 2/4 net-next] skbuff: Add userspace zero-copy buffers in skb

2011-05-26 Thread Shirley Ma
On Thu, 2011-05-26 at 22:55 +0200, Eric Dumazet wrote: > Le jeudi 26 mai 2011 à 13:24 -0700, Shirley Ma a écrit : > > > I could reduce callback pointer by moving it to *arg, but not desc, > this > > indicates that which buffer DMA hasn't done yet in *arg. > > > I guess you dont need to use skb i

Re: [PATCH V6 2/4 net-next] skbuff: Add userspace zero-copy buffers in skb

2011-05-26 Thread Eric Dumazet
Le jeudi 26 mai 2011 à 13:24 -0700, Shirley Ma a écrit : > I could reduce callback pointer by moving it to *arg, but not desc, this > indicates that which buffer DMA hasn't done yet in *arg. I guess you dont need to use skb itself to hold all your states ? I understand its convenient for you, b

Re: [PATCH V6 0/4 net-next] macvtap/vhost TX zero-copy support

2011-05-26 Thread Shirley Ma
On Thu, 2011-05-26 at 23:28 +0300, Michael S. Tsirkin wrote: > On Thu, May 26, 2011 at 01:00:20PM -0700, Shirley Ma wrote: > > 3. Add sleep in vhost shutting down instead of busy-wait for > outstanding > >DMAs. > > I still think this is not much better. We need to use a > completion structure

Re: [PATCH V6 0/4 net-next] macvtap/vhost TX zero-copy support

2011-05-26 Thread Michael S. Tsirkin
On Thu, May 26, 2011 at 01:00:20PM -0700, Shirley Ma wrote: > 3. Add sleep in vhost shutting down instead of busy-wait for outstanding >DMAs. I still think this is not much better. We need to use a completion structure and wait on it instead. If this gets blocked thinkably a tx watchdog can fi

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Ingo Molnar
* Pekka Enberg wrote: > On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > > On 05/26/2011 09:05 PM, Ingo Molnar wrote: > >> > >> > > >> >  I've added some rwlocks because of what Ingo said yesterday about > >> >  adding/removing devices after the first initialization phase. > >> > > >> >  Ta

Re: [PATCH V6 2/4 net-next] skbuff: Add userspace zero-copy buffers in skb

2011-05-26 Thread Shirley Ma
On Thu, 2011-05-26 at 22:04 +0200, Eric Dumazet wrote: > Le jeudi 26 mai 2011 à 12:36 -0700, Shirley Ma a écrit : > > This patch adds userspace buffers support in skb shared info. A new > > struct skb_ubuf_info is needed to maintain the userspace buffers > > argument and index, a callback is used

[ANNOUNCE] kvm-kmod-2.6.39

2011-05-26 Thread Jan Kiszka
After silently releasing kvm-kmod-2.6.38.6 last week as a stable update, here comes the next major new version: http://sourceforge.net/projects/kvm/files/kvm-kmod/2.6.39/kvm-kmod-2.6.39.tar.bz2/download The list of changes looks rather unspectacular, also due to the fact that not all new features

Re: [PATCH V6 2/4 net-next] skbuff: Add userspace zero-copy buffers in skb

2011-05-26 Thread Eric Dumazet
Le jeudi 26 mai 2011 à 12:36 -0700, Shirley Ma a écrit : > This patch adds userspace buffers support in skb shared info. A new > struct skb_ubuf_info is needed to maintain the userspace buffers > argument and index, a callback is used to notify userspace to release > the buffers once lower device

[PATCH V6 0/4 net-next] macvtap/vhost TX zero-copy support

2011-05-26 Thread Shirley Ma
This patchset add supports for TX zero-copy between guest and host kernel through vhost. It significantly reduces CPU utilization on the local host on which the guest is located (It reduced about 50% CPU usage for single stream test on the host, while 4K message size BW has increased about 50%). Th

[PATCH V6 4/4 net-next] vhost: vhost TX zero-copy support

2011-05-26 Thread Shirley Ma
Hello Michael, Let me anything I might miss from your preview's review. Thanks Shirley --- This patch maintains the outstanding userspace buffers in the sequence it is delivered to vhost. The outstanding userspace buffers will be marked as done once the lower device buffers DMA has fi

[PATCH V6 3/4]macvtap: macvtap TX zero-copy support

2011-05-26 Thread Shirley Ma
Only when buffer size is greater than GOODCOPY_LEN (256), macvtap enables zero-copy. Signed-off-by: Shirley Ma --- drivers/net/macvtap.c | 132 1 files changed, 121 insertions(+), 11 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net

[PATCH V6 2/4 net-next] skbuff: Add userspace zero-copy buffers in skb

2011-05-26 Thread Shirley Ma
This patch adds userspace buffers support in skb shared info. A new struct skb_ubuf_info is needed to maintain the userspace buffers argument and index, a callback is used to notify userspace to release the buffers once lower device has done DMA (Last reference to that skb has gone). If there is

[PATCH V6 1/4 net-next] sock.h: Add a new sock zero-copy flag

2011-05-26 Thread Shirley Ma
Signed-off-by: Shirley Ma --- include/net/sock.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 01810a3..ab09097 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -562,6 +562,7 @@ enum sock_flags { SOCK_TIM

[PATCH V6 0/4]

2011-05-26 Thread Shirley Ma
This patchset add supports for TX zero-copy between guest and host kernel through vhost. It significantly reduces CPU utilization on the local host on which the guest is located (It reduced about 50% CPU usage for single stream test on the host, while 4K message size BW has increased about 50%). Th

Re: [PATCH V5 2/6 net-next] netdevice.h: Add zero-copy flag in netdevice

2011-05-26 Thread Shirley Ma
On Thu, 2011-05-26 at 11:49 +0300, Michael S. Tsirkin wrote: > > > > > - SG support > > > - HIGHDMA support (on arches where this makes sense) > > > > This can be checked by device flags. > > OK, but pls note that SG can get turned off dynamically. Tested the patch w/i SG dynmically on/off and

ioeventfd question

2011-05-26 Thread Sasha Levin
Hi Avi, I'm working on adding ioeventfd support into tools/kvm/. Currently the implementation creates ioeventfd entries at the 'VIRTIO_PCI_QUEUE_NOTIFY' of each device and waits on all of them using epoll(). The basics are working - when IO is triggered I receive a notification using the event ins

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Sasha Levin
On Thu, 2011-05-26 at 21:21 +0300, Pekka Enberg wrote: > On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > > On 05/26/2011 09:05 PM, Ingo Molnar wrote: > >> > >> > > >> > I've added some rwlocks because of what Ingo said yesterday about > >> > adding/removing devices after the first initializ

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> In this case I am very puzzled :) well, so am I :) but at least, I now know there seems to be problem with disk access. I'll ask some of our windows guys to try some failsave mode or something and find out what is going on... I'll report when I know something. thanks for Your help! n. > > --

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Pekka Enberg
On Thu, May 26, 2011 at 9:11 PM, Avi Kivity wrote: > On 05/26/2011 09:05 PM, Ingo Molnar wrote: >> >> > >> >  I've added some rwlocks because of what Ingo said yesterday about >> >  adding/removing devices after the first initialization phase. >> > >> >  Take MMIO lock for example: Since we can no

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Avi Kivity
On 05/26/2011 09:05 PM, Ingo Molnar wrote: > > I've added some rwlocks because of what Ingo said yesterday about > adding/removing devices after the first initialization phase. > > Take MMIO lock for example: Since we can now run SMP guests, we may > have multiple MMIO exits (one from each VC

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Ingo Molnar
* Sasha Levin wrote: > On Thu, 2011-05-26 at 19:02 +0300, Pekka Enberg wrote: > > On Thu, 26 May 2011, Sasha Levin wrote: > > > Adds a rwlock wrapper which like the mutex wrapper makes rwlock calls > > > similar to their kernel counterparts. > > > > > > Signed-off-by: Sasha Levin > > > > There

Re: [PERF RESULTS] virtio and vhost-net performance enhancements

2011-05-26 Thread Krishna Kumar2
Krishna Kumar2/India/IBM wrote on 05/26/2011 09:51:32 PM: > > Could you please try TCP_RRs as well? > > Right. Here's the result for TCP_RR: The actual transaction rate/second numbers are: _ # RR1 RR2 (%) SD1SD

Re: [PATCH 6/6] kvm tools: Protect IOPORT tree by rwsem

2011-05-26 Thread Sasha Levin
On Thu, 2011-05-26 at 19:01 +0300, Pekka Enberg wrote: > On Thu, 26 May 2011, Sasha Levin wrote: > > Makes ioport thread-safe. > > > > Signed-off-by: Sasha Levin > > --- > > tools/kvm/ioport.c |7 +++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/tools/kvm/ioport

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Sasha Levin
On Thu, 2011-05-26 at 19:02 +0300, Pekka Enberg wrote: > On Thu, 26 May 2011, Sasha Levin wrote: > > Adds a rwlock wrapper which like the mutex wrapper makes rwlock calls > > similar to their kernel counterparts. > > > > Signed-off-by: Sasha Levin > > There's no explanation why a mutex isn't suff

Re: [PERF RESULTS] virtio and vhost-net performance enhancements

2011-05-26 Thread Krishna Kumar2
Shirley Ma wrote on 05/26/2011 09:12:22 PM: > Could you please try TCP_RRs as well? Right. Here's the result for TCP_RR: __ # RR% SD% CPU% __ 1 4.5 -31.4-27.9 2 5.1 -9.7 -5.4 4 6

Re: [PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Pekka Enberg
On Thu, 26 May 2011, Sasha Levin wrote: Adds a rwlock wrapper which like the mutex wrapper makes rwlock calls similar to their kernel counterparts. Signed-off-by: Sasha Levin There's no explanation why a mutex isn't sufficient. The pthread locking primitives aren't all that great in practice

Re: [PATCH 6/6] kvm tools: Protect IOPORT tree by rwsem

2011-05-26 Thread Pekka Enberg
On Thu, 26 May 2011, Sasha Levin wrote: Makes ioport thread-safe. Signed-off-by: Sasha Levin --- tools/kvm/ioport.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tools/kvm/ioport.c b/tools/kvm/ioport.c index 1f13960..db9ff0f 100644 --- a/tools/kvm/ioport.c +++ b/

Re: [PATCH 2/2] kvm tools: Add virtio-9p

2011-05-26 Thread Sasha Levin
On Thu, 2011-05-26 at 08:22 -0700, Venkateswararao Jujjuri wrote: > On 05/26/2011 07:36 AM, Sasha Levin wrote: > > On Thu, 2011-05-26 at 07:28 -0700, Venkateswararao Jujjuri wrote: > >> Any progress on this? May I get more detailed instructions on how > >> you did this trick? Basically booting on

[PERF RESULTS] virtio and vhost-net performance enhancements

2011-05-26 Thread Krishna Kumar2
"Michael S. Tsirkin" wrote on 05/20/2011 04:40:07 AM: > OK, here is the large patchset that implements the virtio spec update > that I sent earlier (the spec itself needs a minor update, will send > that out too next week, but I think we are on the same page here > already). It supercedes the PUB

Re: [PATCH V5 2/6 net-next] netdevice.h: Add zero-copy flag in netdevice

2011-05-26 Thread Shirley Ma
On Thu, 2011-05-26 at 11:49 +0300, Michael S. Tsirkin wrote: > On Wed, May 25, 2011 at 03:49:40PM -0700, Shirley Ma wrote: > > On Fri, 2011-05-20 at 02:41 +0300, Michael S. Tsirkin wrote: > > > So the requirements are > > > - data must be released in a timely fashion (e.g. unlike > virtio-net > > >

Re: Restoring saved guest causes guest to reboot

2011-05-26 Thread Joerg Roedel
On Thu, May 26, 2011 at 05:20:32PM +0200, Markus Schade wrote: > On 05/26/2011 01:28 PM, Markus Schade wrote: >> On 05/26/2011 08:44 AM, Avi Kivity wrote: >>> On 05/25/2011 09:49 AM, Markus Schade wrote: Git bisect tells me that this is the first bad commit: -%<--

Re: [PATCH 2/2] kvm tools: Add virtio-9p

2011-05-26 Thread Venkateswararao Jujjuri
On 05/26/2011 07:36 AM, Sasha Levin wrote: On Thu, 2011-05-26 at 07:28 -0700, Venkateswararao Jujjuri wrote: Any progress on this? May I get more detailed instructions on how you did this trick? Basically booting on 9P/VirtIO. Thanks, JV Ofcourse. This change didn't go into tools/kvm/ since

Re: Restoring saved guest causes guest to reboot

2011-05-26 Thread Markus Schade
On 05/26/2011 01:28 PM, Markus Schade wrote: On 05/26/2011 08:44 AM, Avi Kivity wrote: On 05/25/2011 09:49 AM, Markus Schade wrote: Git bisect tells me that this is the first bad commit: -%<- aff48baa34c033318ad322ecbf2e4bcd891b29ca is the first bad commit Doe

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 03:32:43PM +0200, Nikola Ciprich wrote: > > According to this: > > http://social.msdn.microsoft.com/Forums/en-US/embeddedwindowscomponents/thread/09aae527-ff6d-4003-9e59-962d73d409ed > > such bsod happens because Windows can't access boot device. Your boot > > device is IDE.

Re: [PATCH 2/2] kvm tools: Add virtio-9p

2011-05-26 Thread Sasha Levin
On Thu, 2011-05-26 at 07:28 -0700, Venkateswararao Jujjuri wrote: > Any progress on this? May I get more detailed instructions on how > you did this trick? Basically booting on 9P/VirtIO. > > Thanks, > JV > Ofcourse. This change didn't go into tools/kvm/ since we only support the legacy 9p2000

Re: [PATCH 2/2] kvm tools: Add virtio-9p

2011-05-26 Thread Venkateswararao Jujjuri
On 05/18/2011 02:05 AM, Sasha Levin wrote: On Tue, 2011-05-17 at 20:18 -0500, Eric Van Hensbergen wrote: On Tue, May 17, 2011 at 3:27 PM, Sasha Levin wrote: On Tue, 2011-05-17 at 22:08 +0300, Sasha Levin wrote: 'kvm_9p' isn't created as a device under /dev, it's just a name used internally by

[PATCH 6/6] kvm tools: Protect IOPORT tree by rwsem

2011-05-26 Thread Sasha Levin
Makes ioport thread-safe. Signed-off-by: Sasha Levin --- tools/kvm/ioport.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tools/kvm/ioport.c b/tools/kvm/ioport.c index 1f13960..db9ff0f 100644 --- a/tools/kvm/ioport.c +++ b/tools/kvm/ioport.c @@ -3,6 +3,7 @@ #inc

[PATCH 4/6] kvm tools: Add rwlock wrapper

2011-05-26 Thread Sasha Levin
Adds a rwlock wrapper which like the mutex wrapper makes rwlock calls similar to their kernel counterparts. Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/rwsem.h | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) create mode 100644 tools/kvm

[PATCH 5/6] kvm tools: Protect MMIO tree by rwsem

2011-05-26 Thread Sasha Levin
Make MMIO code thread-safe. Signed-off-by: Sasha Levin --- tools/kvm/mmio.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/tools/kvm/mmio.c b/tools/kvm/mmio.c index ef986bf..59512c3 100644 --- a/tools/kvm/mmio.c +++ b/tools/kvm/mmio.c @@ -1,5 +1,

[PATCH 3/6] kvm tools: Protect IRQ allocations by a mutex

2011-05-26 Thread Sasha Levin
Makes IRQ allocation for new devices thread-safe. Signed-off-by: Sasha Levin --- tools/kvm/irq.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/tools/kvm/irq.c b/tools/kvm/irq.c index 15f4702..f92123d 100644 --- a/tools/kvm/irq.c +++ b/tools/kvm/irq.

[PATCH 2/6] kvm tools: Exit VCPU thread only when SIGKVMEXIT is received

2011-05-26 Thread Sasha Levin
Currently the VCPU loop would exit when the thread received any signal. Change behaviour to exit only when SIGKVMEXIT is received. This change prevents from the guest to terminate when unrelated signals are processed by the thread (for example, when attaching a debugger). Signed-off-by: Sasha Lev

[PATCH 1/6] kvm tools: Prevent double assignment of guest memory info

2011-05-26 Thread Sasha Levin
Use values calculated and assigned to local variables instead of ignoring them. Signed-off-by: Sasha Levin --- tools/kvm/kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/kvm/kvm.c b/tools/kvm/kvm.c index 7284211..1d756e0 100644 --- a/tools/kvm/kvm.c +++ b/too

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> According to this: > http://social.msdn.microsoft.com/Forums/en-US/embeddedwindowscomponents/thread/09aae527-ff6d-4003-9e59-962d73d409ed > such bsod happens because Windows can't access boot device. Your boot > device is IDE. Nothing changed in this area from 13 to 14. Are you sure > your image w

[PATCH v3] Enable CPU SMEP feature support for QEMU-KVM

2011-05-26 Thread Yang, Wei Y
This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in QEMU-KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published soon. SMEP is identified by CPUID leaf 7 EBX[7], which is 0 befo

[Patch v3] Enable CPU SMEP feature for KVM

2011-05-26 Thread Yang, Wei Y
This patchset enables a new CPU feature SMEP (Supervisor Mode Execution Protection) in KVM. SMEP prevents kernel from executing code in application. Updated Intel SDM describes this CPU feature. The document will be published soon. This patchset is based on Fenghua's SMEP patch series, as referr

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 03:15:19PM +0200, Nikola Ciprich wrote: > > No, try to run the one I gave you. Just replace the image file path. I > > do no have much hope it will work though, but worth trying. > OK, I tried, I just had to remove the monitor device. Still, it fails the > same way... Acco

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> No, try to run the one I gave you. Just replace the image file path. I > do no have much hope it will work though, but worth trying. OK, I tried, I just had to remove the monitor device. Still, it fails the same way... n. > > -- > Gleb. > -- > To unsubscribe from this l

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 02:56:40PM +0200, Nikola Ciprich wrote: > > Should be more like that one with correct image path: > huh, now I got a bit lost :) > I tried running both: > /usr/bin/qemu-kvm -M pc-0.13 -enable-kvm -m 4096 -smp > 1,sockets=1,cores=1,threads=1 -name vmtst04 -uuid > 1f8328b8-8

[AUTOTEST PATCH] Broken installs.

2011-05-26 Thread Gerd Hoffmann
Hi, Started playing around with autotest. For starters tried to run the basic install, boot + shutdown tests for a bunch of guests I have iso images laying around here, expecting that working out-of-the-box. Unfortunaly that wasn't the case. RHEL 5.any does't install. Fixed. OpenSUSE 11.1 do

[AUTOTEST PATCH] Fix rhel5 install

2011-05-26 Thread Gerd Hoffmann
There is no ntpdate.rpm in RHEL-5, ntp.rpm has /usr/sbin/ntpdate. --- client/tests/kvm/unattended/RHEL-5-series.ks |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/unattended/RHEL-5-series.ks b/client/tests/kvm/unattended/RHEL-5-series.ks index 1d8d41b..f

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> Should be more like that one with correct image path: huh, now I got a bit lost :) I tried running both: /usr/bin/qemu-kvm -M pc-0.13 -enable-kvm -m 4096 -smp 1,sockets=1,cores=1,threads=1 -name vmtst04 -uuid 1f8328b8-8849-11e0-91e9-00259009d78c -nodefconfig -nodefaults -chardev socket,id=char

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 02:46:30PM +0200, Nikola Ciprich wrote: > > Hmm. And what if you start qemu directly (without using libvirt) with 0.13 > > command line? > /usr/bin/qemu-kvm -M pc-0.13 -enable-kvm -m 4096 -boot c -drive > file=/dev/vgshared/vmtst04-1,if=none,id=drive-ide0-0-0,format=raw -de

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> Hmm. And what if you start qemu directly (without using libvirt) with 0.13 > command line? /usr/bin/qemu-kvm -M pc-0.13 -enable-kvm -m 4096 -boot c -drive file=/dev/vgshared/vmtst04-1,if=none,id=drive-ide0-0-0,format=raw -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -vnc 0

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 02:30:00PM +0200, Nikola Ciprich wrote: > > May be libvirt does something funny with selinux. > it shouldn't, I don't have selinux enabled in host kernel at all.. > > > Try to run with -M pc-0.13. > tried now, same result... > > Hmm. And what if you start qemu directly (

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> May be libvirt does something funny with selinux. it shouldn't, I don't have selinux enabled in host kernel at all.. > Try to run with -M pc-0.13. tried now, same result... > > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the bo

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 02:03:57PM +0200, Nikola Ciprich wrote: > > This BSOD usually indicates that Windows can't write to the boot disk. > > This is usually happens if qemu has no permission to write to the image > > file. But if you are starting qemu as a root this is probably is not the > OK, I

Re: Restoring saved guest causes guest to reboot

2011-05-26 Thread Markus Schade
On 05/26/2011 08:44 AM, Avi Kivity wrote: On 05/25/2011 09:49 AM, Markus Schade wrote: Git bisect tells me that this is the first bad commit: -%<- aff48baa34c033318ad322ecbf2e4bcd891b29ca is the first bad commit commit aff48baa34c033318ad322ecbf2e4bcd891b29ca Aut

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
> This BSOD usually indicates that Windows can't write to the boot disk. > This is usually happens if qemu has no permission to write to the image > file. But if you are starting qemu as a root this is probably is not the OK, I see. > case. So what is your 0.14 command line? here it goes: /usr/bin/

KVM: x86: use proper port value when checking io instruction permission (v3)

2011-05-26 Thread Marcelo Tosatti
Commit fa4491a6b667304 moved the permission check for io instructions to the ->check_perm callback. It failed to copy the port value from RDX register for string and "in,out ax,dx" instructions. Fix it by reading RDX register at decode stage when appropriate. Fixes FC8.32 installation. diff --g

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 01:50:35PM +0200, Nikola Ciprich wrote: > OK, I tried copying the whole image to my test box running 0.14.0 again and > it crashes with exactly the same BSOD! > So now I have the test environment to play with... > What should I check/try now? > n. > PS: I'm not sure what Yo

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
OK, I tried copying the whole image to my test box running 0.14.0 again and it crashes with exactly the same BSOD! So now I have the test environment to play with... What should I check/try now? n. PS: I'm not sure what You mean by permissions, but I'm using LVM partitions and qemu-kvm is started

Re: KVM: x86: use proper port value when checking io instruction permission (v2)

2011-05-26 Thread Marcelo Tosatti
On Thu, May 26, 2011 at 09:49:21AM +0200, Paolo Bonzini wrote: > On 05/26/2011 09:07 AM, Gleb Natapov wrote: > >> Still, op_bytes is irrelevant for > >> SrcDX, the 16-bit version is always used. > > > >If SrcDX/DstDX will be used only for decoding in/out instruction > >then yes. Otherwise it is nic

Re: Video card passthrough success

2011-05-26 Thread Avi Kivity
On 05/20/2011 05:56 AM, Luke-Jr wrote: Finally decided to see just how much of the Radeon was working (eg, if it was *just* OpenCL or not), and I am happy to confirm that both video output and OpenGL acceleration are fully functional inside KVM. That's really surprising (and a really good surpr

[PATCH v3 7/8] kvm tools: Use dynamic IO port allocation in virtio-console

2011-05-26 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/ioport.h |2 -- tools/kvm/virtio/console.c | 11 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/kvm/include/kvm/ioport.h b/tools/kvm/include/kvm/ioport.h index 310f75d..4fccbd6 100644 --- a/tools/kvm/

[PATCH v3 8/8] kvm tools: Use dynamic IO port allocation in virtio-net

2011-05-26 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/ioport.h |3 --- tools/kvm/virtio/net.c | 12 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/kvm/include/kvm/ioport.h b/tools/kvm/include/kvm/ioport.h index 4fccbd6..59f118f 100644 --- a/tools/kv

[PATCH v3 6/8] kvm tools: Use dynamic IO port allocation in 9p driver

2011-05-26 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/ioport.h |2 -- tools/kvm/virtio/9p.c | 12 +++- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/kvm/include/kvm/ioport.h b/tools/kvm/include/kvm/ioport.h index 84eb65a..310f75d 100644 --- a/tools/kvm

[PATCH v3 5/8] kvm tools: Use dynamic IO port allocation in vesa driver

2011-05-26 Thread Sasha Levin
Signed-off-by: Sasha Levin --- tools/kvm/hw/vesa.c|7 +++ tools/kvm/include/kvm/ioport.h |2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/kvm/hw/vesa.c b/tools/kvm/hw/vesa.c index ec4788c..85fe1a9 100644 --- a/tools/kvm/hw/vesa.c +++ b/tools/kvm/

[PATCH v3 4/8] kvm tools: Add support for multiple virtio-rng devices

2011-05-26 Thread Sasha Levin
Since multiple hardware rng devices of the same type are currently unsupported by the kernel, this serves more as an example of a basic virtio driver under kvm tools and can be used to debug the PCI layer. Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/ioport.h|2 - tools/kvm/i

[PATCH v3 3/8] kvm tools: Use ioport context to control blk devices

2011-05-26 Thread Sasha Levin
Since ioports now has the ability to pass context to its callbacks, we can implement multiple blk devices more efficiently. We can get a ptr to the 'current' blk dev on each ioport call, which means that we don't need to keep track of the blk device allocation and ioport distribution within the mo

[PATCH v3 2/8] kvm tools: Add basic ioport dynamic allocation

2011-05-26 Thread Sasha Levin
Add a very simple allocation of ioports. This prevents the need to coordinate ioports between different modules. Signed-off-by: Sasha Levin --- tools/kvm/include/kvm/ioport.h |7 ++- tools/kvm/ioport.c | 24 +++- 2 files changed, 29 insertions(+), 2 del

[PATCH v3 1/8] kvm tools: Add optional parameter used in ioport callbacks

2011-05-26 Thread Sasha Levin
Allow specifying an optional parameter when registering an ioport range. The callback functions provided by the registering module will be called with the same parameter. This may be used to keep context during callbacks on IO operations. Signed-off-by: Sasha Levin --- tools/kvm/hw/rtc.c

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 12:20:56PM +0200, Nikola Ciprich wrote: > > You can make a copy from your production image, install 0.14 version in > > different place from 0.13 and experiment. > yup, I think I've tried it also with exact copy and wasn't able to reproduce > it, but I'll try it again and r

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
Hello Gleb! > What is you command line? currently it's: /usr/bin/qemu-kvm -S -M pc-0.13 -enable-kvm -m 4096 -smp 1,sockets=1,cores=1,threads=1 -name vmwts02 -uuid 1e501300-dc48-11df-a690-00304834195b -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/vmwts02.monit

Re: qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 11:59:10AM +0200, Nikola Ciprich wrote: > Hello, > after I tried updating our production host to 0.14.0 or 0.14.1, our windows > terminal server stopped booting. > Here's BSOD screen: > http://nik.lbox.cz/public/wincrash.png > reverting to 0.13.5 fixes the problem. > I can'

qemu-kvm-0.14.x regression - windows 2K8 R2 stopped booting

2011-05-26 Thread Nikola Ciprich
Hello, after I tried updating our production host to 0.14.0 or 0.14.1, our windows terminal server stopped booting. Here's BSOD screen: http://nik.lbox.cz/public/wincrash.png reverting to 0.13.5 fixes the problem. I can't reproduce this on testing hardware though :( exact guest version: Microsoft

Re: KVM: x86: use proper port value when checking io instruction permission (v2)

2011-05-26 Thread Gleb Natapov
On Thu, May 26, 2011 at 11:00:24AM +0200, Paolo Bonzini wrote: > On 05/26/2011 10:26 AM, Gleb Natapov wrote: > >Why would c->dst.bytes != c->src.bytes for cwd/cdq/cqo if we'll set > >c->dst.bytes to op_bytes during decode? > > Duh, you're right, cwd/cdq/cqo uses SrcAcc which has > >

Re: [PATCH v2 1/8] kvm tools: Add optional parameter used in ioport callbacks

2011-05-26 Thread Pekka Enberg
Hi Sasha, On Thu, May 26, 2011 at 12:38 PM, Sasha Levin wrote: >>> One option here is to rename 'struct ioport_entry' to 'struct ioport' >>> and pass a pointer to that as the first argument to all of the ops. >>> That's what most APIs in the kernel do anyway. >> >> Why do it like that? this way u

Re: [PATCH v2 1/8] kvm tools: Add optional parameter used in ioport callbacks

2011-05-26 Thread Pekka Enberg
On Thu, May 26, 2011 at 12:38 PM, Sasha Levin wrote: >> One option here is to rename 'struct ioport_entry' to 'struct ioport' >> and pass a pointer to that as the first argument to all of the ops. >> That's what most APIs in the kernel do anyway. > > Why do it like that? this way users of the call

  1   2   >