Re: [PATCH] KVM: MMU: Do not unconditionally read PDPTE from guest memory

On 07/29/2011 02:31 PM, Roedel, Joerg wrote: On Thu, Jul 28, 2011 at 04:36:17AM -0400, Avi Kivity wrote: Architecturally, PDPTEs are cached in the PDPTRs when CR3 is reloaded. On SVM, it is not possible to implement this, but on VMX this is possible and was indeed implemented until nested

Re: Windows7 crashes inside the VM when starting a certain program

On 07/30/2011 03:29 PM, André Weidemann wrote: Looks like it tries to read MSR_LASTBRANCH_TOS MSR which kvm does not support. Do you see something interesting in dmesg? I wonder how availability of the MSR should be checked. You are right about the MSR. The log file from the time of

Re: Windows7 crashes inside the VM when starting a certain program

On Sun, Jul 31, 2011 at 11:16:00AM +0300, Avi Kivity wrote: On 07/30/2011 03:29 PM, André Weidemann wrote: Looks like it tries to read MSR_LASTBRANCH_TOS MSR which kvm does not support. Do you see something interesting in dmesg? I wonder how availability of the MSR should be checked. You

Re: [PATCH 0/4] KVM: x86 emulator: Clean up decoder a bit

On 07/30/2011 11:58 AM, Takuya Yoshikawa wrote: Passed emulator.flat test: SUMMARY: 88 tests, 0 failures Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH 4/4] KVM: x86 emulator: Make x86_decode_insn() return proper macros

On 07/30/2011 12:03 PM, Takuya Yoshikawa wrote: From: Takuya Yoshikawayoshikawa.tak...@oss.ntt.co.jp Return EMULATION_OK/FAILED consistently. Also treat instruction fetch errors, not restricted to X86EMUL_UNHANDLEABLE, as EMULATION_FAILED; although this cannot happen in practice, the current

Re: KVM: x86: report valid microcode update ID

On 07/30/2011 01:44 AM, Marcelo Tosatti wrote: Windows Server 2008 SP2 checked build with smp 1 BSOD's during boot due to lack of microcode update: *** Assertion failed: The system BIOS on this machine does not properly support the processor. The system BIOS did not load any microcode update.

Re: Nested VMX - L1 hangs on running L2

On Fri, Jul 29, 2011, Zachary Amsden wrote about Re: Nested VMX - L1 hangs on running L2: ... In that case, you need to distinguish between reads of the TSC MSR by the guest and reads by the host (as done internally to track drift and ... Unfortunately, the layering currently doesn't seem to

Re: [PATCH 4/4] KVM: x86 emulator: Make x86_decode_insn() return proper macros

On Sun, 31 Jul 2011 11:48:40 +0300 Avi Kivity a...@redhat.com wrote: On 07/30/2011 12:03 PM, Takuya Yoshikawa wrote: From: Takuya Yoshikawayoshikawa.tak...@oss.ntt.co.jp Return EMULATION_OK/FAILED consistently. Also treat instruction fetch errors, not restricted to X86EMUL_UNHANDLEABLE,

Re: kvm PCI assignment VFIO ramblings

On 07/30/2011 02:58 AM, Benjamin Herrenschmidt wrote: - Having a magic heuristic in libvirt to figure out those constraints is WRONG. This reeks of XFree 4 PCI layer trying to duplicate the kernel knowledge of PCI resource management and getting it wrong in many many cases, something that took

Re: Strange MySQL behaviour

On 07/29/2011 02:18 PM, Boris Dolgov wrote: Hello! On Thu, Jul 28, 2011 at 11:34, Avi Kivitya...@redhat.com wrote: Looks like you are blocked on disk. What does iostat say about disk utilization (in both guest and host)? I also thought so, but host cpu states doesn't show any disk

[ANNOUNCE] qemu-kvm-0.15.0-rc1

qemu-kvm-0.15.0-rc1 is now available. This release is based on the upstream qemu 0.15.0-rc1, plus kvm-specific enhancements. Please see http://wiki.qemu.org/ChangeLog/0.15 for a list of changes in this release. This release can be used with the kvm kernel modules provided by your distribution

[PATCH 00/39] Memory API, batch 2: PCI devices

This is a mostly mindless conversion of all QEMU PCI devices to the memory API. After this patchset is applied, it is no longer possible to create a PCI device using the old API. An immediate benefit is that PCI BARs that overlap each other are now handled correctly: currently, the sequence

[PATCH 01/39] pci: add API to get a BAR's mapped address

This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c |5 + hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git

[PATCH 04/39] cirrus: simplify mmio BAR access functions

Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 78 +- 1 files changed, 8 insertions(+), 70 deletions(-) diff --git

[PATCH 02/39] vmsvga: don't remember pci BAR address in callback any more

We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Signed-off-by: Avi Kivity a...@redhat.com --- hw/vmware_vga.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index

[PATCH 03/39] vga: convert vga and its derivatives to the memory API

Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the memory API takes care of that for us. [jan:

[PATCH 05/39] cirrus: simplify bitblt BAR access functions

Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 81 +-- 1 files changed, 13 insertions(+), 68 deletions(-) diff --git

[PATCH 10/39] exec.c: fix initialization of system I/O memory region

Signed-off-by: Avi Kivity a...@redhat.com --- exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index 2fd4adb..11f6641 100644 --- a/exec.c +++ b/exec.c @@ -3823,7 +3823,7 @@ static void memory_map_init(void) set_system_memory_map(system_memory);

[PATCH 08/39] cirrus: simplify linear framebuffer access functions

Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 74 ++- 1 files changed, 8 insertions(+), 66 deletions(-) diff --git

[PATCH 06/39] cirrus: simplify vga window mmio access functions

Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 79 +++--- 1 files changed, 11 insertions(+), 68 deletions(-) diff --git

[PATCH 07/39] vga: simplify vga window mmio access functions

Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c |4 +- hw/vga.c| 56

[PATCH 09/39] Integrate I/O memory regions into qemu

get_system_io() returns the root I/O memory region. Signed-off-by: Avi Kivity a...@redhat.com --- exec-memory.h |2 ++ exec.c| 10 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/exec-memory.h b/exec-memory.h index c439aba..999fd69 100644 ---

[PATCH 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region()

Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 43 +++ hw/pci.h |1 + hw/pci_internals.h |3 ++- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 2659d96..980840f 100644 ---

[PATCH 13/39] rtl8139: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 5214b8c..dfbab90 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -474,7

[PATCH 14/39] ac97: convert to memory API

fixes BAR sizing as well. Signed-off-by: Avi Kivity a...@redhat.com --- hw/ac97.c | 88 +++- 1 files changed, 51 insertions(+), 37 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 0b59896..bcddaa6 100644 --- a/hw/ac97.c +++

[PATCH 17/39] es1370: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/es1370.c | 43 +-- 1 files changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 1ed62b7..6a01797 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -268,6 +268,7 @@ struct

[PATCH 22/39] intel-hda: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/intel-hda.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 5a2bc3a..1e4c71e 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -177,7 +177,7 @@

[PATCH 16/39] eepro100: convert to memory API

Note: the existing code aliases the flash BAR into the MMIO bar. This is probably a bug. This patch does not correct the problem. Signed-off-by: Avi Kivity a...@redhat.com --- hw/eepro100.c | 182 - 1 files changed, 37 insertions(+), 145

[PATCH 11/39] pci: pass I/O address space to new PCI bus

This lets us register BARs in the I/O address space. Signed-off-by: Avi Kivity a...@redhat.com --- hw/apb_pci.c |1 + hw/bonito.c|1 + hw/grackle_pci.c |8 ++-- hw/gt64xxx.c |4 +++- hw/pc.h|4 +++- hw/pc_piix.c |6 +-

[PATCH 15/39] e1000: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/e1000.c | 114 +-- 1 files changed, 48 insertions(+), 66 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 96d84f9..dfc082b 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -82,7 +82,8 @@

[PATCH 19/39] ivshmem: convert to memory API

excluding msix. Signed-off-by: Avi Kivity a...@redhat.com --- hw/ivshmem.c | 148 -- 1 files changed, 50 insertions(+), 98 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 3055dd2..f80e7b6 100644 --- a/hw/ivshmem.c +++

[PATCH 29/39] sun4u: convert to memory API

fixes memory leak on repeated BAR map/unmap Signed-off-by: Avi Kivity a...@redhat.com --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index d7dcaf0..74a06a8 100644 ---

[PATCH 21/39] ahci: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/ide/ahci.c | 31 +-- hw/ide/ahci.h |2 +- hw/ide/ich.c |3 +-- 3 files changed, 15 insertions(+), 21 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1f008a3..e207ca0 100644 --- a/hw/ide/ahci.c

[PATCH 27/39] i6300esb: convert to memory API

Also add missing destructor. Signed-off-by: Avi Kivity a...@redhat.com --- hw/wdt_i6300esb.c | 43 +-- 1 files changed, 29 insertions(+), 14 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 53786ce..abc2e17 100644 ---

[PATCH 25/39] ne2000: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/ne2000-isa.c | 14 +++--- hw/ne2000.c | 77 +- hw/ne2000.h |8 + 3 files changed, 59 insertions(+), 40 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index

[PATCH 20/39] virtio-pci: convert to memory API

except msix. [jan: fix build] Signed-off-by: Avi Kivity a...@redhat.com --- hw/virtio-pci.c | 74 ++ hw/virtio-pci.h |2 +- 2 files changed, 31 insertions(+), 45 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index

[PATCH 18/39] ide: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/ide/cmd646.c | 208 +++ hw/ide/pci.c| 25 --- hw/ide/pci.h| 19 - hw/ide/piix.c | 64 + hw/ide/via.c| 65 + 5 files changed, 261

[PATCH 28/39] isa-mmio: concert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/isa.h |2 ++ hw/isa_mmio.c | 30 +++--- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index d2b6126..f1f2181 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -4,6 +4,7 @@ /* ISA bus

[PATCH 39/39] pci: remove support for pre memory API BARs

Not used anymore. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 33 ++--- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6ed08ae..e6a3e56 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -848,18 +848,7 @@ static void

[PATCH 32/39] xen-platform: convert to memory API

Since this device bypasses PCI and registers I/O ports directly with the system bus, it needs further attention. Signed-off-by: Avi Kivity a...@redhat.com --- hw/xen_platform.c | 84 - 1 files changed, 51 insertions(+), 33 deletions(-) diff

[PATCH 23/39] lsi53c895a: convert to memory API

An optimization that fast-pathed DMA reads from the SCRIPTS memory was removed int the process. Likely it breaks with iommus anyway. Signed-off-by: Avi Kivity a...@redhat.com --- hw/lsi53c895a.c | 258 --- 1 files changed, 56 insertions(+),

[PATCH 26/39] pcnet: convert to memory API

Also related chips. Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c | 31 ++- hw/pcnet-pci.c | 74 +-- hw/pcnet.h |4 ++- 3 files changed, 61 insertions(+), 48 deletions(-) diff --git a/hw/lance.c

[PATCH 34/39] pci: remove pci_register_bar_simple()

Superceded by pci_register_bar_region(). --- hw/pci.c | 17 - hw/pci.h |3 --- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 980840f..6aca1af 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -903,7 +903,6 @@ void pci_register_bar(PCIDevice

[PATCH 35/39] pci: convert pci rom to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 20 +++- hw/pci.h |3 ++- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6aca1af..481eb7e 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1857,11 +1857,6 @@ static uint8_t

[PATCH 36/39] pci: remove pci_register_bar()

Superceded by pci_register_bar_region(). The implementations are folded together. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 42 +- hw/pci.h |3 --- 2 files changed, 17 insertions(+), 28 deletions(-) diff --git a/hw/pci.c b/hw/pci.c

[PATCH 37/39] pci: fold BAR mapping function into its caller

There is only one function, so no need for a function pointer. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 25 + hw/pci.h |1 - 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e9e4874..e6a759a 100644 ---

[PATCH 30/39] ehci: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/usb-ehci.c | 36 +--- 1 files changed, 9 insertions(+), 27 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 8b0dcc3..025ed1f 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -368,8 +368,7 @@ struct

[PATCH 24/39] ppc: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/cuda.c |6 ++- hw/escc.c | 42 +-- hw/escc.h |2 +- hw/heathrow_pic.c | 29 -- hw/ide.h |2 +- hw/ide/macio.c| 36 --- hw/mac_dbdma.c

[PATCH 38/39] pci: rename pci_register_bar_region() to pci_register_bar()

Signed-off-by: Avi Kivity a...@redhat.com --- hw/ac97.c |4 ++-- hw/cirrus_vga.c |5 ++--- hw/e1000.c|5 ++--- hw/eepro100.c |7 +++ hw/es1370.c |2 +- hw/ide/cmd646.c | 14 +- hw/ide/ich.c |2 +- hw/ide/piix.c |

[PATCH 31/39] uhci: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/usb-uhci.c | 42 -- 1 files changed, 28 insertions(+), 14 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index da74c57..96a17bd 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -132,6 +132,7 @@

[PATCH 33/39] msix: convert to memory API

The msix table is defined as a subregion, to allow for a BAR that mixes device specific regions with the msix table. Signed-off-by: Avi Kivity a...@redhat.com --- hw/ivshmem.c| 11 + hw/msix.c | 64 +++ hw/msix.h |

Re: [PATCH 00/39] Memory API, batch 2: PCI devices

79 files changed, 1654 insertions(+), 2082 deletions(-) Unexpected side effect... -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/39] vga: convert vga and its derivatives to the memory API

On 2011-07-31 19:57, Avi Kivity wrote: Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

On 07/31/2011 09:42 PM, Jan Kiszka wrote: On 2011-07-31 19:57, Avi Kivity wrote: Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

On 2011-07-31 20:46, Avi Kivity wrote: On 07/31/2011 09:42 PM, Jan Kiszka wrote: On 2011-07-31 19:57, Avi Kivity wrote: Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region.

Re: Nested VMX - L1 hangs on running L2

This patch looks good, with one comment noted inline below. Are there no other call sites for kvm_get_msr() or which alias some other function to kvm_get_msr(MSR_IA32_TSC) ? Did I miss the first patch? Zach On Sun, Jul 31, 2011 at 6:48 AM, Nadav Har'El n...@math.technion.ac.il wrote: On Fri,

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

On 07/31/2011 09:48 PM, Jan Kiszka wrote: I haven't. How does unconditionally dirty the remapped slot sound? I think it isn't introduced by this patchset, yes? The patch removes the explicit sync from the cirrus code. But the underlying issue is older of course. Ah. So I'll detect

Re: [PATCH v3 0/2] The intro for QEMU disk I/O limits

* Zhi Yong Wu wu...@linux.vnet.ibm.com [2011-07-28 05:53]: The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one

[PATCH] memory: synchronize dirty bitmap before unmapping a range

When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the dirty bitmap to avoid losing information forever. Fixes grub2 screen update. Signed-off-by: Avi Kivity a...@redhat.com --- Please apply before the PCI batch to avoid bisectability issues (and don't pull, since that

Re: Nested VMX - L1 hangs on running L2

On Sun, Jul 31, 2011, Zachary Amsden wrote about Re: Nested VMX - L1 hangs on running L2: This patch looks good, with one comment noted inline below. Are there no other call sites for kvm_get_msr() or which alias some other function to kvm_get_msr(MSR_IA32_TSC) ? This is all I found, but

Re: [Qemu-devel] [PATCH 00/39] Memory API, batch 2: PCI devices

On 07/31/2011 01:02 PM, Avi Kivity wrote: 79 files changed, 1654 insertions(+), 2082 deletions(-) Unexpected side effect... But always welcome :-) Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [Qemu-devel] [PATCH 09/39] Integrate I/O memory regions into qemu

On 07/31/2011 10:57 AM, Avi Kivity wrote: +system_io = qemu_malloc(sizeof(*system_io)); +memory_region_init(system_memory, io, 65536); +set_system_io_map(system_io); Cut-paste error on that second line. r~ -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: kvm PCI assignment VFIO ramblings

On Sat, Jul 30, 2011 at 09:58:53AM +1000, Benjamin Herrenschmidt wrote: [snip] That current hack won't work well if two devices share an iommu. Note that we have an additional constraint here due to our paravirt interfaces (specificed in PAPR) which is that PE domains must have a common

Re: [RFC PATCH]vhost-blk: In-kernel accelerator for virtio block device

On 07/30/2011 02:12 AM, Badari Pulavarty wrote: Hi Liu Yuan, I am glad to see that you started looking at vhost-blk. I did an attempt year ago to improve block performance using vhost-blk approach. http://lwn.net/Articles/379864/ http://lwn.net/Articles/382543/ I will take a closer look