Re: [net-next RFC PATCH 0/7] multiqueue support for tun/tap

2011-08-13 Thread Jason Wang
- Original Message - > On Fri, 2011-08-12 at 09:54 +0800, Jason Wang wrote: > > As multi-queue nics were commonly used for high-end servers, > > current single queue based tap can not satisfy the > > requirement of scaling guest network performance as the > > numbers of vcpus increase. So

Re: [net-next RFC PATCH 4/7] tuntap: multiqueue support

2011-08-13 Thread Jason Wang
- Original Message - > On Fri, Aug 12, 2011 at 09:55:20AM +0800, Jason Wang wrote: > > With the abstraction that each socket were a backend of a > > queue for userspace, this patch adds multiqueue support for > > tap device by allowing multiple sockets to be attached to a > > tap device.

Re: [net-next RFC PATCH 4/7] tuntap: multiqueue support

2011-08-13 Thread Jason Wang
- Original Message - > Le vendredi 12 août 2011 à 09:55 +0800, Jason Wang a écrit : > > >+ rxq = skb_get_rxhash(skb); > >+ if (rxq) { > >+ tfile = rcu_dereference(tun->tfiles[rxq % numqueues]); > >+ if (tfile) > >+ goto out; > >+ } > > You can avoid an expensive divide with following tr

Re: [Qemu-devel] [net-next RFC PATCH 7/7] virtio-net changes

2011-08-13 Thread Jason Wang
- Original Message - > On Fri, 2011-08-12 at 09:55 +0800, Jason Wang wrote: > > From: Krishna Kumar > > > > Implement mq virtio-net driver. > > > > Though struct virtio_net_config changes, it works with the old > > qemu since the last element is not accessed unless qemu sets > > VIRTIO_N

[PATCH v2] posix-aio-compat: fix latency issues

2011-08-13 Thread Avi Kivity
In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio threads to compete for one cpu. - we can create up to max_threads (64) aio threads in one go;

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-13 Thread Rusty Russell
On Sat, 13 Aug 2011 11:51:01 +0300, Sasha Levin wrote: > The MAC of a virtio-net device is located at the first field of the device > specific header. This header is located at offset 20 if the device doesn't > support MSI-X or offset 24 if it does. Erk. This means, in general, we have to do vir

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-13 Thread Avi Kivity
On 08/12/2011 06:24 AM, Anthony Liguori wrote: On 08/08/2011 06:37 AM, Avi Kivity wrote: +static void spawn_thread_bh_fn(void *opaque) +{ +mutex_lock(&lock); +do_spawn_thread(); +mutex_unlock(&lock); +} The locking here is odd. Why not call do_spawn_thread() without the lock, an

Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-13 Thread Avi Kivity
On 08/12/2011 06:48 AM, Anthony Liguori wrote: target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; +bool readable; @@ -125,6 +125,7 @@ struct FlatRange { In a follow up, it might be good to add a comment explaining that this whole readable thing i

gfx card passthrough broken with latest head

2011-08-13 Thread André Weidemann
Hi, I pulled latest git yesterday and noticed that graphics card pass through does not work anymore. The VM hangs (probably when initializing the gfx card) when passing a graphics card to the VM. I started to do a git bisect but device assignment does not work at all when doing it. I starte

[PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-13 Thread Sasha Levin
The MAC of a virtio-net device is located at the first field of the device specific header. This header is located at offset 20 if the device doesn't support MSI-X or offset 24 if it does. Current code in virtnet_probe() used to probe the MAC before checking for MSI-X, which means that the read wa