Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-10-03 Thread Rusty Russell
On Sun, 2 Oct 2011 11:09:00 +0200, "Michael S. Tsirkin" wrote: > On Mon, Sep 19, 2011 at 05:19:49PM +0930, Rusty Russell wrote: > > On Mon, 19 Sep 2011 09:01:50 +0300, "Michael S. Tsirkin" > > wrote: > > > On Mon, Sep 19, 2011 at 01:05:17PM +0930, Rusty Russell wrote: > > > > On Sat, 20 Aug 2011

KVM call agenda for October 4th

2011-10-03 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/1] [PULL] qemu-kvm.git uq/master queue

2011-10-03 Thread Marcelo Tosatti
The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7: etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200) are available in the git repository at: git://github.com/avikivity/qemu.git uq/master Liu, Jinsong (1): kvm: support TSC deadline MSR target-i

[PATCH 1/1] kvm: support TSC deadline MSR

2011-10-03 Thread Marcelo Tosatti
From: "Liu, Jinsong" KVM add emulation of lapic tsc deadline timer for guest. This patch is co-operation work at qemu side. Signed-off-by: Liu, Jinsong Signed-off-by: Marcelo Tosatti --- target-i386/cpu.h |4 +++- target-i386/kvm.c | 14 ++ target-i386/machine.c |

Re: qemu-kvm: Remaining relevant bits in kvm/

2011-10-03 Thread Marcelo Tosatti
On Sun, Oct 02, 2011 at 02:33:44PM +0200, Avi Kivity wrote: > On 09/29/2011 08:10 PM, Marcelo Tosatti wrote: > >On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote: > >> Hi all, > >> > >> in order to reduce the diff between qemu-kvm.git and upstream, > >> getting rid of the kvm subdirecto

Re: [PATCH] qemu-kvm: Drop redundant cpuid filtering from cpu_x86_cpuid

2011-10-03 Thread Marcelo Tosatti
On Wed, Sep 28, 2011 at 04:53:30PM +0200, Jan Kiszka wrote: > This is already done in kvm_arch_init_vcpu based on the kernel-reported > supported features. > > Signed-off-by: Jan Kiszka Applied all 3, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a mes

Re: [PATCH v2 0/2] pci-assign: Fix MSI-X support

2011-10-03 Thread Marcelo Tosatti
On Thu, Sep 22, 2011 at 12:08:55PM -0600, Alex Williamson wrote: > Assigned device MSI-X support hasn't been working, this fixes > it. I believe this should also fix: > > https://bugs.launchpad.net/qemu/+bug/830558 > > v2: >Incorporate comments from Jan > > WRT exposing KVM_CAP_DEVICE_MSIX,

Re: [PATCH] qemu-kvm: Remove broken ia64 fragments

2011-10-03 Thread Marcelo Tosatti
On Fri, Sep 23, 2011 at 05:19:53PM +0200, Jan Kiszka wrote: > This target no longer builds since (at least) 0.14, and no one bothered > fixing it. Remove any diff to upstream before ia64 emulation pops up > there and causes serious merge pain here. > > Signed-off-by: Jan Kiszka Jan, Can you pl

Re: [PATCH] KVM: emulate lapic tsc deadline timer for guest

2011-10-03 Thread Marcelo Tosatti
On Sun, Sep 25, 2011 at 10:47:46PM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > > On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote: > >> Marcelo Tosatti wrote: > >>> On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote: > > From 4d5b83aba40ce0d421add9a41a6c591a8590a

KVM: Another fix for tsc deadline timer without irqchip_in_kernel()

2011-10-03 Thread Marcelo Tosatti
get/set MSR functions not prepared to deal with non existance of in kernel irqchip. Signed-off-by: Marcelo Tosatti diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 92390dc..54abb40 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -963,6 +963,8 @@ void kvm_free_lapic

Re: [PATCH v2 2/2] virtio-net: Prevent NULL dereference

2011-10-03 Thread Michael S. Tsirkin
On Wed, Sep 28, 2011 at 05:40:55PM +0300, Sasha Levin wrote: > This patch prevents a NULL dereference when the user has passed a length > longer than an actual buffer to virtio-net. > > Cc: Rusty Russell > Cc: "Michael S. Tsirkin" > Cc: virtualizat...@lists.linux-foundation.org > Cc: net...@vger

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

2011-10-03 Thread Michael S. Tsirkin
On Wed, Sep 28, 2011 at 05:40:54PM +0300, Sasha Levin wrote: > This patch verifies that the length of a buffer stored in a linked list > of pages is small enough to fit into a skb. > > If the size is larger than a max size of a skb, it means that we shouldn't > go ahead building skbs anyway since

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

2011-10-03 Thread Michael S. Tsirkin
On Mon, Oct 03, 2011 at 02:19:51PM -0400, David Miller wrote: > From: Sasha Levin > Date: Wed, 28 Sep 2011 17:40:54 +0300 > > > This patch verifies that the length of a buffer stored in a linked list > > of pages is small enough to fit into a skb. > > > > If the size is larger than a max size of

Re: [PATCH v2 2/2] virtio-net: Prevent NULL dereference

2011-10-03 Thread Michael S. Tsirkin
On Wed, Sep 28, 2011 at 05:40:55PM +0300, Sasha Levin wrote: > This patch prevents a NULL dereference when the user has passed a length > longer than an actual buffer to virtio-net. > > Cc: Rusty Russell > Cc: "Michael S. Tsirkin" > Cc: virtualizat...@lists.linux-foundation.org > Cc: net...@vger

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

2011-10-03 Thread David Miller
From: Sasha Levin Date: Wed, 28 Sep 2011 17:40:54 +0300 > This patch verifies that the length of a buffer stored in a linked list > of pages is small enough to fit into a skb. > > If the size is larger than a max size of a skb, it means that we shouldn't > go ahead building skbs anyway since we

Re: [PATCH] qemu-kvm: device assignment: add 82599 PCIe Cap struct quirk

2011-10-03 Thread Don Dutile
On 10/02/2011 05:56 AM, Michael S. Tsirkin wrote: On Wed, Sep 28, 2011 at 08:20:33PM -0400, Donald Dutile wrote: commit f9c29774d2174df6ffc20becec20928948198914 changed the PCIe Capability structure version check from if> 2 fail, to if ==1, size=x, if ==2, size=y, else fail. Turns out the 82599

Re: [PATCH 6/9] perf, intel: Use GO/HO bits in perf-ctr

2011-10-03 Thread Gleb Natapov
On Mon, Oct 03, 2011 at 05:06:27PM +0200, Avi Kivity wrote: > On 10/03/2011 03:49 PM, Gleb Natapov wrote: > >Intel does not have guest/host-only bit in perf counters like AMD > >does. To support GO/HO bits KVM needs to switch EVENTSELn values > >(or PERF_GLOBAL_CTRL if available) at a guest entry.

Re: [PATCH 8/9] KVM, VMX: Add support for guest/host-only profiling

2011-10-03 Thread Gleb Natapov
On Mon, Oct 03, 2011 at 05:00:25PM +0200, Avi Kivity wrote: > On 10/03/2011 03:49 PM, Gleb Natapov wrote: > >Support guest/host-only profiling by switch perf msrs on > >a guest entry if needed. > > > >@@ -6052,6 +6056,26 @@ static void vmx_cancel_injection(struct kvm_vcpu > >*vcpu) > > vmcs_wr

Re: [PATCH 6/9] perf, intel: Use GO/HO bits in perf-ctr

2011-10-03 Thread Avi Kivity
On 10/03/2011 03:49 PM, Gleb Natapov wrote: Intel does not have guest/host-only bit in perf counters like AMD does. To support GO/HO bits KVM needs to switch EVENTSELn values (or PERF_GLOBAL_CTRL if available) at a guest entry. If a counter is configured to count only in a guest mode it stays di

Re: [PATCH 8/9] KVM, VMX: Add support for guest/host-only profiling

2011-10-03 Thread Avi Kivity
On 10/03/2011 03:49 PM, Gleb Natapov wrote: Support guest/host-only profiling by switch perf msrs on a guest entry if needed. @@ -6052,6 +6056,26 @@ static void vmx_cancel_injection(struct kvm_vcpu *vcpu) vmcs_write32(VM_ENTRY_INTR_INFO_FIELD, 0); } +static void atomic_switch_perf_msr

[PATCH 1/9] perf, core: Introduce attrs to count in either host or guest mode

2011-10-03 Thread Gleb Natapov
From: Joerg Roedel The two new attributes exclude_guest and exclude_host can bes used by user-space to tell the kernel to setup performance counter to either only count while the CPU is in guest or in host mode. An additional check is also introduced to make sure user-space does not try to exclud

[PATCH 3/9] perf, tools: Add support for guest/host-only profiling

2011-10-03 Thread Gleb Natapov
From: Joerg Roedel To restrict a counter to either host or guest mode this patch introduces two new event modifiers: G and H. With G the counter is configured in guest-only mode and with H in host-only mode. Signed-off-by: Joerg Roedel Signed-off-by: Gleb Natapov --- tools/perf/util/parse-eve

[PATCH 4/9] perf, tools: Fix copy&paste error in perf-kvm option description

2011-10-03 Thread Gleb Natapov
From: Joerg Roedel The --host option certainly enables host-data collection. Signed-off-by: Joerg Roedel Signed-off-by: Gleb Natapov --- tools/perf/builtin-kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index

[PATCH 6/9] perf, intel: Use GO/HO bits in perf-ctr

2011-10-03 Thread Gleb Natapov
Intel does not have guest/host-only bit in perf counters like AMD does. To support GO/HO bits KVM needs to switch EVENTSELn values (or PERF_GLOBAL_CTRL if available) at a guest entry. If a counter is configured to count only in a guest mode it stays disabled in a host, but VMX is configured to swi

[PATCH 7/9] KVM, VMX: add support for switching of PERF_GLOBAL_CTRL

2011-10-03 Thread Gleb Natapov
Some cpus have special support for switching PERF_GLOBAL_CTRL msr. Add logic to detect if such support exists and works properly and extend msr switching code to use it if available. Also extend number of generic msr switching entries to 8. Signed-off-by: Gleb Natapov --- arch/x86/kvm/vmx.c |

[PATCH 9/9] KVM, VMX: Check for automatic switch msr table overflow.

2011-10-03 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/vmx.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index fef7bd9..afa9aa3 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1281,7 +1281,11 @@ static void add_atomic_s

[PATCH 8/9] KVM, VMX: Add support for guest/host-only profiling

2011-10-03 Thread Gleb Natapov
Support guest/host-only profiling by switch perf msrs on a guest entry if needed. Signed-off-by: Gleb Natapov --- arch/x86/kvm/vmx.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index e4cc3c2..

[PATCH 0/9] perf support for x86 guest/host-only bits

2011-10-03 Thread Gleb Natapov
This patch series consists of Joerg series named "perf support for amd guest/host-only bits v2" [1] rebased to 3.1.0-rc7 and in addition, support for intel cpus for the same functionality. [1] https://lkml.org/lkml/2011/6/17/171 Gleb Natapov (4): perf, intel: Use GO/HO bits in perf-ctr KVM,

[PATCH 2/9] perf, amd: Use GO/HO bits in perf-ctr

2011-10-03 Thread Gleb Natapov
From: Joerg Roedel The AMD perf-counters support counting in guest or host-mode only. Make use of that feature when user-space specified guest/host-mode only counting. Signed-off-by: Joerg Roedel Signed-off-by: Gleb Natapov --- arch/x86/include/asm/perf_event.h|3 +++ arch/x86/kernel/

[PATCH 5/9] perf, tools: Do guest-only counting in perf-kvm by default

2011-10-03 Thread Gleb Natapov
From: Joerg Roedel Make use of exclude_guest and exlude_host in perf-kvm to do only guest-only counting by default. Signed-off-by: Joerg Roedel Signed-off-by: Gleb Natapov --- tools/perf/builtin-kvm.c |3 ++- tools/perf/util/event.c|8 tools/perf/util/event.h

Re: [PATCH] KVM: x86: Simplify kvm timer handler

2011-10-03 Thread Jan Kiszka
On 2011-09-14 09:58, Jan Kiszka wrote: > The vcpu reference of a kvm_timer can't become NULL while the timer is > valid, so drop this redundant test. This also makes it pointless to > carry a separate __kvm_timer_fn, fold it into kvm_timer_fn. > > Signed-off-by: Jan Kiszka > --- > arch/x86/kvm/t

Re: [PATCH] need to export variables in config.mak

2011-10-03 Thread Jan Kiszka
On 2011-09-30 19:40, Chris Friesen wrote: > The variables being written to config.mak by configure > need to be exported in order to take effect when building > the package. > > The following patch fixes this in our environment. > > Signed-off-by: Chris Friesen > > > Index: kvm-kmod-3.0b/confi