Re: [SeaBIOS] [PATCH RFC] acpi: add ssdt for cpi hotplug

2011-11-03 Thread Isaku Yamahata
On Thu, Nov 03, 2011 at 02:31:18PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 02, 2011 at 08:30:28PM -0400, Kevin O'Connor wrote: > > On Wed, Nov 02, 2011 at 10:54:42AM +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 01, 2011 at 06:59:01PM -0400, Kevin O'Connor wrote: > > > > Can we leave th

Re: [PATCH 00/16] Libvirt test v5

2011-11-03 Thread Lucas Meneghel Rodrigues
On 11/03/2011 07:26 PM, Lucas Meneghel Rodrigues wrote: So, here it is. The last version of the libvirt test before upstream inclusion. After quite a bit of tests and corrections, this is the version that is going to be committed upstream, if nobody else has strong feelings against it. Ok, we f

[PATCH] virt: Encode a webm video from vm screenshots

2011-11-03 Thread Lucas Meneghel Rodrigues
When we are debugging issues (notably during unattended installs), having to look individual screenshots is less than optimal. So introduce in virt tests the ability to get a webm file that can be played quite nicely and out of the box in recent versions of firefox and chromium. In order to do tha

Biweekly KVM Test report, kernel b796a09c... qemu 7879db7e...

2011-11-03 Thread Ren, Yongjie
Hi All, This is KVM test result against kvm.git b796a09c5d808f4013f27ad45953db604dac18fd based on 3.1.0, and qemu.git 7879db7e9c09b92d9af1c143fbe2cc212ec89e4b. We filed 3 new bugs during our test. One of them is that kvm is not enabled by default when qemu starting a guest. This bug has alr

Re: english book to kvm system's internal

2011-11-03 Thread Jun Koi
On Fri, Nov 4, 2011 at 8:58 AM, Stefanos Gerangelos wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > I don't know if this is a right place to ask, but is there a book for > kvm's internal in english. In kvm site I am able to find these two in > german. > > http://www.amazon.de/

english book to kvm system's internal

2011-11-03 Thread Stefanos Gerangelos
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I don't know if this is a right place to ask, but is there a book for kvm's internal in english. In kvm site I am able to find these two in german. http://www.amazon.de/QEMU-Virtuelle-Computer-viele-Betriebssysteme/dp/3837008762/ref=sr_1_2/028-91

[PATCH 06/16] virt: Introducing libvirt monitor

2011-11-03 Thread Lucas Meneghel Rodrigues
This is an initial implementation for a libvirt monitor. With it, we plan on making the libvirt test use all the monitor features, making most of the tests available for kvm available for libvirt. As of implementation details, it uses aexpect to get a virsh shell, and then the monitor methods are

[PATCH 09/16] Virt: builtin HTTP server for unattended installs

2011-11-03 Thread Lucas Meneghel Rodrigues
From: Cleber Rosa This adds a simple HTTP server that is good enough to support unattended installs. Tested serving kickstart files and RHEL/Fedora content to anaconda. Signed-off-by: Cleber Rosa --- client/virt/virt_http_server.py | 124 +++ 1 files change

[PATCH 10/16] Virt: support XEN via libvirt and auto url installer

2011-11-03 Thread Lucas Meneghel Rodrigues
This patchs adds proper detection of active (alive) XEN domains via libvirt; a quick way to determine whether the current connected hypervisor is XEN or QEMU/KVM and also deals with virt-install options and syntax supported on RHEL 5 libvirt+XEN. Signed-off-by: Cleber Rosa --- client/virt/libvir

[PATCH 03/16] Moving unattended_install test from kvm test to common virt location

2011-11-03 Thread Lucas Meneghel Rodrigues
Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/tests/unattended_install.py | 663 -- client/virt/tests/unattended_install.py | 663 ++ 2 files changed, 663 insertions(+), 663 deletions(-) delete mode 100644 client/tests/kvm/tes

[PATCH 04/16] Moving get_started code to client.virt.virt_utils

2011-11-03 Thread Lucas Meneghel Rodrigues
As most of the get_started.py code could be very well shared among virt tests, moved the bulk of the code to virt_utils.py. Now we have the function virt_test_assistant(), that is generic enough so other tests can implement their variation of the assistant script. Signed-off-by: Lucas Meneghel Rod

[PATCH 05/16] virt: Introducing libvirt VM class

2011-11-03 Thread Lucas Meneghel Rodrigues
This is a first attempt at providing a libvirt VM class, in order to implement the needed methods for virt testing. With this class, we will be able to implement a libvirt test, that behaves similarly to the KVM test. As of implementation details, libvirt_vm uses virsh (a userspace program written

[PATCH 13/16] Virt: pass verbatim hvm_or_pv option to virt_install

2011-11-03 Thread Lucas Meneghel Rodrigues
From: Cleber Rosa When using options that affect whether we want to run a paravirt (pv) or fully virtualized domain (hvm), do not assume that the options will always start with a double dash ('--'). This is useful/needed when using multiple options such as --hvm and --accelerate. Signed-off-by:

[PATCH 07/16] virt.virt_env_process: Add libvirt vm handling

2011-11-03 Thread Lucas Meneghel Rodrigues
With this patch, we make libvirt vm handling integrating to pre/postprocessing code, making it possible the execution of a libvirt test. The idea was to try to abstract some concepts and intrude the least possible in the pre/postprocessing code. Signed-off-by: Martin Jenner Signed-off-by: Lucas M

[PATCH 16/16] Virt: adjust auto http servers (content/kickstart) ports to not overlap

2011-11-03 Thread Lucas Meneghel Rodrigues
From: Cleber Rosa There's a race condition when picking free ports and starting the http server thread, so both servers get the same port. Change to non-overlapping ranges to avoid that. Signed-off-by: Cleber Rosa --- client/virt/tests/unattended_install.py |4 ++-- 1 files changed, 2 ins

[PATCH 15/16] virt: Fix unattended install for libvirt case

2011-11-03 Thread Lucas Meneghel Rodrigues
Only move vmlinuz and initrd.img in case the file names are actually different from the ones virt-install is expecting. Signed-off-by: Lucas Meneghel Rodrigues --- client/virt/tests/unattended_install.py |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client/virt/te

[PATCH 12/16] Virt: small fixes related to libvirt unattended install when using auto url

2011-11-03 Thread Lucas Meneghel Rodrigues
This patch adds a simple formatting chance (to stay withing the 79 cols), and two small fixes to parameter parsing when using auto url feature. Signed-off-by: Cleber Rosa --- client/virt/libvirt_vm.py |9 ++--- client/virt/tests/unattended_install.py |8 +--- 2 file

[PATCH 14/16] Virt: add sample configuration for XEN HVM domains

2011-11-03 Thread Lucas Meneghel Rodrigues
From: Cleber Rosa This explicitly sets the former XEN PV example with a --paravirt option, adds an example configuration for running XEN HVM domains, and moves the prefix setting for kernel, images, iso files to the end of the file, so that cdrom_cd1 parameters will receive those prefixes. Signe

[PATCH 11/16] Virt: add support for XEN via libvirt installs and auto url

2011-11-03 Thread Lucas Meneghel Rodrigues
This patch adds support to unattended installs via libvirt+XEN and serving installation content via the auto url feature (using a builtin http server). A sample configuration is provided to run a Fedora 15 64 bits PV based test (libvirt_xenpv_f15_quick). Signed-off-by: Cleber Rosa --- client/te

[PATCH 02/16] virt: Introducing virt_test.virt_test class

2011-11-03 Thread Lucas Meneghel Rodrigues
During the process of implementing the libvirt test, we've noticed that the whole mechanism implemented by the KVM test (subtest loader, use of env file, params) could be turned into common infrastructure. So move all implementation to a class called virt_test. We believe most virt test classes do

[PATCH 00/16] Libvirt test v5

2011-11-03 Thread Lucas Meneghel Rodrigues
So, here it is. The last version of the libvirt test before upstream inclusion. After quite a bit of tests and corrections, this is the version that is going to be committed upstream, if nobody else has strong feelings against it. I've posted it here for folks who wish to take a look at it, and pr

Re: State of KVM guest debugging support on Power

2011-11-03 Thread Jan Kiszka
On 2011-11-03 19:59, Stuart Yoder wrote: > On Tue, Nov 1, 2011 at 9:22 AM, Jan Kiszka wrote: >> Hi there, >> >> I'm generating some slides on guest debugging via kvm. What's the >> current state for Book-E and Book-S? Works out of box, mostly usable, or >> to be implemented? Is anyone using it? >

Re: State of KVM guest debugging support on Power

2011-11-03 Thread Alexander Graf
On 03.11.2011, at 11:59, Stuart Yoder wrote: > On Tue, Nov 1, 2011 at 9:22 AM, Jan Kiszka wrote: >> Hi there, >> >> I'm generating some slides on guest debugging via kvm. What's the >> current state for Book-E and Book-S? Works out of box, mostly usable, or >> to be implemented? Is anyone usin

Re: State of KVM guest debugging support on Power

2011-11-03 Thread Stuart Yoder
On Tue, Nov 1, 2011 at 9:22 AM, Jan Kiszka wrote: > Hi there, > > I'm generating some slides on guest debugging via kvm. What's the > current state for Book-E and Book-S? Works out of box, mostly usable, or > to be implemented? Is anyone using it? Are you talking about guest debug using the QEMU

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 01:31:11 +0200 "Michael S. Tsirkin" wrote: > Add a flexible mechanism to specify virtio configuration layout, using > pci vendor-specific capability. A separate capability is used for each > of common, device specific and data-path accesses. > > Warning: compiled only. > This

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-03 Thread Avi Kivity
On 11/03/2011 04:37 PM, Anthony Liguori wrote: > >> 2. Proposed spec patch, kernel change, qemu change >> 3. Buy-ins from spec maintainer, kernel driver maintainer, qemu >> device >> maintainer (only regarding the ABI, not the code) > > I don't think this is how it's working

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-03 Thread Anthony Liguori
On 11/03/2011 09:31 AM, Michael S. Tsirkin wrote: On Thu, Nov 03, 2011 at 08:49:31AM -0500, Anthony Liguori wrote: On 11/03/2011 08:45 AM, Avi Kivity wrote: On 11/03/2011 03:38 PM, Anthony Liguori wrote: We could use a better agreement on the processor for making virtio changes. Should it go

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 08:49:31AM -0500, Anthony Liguori wrote: > On 11/03/2011 08:45 AM, Avi Kivity wrote: > >On 11/03/2011 03:38 PM, Anthony Liguori wrote: > >>> > We could use a better agreement on the processor for making virtio > changes. Should it go (1) virtio spec (2) kernel (3) qe

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 03:37:42PM +0200, Avi Kivity wrote: > On 11/03/2011 02:11 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 03, 2011 at 12:37:04PM +0200, Avi Kivity wrote: > > > On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote: > > > > Add a flexible mechanism to specify virtio configuration la

Re: virtio-pci new configuration proposal

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 03:19:01PM +0200, Sasha Levin wrote: > On Thu, 2011-11-03 at 14:46 +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 03, 2011 at 10:33:23AM +0200, Sasha Levin wrote: > > > On Thu, 2011-11-03 at 12:28 +1030, Rusty Russell wrote: > > > > On Wed, 02 Nov 2011 20:49:27 +0200, Sas

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Avi Kivity
On 11/03/2011 02:11 PM, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2011 at 12:37:04PM +0200, Avi Kivity wrote: > > On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote: > > > Add a flexible mechanism to specify virtio configuration layout, using > > > pci vendor-specific capability. A separate capabi

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Michael S. Tsirkin
> 2. Move device specific features into the device specific region. > Currently the features field is a mix between virtio-pci and device > specific features. A single feature field with bits partitioned to transport specific and device specific fields is a generic virtio thing. So there's relativ

Re: virtio-pci new configuration proposal

2011-11-03 Thread Sasha Levin
On Thu, 2011-11-03 at 14:46 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2011 at 10:33:23AM +0200, Sasha Levin wrote: > > On Thu, 2011-11-03 at 12:28 +1030, Rusty Russell wrote: > > > On Wed, 02 Nov 2011 20:49:27 +0200, Sasha Levin > > > wrote: > > > > This is a proposal for a new layout o

Re: virtio-pci new configuration proposal

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 10:33:23AM +0200, Sasha Levin wrote: > On Thu, 2011-11-03 at 12:28 +1030, Rusty Russell wrote: > > On Wed, 02 Nov 2011 20:49:27 +0200, Sasha Levin > > wrote: > > > This is a proposal for a new layout of the virtio-pci config space. > > > > > > We will separate the curren

Re: [PATCH 0/9] KVM in-guest performance monitoring

2011-11-03 Thread Gleb Natapov
Disregard this one please. I've sent old version of the patch series along with new one by mistake. Please look at PATCHv2 version of the patch series. Sorry about that :( On Thu, Nov 03, 2011 at 02:31:29PM +0200, Gleb Natapov wrote: > This patchset exposes an emulated version 2 architectural perf

[PATCH 0/9] KVM in-guest performance monitoring

2011-11-03 Thread Gleb Natapov
This patchset exposes an emulated version 2 architectural performance monitoring unit to KVM guests. The PMU is emulated using perf_events, so the host kernel can multiplex host-wide, host-user, and the guest on available resources. The patches should be applied on top of KVM patches from the pat

[PATCHv2 1/9] KVM: Expose kvm_lapic_local_deliver()

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Needed to deliver performance monitoring interrupts. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/lapic.c |2 +- arch/x86/kvm/lapic.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lap

[PATCHv2 6/9] perf: expose perf capability to other modules.

2011-11-03 Thread Gleb Natapov
KVM needs to know perf capability to decide which PMU it can expose to a guest. Signed-off-by: Gleb Natapov --- arch/x86/include/asm/perf_event.h | 15 +++ arch/x86/kernel/cpu/perf_event.c | 11 +++ arch/x86/kernel/cpu/perf_event.h |2 ++ arch/x86/ker

[PATCHv2 5/9] KVM: VMX: Intercept RDPMC

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Intercept RDPMC and forward it to the PMU emulation code. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/vmx.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6e28d58

[PATCHv2 4/9] KVM: SVM: Intercept RDPMC

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Intercept RDPMC and forward it to the PMU emulation code. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/svm.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index e32243e

[PATCHv2 8/9] KVM: x86 emulator: fix RDPMC privilege check

2011-11-03 Thread Gleb Natapov
From: Avi Kivity RDPMC is only privileged if CR4.PCE=0. check_rdpmc() already implements this, so all we need to do is drop the Priv flag. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/emulate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCHv2 9/9] KVM: x86 emulator: implement RDPMC (0F 33)

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_emulate.h |1 + arch/x86/kvm/emulate.c | 13 - arch/x86/kvm/x86.c |7 +++ 3 files changed, 20 insertions(+), 1 deletions(-) diff --git a/ar

[PATCHv2 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-03 Thread Gleb Natapov
Use perf_events to emulate an architectural PMU, version 2. Based on PMU version 1 emulation by Avi Kivity. Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h | 48 arch/x86/kvm/Kconfig|1 + arch/x86/kvm/Makefile |2 +- arch/x86/kvm/pmu.c

[PATCH 6/9] perf: expose perf capability to other modules.

2011-11-03 Thread Gleb Natapov
KVM needs to know perf capability to decide which PMU it can expose to a guest. Signed-off-by: Gleb Natapov --- arch/x86/include/asm/perf_event.h | 11 +++ arch/x86/kernel/cpu/perf_event.c | 11 +++ arch/x86/kernel/cpu/perf_event.h |2 ++ arch/x86/kernel/

[PATCHv2 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-03 Thread Gleb Natapov
Provide a CPUID leaf that describes the emulated PMU. Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index b88426c..3c9c8c9 100644 --- a/arch/x86/kvm/x86.c

[PATCH 9/9] KVM: x86 emulator: implement RDPMC (0F 33)

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_emulate.h |1 + arch/x86/kvm/emulate.c | 13 - arch/x86/kvm/x86.c |7 +++ 3 files changed, 20 insertions(+), 1 deletions(-) diff --git a/ar

[PATCHv2 3/9] KVM: Add generic RDPMC support

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Add a helper function that emulates the RDPMC instruction operation. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/x86.c | 15 +++ 2 files changed, 16 insertions(+), 0 deletions(-)

[PATCHv2 0/9] KVM in-guest performance monitoring

2011-11-03 Thread Gleb Natapov
This patchset exposes an emulated version 2 architectural performance monitoring unit to KVM guests. The PMU is emulated using perf_events, so the host kernel can multiplex host-wide, host-user, and the guest on available resources. The patches are against next branch on kvm.git. If you want to

[PATCH 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Use perf_events to emulate an architectural PMU, version 2. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h | 43 arch/x86/kvm/Makefile |2 +- arch/x86/kvm/pmu.c | 513 +++

Re: [SeaBIOS] [PATCH RFC] acpi: add ssdt for cpi hotplug

2011-11-03 Thread Michael S. Tsirkin
On Wed, Nov 02, 2011 at 09:36:58PM -0400, Kevin O'Connor wrote: > On Thu, Nov 03, 2011 at 09:04:57AM +0800, Wen Congyang wrote: > > At 11/03/2011 08:30 AM, Kevin O'Connor Write: > > > I think it's reasonable to require that a user supplied DSDT still > > > fill certain requirements. Keep in mind t

[PATCH 7/9] KVM: Expose the architectural performance monitoring CPUID leaf

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Provide a CPUID leaf that describes the emulated PMU. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/x86.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 5ea

[PATCH 3/9] KVM: Add generic RDPMC support

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Add a helper function that emulates the RDPMC instruction operation. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/x86.c | 15 +++ 2 files changed, 16 insertions(+), 0 deletions(-)

[PATCH 8/9] KVM: x86 emulator: fix RDPMC privilege check

2011-11-03 Thread Gleb Natapov
From: Avi Kivity RDPMC is only privileged if CR4.PCE=0. check_rdpmc() already implements this, so all we need to do is drop the Priv flag. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/emulate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 1/9] KVM: Expose kvm_lapic_local_deliver()

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Needed to deliver performance monitoring interrupts. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/lapic.c |2 +- arch/x86/kvm/lapic.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lap

[PATCH 5/9] KVM: VMX: Intercept RDPMC

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Intercept RDPMC and forward it to the PMU emulation code. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/vmx.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6e28d58

[PATCH 4/9] KVM: SVM: Intercept RDPMC

2011-11-03 Thread Gleb Natapov
From: Avi Kivity Intercept RDPMC and forward it to the PMU emulation code. Signed-off-by: Avi Kivity Signed-off-by: Gleb Natapov --- arch/x86/kvm/svm.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index e32243e

Re: [PATCH RFC] acpi: add ssdt for cpi hotplug

2011-11-03 Thread Michael S. Tsirkin
On Wed, Nov 02, 2011 at 08:30:28PM -0400, Kevin O'Connor wrote: > On Wed, Nov 02, 2011 at 10:54:42AM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 01, 2011 at 06:59:01PM -0400, Kevin O'Connor wrote: > > > Can we leave these parts in the DSDT and only move the bulk generated > > > stuff to the SS

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 12:37:04PM +0200, Avi Kivity wrote: > On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote: > > Add a flexible mechanism to specify virtio configuration layout, using > > pci vendor-specific capability. A separate capability is used for each > > of common, device specific and d

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 01:09:51PM +0200, Sasha Levin wrote: > On Thu, 2011-11-03 at 12:33 +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 03, 2011 at 02:19:03AM +0200, Sasha Levin wrote: > > > Hi Michael, > > > > > > On Thu, 2011-11-03 at 01:31 +0200, Michael S. Tsirkin wrote: > > > > Add a flex

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Sasha Levin
On Thu, 2011-11-03 at 12:33 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2011 at 02:19:03AM +0200, Sasha Levin wrote: > > Hi Michael, > > > > On Thu, 2011-11-03 at 01:31 +0200, Michael S. Tsirkin wrote: > > > Add a flexible mechanism to specify virtio configuration layout, using > > > pci ve

Re: virtio-pci new configuration proposal

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 12:28:46PM +1030, Rusty Russell wrote: > 3) If we're changing the queue layout, it's a chance to fix a >longstanding bug: let the guest notify the host of preferred >queue size and alignment. With device config split from the common one, we can just tuck new fields

Re: [PATCH 4 of 5] virtio: avoid modulus operation

2011-11-03 Thread Rusty Russell
On Thu, 3 Nov 2011 09:51:15 +0200, Pekka Enberg wrote: > On Thu, Nov 3, 2011 at 9:42 AM, Rusty Russell wrote: > > Since we know vq->vring.num is a power of 2, modulus is lazy (it's asserted > > in vring_new_virtqueue()). > > > > Signed-off-by: Rusty Russell > > --- > >  drivers/virtio/virtio_rin

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Avi Kivity
On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote: > Add a flexible mechanism to specify virtio configuration layout, using > pci vendor-specific capability. A separate capability is used for each > of common, device specific and data-path accesses. > > How about posting the spec change instead of

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 02:19:03AM +0200, Sasha Levin wrote: > Hi Michael, > > On Thu, 2011-11-03 at 01:31 +0200, Michael S. Tsirkin wrote: > > Add a flexible mechanism to specify virtio configuration layout, using > > pci vendor-specific capability. A separate capability is used for each > > of

Re: virtio-pci new configuration proposal

2011-11-03 Thread Sasha Levin
On Thu, 2011-11-03 at 12:28 +1030, Rusty Russell wrote: > On Wed, 02 Nov 2011 20:49:27 +0200, Sasha Levin > wrote: > > This is a proposal for a new layout of the virtio-pci config space. > > > > We will separate the current configuration into two: A virtio-pci common > > configuration and a dev

Re: [PATCH 2/9] KVM: Expose a version 2 architectural PMU to a guests

2011-11-03 Thread Gleb Natapov
On Wed, Nov 02, 2011 at 01:09:46PM +0200, Gleb Natapov wrote: > > > > The user can cause this to be very small (even zero). Can this cause an > > > > NMI storm? > > > > > > > If user will set it to zero then attr.sample_period will always be 0 and > > > perf will think that the event is non sampl

Re: [PATCH 3 of 5] virtio: support unlocked queue kick

2011-11-03 Thread Christoph Hellwig
On Thu, Nov 03, 2011 at 06:12:51PM +1030, Rusty Russell wrote: > Based on patch by Christoph for virtio_blk speedup: Please credit it to Stefan - he also sent a pointer to his original version in reply to the previous thread. Also shouldn't virtqueue_kick have kerneldoc comments? I also notices

Re: [PATCH 4 of 5] virtio: avoid modulus operation

2011-11-03 Thread Pekka Enberg
On Thu, Nov 3, 2011 at 9:42 AM, Rusty Russell wrote: > Since we know vq->vring.num is a power of 2, modulus is lazy (it's asserted > in vring_new_virtqueue()). > > Signed-off-by: Rusty Russell > --- >  drivers/virtio/virtio_ring.c |   10 ++ >  1 file changed, 6 insertions(+), 4 deletions(

Re: [PATCH 2 of 5] virtio: rename virtqueue_add_buf_gfp to virtqueue_add_buf

2011-11-03 Thread Christoph Hellwig
On Thu, Nov 03, 2011 at 06:12:50PM +1030, Rusty Russell wrote: > Remove wrapper functions. This makes the allocation type explicit in > all callers; I used GPF_KERNEL where it seemed obvious, left it at > GFP_ATOMIC otherwise. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from thi

Re: [PATCH 1 of 5] virtio: document functions better

2011-11-03 Thread Christoph Hellwig
On Thu, Nov 03, 2011 at 06:12:49PM +1030, Rusty Russell wrote: > The old documentation is left over from when we used a structure with > strategy pointers. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to maj

[PATCH 2 of 5] virtio: rename virtqueue_add_buf_gfp to virtqueue_add_buf

2011-11-03 Thread Rusty Russell
Remove wrapper functions. This makes the allocation type explicit in all callers; I used GPF_KERNEL where it seemed obvious, left it at GFP_ATOMIC otherwise. Signed-off-by: Rusty Russell diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c --- a/drivers/block/virtio_blk.c +++ b/d

[PATCH 1 of 5] virtio: document functions better

2011-11-03 Thread Rusty Russell
The old documentation is left over from when we used a structure with strategy pointers. Signed-off-by: Rusty Russell --- include/linux/virtio.h | 130 - 1 file changed, 87 insertions(+), 43 deletions(-) diff --git a/include/linux/virtio.h b/incl

[PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-03 Thread Rusty Russell
A virtio driver does virtqueue_add_buf() multiple times before finally calling virtqueue_kick(); previously we only exposed the added buffers in the virtqueue_kick() call. This means we don't need a memory barrier in virtqueue_add_buf(), but it reduces concurrency as the device (ie. host) can't se

[PATCH 4 of 5] virtio: avoid modulus operation

2011-11-03 Thread Rusty Russell
Since we know vq->vring.num is a power of 2, modulus is lazy (it's asserted in vring_new_virtqueue()). Signed-off-by: Rusty Russell --- drivers/virtio/virtio_ring.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c --

[PATCH 3 of 5] virtio: support unlocked queue kick

2011-11-03 Thread Rusty Russell
Based on patch by Christoph for virtio_blk speedup: Split virtqueue_kick to be able to do the actual notification outside the lock protecting the virtqueue. This patch was originally done by Stefan Hajnoczi, but I can't find the original one anymore and had to recr

Re: [PATCH 2/2] adds cgroup tests on KVM guests with first test

2011-11-03 Thread Lukáš Doktor
Dne 3.11.2011 07:04, Suqin napsal(a): On 09/23/2011 12:29 AM, Lukas Doktor wrote: basic structure: * similar to general client/tests/cgroup/ test (imports from the cgroup_common.py) * uses classes for better handling * improved logging and error handling * checks/repair the guests af