Fwd: oVirt Beijing - March 21st

2012-02-04 Thread Itamar Heim
Original Message Subject: oVirt Beijing - March 21st Date: Fri, 03 Feb 2012 15:52:41 -0500 From: Carl Trieloff Spread the word/ come join us! http://www.ovirt.org/news-and-events/workshop/ Carl -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of

Re: [PATCH] kvm tool: Don't close not yet opened files and SIGSEV fix

2012-02-04 Thread Cyrill Gorcunov
On Sat, Feb 04, 2012 at 07:54:38PM +0200, Pekka Enberg wrote: > On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: > >Index: linux-2.6.git/tools/kvm/kvm.c > >=== > >--- linux-2.6.git.orig/tools/kvm/kvm.c > >+++ linux-2.6.git/tools/kvm/kvm.c >

Re: [PATCH] kvm tool: Don't close not yet opened files and SIGSEV fix

2012-02-04 Thread Pekka Enberg
On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: Index: linux-2.6.git/tools/kvm/kvm.c === --- linux-2.6.git.orig/tools/kvm/kvm.c +++ linux-2.6.git/tools/kvm/kvm.c @@ -123,10 +123,12 @@ static int kvm__check_extensions(struct static struct

Re: [PATCH] kvm tool: Don't close not yet opened files and SIGSEV fix

2012-02-04 Thread Cyrill Gorcunov
On Sat, Feb 04, 2012 at 07:38:41PM +0200, Pekka Enberg wrote: > On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: > >In case if there error happened in kvm__init and we have > >no files opened -- we should not try to close them. > > > >Also once kvm failed to init the caller should not try > >to dereferen

Re: [PATCH] kvm tool: Don't close not yet opened files and SIGSEV fix

2012-02-04 Thread Pekka Enberg
On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: In case if there error happened in kvm__init and we have no files opened -- we should not try to close them. Also once kvm failed to init the caller should not try to dereference a pointer obtained, otherwise we might get SIGSEV | [cyrill@moon kvm]$ ./

[PATCH] kvm tool: Don't close not yet opened files and SIGSEV fix

2012-02-04 Thread Cyrill Gorcunov
In case if there error happened in kvm__init and we have no files opened -- we should not try to close them. Also once kvm failed to init the caller should not try to dereference a pointer obtained, otherwise we might get SIGSEV | [cyrill@moon kvm]$ ./lkvm run ... | Error: '/dev/kvm' not found

Re: [PATCH] kvm tool: Make kvm structure to carry name copy

2012-02-04 Thread Cyrill Gorcunov
On Sat, Feb 04, 2012 at 02:57:23PM +0200, Pekka Enberg wrote: > On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: > >Index: linux-2.6.git/tools/kvm/kvm.c > >=== > >--- linux-2.6.git.orig/tools/kvm/kvm.c > >+++ linux-2.6.git/tools/kvm/kvm.c >

Re: [PATCH] kvm tool: Make kvm structure to carry name copy

2012-02-04 Thread Pekka Enberg
On Sat, 4 Feb 2012, Cyrill Gorcunov wrote: Index: linux-2.6.git/tools/kvm/kvm.c === --- linux-2.6.git.orig/tools/kvm/kvm.c +++ linux-2.6.git/tools/kvm/kvm.c @@ -254,6 +254,7 @@ int kvm__exit(struct kvm *kvm) kvm__arch_delete_

Re: [PATCH] kvm tool: Make kvm structure to carry name copy

2012-02-04 Thread Cyrill Gorcunov
On Sat, Feb 04, 2012 at 04:20:05PM +0400, Cyrill Gorcunov wrote: > On Sat, Feb 04, 2012 at 02:15:36PM +0200, Pekka Enberg wrote: > > On Fri, 3 Feb 2012, Cyrill Gorcunov wrote: > > >If guest name is used (which is default case) the kvm might end > > >up carrying the pointer to name which is allocate

Re: [PATCH] kvm tool: Make kvm structure to carry name copy

2012-02-04 Thread Cyrill Gorcunov
On Sat, Feb 04, 2012 at 02:15:36PM +0200, Pekka Enberg wrote: > On Fri, 3 Feb 2012, Cyrill Gorcunov wrote: > >If guest name is used (which is default case) the kvm might end > >up carrying the pointer to name which is allocated on stack. > > > >kvm_cmd_run_init > > (on stack) default_name > > kvm__

Re: [PATCH] kvm tool: Make kvm structure to carry name copy

2012-02-04 Thread Pekka Enberg
On Fri, 3 Feb 2012, Cyrill Gorcunov wrote: If guest name is used (which is default case) the kvm might end up carrying the pointer to name which is allocated on stack. kvm_cmd_run_init (on stack) default_name kvm__init(..., default_name) kvm->name = default_name So I think better to allow

Re: Unable to pass multiple cores / CPUs to guests

2012-02-04 Thread Binarus
Jim, I just don't know how I could thank you! I have put multiple days into that problem and didn't remember nor see that I already have put -smp 1 later in the command. I think it would have cost me some more days or I would have been unable to solve the problem at all if you didn't give me th