Re: [PATCH v2 5/7] KVM: Introduce PV kick in flush tlb

2012-07-05 Thread Nikunj A Dadhania
On Wed, 4 Jul 2012 23:37:46 -0300, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 03, 2012 at 01:55:02PM +0530, Nikunj A Dadhania wrote: On Tue, 3 Jul 2012 05:07:13 -0300, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Jun 04, 2012 at 10:38:17AM +0530, Nikunj A. Dadhania

Re: [PATCH 6/6] virtio-scsi: Set shost-max_id=1 for tcm_vhost WWPNs

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 04:05, Nicholas A. Bellinger ha scritto: But that's what the config field is for... why can't tcm_vhost (or QEMU) set max_id to 0? So this patch was carried forward from Stefan's original code that I thought was required due to other limitations.. If that's not the case

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-05 Thread Paolo Bonzini
Il 04/07/2012 23:30, Michael S. Tsirkin ha scritto: +static int virtblk_get_cache_mode(struct virtio_device *vdev) Why are you converting u8 to int here? The fact that it is a u8 is really an internal detail. Perhaps the bug is using u8 in the callers. Make it bool then? You are using

Re: [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm.h b/kvm.h index 9c7b0ea..5b3c228

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-05 Thread Paolo Bonzini
Il 04/07/2012 23:11, Sasha Levin ha scritto: There are two things going on here: 1. Rename VIRTIO_BLK_F_FLUSH to VIRTIO_BLK_F_WCE 2. Add a new VIRTIO_BLK_F_CONFIG_WCE I'm concerned that the first change is going to break compilation for any code that included linux/virtio-blk.h and used

Re: race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Xiao Guangrong
On 07/05/2012 07:12 AM, Peter Lieven wrote: On 07/03/12 15:13, Avi Kivity wrote: On 07/03/2012 04:01 PM, Peter Lieven wrote: Further output from my testing. Working: Linux 2.6.38 with included kvm module Linux 3.0.0 with included kvm module Not-Working: Linux 3.2.0 with included kvm

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 08:47 +0200, Paolo Bonzini wrote: Il 04/07/2012 23:11, Sasha Levin ha scritto: There are two things going on here: 1. Rename VIRTIO_BLK_F_FLUSH to VIRTIO_BLK_F_WCE 2. Add a new VIRTIO_BLK_F_CONFIG_WCE I'm concerned that the first change is going to break

Re: race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Xiao Guangrong
On 06/28/2012 05:11 PM, Peter Lieven wrote: that here is bascially whats going on: qemu-kvm-1.0-2506 [010] 60996.908000: kvm_mmio: mmio read len 3 gpa 0xa val 0x10ff qemu-kvm-1.0-2506 [010] 60996.908000: vcpu_match_mmio: gva 0xa gpa 0xa Read GPA

RE: [Qemu-ppc] [RFC PATCH 04/17] KVM: PPC64: booke: Add guest computation mode for irq delivery

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:41 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 04/17]

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 07:01:05PM -0700, Nicholas A. Bellinger wrote: On Wed, 2012-07-04 at 18:05 +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +,

[PATCH] MAINTAINERS: add kvm list for virtio components

2012-07-05 Thread Paolo Bonzini
The KVM list is followed by more people than the generic virtualizat...@lists.linux-foundation.org mailing list, and is already de facto the place where virtio patches are posted. pv-ops still has no other lists than virtualizat...@lists.linux-foundation.org. However, pv-ops patches will likely

[PATCH] virtio-blk: add back VIRTIO_BLK_F_FLUSH

2012-07-05 Thread Paolo Bonzini
The old name is part of the userspace API, add it back for compatibility. Reported-by: Sasha Levin levinsasha...@gmail.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/linux/virtio_blk.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread liu ping fan
On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 + 1 files changed, 1 insertions(+), 0

Re: [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 +

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block 25 Write / 75 Read | ~15K | ~45K |

[net-next RFC V5 0/5] Multiqueue virtio-net

2012-07-05 Thread Jason Wang
Hello All: This series is an update version of multiqueue virtio-net driver based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Please review and comments. Test Environment: - Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa

[net-next RFC V5 1/5] virtio_net: Introduce VIRTIO_NET_F_MULTIQUEUE

2012-07-05 Thread Jason Wang
From: Krishna Kumar krkum...@in.ibm.com Introduce VIRTIO_NET_F_MULTIQUEUE. Signed-off-by: Krishna Kumar krkum...@in.ibm.com Signed-off-by: Jason Wang jasow...@redhat.com --- include/linux/virtio_net.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Jason Wang
Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/virtio/virtio_mmio.c |5 +

[net-next RFC V5 3/5] virtio: intorduce an API to set affinity for a virtqueue

2012-07-05 Thread Jason Wang
Sometimes, virtio device need to configure irq affiniry hint to maximize the performance. Instead of just exposing the irq of a virtqueue, this patch introduce an API to set the affinity for a virtqueue. The api is best-effort, the affinity hint may not be set as expected due to platform support,

[net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-05 Thread Jason Wang
This patch converts virtio_net to a multi queue device. After negotiated VIRTIO_NET_F_MULTIQUEUE feature, the virtio device has many tx/rx queue pairs, and driver could read the number from config space. The driver expects the number of rx/tx queue paris is equal to the number of vcpus. To

[net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Jason Wang
This patch let the virtio_net driver can negotiate the number of queues it wishes to use through control virtqueue and export an ethtool interface to let use tweak it. As current multiqueue virtio-net implementation has optimizations on per-cpu virtuqueues, so only two modes were support: -

[PATCH] KVM: MMU: Fix mmu_shrink() so that it can free mmu pages as intended

2012-07-05 Thread Takuya Yoshikawa
The following commit changed mmu_shrink() so that it would skip VMs whose n_used_mmu_pages is not zero and try to free pages from others: commit 1952639665e92481c34c34c3e2a71bf3e66ba362 KVM: MMU: do not iterate over all VMs in mmu_shrink() This patch fixes the function so that it can free

Re: [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread liu ping fan
On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI

RE: [Qemu-ppc] [RFC PATCH 05/17] KVM: PPC: booke: Extend MAS2 EPN mask for 64-bit

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:50 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 05/17]

RE: [RFC PATCH 06/17] KVM: PPC: e500: Add emulation helper for getting instruction ea

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc- ow...@vger.kernel.org] On Behalf Of Alexander Graf Sent: Wednesday, July 04, 2012 4:56 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org;

Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing. Signed-off-by: Jason Wang jasow...@redhat.com

RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:34 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 03/17]

Re: [PATCH] KVM: MMU: Fix mmu_shrink() so that it can free mmu pages as intended

2012-07-05 Thread Gleb Natapov
On Thu, Jul 05, 2012 at 07:56:07PM +0900, Takuya Yoshikawa wrote: The following commit changed mmu_shrink() so that it would skip VMs whose n_used_mmu_pages is not zero and try to free pages from others: Oops, commit 1952639665e92481c34c34c3e2a71bf3e66ba362 KVM: MMU: do not iterate over

Re: [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 13:02, liu ping fan wrote: On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set

Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs

2012-07-05 Thread Alexander Graf
On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:34 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org;

Re: [PATCH] MAINTAINERS: add kvm list for virtio components

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:07:07PM +0200, Paolo Bonzini wrote: The KVM list is followed by more people than the generic virtualizat...@lists.linux-foundation.org mailing list, and is already de facto the place where virtio patches are posted. I have no data on the first statement (do you?) and

Re: race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Peter Lieven
On 05.07.2012 10:51, Xiao Guangrong wrote: On 06/28/2012 05:11 PM, Peter Lieven wrote: that here is bascially whats going on: qemu-kvm-1.0-2506 [010] 60996.908000: kvm_mmio: mmio read len 3 gpa 0xa val 0x10ff qemu-kvm-1.0-2506 [010] 60996.908000: vcpu_match_mmio:

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi-has_cvq = true; + /* Use single tx/rx queue pair as default */ +

RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Thursday, July 05, 2012 3:13 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM:

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-05 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce

Re: [PATCH 1/2] kvm, Add x86_hyper_kvm to complete detect_hypervisor_platform check [v2]

2012-07-05 Thread Prarit Bhargava
On 07/05/2012 09:26 AM, Avi Kivity wrote: Please copy at least kvm@vger.kernel.org, and preferably Marcelo as well (the other kvm co-maintainer). While debugging I noticed that unlike all the other hypervisor code in the kernel, kvm does not have an entry for x86_hyper which is used in

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block

Re: [PATCH] KVM: MMU: Fix mmu_shrink() so that it can free mmu pages as intended

2012-07-05 Thread Takuya Yoshikawa
On Thu, 5 Jul 2012 14:50:00 +0300 Gleb Natapov g...@redhat.com wrote: Note that if (!nr_to_scan--) check is removed since we do not try to free mmu pages from more than one VM. IIRC this was proposed in the past that we should iterate over vm list until freeing something eventually, but

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Anthony Liguori
On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 15:53, Michael S. Tsirkin ha scritto: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 09:06:35AM -0500, Anthony Liguori wrote: On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw |

Re: [PATCH] kvm: handle last_boosted_vcpu = 0 case

2012-07-05 Thread Andrew Theurer
On Mon, 2012-07-02 at 10:49 -0400, Rik van Riel wrote: On 06/28/2012 06:55 PM, Vinod, Chegu wrote: Hello, I am just catching up on this email thread... Perhaps one of you may be able to help answer this query.. preferably along with some data. [BTW, I do understand the basic intent

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 16:40, Michael S. Tsirkin ha scritto: virtio-scsi is brand new. It's not as if we've had any significant time to make virtio-scsi-qemu faster. In fact, tcm_vhost existed before virtio-scsi-qemu did if I understand correctly. Yes. Can't same can be said about virtio scsi - it

Re: [PATCH] buildsys: Move msi[x] and virtio-pci from Makefile.objs to Makefile.target

2012-07-05 Thread Jan Kiszka
On 2012-07-05 15:35, Hans de Goede wrote: Building non-kvm versions of qemu from qemu-kvm.git results in a linker error with undefined references to kvm_kernel_irqchip, expanded from the kvm_irqchip_in_kernel macro in kvm.h: This patch fixes this. Note maybe a better fix would be to drop

[PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code

2012-07-05 Thread Paolo Bonzini
This is part 1 of a three-part series that expands usage of EventNotifier in QEMU (including AIO and the main loop). I started working on this when playing with the threaded block layer; the part of that work that I hope will be in 1.2 is generalizing posix-aio-compat.c to be a generic portable

[PATCH uq/master 1/9] event_notifier: add event_notifier_set

2012-07-05 Thread Paolo Bonzini
EventNotifier right now cannot be used as an inter-thread communication primitive. It only works if something else (the kernel) sets the eventfd. Add a primitive to signal an EventNotifier that another thread is waiting on. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- event_notifier.c |

[PATCH uq/master 2/9] event_notifier: remove event_notifier_test

2012-07-05 Thread Paolo Bonzini
This is broken; since the eventfd is used in nonblocking mode there is a race between reading and writing. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- event_notifier.c | 15 --- event_notifier.h |1 - 2 files changed, 16 deletions(-) diff --git a/event_notifier.c

[PATCH uq/master 3/9] event_notifier: add event_notifier_init_fd

2012-07-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- event_notifier.c |7 +++ event_notifier.h |3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/event_notifier.c b/event_notifier.c index c339bfe..99c376c 100644 --- a/event_notifier.c +++ b/event_notifier.c @@

[PATCH uq/master 4/9] ivshmem: use EventNotifier and memory API

2012-07-05 Thread Paolo Bonzini
All of ivshmem's usage of eventfd now has a corresponding API in EventNotifier. Simplify the code by using it, and also use the memory API consistently to set up and tear down the ioeventfds. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ivshmem.c | 63

[PATCH uq/master 5/9] ivshmem: wrap ivshmem_del_eventfd loops with transaction

2012-07-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ivshmem.c |4 1 file changed, 4 insertions(+) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 3cdbea2..19e164a 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -369,8 +369,12 @@ static void close_guest_eventfds(IVShmemState *s, int

[PATCH uq/master 6/9] memory: pass EventNotifier, not eventfd

2012-07-05 Thread Paolo Bonzini
Under Win32, EventNotifiers will not have event_notifier_get_fd, so we cannot call it in common code such as hw/virtio-pci.c. Pass a pointer to the notifier, and only retrieve the file descriptor in kvm-specific code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c |8

[PATCH uq/master 7/9] event_notifier: add event_notifier_set_handler

2012-07-05 Thread Paolo Bonzini
Win32 event notifiers are not file descriptors, so they will not be able to use qemu_set_fd_handler. But even if for now we only have a POSIX version of EventNotifier, we can add a specific function that wraps the call. The wrapper passes the EventNotifier as the opaque value so that it will be

[PATCH uq/master 8/9] virtio: move common ioeventfd handling out of virtio-pci

2012-07-05 Thread Paolo Bonzini
All transports can use the same event handler for the ioeventfd, though the exact setup (address/memory region) will be specific. This lets virtio use event_notifier_set_handler. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio-pci.c | 36 ++--

[PATCH uq/master 9/9] virtio: move common irqfd handling out of virtio-pci

2012-07-05 Thread Paolo Bonzini
All transports can use the same event handler for the irqfd, though the exact mechanics of the assignment will be specific. Note that there are three states: handled by the kernel, handled in userspace, disabled. This also lets virtio use event_notifier_set_handler. Signed-off-by: Paolo Bonzini

RE: [RFC PATCH 13/17] PowerPC: booke64: Use SPRG0/3 scratch for bolted TLB miss crit int

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Wednesday, June 27, 2012 1:16 AM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org; Anton Blanchard Subject:

Re: [PATCH v3 2/2] kvm: KVM_EOIFD, an eventfd for EOIs

2012-07-05 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 10:24:54PM -0600, Alex Williamson wrote: On Wed, 2012-07-04 at 17:00 +0300, Michael S. Tsirkin wrote: On Tue, Jul 03, 2012 at 01:21:29PM -0600, Alex Williamson wrote: This new ioctl enables an eventfd to be triggered when an EOI is written for a specified irqchip

[Bug 15486] amd_adac error

2012-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=15486 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH v3] Fixes related to processing of qemu's -numa option

2012-07-05 Thread Chegu Vinod
Changes since v2: - Using unsigned long * for the node_cpumask[]. - Use bitmap_new() instead of g_malloc0() for allocation. - Don't rely on max_cpus since it may not be initialized before the numa related qemu options are parsed processed. Note: Continuing to use a new constant for

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 04:47:43PM +0200, Paolo Bonzini wrote: Il 05/07/2012 16:40, Michael S. Tsirkin ha scritto: virtio-scsi is brand new. It's not as if we've had any significant time to make virtio-scsi-qemu faster. In fact, tcm_vhost existed before virtio-scsi-qemu did if I

Re: [net-next RFC V5 0/5] Multiqueue virtio-net

2012-07-05 Thread Rick Jones
On 07/05/2012 03:29 AM, Jason Wang wrote: Test result: 1) 1 vm 2 vcpu 1q vs 2q, 1 - 1q, 2 - 2q, no pinning - Guest to External Host TCP STREAM sessions size throughput1 throughput2 norm1 norm2 1 64 650.55 655.61 100% 24.88 24.86 99% 2 64 1446.81 1309.44 90% 30.49 27.16 89% 4 64 1430.52

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/04/12 04:24, Nicholas A. Bellinger wrote: +/* Fill in status and signal that we are done processing this command + * + * This is scheduled in the vhost work queue so we are called with the owner + * process mm and can access the vring. + */ +static void

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Bart Van Assche
On 07/05/12 01:52, Nicholas A. Bellinger wrote: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block 25 Write / 75 Read | ~15K | ~45K |

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:47, Bart Van Assche wrote: On 07/04/12 04:24, Nicholas A. Bellinger wrote: +/* Fill in status and signal that we are done processing this command + * + * This is scheduled in the vhost work queue so we are called with the owner + * process mm and can access the vring. + */

Re: [Qemu-devel] plan for device assignment upstream

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:05 AM, Avi Kivity a...@redhat.com wrote: On 07/03/2012 10:06 PM, Blue Swirl wrote: On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity a...@redhat.com wrote: On 07/02/2012 12:30 PM, Jan Kiszka wrote: On 2012-07-02 11:18, Michael S. Tsirkin wrote: I've been thinking hard about

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-05 Thread Badari Pulavarty
On Tue, 2012-07-03 at 15:19 +0200, Paolo Bonzini wrote: This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature, which exposes the cache mode in the configuration space and lets the driver modify it. The cache mode is exposed via sysfs. Even if the host does not support the new

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:53, Bart Van Assche wrote: On 07/05/12 01:52, Nicholas A. Bellinger wrote: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block 25 Write / 75 Read | ~15K

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-05 Thread Amos Kong
On 07/05/2012 06:29 PM, Jason Wang wrote: This patch converts virtio_net to a multi queue device. After negotiated VIRTIO_NET_F_MULTIQUEUE feature, the virtio device has many tx/rx queue pairs, and driver could read the number from config space. The driver expects the number of rx/tx queue

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Amos Kong
On 07/05/2012 08:51 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi-has_cvq = true; + /* Use single

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 04:32:31PM +0200, Paolo Bonzini wrote: Il 05/07/2012 15:53, Michael S. Tsirkin ha scritto: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw |

[PATCH] add PLE stats to kvmstat

2012-07-05 Thread Andrew Theurer
I, and I expect others, have a keen interest in knowing how often we exit for PLE, and also how often that includes a yielding to another vcpu. The following adds two more counters to kvmstat to track the exits and the vcpu yields. This in no way changes PLE behavior, just helps us track what's

Re: [Qemu-ppc] [RFC PATCH 04/17] KVM: PPC64: booke: Add guest computation mode for irq delivery

2012-07-05 Thread Scott Wood
On 07/04/2012 08:40 AM, Alexander Graf wrote: On 25.06.2012, at 14:26, Mihai Caraman wrote: @@ -381,7 +386,8 @@ static int kvmppc_booke_irqprio_deliver(struct kvm_vcpu *vcpu, set_guest_esr(vcpu, vcpu-arch.queued_esr); if (update_dear == true)

Re: [Qemu-ppc] [RFC PATCH 12/17] PowerPC: booke64: Add DO_KVM kernel hooks

2012-07-05 Thread Scott Wood
On 07/04/2012 01:15 PM, Caraman Mihai Claudiu-B02008 wrote: From: Alexander Graf [ag...@suse.de] Sent: Wednesday, July 04, 2012 6:45 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; KVM list; linuxppc-dev; qemu-...@nongnu.org List;

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-05 Thread Asias He
On 07/04/2012 10:40 AM, Rusty Russell wrote: On Tue, 03 Jul 2012 08:39:39 +0800, Asias He as...@redhat.com wrote: On 07/02/2012 02:41 PM, Rusty Russell wrote: Sure, our guest merging might save us 100x as many exits as no merging. But since we're not doing many requests, does it matter? We

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 09:06 -0500, Anthony Liguori wrote: On 07/05/2012 08:53 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost |

RE: [PATCHv3 RFC 0/2] kvm: direct msix injection

2012-07-05 Thread Hao, Xudong
Hi, Michael/Alex, do you have progress for device assignment issue fixing? https://bugzilla.kernel.org/show_bug.cgi?id=43328 Thanks, -Xudong -Original Message- From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of Alex Williamson Sent: Tuesday, July 03,

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 12:31 +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 07:01:05PM -0700, Nicholas A. Bellinger wrote: On Wed, 2012-07-04 at 18:05 +0300, Michael S. Tsirkin wrote: SNIP I was talking about 4/6 first of all. So yeah, this code is still considered RFC at

Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Jason Wang
On 07/05/2012 07:40 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing.

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Jason Wang
On 07/05/2012 08:51 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi-has_cvq = true; + /* Use single

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Nicholas A. Bellinger
On Thu, 2012-07-05 at 16:53 +0300, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:22:33PM +0200, Paolo Bonzini wrote: Il 05/07/2012 03:52, Nicholas A. Bellinger ha scritto: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block

SCSI Performance regression [was Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6]

2012-07-05 Thread James Bottomley
On Thu, 2012-07-05 at 20:01 -0700, Nicholas A. Bellinger wrote: So I'm pretty sure this discrepancy is attributed to the small block random I/O bottleneck currently present for all Linux/SCSI core LLDs regardless of physical or virtual storage fabric. The SCSI wide host-lock less conversion

RE: [Qemu-ppc] [RFC PATCH 04/17] KVM: PPC64: booke: Add guest computation mode for irq delivery

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:41 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 04/17]

RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:34 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 03/17]

Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs

2012-07-05 Thread Alexander Graf
On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:34 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org;

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-05 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce

RE: [RFC PATCH 13/17] PowerPC: booke64: Use SPRG0/3 scratch for bolted TLB miss crit int

2012-07-05 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Wednesday, June 27, 2012 1:16 AM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org; Anton Blanchard Subject:

Re: [Qemu-ppc] [RFC PATCH 12/17] PowerPC: booke64: Add DO_KVM kernel hooks

2012-07-05 Thread Scott Wood
On 07/04/2012 01:15 PM, Caraman Mihai Claudiu-B02008 wrote: From: Alexander Graf [ag...@suse.de] Sent: Wednesday, July 04, 2012 6:45 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; KVM list; linuxppc-dev; qemu-...@nongnu.org List;

RE: [PATCH 3/4] Watchdog exit handling support

2012-07-05 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Friday, July 06, 2012 1:57 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; qemu-...@nongnu.org; kvm-ppc@vger.kernel.org; ag...@suse.de Subject: Re: [PATCH 3/4] Watchdog exit handling support On 07/04/2012 06:13 AM, Bhushan

Re: [PATCH 3/4] Watchdog exit handling support

2012-07-05 Thread Scott Wood
On 07/05/2012 07:43 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, July 06, 2012 1:57 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; qemu-...@nongnu.org; kvm-ppc@vger.kernel.org; ag...@suse.de Subject: Re: [PATCH 3/4] Watchdog exit

RE: [PATCH 3/4] Watchdog exit handling support

2012-07-05 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Friday, July 06, 2012 6:30 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; qemu-...@nongnu.org; kvm-ppc@vger.kernel.org; ag...@suse.de Subject: Re: [PATCH 3/4] Watchdog exit handling support On 07/05/2012 07:43 PM, Bhushan

Re: [PATCH 3/4] Watchdog exit handling support

2012-07-05 Thread Scott Wood
On 07/05/2012 08:16 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, July 06, 2012 6:30 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; qemu-...@nongnu.org; kvm-ppc@vger.kernel.org; ag...@suse.de Subject: Re: [PATCH 3/4] Watchdog exit