Re: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Gleb Natapov
On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote: Zhang, Yang Z wrote on 2012-12-24: Gleb Natapov wrote on 2012-12-20: On Mon, Dec 17, 2012 at 01:30:50PM +0800, Yang Zhang wrote: basically to benefit from apicv, we need clear MSR bitmap for corresponding x2apic MSRs:

Re: [PATCH 1/7] KVM: Write protect the updated slot only when we start dirty logging

2012-12-24 Thread Gleb Natapov
On Tue, Dec 18, 2012 at 04:26:47PM +0900, Takuya Yoshikawa wrote: This is needed to make kvm_mmu_slot_remove_write_access() rmap based: otherwise we may end up using invalid rmap's. Signed-off-by: Takuya Yoshikawa yoshikawa_takuya...@lab.ntt.co.jp --- arch/x86/kvm/x86.c |9 -

Re: [PATCH v3] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-24 Thread Alex Williamson
On Sun, 2012-12-23 at 10:06 +0200, Gleb Natapov wrote: On Thu, Dec 20, 2012 at 11:07:23AM +0800, Xudong Hao wrote: Enable 64 bits bar emulation. v3 changes from v2: - Leave original error string and drop the leading 016. v2 changes from v1: - Change 0lx% to 0x%016 when print a 64

Re: [PATCH] kvm: Fix memory slot generation updates

2012-12-24 Thread Alex Williamson
On Sun, 2012-12-23 at 10:55 +0200, Gleb Natapov wrote: On Fri, Dec 21, 2012 at 08:20:16AM -0700, Alex Williamson wrote: Previous patch kvm: Minor memory slot optimization overlooked the generation field of the memory slots. Re-using the original memory slots left us with with two slightly

RE: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-24: On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote: Zhang, Yang Z wrote on 2012-12-24: Gleb Natapov wrote on 2012-12-20: On Mon, Dec 17, 2012 at 01:30:50PM +0800, Yang Zhang wrote: basically to benefit from apicv, we need clear MSR bitmap for

Re: [PATCH 1/7] KVM: Write protect the updated slot only when we start dirty logging

2012-12-24 Thread Takuya Yoshikawa
On Mon, 24 Dec 2012 15:27:17 +0200 Gleb Natapov g...@redhat.com wrote: @@ -6897,7 +6897,14 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, spin_lock(kvm-mmu_lock); if (nr_mmu_pages) kvm_mmu_change_mmu_pages(kvm, nr_mmu_pages); -

Re: [PATCH 1/7] KVM: Write protect the updated slot only when we start dirty logging

2012-12-24 Thread Gleb Natapov
On Tue, Dec 25, 2012 at 01:08:40PM +0900, Takuya Yoshikawa wrote: On Mon, 24 Dec 2012 15:27:17 +0200 Gleb Natapov g...@redhat.com wrote: @@ -6897,7 +6897,14 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, spin_lock(kvm-mmu_lock); if (nr_mmu_pages)

Re: [PATCH 1/7] KVM: Write protect the updated slot only when we start dirty logging

2012-12-24 Thread Takuya Yoshikawa
On Tue, 25 Dec 2012 07:05:55 +0200 Gleb Natapov g...@redhat.com wrote: Other parts are doing if (!slot-dirty_bitmap) to see if the slot is in dirty logging mode. If you prefer, we can do the same here. Does not matter to me. If you think it will be more consistent do it. No preference

Re: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Gleb Natapov
On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-24: On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote: Zhang, Yang Z wrote on 2012-12-24: Gleb Natapov wrote on 2012-12-20: On Mon, Dec 17, 2012 at 01:30:50PM +0800, Yang Zhang wrote:

RE: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-25: On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-24: On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote: Zhang, Yang Z wrote on 2012-12-24: Gleb Natapov wrote on 2012-12-20: On Mon, Dec 17, 2012 at

Re: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Gleb Natapov
On Tue, Dec 25, 2012 at 06:42:59AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-24: On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote: Zhang, Yang Z wrote on

RE: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 06:42:59AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-24: On Mon, Dec 24, 2012 at 02:35:35AM +, Zhang, Yang Z wrote:

Re: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Gleb Natapov
On Tue, Dec 25, 2012 at 07:25:15AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 06:42:59AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on

RE: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 07:25:15AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 06:42:59AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Mon, Dec 24, 2012 at 11:53:37PM +, Zhang, Yang Z wrote:

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-24 Thread Zhang, Yang Z
Marcelo Tosatti wrote on 2012-12-21: On Thu, Dec 20, 2012 at 03:12:32PM +0200, Gleb Natapov wrote: On Thu, Dec 20, 2012 at 10:53:16AM -0200, Marcelo Tosatti wrote: On Thu, Dec 20, 2012 at 08:42:06AM +0200, Gleb Natapov wrote: On Wed, Dec 19, 2012 at 10:59:36PM -0200, Marcelo Tosatti wrote: On

Re: [PATCH v7 3/3] x86, apicv: add virtual x2apic support

2012-12-24 Thread Gleb Natapov
On Tue, Dec 25, 2012 at 07:46:53AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 07:25:15AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-25: On Tue, Dec 25, 2012 at 06:42:59AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on