Re: kvm lockdep splat with 3.8-rc1+

2012-12-26 Thread Hillf Danton
On Wed, Dec 26, 2012 at 6:30 AM, Borislav Petkov b...@alien8.de wrote: Hi all, just saw this in dmesg while running -rc1 + tip/master: [ 6983.694615] = [ 6983.694617] [ INFO: possible recursive locking detected ] [ 6983.694620] 3.8.0-rc1+ #26 Not

Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures.

2012-12-26 Thread Gleb Natapov
On Wed, Nov 21, 2012 at 06:34:00PM -0800, Sanjay Lal wrote: + +#ifndef __unused +#define __unused __attribute__((unused)) +#endif + There are __maybe_unused and __always_unused, no need to define your own. -- Gleb. -- To unsubscribe from this list: send the line

Re: KVM: VMX: fix incorrect cached cpl value with real/v8086 modes

2012-12-26 Thread Marcelo Tosatti
On Wed, Dec 26, 2012 at 07:25:49AM +0200, Gleb Natapov wrote: On Tue, Dec 25, 2012 at 07:37:10PM -0200, Marcelo Tosatti wrote: On Tue, Dec 25, 2012 at 02:48:08PM +0200, Gleb Natapov wrote: On Sat, Dec 22, 2012 at 02:31:10PM +0200, Avi Kivity wrote: On Wed, Dec 19, 2012 at 3:29 PM,

Re: KVM: VMX: fix incorrect cached cpl value with real/v8086 modes

2012-12-26 Thread Gleb Natapov
On Wed, Dec 26, 2012 at 11:25:24AM -0200, Marcelo Tosatti wrote: On Wed, Dec 26, 2012 at 07:25:49AM +0200, Gleb Natapov wrote: On Tue, Dec 25, 2012 at 07:37:10PM -0200, Marcelo Tosatti wrote: On Tue, Dec 25, 2012 at 02:48:08PM +0200, Gleb Natapov wrote: On Sat, Dec 22, 2012 at 02:31:10PM

[PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

2012-12-26 Thread Gleb Natapov
The following changes since commit e376a788ae130454ad5e797f60cb70d0308babb6: Merge remote-tracking branch 'kwolf/for-anthony' into staging (2012-12-13 14:32:28 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for you to fetch

[PATCH 1/2] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-12-26 Thread Gleb Natapov
From: Will Auld will.auld.in...@gmail.com CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to the hypervisor vcpu specific locations to store the value of the emulated MSRs. In this way the IA32_TSC_ADJUST value

[PATCH 2/2] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-26 Thread Gleb Natapov
From: Xudong Hao xudong@intel.com Enable 64 bits bar emulation. Test pass with the current seabios which already support 64bit pci bars. Signed-off-by: Xudong Hao xudong@intel.com Reviewed-by: Alex Williamson alex.william...@redhat.com Signed-off-by: Gleb Natapov g...@redhat.com ---

Re: [PATCH] trace-cmd: fix kvm_mmu_prepare_zap_page even name and kvm_mmu_get_page event output in kvm plugin

2012-12-26 Thread Steven Rostedt
On Tue, 2012-12-25 at 13:46 +0200, Gleb Natapov wrote: kvm_mmu_zap_page even was renamed to kvm_mmu_prepare_zap_page. Print out created field for kvm_mmu_get_page event. trace-cmd needs to be backward compatible with older kernels. If older kernels used kvm_mmu_zap_page, then please add a check

Re: [PATCH] trace-cmd: fix kvm_mmu_prepare_zap_page even name and kvm_mmu_get_page event output in kvm plugin

2012-12-26 Thread Gleb Natapov
On Wed, Dec 26, 2012 at 08:58:30AM -0500, Steven Rostedt wrote: On Tue, 2012-12-25 at 13:46 +0200, Gleb Natapov wrote: kvm_mmu_zap_page even was renamed to kvm_mmu_prepare_zap_page. Print out created field for kvm_mmu_get_page event. trace-cmd needs to be backward compatible with older

Re: [PATCH] trace-cmd: fix kvm_mmu_prepare_zap_page even name and kvm_mmu_get_page event output in kvm plugin

2012-12-26 Thread Steven Rostedt
On Wed, 2012-12-26 at 16:13 +0200, Gleb Natapov wrote: On Wed, Dec 26, 2012 at 08:58:30AM -0500, Steven Rostedt wrote: On Tue, 2012-12-25 at 13:46 +0200, Gleb Natapov wrote: kvm_mmu_zap_page even was renamed to kvm_mmu_prepare_zap_page. Print out created field for kvm_mmu_get_page event.

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-12-26 Thread Bjorn Helgaas
On Mon, Nov 26, 2012 at 11:46 PM, Gleb Natapov g...@redhat.com wrote: On Mon, Nov 26, 2012 at 09:46:12PM -0200, Marcelo Tosatti wrote: On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote: -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com]

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-21: On Fri, Dec 21, 2012 at 09:39:20AM -0200, Marcelo Tosatti wrote: On Fri, Dec 21, 2012 at 09:51:40AM +0200, Gleb Natapov wrote: On Thu, Dec 20, 2012 at 08:59:11PM -0200, Marcelo Tosatti wrote: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: From:

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Zhang, Yang Z
Marcelo Tosatti wrote on 2012-12-21: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com @@ -3925,6 +3942,15 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx) vmx_secondary_exec_control(vmx)); } +if

Re: kvm lockdep splat with 3.8-rc1+

2012-12-26 Thread Borislav Petkov
Hi Hillf, On Wed, Dec 26, 2012 at 08:18:13PM +0800, Hillf Danton wrote: Can you please test with 5a505085f0 and 4fc3f1d66b reverted? sure can do, but am travelling ATM so I'll run it with the reverted commits when I get back next week. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from

[PATCH KVM v2 0/4] fix KVM i8259 IRQ trailing-edge logic

2012-12-26 Thread Matthew Ogilvie
Changes since version 1 (from Sep 9): * Split off patch 1; this is the critical prerequisite to make the i8254 work with the fixed i8259. * Add patch 2, to make additional changes to the i8254 to make it consistent with the spec and with proposed changes to qemu's i8254 model.

[PATCH KVM v2 3/4] KVM: fix i8259 interrupt high to low transition logic

2012-12-26 Thread Matthew Ogilvie
Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or goes away unhandled. So the only difference between edge triggered and level triggered is in

[PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2012-12-26 Thread Matthew Ogilvie
Make git_get_out() consistent with spec. Currently pit_get_out() doesn't affect IRQ0, but it can be read by the guest in other ways. This makes it consistent with proposed changes in qemu's i8254 model as well. See http://bochs.sourceforge.net/techspec/intel-82c54-timer.pdf.gz or search the net

[PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2012-12-26 Thread Matthew Ogilvie
Reading the spec, it is clear that most modes normally leave the IRQ output line high, and only pulse it low to generate a leading edge. Especially the most commonly used mode 2. The KVM i8254 model does not try to emulate the duration of the pulse at all, so just swap the high/low settings it to

[PATCH KVM v2 4/4] KVM: i8259: refactor pic_set_irq level logic

2012-12-26 Thread Matthew Ogilvie
No change in functionality. Clarify that the only difference between level triggered and edge triggered interrupts is on the leading edge. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- arch/x86/kvm/i8259.c | 28 +++- 1 file changed, 11 insertions(+), 17

Re: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Gleb Natapov
On Thu, Dec 27, 2012 at 03:32:47AM +, Zhang, Yang Z wrote: Marcelo Tosatti wrote on 2012-12-21: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com @@ -3925,6 +3942,15 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)

Re: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Gleb Natapov
On Thu, Dec 27, 2012 at 02:24:04AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-21: On Fri, Dec 21, 2012 at 09:39:20AM -0200, Marcelo Tosatti wrote: On Fri, Dec 21, 2012 at 09:51:40AM +0200, Gleb Natapov wrote: On Thu, Dec 20, 2012 at 08:59:11PM -0200, Marcelo Tosatti wrote:

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-27: On Thu, Dec 27, 2012 at 02:24:04AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-21: On Fri, Dec 21, 2012 at 09:39:20AM -0200, Marcelo Tosatti wrote: On Fri, Dec 21, 2012 at 09:51:40AM +0200, Gleb Natapov wrote: On Thu, Dec 20, 2012 at 08:59:11PM

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-27: On Thu, Dec 27, 2012 at 03:32:47AM +, Zhang, Yang Z wrote: Marcelo Tosatti wrote on 2012-12-21: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com @@ -3925,6 +3942,15 @@ static int vmx_vcpu_setup(struct

Re: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Gleb Natapov
On Thu, Dec 27, 2012 at 06:34:37AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-27: On Thu, Dec 27, 2012 at 03:32:47AM +, Zhang, Yang Z wrote: Marcelo Tosatti wrote on 2012-12-21: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: From: Yang Zhang

[PATCH 2/2] vhost: handle polling failure

2012-12-26 Thread Jason Wang
Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: - extend the idea of vhost_net_poll_state to all vhost_polls - change the state only when polling is succeed - make vhost_poll_start()

[PATCH 1/2] vhost_net: correct error hanlding in vhost_net_set_backend()

2012-12-26 Thread Jason Wang
Fix the leaking of oldubufs and fd refcnt when fail to initialized used ring. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index

RE: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support

2012-12-26 Thread Zhang, Yang Z
Gleb Natapov wrote on 2012-12-27: On Thu, Dec 27, 2012 at 06:34:37AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2012-12-27: On Thu, Dec 27, 2012 at 03:32:47AM +, Zhang, Yang Z wrote: Marcelo Tosatti wrote on 2012-12-21: On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote: