Re: [Bug 53611] New: nVMX: Add nested EPT

2013-02-12 Thread Jan Kiszka
On 2013-02-12 20:13, Nakajima, Jun wrote: > On Mon, Feb 11, 2013 at 5:27 AM, Nadav Har'El > wrote: >> Hi, >> >> On Mon, Feb 11, 2013, Jan Kiszka wrote about "Re: [Bug 53611] New: nVMX: Add >> nested EPT": >>> On 2013-02-11 13:49, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.k

[Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-12 Thread Peter Hurley
With -next-20130204+ in ubuntu 12.10 VM (so the 80x25 VGA device/console): [0.666410] udevd[97]: starting version 175 [0.674043] udevd[97]: udevd:[97]: segfault at ff5fd020 ip 7fff069e277f sp 7fff068c9ef8 error d and boots to an initramfs prompt. git bisect (log attached

Re: [Bisected][-next-20130204+] [x86/kvm] udevd:[97]: segfault at ffffffffff5fd020 ip 00007fff069e277f sp 00007fff068c9ef8 error d

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 04:26 PM, Peter Hurley wrote: > With -next-20130204+ in ubuntu 12.10 VM (so the 80x25 VGA > device/console): > > [0.666410] udevd[97]: starting version 175 > [0.674043] udevd[97]: udevd:[97]: segfault at ff5fd020 ip > 7fff069e277f sp 7fff068c9ef8 error d > >

Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors

2013-02-12 Thread Borislav Petkov
On Tue, Feb 12, 2013 at 04:21:13PM -0800, H. Peter Anvin wrote: > On 02/12/2013 04:16 PM, Borislav Petkov wrote: > > > >This family check is redundant, we're already in a 0x10 if-branch > >above. Boris had sent a second version which doesn't have that check: > >http://marc.info/?l=linux-kernel&m=13

Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support

2013-02-12 Thread Andreas Färber
Am 01.02.2013 08:39, schrieb Jason Wang: > diff --git a/net/net.c b/net/net.c > index 98a1934..9806862 100644 > --- a/net/net.c > +++ b/net/net.c [...] > @@ -271,9 +287,7 @@ static void qemu_cleanup_net_client(NetClientState *nc) > { > QTAILQ_REMOVE(&net_clients, nc, next); > > -if (nc-

Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support

2013-02-12 Thread Alexander Graf
On 01.02.2013, at 08:39, Jason Wang wrote: > This patch adds basic multiqueue support for qemu. The idea is simple, an > array > of NetClientStates were introduced in NICState, parse_netdev() were extended > to > find and match all NetClientStates belongs to the backend and place their > pointe

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 09:08:27PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto: > > On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: > Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just > for this are definitely too

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto: > On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just for this are definitely too many and make the API harder to use. You have to find a balan

Re: [Bug 53611] New: nVMX: Add nested EPT

2013-02-12 Thread Nakajima, Jun
On Mon, Feb 11, 2013 at 5:27 AM, Nadav Har'El wrote: > Hi, > > On Mon, Feb 11, 2013, Jan Kiszka wrote about "Re: [Bug 53611] New: nVMX: Add > nested EPT": >> On 2013-02-11 13:49, bugzilla-dae...@bugzilla.kernel.org wrote: >> > https://bugzilla.kernel.org/show_bug.cgi?id=53611 >> >Summ

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: > >> Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just > >> for this are definitely too many and make the API harder to use. > >> > >> You have to find a balance. Having actually used the API, the > >> possibilit

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 18:34, Michael S. Tsirkin ha scritto: > On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: >> Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: >>> On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: >>>

[PATCH v2 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
virtio device drivers translate requests from higher layer in two steps: a device-specific step in the device driver, and generic preparation of virtio direct or indirect buffers in virtqueue_add_buf. Because virtqueue_add_buf also accepts the outcome of the first step as a single struct scatterli

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: > > On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: > >> Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: > > + * @nsg: the number of sg lists that will be

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: > On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: >> Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: > + * @nsg: the number of sg lists that will be added >>> This means number of calls to add_sg ? Not sure why this

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: > >>> + * @nsg: the number of sg lists that will be added > > This means number of calls to add_sg ? Not sure why this matters. > > How about we pass in in_num/out_num -

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: >>> + * @nsg: the number of sg lists that will be added > This means number of calls to add_sg ? Not sure why this matters. > How about we pass in in_num/out_num - that is total # of sg, > same as add_buf? It is used to c

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 04:48:39PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 16:43, Michael S. Tsirkin ha scritto: > > On Tue, Feb 12, 2013 at 04:32:27PM +0100, Paolo Bonzini wrote: > >> Il 12/02/2013 15:56, Michael S. Tsirkin ha scritto: > > +/** > > + * virtqueue_start_buf - start build

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 16:43, Michael S. Tsirkin ha scritto: > On Tue, Feb 12, 2013 at 04:32:27PM +0100, Paolo Bonzini wrote: >> Il 12/02/2013 15:56, Michael S. Tsirkin ha scritto: > +/** > + * virtqueue_start_buf - start building buffer for the other end > + * @vq: the struct virtqueue we're ta

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 04:32:27PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 15:56, Michael S. Tsirkin ha scritto: > >> > +/** > >> > + * virtqueue_start_buf - start building buffer for the other end > >> > + * @vq: the struct virtqueue we're talking about. > >> > + * @data: the token identifying

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 15:56, Michael S. Tsirkin ha scritto: >> > +/** >> > + * virtqueue_start_buf - start building buffer for the other end >> > + * @vq: the struct virtqueue we're talking about. >> > + * @data: the token identifying the buffer. >> > + * @nents: the number of buffers that will be added >

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 01:23:27PM +0100, Paolo Bonzini wrote: > virtio device drivers translate requests from higher layer in two steps: > a device-specific step in the device driver, and generic preparation > of virtio direct or indirect buffers in virtqueue_add_buf. Because > virtqueue_add_buf

Re: KVM call agenda for 2013-02-12

2013-02-12 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there is no topics, call gets canceled. Happy hacking, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-12 Thread Eduardo Habkost
On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: > On Fri, 8 Feb 2013 16:13:02 -0200 > Eduardo Habkost wrote: > > > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, I

Win2003 disk corruption with kvm-1.0. and virtio

2013-02-12 Thread Sylvain Bauza
Hi, We currently run Openstack Essex hosts with KVM-1.0 (Ubuntu 12.04) instances with qcow2,virtio,cache=none For Linux VMs, no trouble at all but we do observe filesystem corruption and inconsistency (missing DLLs, CHKDSK asked by EventViewer, failure at reboot) with some of our Windows 200

[PATCH v3 0/5] virtio-scsi multiqueue

2013-02-12 Thread Paolo Bonzini
This series implements virtio-scsi queue steering, which gives performance improvements of up to 50% (measured both with QEMU and tcm_vhost backends). The patches build on top of the new virtio APIs at http://permalink.gmane.org/gmane.linux.kernel.virtualization/18431; the new API simplifies the l

[PATCH v3 1/5] virtio-scsi: redo allocation of target data

2013-02-12 Thread Paolo Bonzini
virtio_scsi_target_state is now empty, but we will find new uses for it in the next few patches. However, dropping the sglist lets us turn the array-of-pointers into a simple array, which simplifies the allocation. However, we do not leave the virtio_scsi_target_state structs in the flexible arra

[PATCH v3 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-02-12 Thread Paolo Bonzini
From: Wanlong Gao Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-s...@vger.kernel.org Signed-off-by: Wanlong Gao [ The version that doesn't get/put_online_cpus is now called __virtscsi_set_affinity - Paolo ] Signed-off-by: Paolo Bonzini --- dr

[PATCH v3 4/5] virtio-scsi: introduce multiqueue support

2013-02-12 Thread Paolo Bonzini
This patch adds queue steering to virtio-scsi. When a target is sent multiple requests, we always drive them to the same queue so that FIFO processing order is kept. However, if a target was idle, we can choose a queue arbitrarily. In this case the queue is chosen according to the current VCPU,

[PATCH v3 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

2013-02-12 Thread Paolo Bonzini
Avoid duplicated code in all of the callers. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 3dd

[PATCH v3 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

2013-02-12 Thread Paolo Bonzini
This will be needed soon in order to retrieve the per-target struct. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virti

Re: KVM: x86: switch unhandled MSR printk's to tracepoints

2013-02-12 Thread Marcelo Tosatti
On Tue, Feb 12, 2013 at 02:33:17PM +0200, Gleb Natapov wrote: > On Mon, Feb 11, 2013 at 09:50:09PM -0200, Marcelo Tosatti wrote: > > > > Such messages in the system log very often cause confusion because users > > understand the "kvm: unhandled MSR" messages as errors. > > > They are errors. Linu

Re: KVM: x86: switch unhandled MSR printk's to tracepoints

2013-02-12 Thread Gleb Natapov
On Mon, Feb 11, 2013 at 09:50:09PM -0200, Marcelo Tosatti wrote: > > Such messages in the system log very often cause confusion because users > understand the "kvm: unhandled MSR" messages as errors. > They are errors. Linux compiled with PV support ignores them, but other guest OSes or Linux wit

[PATCH 2/9] virtio-blk: reorganize virtblk_add_req

2013-02-12 Thread Paolo Bonzini
Right now, both virtblk_add_req and virtblk_add_req_wait call virtqueue_add_buf. To prepare for the next patches, abstract the call to virtqueue_add_buf into a new function __virtblk_add_req, and include the waiting logic directly in virtblk_add_req. Signed-off-by: Paolo Bonzini --- drivers/blo

[PATCH 5/9] scatterlist: introduce sg_unmark_end

2013-02-12 Thread Paolo Bonzini
This is useful in places that recycle the same scatterlist multiple times, and do not want to incur the cost of sg_init_table every time in hot paths. Acked-by: Jens Axboe Signed-off-by: Paolo Bonzini --- block/blk-integrity.c |2 +- block/blk-merge.c |2 +- include/linu

[PATCH 6/9] virtio-net: unmark scatterlist ending after virtqueue_add_buf

2013-02-12 Thread Paolo Bonzini
Prepare for when virtqueue_add_buf will use sg_next instead of ignoring ending markers. Note that for_each_sg (and thus virtqueue_add_sg) allows you to pass a "truncated" scatterlist that does not have a marker on the last item. We rely on this in add_recvbuf_mergeable. Signed-off-by: Paolo Bonz

[PATCH 3/9] virtio-blk: use virtqueue_start_buf on bio path

2013-02-12 Thread Paolo Bonzini
Move the creation of the request header and response footer to __virtblk_add_req. vbr->sg only contains the data scatterlist, the header/footer are added separately using the new piecewise API for building virtqueue buffers. With this change, virtio-blk (with use_bio) is not relying anymore on th

[PATCH 4/9] virtio-blk: use virtqueue_start_buf on req path

2013-02-12 Thread Paolo Bonzini
This is similar to the previous patch, but a bit more radical because the bio and req paths now share the buffer construction code. Because the req path doesn't use vbr->sg, however, we need to add a couple of arguments to __virtblk_add_req. We also need to teach __virtblk_add_req how to build SC

[PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
virtio device drivers translate requests from higher layer in two steps: a device-specific step in the device driver, and generic preparation of virtio direct or indirect buffers in virtqueue_add_buf. Because virtqueue_add_buf also accepts the outcome of the first step as a single struct scatterli

[PATCH 9/9] virtio: reimplement virtqueue_add_buf using new functions

2013-02-12 Thread Paolo Bonzini
Eliminate the code duplication between virtqueue_add_buf and virtqueue_add_sg. That's safe to do now that no devices will pass scatterlists with a termination marker in the middle. Signed-off-by: Paolo Bonzini --- drivers/virtio/virtio_ring.c | 159 +++--- 1

[PATCH 8/9] virtio: introduce and use virtqueue_add_buf_single

2013-02-12 Thread Paolo Bonzini
Adding a single direct buffer is a very common case. Introduce an optimized function for that. Signed-off-by: Paolo Bonzini --- drivers/char/hw_random/virtio-rng.c |2 +- drivers/char/virtio_console.c |4 +- drivers/net/virtio_net.c|2 +- drivers/rpmsg/virtio_rpmsg

[PATCH 7/9] virtio-scsi: use virtqueue_start_buf

2013-02-12 Thread Paolo Bonzini
Using the new virtio_scsi_add_sg function lets us simplify the queueing path. In particular, all data protected by the tgt_lock is just gone (multiqueue will find a new use for the lock). The speedup is relatively small (2-4%) but it is worthwhile because of the code simplification it enables. A

[PATCH 0/9] virtio: new API for addition of buffers, scatterlist changes

2013-02-12 Thread Paolo Bonzini
Most device drivers do not need to perform any postprocessing on the scatterlists they receive from higher-level drivers (e.g. the block or SCSI layer), because they translate the request metadata directly from the various C structs into the data that is required by the device. virtio devices howe

[PATCH 2/2 v2] Added one_reg interface for timer registers

2013-02-12 Thread Bharat Bhushan
If userspace wants to change some specific bits of TSR (timer status register) then it uses GET/SET_SREGS ioctl interface. So the steps will be: i) user-space will make get ioctl, ii) change TSR in userspace iii) then make set ioctl. It can happen that TSR gets changed by kerne

[PATCH 1/2 v2] KVM: PPC: move tsr update in a separate function

2013-02-12 Thread Bharat Bhushan
This is done so that same function can be called from SREGS and ONE_REG interface (follow up patch). Signed-off-by: Bharat Bhushan --- v2: No Change arch/powerpc/kvm/booke.c | 24 ++-- arch/powerpc/kvm/booke.h |1 + 2 files changed, 15 insertions(+), 10 deletions(-)

[PATCH 0/2 v2] KVM:PPC Adding one_reg interface for TCR and TSR

2013-02-12 Thread Bharat Bhushan
This patchset adds the one_reg interface to get/set TSR and TCR registers. This patchet also adds the one_reg interface to or/clear specific bits in TSR register. v2: -- Added Documentation Bharat Bhushan (2): move tsr update in a seprate function Added one_reg interface for timer registers

Lockups using per-thread cgs and kvm

2013-02-12 Thread Andrey Korolyov
Hi, We (a cloud hosting provider) has recently observed a couple of strange lockups when physical node runs significant amount of Win2008R2 kvm appliances, one may see collection of those lockups at the link below. After checking a lot of ideas without any valuable result, I have suggested that ne

[Bug 53711] nVMX: potential bug with IDT_VECTORING_INFO if !PIN_BASED_EXT_INTR_MASK

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53711 Nadav Har'El changed: What|Removed |Added Blocks||53601 -- Configure bugmail: https://b

[Bug 53601] nVMX meta-bug

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53601 Nadav Har'El changed: What|Removed |Added Depends on||53711 -- Configure bugmail: https://b

[Bug 53711] New: nVMX: potential bug with IDT_VECTORING_INFO if !PIN_BASED_EXT_INTR_MASK

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53711 Summary: nVMX: potential bug with IDT_VECTORING_INFO if !PIN_BASED_EXT_INTR_MASK Product: Virtualization Version: unspecified Platform: All OS/Version: Linux Tree:

[Bug 53701] nVMX: Unchecked setting of cr4 for nested guest

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53701 Nadav Har'El changed: What|Removed |Added Blocks||53601 -- Configure bugmail: https://b

[Bug 53601] nVMX meta-bug

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53601 Nadav Har'El changed: What|Removed |Added Depends on||53701 -- Configure bugmail: https://b

[Bug 53701] New: nVMX: Unchecked setting of cr4 for nested guest

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53701 Summary: nVMX: Unchecked setting of cr4 for nested guest Product: Virtualization Version: unspecified Platform: All OS/Version: Linux Tree: Mainline Status: NEW

[Bug 53601] nVMX meta-bug

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53601 Nadav Har'El changed: What|Removed |Added Depends on||53691 -- Configure bugmail: https://b

[Bug 53691] nVMX: Bug when L1 is swapped out

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53691 Nadav Har'El changed: What|Removed |Added Blocks||53601 -- Configure bugmail: https://b

[Bug 53691] New: nVMX: Bug when L1 is swapped out

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53691 Summary: nVMX: Bug when L1 is swapped out Product: Virtualization Version: unspecified Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: norma

[Bug 53681] nVMX: Rare crash on shadow-on-shadow case

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53681 Nadav Har'El changed: What|Removed |Added Blocks||53601 -- Configure bugmail: https://b

[Bug 53601] nVMX meta-bug

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53601 Nadav Har'El changed: What|Removed |Added Depends on||53681 -- Configure bugmail: https://b

[Bug 53681] New: nVMX: Rare crash on shadow-on-shadow case

2013-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53681 Summary: nVMX: Rare crash on shadow-on-shadow case Product: Virtualization Version: unspecified Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severi