Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 05.09.14 13:39, Frank Blaschka wrote: > On Fri, Sep 05, 2014 at 10:21:27AM +0200, Alexander Graf wrote: >> >> >> On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: >>> This set of patches implements pci pass-through support for qemu/KVM on >>> s390. >>> PCI support on s390 is very different

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 05.09.14 13:55, Frank Blaschka wrote: > On Fri, Sep 05, 2014 at 10:35:59AM +0200, Alexander Graf wrote: >> >> >> On 05.09.14 09:46, Frank Blaschka wrote: >>> On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Paolo Bonzini wrote: > Il 05/09/2014 23:24, Thomas Gleixner ha scritto: > > > >> > that besides acting as a workaround, I find the patched code easier to > >> > understand, and I clearly stated the same in the tag message. > > Well, we might have different opinions about easie

[GIT PULL v2] KVM changes for 3.17-rc4

2014-09-05 Thread Paolo Bonzini
Linus, The following changes since commit 30d1e0e806e5b2fadc297ba78f2d7afd6ba309cf: virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it (2014-08-19 15:12:28 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Paolo Bonzini
Il 05/09/2014 23:24, Thomas Gleixner ha scritto: > >> > that besides acting as a workaround, I find the patched code easier to >> > understand, and I clearly stated the same in the tag message. > Well, we might have different opinions about easier to understand. I > did go a great length to distan

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Paolo Bonzini wrote: > Il 05/09/2014 22:58, Thomas Gleixner ha scritto: > > Nothing new there. Forgot to push out, or perhaps to use "-f" to > > overwrite the previous tag of the same name? > > It's there now. Probably a --dry-run too much (I have > push=+refs/tags/for-linus:

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Paolo Bonzini
Il 05/09/2014 22:58, Thomas Gleixner ha scritto: > Nothing new there. Forgot to push out, or perhaps to use "-f" to > overwrite the previous tag of the same name? It's there now. Probably a --dry-run too much (I have push=+refs/tags/for-linus:refs/tags/for-linus in the remote configuration). > A

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Paolo Bonzini
Il 05/09/2014 22:41, Thomas Gleixner ha scritto: > No, it needs to be above update_vsyscall(). Here is the patch again > which I sent before. [https://lkml.org/lkml/2014/9/5/395] Ah, I missed it after your signature. Thanks, I'll test yours then next week. Paolo -- To unsubscribe from this list:

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Linus Torvalds wrote: > On Fri, Sep 5, 2014 at 3:16 AM, Paolo Bonzini wrote: > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > Nothing new there. Forgot to push out, or perhaps to use "-f" to > overwrite

Re: [GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Linus Torvalds
On Fri, Sep 5, 2014 at 3:16 AM, Paolo Bonzini wrote: > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus Nothing new there. Forgot to push out, or perhaps to use "-f" to overwrite the previous tag of the same name? Linus -- To

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Paolo Bonzini wrote: > Il 05/09/2014 20:33, Thomas Gleixner ha scritto: > >> > update_vsyscall(tk); > >> > -update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET); > >> > > >> > tk_update_ktime_data(tk); > >> > +update_pvclock_gtod(tk, action & TK

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Paolo Bonzini
Il 05/09/2014 20:33, Thomas Gleixner ha scritto: >> >update_vsyscall(tk); >> > - update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET); >> > >> >tk_update_ktime_data(tk); >> > + update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET); > Why are you moving the update between vsycall and pvclock u

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Paolo Bonzini wrote: > Il 05/09/2014 17:14, Thomas Gleixner ha scritto: > > So that means the code is correct. Now where is the bug? > > In kernel/time/timekeeping.c? > > We know that we should have > > base_mono = wall_to_monotonic + xtime_sec > > Instead

Re: [PATCH v3 0/4 resend] Introduce device assignment flag operation helper function

2014-09-05 Thread Bjorn Helgaas
On Fri, Aug 08, 2014 at 01:36:03PM +0800, Ethan Zhao wrote: > This patch set introduces three PCI device flag operation helper functions > when set pci device PF/VF to assigned or deassigned status also check it. > and patch 2,3,4 apply these helper functions to KVM,XEN and PCI. > > v2: simplify u

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Paolo Bonzini
Il 05/09/2014 17:14, Thomas Gleixner ha scritto: > So that means the code is correct. Now where is the bug? In kernel/time/timekeeping.c? We know that we should have base_mono = wall_to_monotonic + xtime_sec Instead it is base_mono = wall_to_monotonic + xtime_se

Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

2014-09-05 Thread Thomas Gleixner
On Thu, 4 Sep 2014, Paolo Bonzini wrote: > Il 04/09/2014 22:58, Thomas Gleixner ha scritto: > > This is simply wrong. > > It is. > > > Now I have no idea why you think it needs to add xtime_sec. If the > > result is wrong, then we need to figure out which one of the supplied > > values is wrong

Re: [RFC v2 0/9] KVM-VFIO IRQ forward control

2014-09-05 Thread Eric Auger
On 09/02/2014 11:05 PM, Alex Williamson wrote: > On Mon, 2014-09-01 at 14:52 +0200, Eric Auger wrote: >> This RFC proposes an integration of "ARM: Forwarding physical >> interrupts to a guest VM" (http://lwn.net/Articles/603514/) in >> KVM. >> >> It enables to transform a VFIO platform driver IRQ i

Re: [PATCH v5 3/3] ivshmem: add check on protocol version in QEMU

2014-09-05 Thread David Marchand
Hello Stefan, On 09/05/2014 12:29 PM, Stefan Hajnoczi wrote: On Thu, Sep 04, 2014 at 02:51:01PM +0200, David Marchand wrote: diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c index ad210c8..0c4e016 100644 --- a/contrib/ivshmem-client/ivshmem-client.

Re: [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread David Marchand
Hello Michael, On 09/04/2014 05:56 PM, Michael S. Tsirkin wrote: +/* create the unix listening socket */ +sock_fd = socket(AF_UNIX, SOCK_STREAM, 0); +if (sock_fd < 0) { +debug_log(server, "cannot create socket: %s\n", strerror(errno)); +goto err_close_shm; +} + +

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Frank Blaschka
On Fri, Sep 05, 2014 at 10:35:59AM +0200, Alexander Graf wrote: > > > On 05.09.14 09:46, Frank Blaschka wrote: > > On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: > >> On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote: > >>> This set of patches implements pci pas

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Frank Blaschka
On Fri, Sep 05, 2014 at 10:21:27AM +0200, Alexander Graf wrote: > > > On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: > > This set of patches implements pci pass-through support for qemu/KVM on > > s390. > > PCI support on s390 is very different from other platforms. > > Major differences ar

Re: [RFC][patch 3/6] KVM: s390: Add GISA support

2014-09-05 Thread Frank Blaschka
On Fri, Sep 05, 2014 at 10:29:26AM +0200, Alexander Graf wrote: > > > On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: > > From: Frank Blaschka > > > > This patch adds GISA (Guest Interrupt State Area) support > > to s390 kvm. GISA can be used for exitless interrupts. The > > patch provides

Re: [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:50:59PM +0200, David Marchand wrote: > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-by: Olivier Matz > Signe

Re: [PATCH v5 2/3] docs: update ivshmem device spec

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:51:00PM +0200, David Marchand wrote: > Add some notes on the parts needed to use ivshmem devices: more specifically, > explain the purpose of an ivshmem server and the basic concept to use the > ivshmem devices in guests. > Move some parts of the documentation and re-orga

Re: [PATCH v5 3/3] ivshmem: add check on protocol version in QEMU

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:51:01PM +0200, David Marchand wrote: > diff --git a/contrib/ivshmem-client/ivshmem-client.c > b/contrib/ivshmem-client/ivshmem-client.c > index ad210c8..0c4e016 100644 > --- a/contrib/ivshmem-client/ivshmem-client.c > +++ b/contrib/ivshmem-client/ivshmem-client.c > @@ -1

Re: [PATCH] kvm tools: arm: remove register accessor macros now that they are in uapi

2014-09-05 Thread Will Deacon
On Fri, Aug 29, 2014 at 02:00:24PM +0100, Will Deacon wrote: > The kernel now exposes register accessor macros in the uapi/ headers > for arm and arm64, so use those instead (and avoid the compile failure > from the duplicate definitions). > > Signed-off-by: Will Deacon > --- > > Pekka -- please

[GIT PULL] KVM changes for 3.17-rc4

2014-09-05 Thread Paolo Bonzini
Linus, The following changes since commit 30d1e0e806e5b2fadc297ba78f2d7afd6ba309cf: virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it (2014-08-19 15:12:28 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for

Re: [PATCH 3/4] KVM: x86: inject nested page faults on emulated instructions

2014-09-05 Thread Gleb Natapov
On Thu, Sep 04, 2014 at 07:44:51PM +0200, Paolo Bonzini wrote: > Il 04/09/2014 17:05, Gleb Natapov ha scritto: > >> > > >> > If you do that, KVM gets down to the "if (writeback)" and writes the > >> > ctxt->eip from L2 into the L1 EIP. > > Heh, that's a bummer. We should not write back if an inst

Re: [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Claudio Fontana
Just to point out that for the client there is also a DEBUG_LOG to uppercase, just like already pointed out for the server. >> diff --git a/contrib/ivshmem-client/ivshmem-client.c >> b/contrib/ivshmem-client/ivshmem-client.c >> new file mode 100644 >> index 000..ad210c8 >> --- /dev/null >> +

Re: [RFC][patch 4/6] KVM: s390: Add PCI pass-through support

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: > From: Frank Blaschka > > This patch implemets PCI pass-through kernel support for s390. > Design approach is very similar to the x86 device assignment. > User space executes the KVM_ASSIGN_PCI_DEVICE ioctl to create > a proxy instance in the

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 05.09.14 09:46, Frank Blaschka wrote: > On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: >> On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote: >>> This set of patches implements pci pass-through support for qemu/KVM on >>> s390. >>> PCI support on s390 is very

Re: [RFC][patch 3/6] KVM: s390: Add GISA support

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: > From: Frank Blaschka > > This patch adds GISA (Guest Interrupt State Area) support > to s390 kvm. GISA can be used for exitless interrupts. The > patch provides a set of functions for GISA related operations > like accessing GISA fields or r

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Alexander Graf
On 04.09.14 12:52, frank.blasc...@de.ibm.com wrote: > This set of patches implements pci pass-through support for qemu/KVM on s390. > PCI support on s390 is very different from other platforms. > Major differences are: > > 1) all PCI operations are driven by special s390 instructions > 2) all s3

Re: [PATCH v2 12/15] arm/arm64: KVM: add virtual GICv3 distributor emulation

2014-09-05 Thread Andre Przywara
Hi wanghaibin, On 05/09/14 04:28, wanghaibin wrote: > On 2014/8/21 21:06, Andre Przywara wrote: > > >> +void vgic_v3_dispatch_sgi(struct kvm_vcpu *vcpu, u64 reg) >> +{ >> +struct kvm *kvm = vcpu->kvm; >> +struct kvm_vcpu *c_vcpu; >> +struct vgic_dist *dist = &kvm->arch.vgic; >> +

Re: [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-05 Thread Frank Blaschka
On Thu, Sep 04, 2014 at 07:16:24AM -0600, Alex Williamson wrote: > On Thu, 2014-09-04 at 12:52 +0200, frank.blasc...@de.ibm.com wrote: > > This set of patches implements pci pass-through support for qemu/KVM on > > s390. > > PCI support on s390 is very different from other platforms. > > Major dif

[Bug 83381] 4-ports 82576 detect 2 ports when add "intel_iommu=on pci=assign-busses".

2014-09-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=83381 robert...@intel.com changed: What|Removed |Added CC||robert...@intel.com --- Comment #10