Re: [RFC PATCH 0/6] ARM64: KVM: PMU infrastructure support

2015-01-07 Thread Anup Patel
On Tue, Dec 30, 2014 at 11:19 AM, Anup Patel wrote: > (dropping previous conversation for easy reading) > > Hi Marc/Christoffer, > > I tried implementing PMU context-switch via C code > in EL1 mode and in atomic context with irqs disabled. > The context switch itself works perfectly fine but > irq

Re: [PATCH v15 11/11] KVM: arm/arm64: Add support to dissolve huge PUD

2015-01-07 Thread Mario Smarduch
On 01/07/2015 05:05 AM, Christoffer Dall wrote: > On Sun, Dec 14, 2014 at 11:28:08PM -0800, Mario Smarduch wrote: >> This patch adds the same support for PUD huge page as for PMD. Huge PUD is >> write protected for initial memory region write protection. Code to dissolve >> huge PUD is supported

Re: [PATCH v15 10/11] KVM: arm/arm64: Enable Dirty Page logging for ARMv8

2015-01-07 Thread Mario Smarduch
On 01/07/2015 04:47 AM, Christoffer Dall wrote: > On Sun, Dec 14, 2014 at 11:28:07PM -0800, Mario Smarduch wrote: >> This patch enables ARMv8 ditry page logging support. Plugs ARMv8 into generic > >dirty yeah. > >> layer through Kconfig symbol, and drops earlier ARM64

Re: [RESEND PATCH v15 07/11] KVM: arm: page logging 2nd stage fault handling

2015-01-07 Thread Mario Smarduch
Hi Christoffer, before going through your comments, I discovered that in 3.18.0-rc2 - a generic __get_user_pages_fast() was implemented, now ARM picks this up. This causes gfn_to_pfn_prot() to return meaningful 'writable' value for a read fault, provided the region is writable. Prior to that the

Re: [PATCH] vhost/net: length miscalculation

2015-01-07 Thread Sergei Shtylyov
Hello. On 01/07/2015 11:55 AM, Michael S. Tsirkin wrote: commit 8b38694a2dc8b18374310df50174f1e4376d6824 vhost/net: virtio 1.0 byte swap had this chunk: - heads[headcount - 1].len += datalen; + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); This adds datalen w

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Scott Wood
On Wed, 2015-01-07 at 10:55 +, Andre Przywara wrote: > Hi Scott, > > thanks for looking at the patch. > > On 06/01/15 20:52, Scott Wood wrote: > > Out of curiosity, why do you need to test it from inside the kernel but > > outside kvm_main.c? > > I need it from arch/arm/kvm/arm.c or alternat

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Scott Wood
On Wed, 2015-01-07 at 18:11 +, Andre Przywara wrote: > On 07/01/15 17:45, Scott Wood wrote: > > On Wed, 2015-01-07 at 10:55 +, Andre Przywara wrote: > >> Hi Scott, > >> > >> thanks for looking at the patch. > >> > >> On 06/01/15 20:52, Scott Wood wrote: > >>> Out of curiosity, why do you ne

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Andre Przywara
On 07/01/15 17:45, Scott Wood wrote: > On Wed, 2015-01-07 at 10:55 +, Andre Przywara wrote: >> Hi Scott, >> >> thanks for looking at the patch. >> >> On 06/01/15 20:52, Scott Wood wrote: >>> Out of curiosity, why do you need to test it from inside the kernel but >>> outside kvm_main.c? >> >> I

Re: [PATCH 1/3] x86_64,entry: Fix RCX for traced syscalls

2015-01-07 Thread Borislav Petkov
On Tue, Jan 06, 2015 at 08:00:41PM +0100, Borislav Petkov wrote: > I'll redo the whole games tomorrow. Ok I can't reproduce today either. Let's ascribe it to this particular test box being funny or something in 3.19-rcs. We can look at it if it happens again. Thanks. -- Regards/Gruss, Bori

Re: [PATCH] vhost/net: length miscalculation

2015-01-07 Thread Alex Williamson
On Wed, 2015-01-07 at 10:55 +0200, Michael S. Tsirkin wrote: > commit 8b38694a2dc8b18374310df50174f1e4376d6824 > vhost/net: virtio 1.0 byte swap > had this chunk: > - heads[headcount - 1].len += datalen; > + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); > > This add

Re: [RFC 2/2] x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader

2015-01-07 Thread Marcelo Tosatti
On Tue, Jan 06, 2015 at 11:18:21PM -0800, Andy Lutomirski wrote: > On Tue, Jan 6, 2015 at 9:38 PM, Paolo Bonzini wrote: > > > > > > On 06/01/2015 17:56, Andy Lutomirski wrote: > >> Still no good. We can migrate a bunch of times so we see the same CPU > >> all three times > > > > There are no thre

Re: [PATCH] arm64: KVM: Fix HCR setting for 32bit guests

2015-01-07 Thread Christoffer Dall
On Wed, Jan 07, 2015 at 10:45:03AM +, Marc Zyngier wrote: > Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu > when resetting the vcpu) moved the init of the HCR register to > happen later in the init of a vcpu, but left out the fixup > done in kvm_reset_vcpu when preparing for a

Re: [ÞATCH] kvmtool, mips: Support more than 256 MB guest memory

2015-01-07 Thread Andreas Herrmann
On Wed, Jan 07, 2015 at 05:38:53PM +0800, Chen, Tiejun wrote: > On 2015/1/6 21:15, Andreas Herrmann wrote: > >Two guest memory regions need to be defined and two "mem=" parameters > >need to be passed to guest kernel to support more than 256 MB. > > > >Signed-off-by: Andreas Herrmann > >--- > > t

Re: [PATCH v15 06/11] KVM: arm: dirty logging write protect support

2015-01-07 Thread Christoffer Dall
On Sun, Dec 14, 2014 at 11:28:03PM -0800, Mario Smarduch wrote: > Add support to track dirty pages between user space KVM_GET_DIRTY_LOG ioctl > calls. We call kvm_get_dirty_log_protect() function to do most of the work. > > Reviewed-by: Marc Zyngier > Signed-off-by: Mario Smarduch Reviewed-by:

Re: [PATCH v15 05/11] KVM: arm: Add initial dirty page locking support

2015-01-07 Thread Christoffer Dall
On Sun, Dec 14, 2014 at 11:28:02PM -0800, Mario Smarduch wrote: > Add support for initial write protection of VM memslots. This patch > series assumes that huge PUDs will not be used in 2nd stage tables, which is > always valid on ARMv7 > > Signed-off-by: Mario Smarduch Acked-by: Christoffer Dal

Re: [PATCH v15 11/11] KVM: arm/arm64: Add support to dissolve huge PUD

2015-01-07 Thread Christoffer Dall
On Sun, Dec 14, 2014 at 11:28:08PM -0800, Mario Smarduch wrote: > This patch adds the same support for PUD huge page as for PMD. Huge PUD is > write protected for initial memory region write protection. Code to dissolve > huge PUD is supported in user_mem_abort(). At this time this code has not

Re: [PATCH v15 10/11] KVM: arm/arm64: Enable Dirty Page logging for ARMv8

2015-01-07 Thread Christoffer Dall
On Sun, Dec 14, 2014 at 11:28:07PM -0800, Mario Smarduch wrote: > This patch enables ARMv8 ditry page logging support. Plugs ARMv8 into generic dirty > layer through Kconfig symbol, and drops earlier ARM64 constraints to enable > logging at architecture layer. > > Sign

Re: Clarification for patch 7

2015-01-07 Thread Christoffer Dall
On Tue, Dec 16, 2014 at 07:40:09PM -0800, Mario Smarduch wrote: > Hi Christoffer, Marc - >in stage2_dissolve_pmd() CONFIG_SMP is > unnecessary. At the time huge page is write protected, > until it faults and is cleared any page in the range > may be dirty not just the gpa access that caused the

Re: [RESEND PATCH v15 07/11] KVM: arm: page logging 2nd stage fault handling

2015-01-07 Thread Christoffer Dall
On Wed, Dec 17, 2014 at 06:07:29PM -0800, Mario Smarduch wrote: > This patch is a followup to v15 patch series, with following changes: > - When clearing/dissolving a huge, PMD mark huge page range dirty, since > the state of whole range is unknown. After the huge page is dissolved > dirty pag

AVERTISMENT !!

2015-01-07 Thread WEB ADMIN
-- E-mail ®account frissíteni kell az F-Secure R-HTK4S új (2015) verziója az anti-spam / anti-virus / anti-spyware. Kérjük, kattintson az alábbi linkre frissítések == >> http://webmaster-hungaryservice.dudaone.com/ A kellemetlenségért elnézést. Üdvözlettel, WEBMAIL RENDSZERGAZDA Minden jog fe

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Andre Przywara
Hi Scott, thanks for looking at the patch. On 06/01/15 20:52, Scott Wood wrote: > On Tue, 2015-01-06 at 16:12 +, Andre Przywara wrote: >> While we can easily register and unregister KVM devices, there is >> currently no easy way of checking whether a device has been >> registered. >> Introduc

Re: [PATCH] arm64: KVM: Fix HCR setting for 32bit guests

2015-01-07 Thread Vladimir Murzin
Hi Marc, On 07/01/15 10:45, Marc Zyngier wrote: > Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu > when resetting the vcpu) moved the init of the HCR register to > happen later in the init of a vcpu, but left out the fixup > done in kvm_reset_vcpu when preparing for a 32bit guest.

[PATCH] arm64: KVM: Fix HCR setting for 32bit guests

2015-01-07 Thread Marc Zyngier
Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu when resetting the vcpu) moved the init of the HCR register to happen later in the init of a vcpu, but left out the fixup done in kvm_reset_vcpu when preparing for a 32bit guest. As a result, the 32bit guest is run as a 64bit guest, b

Re: [ÞATCH] kvmtool, mips: Support more than 256 MB guest memory

2015-01-07 Thread Chen, Tiejun
On 2015/1/6 21:15, Andreas Herrmann wrote: Two guest memory regions need to be defined and two "mem=" parameters need to be passed to guest kernel to support more than 256 MB. Signed-off-by: Andreas Herrmann --- tools/kvm/mips/include/kvm/kvm-arch.h | 10 + tools/kvm/mips/kvm.c

Re: [RFC 2/2] x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 08:18, Andy Lutomirski wrote: >>> >> Thus far, I've been told unambiguously that a guest can't observe pvti >>> >> while it's being written, and I think you're now telling me that this >>> >> isn't true and that a guest *can* observe pvti while it's being >>> >> written while the lo

Re: [PATCH v8 34/50] vhost/net: virtio 1.0 byte swap

2015-01-07 Thread Michael S. Tsirkin
On Wed, Jan 07, 2015 at 09:31:05AM +0100, Greg Kurz wrote: > On Tue, 06 Jan 2015 16:55:30 -0700 > Alex Williamson wrote: > > > On Mon, 2014-12-01 at 18:05 +0200, Michael S. Tsirkin wrote: > > > I had to add an explicit tag to suppress compiler warning: > > > gcc isn't smart enough to notice that

[PATCH] vhost/net: length miscalculation

2015-01-07 Thread Michael S. Tsirkin
commit 8b38694a2dc8b18374310df50174f1e4376d6824 vhost/net: virtio 1.0 byte swap had this chunk: - heads[headcount - 1].len += datalen; + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); This adds datalen with the wrong sign, causing guest panics. Fixes: 8b38694a2dc8b1

Re: [PATCH v8 34/50] vhost/net: virtio 1.0 byte swap

2015-01-07 Thread Greg Kurz
On Tue, 06 Jan 2015 16:55:30 -0700 Alex Williamson wrote: > On Mon, 2014-12-01 at 18:05 +0200, Michael S. Tsirkin wrote: > > I had to add an explicit tag to suppress compiler warning: > > gcc isn't smart enough to notice that > > len is always initialized since function is called with size > 0. >