[GIT PULL] MIPS KVM Guest FPU SIMD (MSA) Support for 4.1

2015-03-30 Thread James Hogan
Hi Paolo, Marcelo, Here is the MIPS guest FPU SIMD (MSA) work. I've based this on kvm/queue as of Friday, and it also pulls in some MIPS FP/MSA fixes from a branch in Ralf's MIPS tree. Hope that's okay. Please pull Thanks James The following changes since commit

[PATCH 4/5] KVM: x86: INIT and reset sequences are different

2015-03-30 Thread Nadav Amit
x86 architecture defines differences between the reset and INIT sequences. INIT does not initialize the FPU (including MMX, XMM, YMM, etc.), TSC, PMU, MSRs (in general), MTRRs machine-check, APIC ID, APIC arbitration ID and BSP. References (from Intel SDM): If the MP protocol has completed and a

[PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
After reset, the CPU can change the BSP, which will be used upon INIT. Reset should return the BSP which QEMU asked for, and therefore handled accordingly. To quote: If the MP protocol has completed and a BSP is chosen, subsequent INITs (either to a specific processor or system wide) do not

[PATCH 1/5] KVM: x86: CMOV emulation on legacy mode is wrong

2015-03-30 Thread Nadav Amit
On legacy mode CMOV emulation should still clear bits [63:32] even if the assignment is not done. The previous fix 140bad89fd (KVM: x86: emulation of dword cmov on long-mode should clear [63:32]) was incomplete. Signed-off-by: Nadav Amit na...@cs.technion.ac.il --- arch/x86/kvm/emulate.c | 3 +--

[PATCH 3/5] KVM: x86: BSF and BSR emulation change register unnecassarily

2015-03-30 Thread Nadav Amit
If the source of BSF and BSR is zero, the destination register should not change. That is how real hardware behaves. If we set the destination even with the same value that we had before, we may clear bits [63:32] unnecassarily. Signed-off-by: Nadav Amit na...@cs.technion.ac.il ---

[PATCH 0/5] KVM: x86: 64/32 bit fixes and INIT/BSP fixes

2015-03-30 Thread Nadav Amit
This patch-set handles 2 issues. Patches 1-3 deal with some more cases in which bits [63:32] are not cleared when using dword opsize. Patches 4-5 handle anomalies with INIT/BSP (INIT does not behave exactly as reset). Thanks for reviewing the patches. Nadav Amit (5): KVM: x86: CMOV emulation

[PATCH 2/5] KVM: x86: POPA emulation may not clear bits [63:32]

2015-03-30 Thread Nadav Amit
POPA should assign the values to the registers as usual registers are assigned. In other words, 32-bits register assignments should clear bits [63:32] of the register. Split the code of register assignments that will be used by future changes as well. Signed-off-by: Nadav Amit

[PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-30 Thread Michael Mueller
The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc target-s390 Signed-off-by: Michael Mueller

[PATCH v4 15/15] target-s390x: Enable cpu model usage

2015-03-30 Thread Michael Mueller
This patch enables QEMU to instantiate S390 CPUs with cpu model types. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- hw/s390x/s390-virtio.c | 12 +++- target-s390x/helper.c | 9 ++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH v4 13/15] target-s390x: Extend QMP command query-cpu-definitions

2015-03-30 Thread Michael Mueller
This patch implements the QMP command 'query-cpu-definitions' in the S390 context. The command returns a list of cpu model names in the current host context. A consumer may successfully request each listed cpu model as long for a given accelerator and machine this model is runnable. request:

[PATCH v4 04/15] target-s390x: Introduce cpu models

2015-03-30 Thread Michael Mueller
This patch implements the static part of the s390 cpu class definitions. It defines s390 cpu models by means of virtual cpu ids (enum) which contain information on the cpu generation, the machine class, the GA number and the machine type. The cpu id is used to instantiate a cpu class per cpu

Re: [GIT PULL] MIPS KVM Guest FPU SIMD (MSA) Support for 4.1

2015-03-30 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 30/03/2015 12:07, James Hogan wrote: Hi Paolo, Marcelo, Here is the MIPS guest FPU SIMD (MSA) work. I've based this on kvm/queue as of Friday, and it also pulls in some MIPS FP/MSA fixes from a branch in Ralf's MIPS tree. Hope that's

[PATCH v4 08/15] target-s390x: Add KVM VM attribute interface for cpu models

2015-03-30 Thread Michael Mueller
The patch implements routines to set and retrieve processor configuration data and to retrieve machine configuration data. The machine related data is used together with the cpu model facility lists to determine the list of supported cpu models of this host. The above mentioned routines have QEMU

[PATCH v4 05/15] target-s390x: Define cpu model specific facility lists

2015-03-30 Thread Michael Mueller
This patch defines S390 cpu facilities and their presence at the different cpu model levels. Beside defining a base which facilities have to be requested per cpu model, these sets are associated to the defined cpu classes and used to calculate the list of supported cpu models in context of the

[PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h

2015-03-30 Thread Michael Mueller
Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- linux-headers/asm-s390/kvm.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index c5a93eb..bfe6925 100644 ---

[PATCH v4 02/15] target-s390x: Introduce cpu facilities

2015-03-30 Thread Michael Mueller
The patch introduces S390 CPU facility bit numbers and names as well as the architectural facility size limit in bytes. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- target-s390x/cpu-facilities.h | 86 +++ 1 file changed, 86 insertions(+)

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
Paolo, It appears you are right and I have not tested 4 and 5 well enough. I’ll repost them (the others were tested presumably well enough). Two short questions: Can I use init.c in the kvm-unit-tests ? Why is it disabled? Nadav Paolo Bonzini pbonz...@redhat.com wrote: On 30/03/2015

Re: [PATCH] kvm: x86: i8259: return initialized data on invalid-size read

2015-03-30 Thread Paolo Bonzini
On 11/03/2015 12:16, Petr Matousek wrote: If data is read from PIC with invalid access size, the return data stays uninitialized even though success is returned. Fix this by always initializing the data. Signed-off-by: Petr Matousek pmato...@redhat.com Reported-by: Nadav Amit

[PATCH v4 01/15] Introduce stub routine cpu_desc_avail

2015-03-30 Thread Michael Mueller
This patch introduces the function cpu_desc_avail() which returns by default true if not architecture specific implemented. Its intention is to indicate if the cpu model description is available for display by list_cpus(). This change allows cpu model descriptions to become dynamically created by

[PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Michael Mueller
This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer: {return : {name: 2827-ga2, accel: kvm }} Alias names are resolved to their respective machine type and GA names

[PATCH v4 03/15] target-s390x: Generate facility defines per cpu model

2015-03-30 Thread Michael Mueller
This patch introduces the helper gen-facilities which allows to generate facility list definitions and masks at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper includes target-s390x/cpu-facilities.h to

[PATCH v4 00/15] s390x cpu model implementation

2015-03-30 Thread Michael Mueller
This patch set in combination with its kernel kvm patch set proposes an implementation of S390 cpu models. The origin of this item is to provide a means for management interfaces like libvirt to draw decisions if life guest migration to a target hypervisor is reasonable. A migration constraint is

[PATCH v4 09/15] target-s390x: Add cpu class initialization routines

2015-03-30 Thread Michael Mueller
This patch provides routines to dynamically update the previously defined S390 cpu classes in the current host context. The main function performing this process is s390_setup_cpu_classes(). It takes the current host context and a facility list mask as parameter to setup the classes accordingly.

[PATCH v4 06/15] target-s390x: Add cpu model alias definition routines

2015-03-30 Thread Michael Mueller
This patch implements the infrastructure to dynamically add cpu model aliases. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- target-s390x/cpu-models.c | 89 +++ target-s390x/cpu-models.h

[PATCH v4 14/15] target-s390x: Introduce facility test routine

2015-03-30 Thread Michael Mueller
The patch introduces routine s390_facility_test() which allows to verify a specific facility bit is set. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- target-s390x/cpu-models.c | 29 + target-s390x/cpu-models.h | 1 + 2 files changed, 30 insertions(+)

[PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization

2015-03-30 Thread Michael Mueller
This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an cpu object. Its task is to initialize the current accelerator with the properties of the selected processor model. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com ---

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 14:39, Nadav Amit wrote: After reset, the CPU can change the BSP, which will be used upon INIT. Reset should return the BSP which QEMU asked for, and therefore handled accordingly. To quote: If the MP protocol has completed and a BSP is chosen, subsequent INITs (either to a

KVM call agenda for 2015-03-31

2015-03-30 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ (Let me know if you have any problems

Re: [PATCH v3a 11/11] KVM: arm/arm64: rework MMIO abort handling to use KVM MMIO bus

2015-03-30 Thread Marc Zyngier
On 28/03/15 01:13, Andre Przywara wrote: Currently we have struct kvm_exit_mmio for encapsulating MMIO abort data to be passed on from syndrome decoding all the way down to the VGIC register handlers. Now as we switch the MMIO handling to be routed through the KVM MMIO bus, it does not make

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 16:40, Nadav Amit wrote: Paolo, It appears you are right and I have not tested 4 and 5 well enough. I’ll repost them (the others were tested presumably well enough). Two short questions: Can I use init.c in the kvm-unit-tests ? Why is it disabled? Because QEMU support

Re: [PATCH 0/2] KVM: x86: Removing redundant definitions from emulator

2015-03-30 Thread Paolo Bonzini
On 29/03/2015 15:33, Nadav Amit wrote: There are several redundant definitions in processor-flags.h and emulator.c. Slowly, but surely they will get mixed, so removing those of emulator.c seems like a reasonable move (unless I am missing something, e.g., kvm-kmod consideration). Nadav

Re: [PATCH 0/5] KVM: x86: 64/32 bit fixes and INIT/BSP fixes

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 14:39, Nadav Amit wrote: This patch-set handles 2 issues. Patches 1-3 deal with some more cases in which bits [63:32] are not cleared when using dword opsize. Patches 4-5 handle anomalies with INIT/BSP (INIT does not behave exactly as reset). Thanks for reviewing the

Re: [RFC PATCH 1/2] KVM: remove useless check of ret variable prior to returning the same value

2015-03-30 Thread Paolo Bonzini
On 28/03/2015 23:27, Eugene Korenevsky wrote: A trivial code cleanup. This `if` is redundant. Signed-off-by: Eugene Korenevsky ekorenev...@gmail.com --- arch/x86/kvm/emulate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/emulate.c

Re: [PATCH 0/9] qspinlock stuff -v15

2015-03-30 Thread Waiman Long
On 03/30/2015 12:29 PM, Peter Zijlstra wrote: On Mon, Mar 30, 2015 at 12:25:12PM -0400, Waiman Long wrote: I did it differently in my PV portion of the qspinlock patch. Instead of just waking up the CPU, the new lock holder will check if the new queue head has been halted. If so, it will set

Re: [PATCH 0/9] qspinlock stuff -v15

2015-03-30 Thread Waiman Long
On 03/27/2015 10:07 AM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 26, 2015 at 09:21:53PM +0100, Peter Zijlstra wrote: On Wed, Mar 25, 2015 at 03:47:39PM -0400, Konrad Rzeszutek Wilk wrote: Ah nice. That could be spun out as a seperate patch to optimize the existing ticket locks I presume. Yes

RE: XP machine freeze

2015-03-30 Thread Saso Slavicic
From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Thursday, March 19, 2015 1:52 AM Generate a Windows dump? https://support.microsoft.com/en-us/kb/254649 https://support.microsoft.com/en-us/kb/972110 Step 7: Generate a complete crash dump file or a kernel crash dump file by

Re: [PATCH 0/9] qspinlock stuff -v15

2015-03-30 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 12:25:12PM -0400, Waiman Long wrote: I did it differently in my PV portion of the qspinlock patch. Instead of just waking up the CPU, the new lock holder will check if the new queue head has been halted. If so, it will set the slowpath flag for the halted queue head in

Re: [PATCH 0/9] qspinlock stuff -v15

2015-03-30 Thread Waiman Long
On 03/25/2015 03:47 PM, Konrad Rzeszutek Wilk wrote: On Mon, Mar 16, 2015 at 02:16:13PM +0100, Peter Zijlstra wrote: Hi Waiman, As promised; here is the paravirt stuff I did during the trip to BOS last week. All the !paravirt patches are more or less the same as before (the only real change

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-30 Thread Radim Krčmář
2015-03-27 13:16+0300, Andrey Korolyov: On Fri, Mar 27, 2015 at 12:03 AM, Bandan Das b...@redhat.com wrote: Radim Krčmář rkrc...@redhat.com writes: I second Bandan -- checking that it reproduces on other machine would be great for sanity :) (Although a bug in our APICv is far more likely.)

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
Paolo Bonzini pbonz...@redhat.com wrote: On 30/03/2015 16:40, Nadav Amit wrote: Paolo, It appears you are right and I have not tested 4 and 5 well enough. I’ll repost them (the others were tested presumably well enough). Two short questions: Can I use init.c in the kvm-unit-tests ?

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 21:31, Nadav Amit wrote: Because QEMU support for INIT is incomplete, so the tests would fail (Uh, hard reset!). IIRC sending init to BSP with APIC_DEST_SELF is also not supported by actual hardware (or at least not supported officially) so that test would also have to be

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-30 Thread Eric Blake
On 03/30/2015 08:28 AM, Michael Mueller wrote: The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc

Re: [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization

2015-03-30 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:23PM +0200, Michael Mueller wrote: This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an cpu object. Its task is to initialize the current accelerator with the properties of the selected processor

Re: [PATCH v4 13/15] target-s390x: Extend QMP command query-cpu-definitions

2015-03-30 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:26PM +0200, Michael Mueller wrote: [...] CpuDefinitionInfoList *arch_query_cpu_definitions(bool has_machine, const char *machine, bool has_accel,

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-30 Thread Radim Krčmář
2015-03-27 14:54+0300, Andrey Korolyov: Trace with new bits: Thanks. KVM internal error. Suberror: 2 extra data[0]: 80ef extra data[1]: 8b0d extra data[2]: 77b The #GP code looks formatted as documented under INT in SDM, (vector 3) | 2 | ext where 'ext' stands for 'external' (as

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-30 Thread Andrey Korolyov
On Mon, Mar 30, 2015 at 9:56 PM, Radim Krčmář rkrc...@redhat.com wrote: 2015-03-27 13:16+0300, Andrey Korolyov: On Fri, Mar 27, 2015 at 12:03 AM, Bandan Das b...@redhat.com wrote: Radim Krčmář rkrc...@redhat.com writes: I second Bandan -- checking that it reproduces on other machine would be

Re: [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: [...] diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 829945d..1698b52 100644 --- a/target-s390x/cpu.c +++ b/target-s390x/cpu.c @@ -37,6 +37,11 @@ #define CR0_RESET 0xE0UL #define CR14_RESET

Re: [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer: {return : {name: 2827-ga2, accel: kvm }} If

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 08:28 AM, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer: {return : {name: 2827-ga2, accel: kvm }} Alias names are

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 02:17 PM, Eduardo Habkost wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer:

Re: [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h

2015-03-30 Thread Christian Borntraeger
Am 30.03.2015 um 16:28 schrieb Michael Mueller: Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- linux-headers/asm-s390/kvm.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Looks like a leftover. Drop that patch and rename ibc_range to ibc in the other

Re: XP machine freeze

2015-03-30 Thread Paolo Bonzini
On 22/03/2015 16:31, Brad Campbell wrote: No help I'm afraid, but at least I can conclusively say that 3.16 is good, and 3.17 is bad. Can you try more specifically around the first KVM pull request? That would be between c9b88e958182 (presumed good) and 8533ce727188 (presumed bad)?

RE: [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked

2015-03-30 Thread Wu, Feng
-Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Tuesday, March 31, 2015 7:56 AM To: Wu, Feng Cc: h...@zytor.com; t...@linutronix.de; mi...@redhat.com; x...@kernel.org; g...@kernel.org; pbonz...@redhat.com; dw...@infradead.org; j...@8bytes.org;

[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of true/false not 1/0 mips: Use bool function

[PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/include/asm/dcr-native.h| 2 +- arch/powerpc/include/asm/dma-mapping.h | 4 ++-- arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- arch/powerpc/sysdev/dcr.c| 2 +-

[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of true/false not 1/0 mips: Use bool function

[PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/include/asm/dcr-native.h| 2 +- arch/powerpc/include/asm/dma-mapping.h | 4 ++-- arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- arch/powerpc/sysdev/dcr.c| 2 +-

[PATCH 01/25] arm: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/arm/include/asm/dma-mapping.h | 8 arch/arm/include/asm/kvm_emulate.h | 2 +- arch/arm/mach-omap2/powerdomain.c | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-)

Re: XP machine freeze

2015-03-30 Thread Brad Campbell
On 31/03/15 05:11, Paolo Bonzini wrote: On 22/03/2015 16:31, Brad Campbell wrote: No help I'm afraid, but at least I can conclusively say that 3.16 is good, and 3.17 is bad. Can you try more specifically around the first KVM pull request? That would be between c9b88e958182 (presumed

Re: [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked

2015-03-30 Thread Marcelo Tosatti
On Mon, Mar 30, 2015 at 04:46:55AM +, Wu, Feng wrote: -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Saturday, March 28, 2015 3:30 AM To: Wu, Feng Cc: h...@zytor.com; t...@linutronix.de; mi...@redhat.com; x...@kernel.org; g...@kernel.org;

[PATCH 11/25] x86: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/x86/include/asm/archrandom.h | 2 +- arch/x86/include/asm/dma-mapping.h | 2 +- arch/x86/include/asm/kvm_para.h| 2 +- arch/x86/kvm/cpuid.h | 2 +- arch/x86/kvm/vmx.c

Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Tue, 2015-03-31 at 12:49 +1100, Benjamin Herrenschmidt wrote: On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org Should we merge it or will you ? Hey Ben. I don't merge stuff.

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Casey Schaufler
On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Casey Schaufler
On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote: On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 [etc...] Why, and why these in particular? bool functions are probably better returning bool values instead of

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote: On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 [etc...] Why, and why these in particular? bool functions are probably better returning bool values instead of

Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Tue, 2015-03-31 at 12:49 +1100, Benjamin Herrenschmidt wrote: On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org Should we merge it or will you ? Hey Ben. I don't merge stuff.

Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Benjamin Herrenschmidt
On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org Should we merge it or will you ? Cheers, Ben. Signed-off-by: Joe Perches j...@perches.com ---

Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0

2015-03-30 Thread Benjamin Herrenschmidt
On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org Should we merge it or will you ? Cheers, Ben. Signed-off-by: Joe Perches j...@perches.com ---