Re: [PATCH v2 2/9] KVM: MMU: introduce for_each_rmap_spte()

2015-05-12 Thread Xiao Guangrong
On 05/12/2015 04:08 PM, Paolo Bonzini wrote: On 12/05/2015 04:32, Xiao Guangrong wrote: - while ((sptep = rmap_get_first(*rmapp, &iter))) { - BUG_ON(!(*sptep & PT_PRESENT_MASK)); +restart: + for_each_rmap_spte(rmapp, &iter, sptep) { rmap_printk("kvm_

Re: [PATCH v6 0/8] vhost: support for cross endian guests

2015-05-12 Thread Michael S. Tsirkin
On Tue, May 12, 2015 at 12:44:26PM +0200, Greg Kurz wrote: > On Fri, 24 Apr 2015 15:31:54 +0200 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: > > > Only cosmetic and documentation changes since v5. > > > > > > --- > > > > Looks sane to me. I plan

[PATCH v2] KVM: x86: add module parameter to disable periodic kvmclock sync

2015-05-12 Thread Marcelo Tosatti
The periodic kvmclock sync can be an undesired source of latencies. When running cyclictest on a guest, a latency spike is visible. With kvmclock periodic sync disabled, the spike is gone. Guests should use ntp which means the propagations of ntp corrections from the host clock are unnecessary.

[RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-12 Thread Steve Rutherford
In order to support a userspace IOAPIC interacting with an in kernel APIC, the EOI exit bitmaps need to be configurable. If the IOAPIC is in userspace (i.e. the irqchip has been split), the EOI exit bitmaps will be set whenever the GSI Routes are configured. In particular, for the low 24 MSI route

Re: [PATCH] KVM: x86: fix initial PAT value

2015-05-12 Thread Jan Kiszka
On 2015-05-13 07:02, Wanpeng Li wrote: > Hi Radim, > On Mon, Apr 27, 2015 at 03:11:25PM +0200, Radim Krčmář wrote: >> PAT should be 0007_0406_0007_0406h on RESET and not modified on INIT. > > Could you point out where this value is described in SDM? :) 11.12.4 (revision from September 2014) Jan

Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-12 Thread Jan Kiszka
On 2015-05-13 03:47, Steve Rutherford wrote: > In order to support a userspace IOAPIC interacting with an in kernel > APIC, the EOI exit bitmaps need to be configurable. > > If the IOAPIC is in userspace (i.e. the irqchip has been split), the > EOI exit bitmaps will be set whenever the GSI Routes

Re: [RFC PATCH 4/4] KVM: x86: Add support for local interrupt requests from userspace

2015-05-12 Thread Jan Kiszka
On 2015-05-13 03:47, Steve Rutherford wrote: > In order to enable userspace PIC support, the userspace PIC needs to > be able to inject local interrupt requests. > > This adds the ioctl KVM_REQUEST_LOCAL_INTERRUPT and kvm exit > KVM_EXIT_GET_EXTINT. > > The vm ioctl KVM_REQUEST_LOCAL_INTERRUPT ma