Re: [kvm-unit-tests PATCH 02/18] trivial: lib: fail hard on failed mallocs

On Fri, Nov 06, 2015 at 03:05:41PM +0100, Thomas Huth wrote: > On 06/11/15 01:24, Andrew Jones wrote: > > It's pretty safe to not even bother checking for NULL when > > using malloc and friends, but if we do check, then fail > > hard. > > > > Signed-off-by: Andrew Jones > >

Re: [GIT PULL v4 3/3] s390/dma: Allow per device dma ops

On Thu, 5 Nov 2015 21:08:56 +0100 Christian Borntraeger wrote: > As virtio-ccw will have dma ops, we can no longer default to the > zPCI ones. Make use of dev_archdata to keep the dma_ops per device. > The pci devices now use that to override the default, and the >

Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On 11/05/2015 10:49 PM, Igor Mammedov wrote: On Thu, 5 Nov 2015 21:33:39 +0800 Xiao Guangrong wrote: On 11/05/2015 09:03 PM, Igor Mammedov wrote: On Thu, 5 Nov 2015 18:15:31 +0800 Xiao Guangrong wrote: On 11/05/2015

RE: [PATCH] KVM: arm: Fix crash in free_hyp_pgds() if timer initialization fails

Hello! > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > > index 7b42012..839dd970 100644 > > --- a/arch/arm/kvm/mmu.c > > +++ b/arch/arm/kvm/mmu.c > > @@ -213,7 +213,10 @@ static void unmap_ptes(struct kvm *kvm, pmd_t *pmd, > > kvm_tlb_flush_vmid_ipa(kvm, addr); > >

Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On 11/06/2015 04:31 PM, Xiao Guangrong wrote: On 11/05/2015 10:49 PM, Igor Mammedov wrote: On Thu, 5 Nov 2015 21:33:39 +0800 Xiao Guangrong wrote: On 11/05/2015 09:03 PM, Igor Mammedov wrote: On Thu, 5 Nov 2015 18:15:31 +0800 Xiao Guangrong

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 20/10/2015 09:39, Haozhong Zhang wrote: > This patchset adds support for VMX TSC scaling feature which is > available on Intel Skylake CPU. The specification of VMX TSC scaling > can be found at >

Re: [PATCH 1/2] target-i386: tcg: Accept clwb instruction

On 11/04/2015 10:24 PM, Eduardo Habkost wrote: Accept the clwb instruction (66 0F AE /6) if its corresponding feature flag is enabled on CPUID[7]. Signed-off-by: Eduardo Habkost --- target-i386/translate.c | 13 - 1 file changed, 12 insertions(+), 1

Re: [PATCH 2/2] target-i386: tcg: Check right CPUID bits for clflushopt/pcommit

On 11/04/2015 10:24 PM, Eduardo Habkost wrote: Detect the clflushopt and pcommit instructions and check their corresponding feature flags, instead of checking CPUID_SSE and CPUID_CLFLUSH. Signed-off-by: Eduardo Habkost --- target-i386/translate.c | 28

RE: [PATCH] KVM: arm: Fix crash in free_hyp_pgds() if timer initialization fails

Hello! > > > Did you check if PAGE_HYP_DEVICE can mean something sane on a stage-2 > > > page table entry and vice verse? > > > > I tried to, the chain of macros and variables is complicated enough not to > > get 200% sure, but anyway PAGE_HYP_DEVICE (as well as PAGE_S2_DEVICE) > > includes

RE: [PATCH] KVM: arm: Fix crash in free_hyp_pgds() if timer initialization fails

Hello! > >> The thing I want to avoid is PAGE_HYP_DEVICE covering some normal S2 > >> mapping, which we *should* flush but that we now end up ignoring? That > >> doesn't sound like it can be the case because the device bit is the same > >> bit for both types of page tables, correct? > > > >

Re: [kvm-unit-tests PATCH 02/18] trivial: lib: fail hard on failed mallocs

On 06/11/15 01:24, Andrew Jones wrote: > It's pretty safe to not even bother checking for NULL when > using malloc and friends, but if we do check, then fail > hard. > > Signed-off-by: Andrew Jones > --- > lib/virtio-mmio.c | 7 ++- > 1 file changed, 2 insertions(+), 5

Re: [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

On Fri, Nov 06, 2015 at 10:32:24AM +0800, haozhong.zh...@intel.com wrote: > On 11/05/15 14:05, Eduardo Habkost wrote: > > On Thu, Nov 05, 2015 at 09:30:51AM +0800, Haozhong Zhang wrote: > > > On 11/04/15 19:42, Eduardo Habkost wrote: [...] > > > > > +env->tsc_khz_saved = r; > > > > > +

Re: [PATCH v3 3/3] target-i386: load the migrated vcpu's TSC rate

On Fri, Nov 06, 2015 at 10:32:44AM +0800, Haozhong Zhang wrote: > On 11/05/15 14:10, Eduardo Habkost wrote: > > On Mon, Nov 02, 2015 at 05:26:43PM +0800, Haozhong Zhang wrote: > > > Set vcpu's TSC rate to the migrated value if the user does not specify a > > > TSC rate by cpu option 'tsc-freq' and

Re: [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

On Mon, Nov 02, 2015 at 05:13:09PM +0800, Xiao Guangrong wrote: > There are three places use the some logic to get the page size on > the file path or file fd > > Windows did not support file hugepage, so it will return normal page > for this case. And this interface has not been used on windows

Re: [PATCH v7 12/35] util: let qemu_fd_getlength support block device

On Tue, Nov 03, 2015 at 12:21:30AM +0800, Xiao Guangrong wrote: > On 11/03/2015 12:11 AM, Vladimir Sementsov-Ogievskiy wrote: > >On 02.11.2015 12:13, Xiao Guangrong wrote: > >>lseek can not work for all block devices as the man page says: > >>| Some devices are incapable of seeking and POSIX does

Re: [PATCH v7 12/35] util: let qemu_fd_getlength support block device

As this patch affects raw_getlength(), CCing the raw block driver maintainer and the qemu-block mailing list. On Mon, Nov 02, 2015 at 05:13:14PM +0800, Xiao Guangrong wrote: > lseek can not work for all block devices as the man page says: > | Some devices are incapable of seeking and POSIX does

Re: [PATCH v7 11/35] util: introduce qemu_file_getlength()

As this patch affects raw_getlength(), CCing the raw block driver maintainer and the qemu-block mailing list. On Mon, Nov 02, 2015 at 05:13:13PM +0800, Xiao Guangrong wrote: > It is used to get the size of the specified file, also qemu_fd_getlength() > is introduced to unify the code with

Re: [PATCH v7 12/35] util: let qemu_fd_getlength support block device

On Mon, Nov 02, 2015 at 05:13:14PM +0800, Xiao Guangrong wrote: > lseek can not work for all block devices as the man page says: > | Some devices are incapable of seeking and POSIX does not specify > | which devices must support lseek(). > > This patch tries to add the support on Linux by using

Re: OpenBSD 5.3 guest on KVM

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/09/2013 01:31, Daniel Bareiro wrote: > Hi all! > > These days I tested OpenBSD 5.3 and pleasantly surprised me notice > that they implemented VirtIO for block devices, network and memory > ballooning. It is an important step for those who

Re: [PATCH 3/3] KVM/arm64: enable enhanced armv8 fp/simd lazy switch

On 11/6/2015 3:29 AM, Christoffer Dall wrote: > On Thu, Nov 05, 2015 at 04:57:12PM -0800, Mario Smarduch wrote: >> >> >> On 11/5/2015 7:02 AM, Christoffer Dall wrote: >>> On Fri, Oct 30, 2015 at 02:56:33PM -0700, Mario Smarduch wrote: This patch enables arm64 lazy fp/simd switch, similar to

Re: [PATCH v3 2/3] KVM/arm/arm64: enable enhanced armv7 fp/simd lazy switch

On 11/6/2015 3:37 AM, Christoffer Dall wrote: > On Thu, Nov 05, 2015 at 04:23:41PM -0800, Mario Smarduch wrote: >> >> >> On 11/5/2015 6:48 AM, Christoffer Dall wrote: >>> On Fri, Oct 30, 2015 at 02:56:32PM -0700, Mario Smarduch wrote: This patch tracks vfp/simd hardware state with a vcpu

Re: [PATCH v2] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c

On 06/11/2015 14:02, William Dauchy wrote: > Hi Paolo, > > Looking at the history of this function, is it reasonable to say > it fixes the following commit? af585b9 KVM: Halt vcpu if page it > tries to access is swapped out > > Does it make it a good candidate for -stable? It's just a

Re: [PATCH v2] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c

Hi Paolo, Looking at the history of this function, is it reasonable to say it fixes the following commit? af585b9 KVM: Halt vcpu if page it tries to access is swapped out Does it make it a good candidate for -stable? Thanks, On Oct09 12:21, Kosuke Tatsukawa wrote: > async_pf_execute() seems to

Re: [PATCH 1/2] target-i386: tcg: Accept clwb instruction

On Fri, Nov 06, 2015 at 12:04:56PM +0100, Richard Henderson wrote: > On 11/04/2015 10:24 PM, Eduardo Habkost wrote: > >Accept the clwb instruction (66 0F AE /6) if its corresponding feature > >flag is enabled on CPUID[7]. > > > >Signed-off-by: Eduardo Habkost > >--- > >

Re: [PATCH] KVM: arm: Fix crash in free_hyp_pgds() if timer initialization fails

On 06/11/15 13:43, Pavel Fedin wrote: > Hello! > Did you check if PAGE_HYP_DEVICE can mean something sane on a stage-2 page table entry and vice verse? >>> >>> I tried to, the chain of macros and variables is complicated enough not to >>> get 200% sure, but anyway PAGE_HYP_DEVICE (as

Re: [PATCH v3 2/3] KVM/arm/arm64: enable enhanced armv7 fp/simd lazy switch

On Thu, Nov 05, 2015 at 04:23:41PM -0800, Mario Smarduch wrote: > > > On 11/5/2015 6:48 AM, Christoffer Dall wrote: > > On Fri, Oct 30, 2015 at 02:56:32PM -0700, Mario Smarduch wrote: > >> This patch tracks vfp/simd hardware state with a vcpu lazy flag. vCPU lazy > >> flag is set on guest

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 11/06/15 11:49, Paolo Bonzini wrote: > > > On 20/10/2015 09:39, Haozhong Zhang wrote: > > This patchset adds support for VMX TSC scaling feature which is > > available on Intel Skylake CPU. The specification of VMX TSC scaling > > can be found at > >

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 06/11/2015 13:42, Haozhong Zhang wrote: > On 11/06/15 11:49, Paolo Bonzini wrote: >> >> >> On 20/10/2015 09:39, Haozhong Zhang wrote: >>> This patchset adds support for VMX TSC scaling feature which is >>> available on Intel Skylake CPU. The specification of VMX TSC scaling >>> can be found

Re: [PATCH 3/3] KVM/arm64: enable enhanced armv8 fp/simd lazy switch

On Thu, Nov 05, 2015 at 04:57:12PM -0800, Mario Smarduch wrote: > > > On 11/5/2015 7:02 AM, Christoffer Dall wrote: > > On Fri, Oct 30, 2015 at 02:56:33PM -0700, Mario Smarduch wrote: > >> This patch enables arm64 lazy fp/simd switch, similar to arm described in > >> second patch. Change from

Re: [PATCH 1/2] target-i386: tcg: Accept clwb instruction

On 11/06/2015 02:59 PM, Eduardo Habkost wrote: Thanks! BTW, clflush uses gen_lea_modrm() too, does it do anything with the address somewhere else? Nope. It probably pre-dates the introduction of gen_nop_modrm. r~ -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body

Re: [PATCH] KVM: arm: Fix crash in free_hyp_pgds() if timer initialization fails

On Fri, Nov 06, 2015 at 12:32:51PM +0300, Pavel Fedin wrote: > Hello! > > > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > > > index 7b42012..839dd970 100644 > > > --- a/arch/arm/kvm/mmu.c > > > +++ b/arch/arm/kvm/mmu.c > > > @@ -213,7 +213,10 @@ static void unmap_ptes(struct kvm *kvm,