Re: [PATCH] x86: Use entire page for the per-cpu GDT only if paravirt-enabled

2015-09-28 Thread Denys Vlasenko
On 09/28/2015 09:58 AM, Ingo Molnar wrote: > > * Denys Vlasenko <dvlas...@redhat.com> wrote: > >> On 09/26/2015 09:50 PM, H. Peter Anvin wrote: >>> NAK. We really should map the GDT read-only on all 64 bit systems, >>> since we can't hide the address fro

Re: [PATCH] x86: Use entire page for the per-cpu GDT only if paravirt-enabled

2015-09-26 Thread Denys Vlasenko
On 09/26/2015 09:50 PM, H. Peter Anvin wrote: > NAK. We really should map the GDT read-only on all 64 bit systems, > since we can't hide the address from SLDT. Same with the IDT. Sorry, I don't understand your point. > On September 26, 2015 11:00:40 AM PDT, Denys Vlasenko <dvlas..

[PATCH] x86: Use entire page for the per-cpu GDT only if paravirt-enabled

2015-09-26 Thread Denys Vlasenko
<<< HERE 00016000 wO .data..percpu 0018 cpu_tlbstate ... 00018418 g .data..percpu __per_cpu_end Run-tested on a 144 CPU machine. Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> CC: Ingo Molnar <mi...@kernel.org> CC: H. P

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Denys Vlasenko
On Tue, Feb 10, 2015 at 10:30 AM, Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: On 02/10/2015 06:23 AM, Linus Torvalds wrote: add_smp(lock-tickets.head, TICKET_LOCK_INC); if (READ_ONCE(lock-tickets.tail) TICKET_SLOWPATH_FLAG) .. into something like val

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Denys Vlasenko
On Tue, Feb 10, 2015 at 2:18 PM, Denys Vlasenko vda.li...@googlemail.com wrote: while (1) { if (READ_ONCE(lock-tickets.head) != TICKET_TAIL(val)) cpu_relax(); } Doh should be while (READ_ONCE(lock-tickets.head) != TICKET_TAIL(val