Re: pci-assign terminates the guest upon pread() / pwrite() error?

2012-09-21 Thread Etienne Martineau
On 09/20/2012 05:13 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 16:36 -0400, Etienne Martineau wrote: On 09/20/2012 03:37 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 15:08 -0400, Etienne Martineau wrote: On 09/20/2012 02:16 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 13:27

Re: pci-assign terminates the guest upon pread() / pwrite() error?

2012-09-21 Thread Etienne Martineau
On 09/21/2012 11:49 AM, Alex Williamson wrote: On Fri, 2012-09-21 at 11:17 -0400, Etienne Martineau wrote: On 09/20/2012 05:13 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 16:36 -0400, Etienne Martineau wrote: On 09/20/2012 03:37 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 15:08

pci-assign terminates the guest upon pread() / pwrite() error?

2012-09-20 Thread Etienne Martineau
In hw/kvm/pci-assign.c a pread() error part of assigned_dev_pci_read() result in a hw_error(). Similarly a pwrite() error part of assigned_dev_pci_write() also result in a hw_error(). Would there be a way to avoid terminating the guest for those cases? How about we deassign the device upon

Re: pci-assign terminates the guest upon pread() / pwrite() error?

2012-09-20 Thread Etienne Martineau
On 09/20/2012 03:37 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 15:08 -0400, Etienne Martineau wrote: On 09/20/2012 02:16 PM, Alex Williamson wrote: On Thu, 2012-09-20 at 13:27 -0400, Etienne Martineau wrote: In hw/kvm/pci-assign.c a pread() error part of assigned_dev_pci_read() result

[RFC PATCH] kvm: PCI error stub driver

2010-11-19 Thread Etienne Martineau
should restore the device's config space? Can the guest's driver do it? - Should suspend and resume for assigned devices be also part of this driver? - The only policy implemented is 'lazy' thanks, -Etienne Signed-off-by: Etienne Martineau etmar...@cisco.com --- drivers/uio/Kconfig | 11

Re: [PATCH 0/4] VFIO V5: Non-privileged user level PCI drivers

2010-11-01 Thread Etienne Martineau
Is this the complete patch set? Or maybe it assumes a pre-patch kernel tree. If so where can I get it? thanks, -Etienne -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

[RFC PATCH] kvm: BSimple stub driver with AER capabilities

2010-10-31 Thread Etienne Martineau
, -Etienne Signed-off-by: Etienne Martineau etmar...@cisco.com --- drivers/uio/Kconfig | 11 ++ drivers/uio/Makefile |1 + drivers/uio/uio_pci_stub.c | 359 ++ include/linux/Kbuild |1 + include/linux/uio_pci_stub.h | 31

Re: KVM devices assignment; PCIe AER?

2010-10-28 Thread Etienne Martineau
On Wed, 27 Oct 2010, Alex Williamson wrote: KVM already has an internal IRQ ACK notifier (which is what current device assignment uses to do the same thing), it's just a matter of adding a callback that does a kvm_register_irq_ack_notifier that sends off the eventfd signal. I've got this

Re: KVM devices assignment; PCIe AER?

2010-10-27 Thread Etienne Martineau
On Wed, 27 Oct 2010, Alex Williamson wrote: I've actually been working on porting the qemu vfio driver over to qemu-kvm recently, and nearly have it working. For MSI-X interrupts I've ported to the common msix.c code, which abstracts how the interrupt is actually sent to the guest. I've also

Re: KVM devices assignment; PCIe AER?

2010-10-27 Thread Etienne Martineau
On Wed, 27 Oct 2010, Alex Williamson wrote: No, emulated devices trigger interrupts directly with qemu_set_irq. irqfds are currently only used by vhost afaik, since it's being interrupted externally, much like pass through devices are. Fair enough. Thanks for the clarification. Sort of.

Re: KVM devices assignment; PCIe AER?

2010-10-26 Thread Etienne Martineau
***Background context: We are using kvm on a x86 based platform. For performance reason, we use devices assignment. The type of devices we have to deal with is mostly custom ASICs but we also have standard stuff (ex 82599EB 10-GigabitSR-IOV). AER handling in guest VM is very important to us.

Re: KVM devices assignment; PCIe AER?

2010-10-26 Thread Etienne Martineau
On Tue, 26 Oct 2010, Chris Wright wrote: ***One of the aspect I'm not clear is the strategy for device-assignment under KVM? A) Move to VFIO; [/dev/iommu, /dev/vfio] Long term, hopefully VFIO B) KVM as a driver for the assigned devices; [sysfs/ ioctls..] Short term (i.e. current

Re: KVM devices assignment; PCIe AER?

2010-10-26 Thread Etienne Martineau
On Tue, 26 Oct 2010, Chris Wright wrote: Right, and adding more to the existing KVM code which we are hoping to push to legacy support mode doesn't sound like a great idea. I would totally agree with you if the alternative implementation to this legacy mode would be available in a

Re: KVM devices assignment; PCIe AER?

2010-10-26 Thread Etienne Martineau
On Tue, 26 Oct 2010, Chris Wright wrote: I would totally agree with you if the alternative implementation to this legacy mode would be available in a relatively short time frame. I'm not sure about that? Depends on how quickly you can help whip it into shape ;) Humm, this is not an easy