Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code

2013-04-05 Thread Geoff Levand
Hi Marc, On Fri, 2013-04-05 at 10:08 +0100, Marc Zyngier wrote: On 04/04/13 23:10, Geoff Levand wrote: On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: + @ Jump to the trampoline page + ldr r2, =#PAGE_MASK + adr r3, target + bic r3, r3, r2 + ldr r2

[PATCH v2 0/4] KVM minor fixups

2013-04-05 Thread Geoff Levand
in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geoff/kvm.git for-kvm for you to fetch changes up to 753c819ec3c3c55d6ca0eeddb4c6c2a32be7219b: KVM: Move vm_list kvm_lock declarations out of x86 (2013-04-05 11:43:22 -0700) Geoff Levand (4): KVM: Make local routines

[PATCH 4/4] KVM: Move vm_list kvm_lock declarations out of x86

2013-04-05 Thread Geoff Levand
it be static? virt/kvm/kvm_main.c: warning: symbol 'vm_list' was not declared. Should it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- arch/x86/include/asm/kvm_host.h |3 --- include/linux/kvm_host.h|3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/4] KVM: Make local routines static

2013-04-05 Thread Geoff Levand
' was not declared. Should it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- virt/kvm/kvm_main.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index adc68fe..82ca8e2 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm

[PATCH 2/4] KVM: Move kvm_spurious_fault to x86.c

2013-04-05 Thread Geoff Levand
The routine kvm_spurious_fault() is an x86 specific routine, so move it from virt/kvm/kvm_main.c to arch/x86/kvm/x86.c. Fixes this sparse warning when building on arm64: virt/kvm/kvm_main.c:warning: symbol 'kvm_spurious_fault' was not declared. Should it be static? Signed-off-by: Geoff

[PATCH 3/4] KVM: Move kvm_rebooting declaration out of x86

2013-04-05 Thread Geoff Levand
-by: Geoff Levand ge...@infradead.org --- arch/x86/include/asm/kvm_host.h |1 - include/linux/kvm_host.h|2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 4979778..8578da4 100644 --- a/arch/x86

Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code

2013-04-04 Thread Geoff Levand
Hi, On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: + @ Jump to the trampoline page + ldr r2, =#PAGE_MASK + adr r3, target + bic r3, r3, r2 + ldr r2, =#TRAMPOLINE_VA + add r3, r3, r2 + mov pc, r3 I guess you need 'ldr r2,

[PATCH 5/7] kvm/arm: Fix missing include build error

2013-04-04 Thread Geoff Levand
Include linux/cpu.h in kvm/arm.c. Fixes build errors like these with ARCH=arm64: arch/arm/kvm/arm.c: error: ‘CPU_STARTING_FROZEN’ undeclared Signed-off-by: Geoff Levand ge...@infradead.org --- arch/arm/kvm/arm.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/kvm/arm.c b/arch

[PATCH 7/7] kvm/arm: Remove unused kvm_arch_set_memory_region

2013-04-04 Thread Geoff Levand
Remove the unused and empty routine kvm_arch_set_memory_region(). Signed-off-by: Geoff Levand ge...@infradead.org --- arch/arm/kvm/arm.c |8 1 file changed, 8 deletions(-) diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c index 86becdc..a67b798 100644 --- a/arch/arm/kvm/arm.c

[PATCH 0/7] KVM minor fixups

2013-04-04 Thread Geoff Levand
at: git://git.kernel.org/pub/scm/linux/kernel/git/geoff/kvm.git for-kvm for you to fetch changes up to 5d9e775fd2d7c9ab03d70175610a5d8cedcc3799: kvm/arm: Remove unused kvm_arch_set_memory_region (2013-04-04 16:08:28 -0700) Geoff

[PATCH 4/7] kvm: Move kvm_rebooting dec out of x86

2013-04-04 Thread Geoff Levand
-off-by: Geoff Levand ge...@infradead.org --- arch/x86/include/asm/kvm_host.h |2 -- include/linux/kvm_host.h|1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index da7c126..225139a 100644 --- a/arch

[PATCH 3/7] kvm: Move kvm_spurious_fault dec out of x86

2013-04-04 Thread Geoff Levand
it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- arch/x86/include/asm/kvm_host.h |6 -- include/linux/kvm_host.h|7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 40fc39f

[PATCH 6/7] kvm/arm: Make force_vm_exit static

2013-04-04 Thread Geoff Levand
The routine force_vm_exit() is not referenced outside kvm/arm.c, so make it have static linkage. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/arm/include/asm/kvm_host.h |1 - arch/arm/kvm/arm.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 2/7] kvm: Move vm_list, kvm_lock dec's out of x86

2013-04-04 Thread Geoff Levand
it be static? virt/kvm/kvm_main.c: warning: symbol 'vm_list' was not declared. Should it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- arch/x86/include/asm/kvm_host.h |3 --- include/linux/kvm_host.h|3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/7] kvm: Make local routines static

2013-04-04 Thread Geoff Levand
' was not declared. Should it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- virt/kvm/kvm_main.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index adc68fe..82ca8e2 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm

Re: [PATCH 0/7] KVM minor fixups

2013-04-04 Thread Geoff Levand
Hi Christoffer, On Thu, 2013-04-04 at 16:53 -0700, Christoffer Dall wrote: On Thu, Apr 4, 2013 at 4:33 PM, Geoff Levand ge...@infradead.org wrote: Hi Marcelo, These are a few fixups I found when running sparse and building Marc's 64 bit ARM tree. Please consider for 3.10. running

Re: [PATCH 5/7] kvm/arm: Fix missing include build error

2013-04-04 Thread Geoff Levand
Hi Christoffer, On Thu, 2013-04-04 at 16:51 -0700, Christoffer Dall wrote: On Thu, Apr 4, 2013 at 4:33 PM, Geoff Levand ge...@infradead.org wrote: Include linux/cpu.h in kvm/arm.c. Fixes build errors like these with ARCH=arm64: arch/arm/kvm/arm.c: error: ‘CPU_STARTING_FROZEN’ undeclared

Re: [PATCH 5/7] kvm/arm: Fix missing include build error

2013-04-04 Thread Geoff Levand
Hi, On Thu, 2013-04-04 at 17:15 -0700, Christoffer Dall wrote: On Thu, Apr 4, 2013 at 5:04 PM, Geoff Levand ge...@infradead.org wrote: Sorry, this one is from Marc's kvm-for-next branch. I'll send it to him to include, unless you just want to take it in preparation. Hmm, not sure what

Re: [PATCH 23/29] arm64: KVM: 32bit GP register access

2013-03-15 Thread Geoff Levand
Hi Marc, On Tue, 2013-03-05 at 03:47 +, Marc Zyngier wrote: diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c new file mode 100644 index 000..f8d4a0c --- /dev/null +++ b/arch/arm64/kvm/regmap.c ... + switch (mode) { + case

Re: [PATCH 05/29] arm64: KVM: Basic ESR_EL2 helpers and vcpu register access

2013-03-15 Thread Geoff Levand
Hi Marc, On Tue, 2013-03-05 at 03:47 +, Marc Zyngier wrote: --- /dev/null +++ b/arch/arm64/include/asm/kvm_emulate.h ... +static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu) +{ + return false; /* 32bit? Bahhh... */ +} + +static inline bool kvm_condition_valid(struct

Re: [PATCH 06/29] arm64: KVM: fault injection into a guest

2013-03-15 Thread Geoff Levand
Hi Marc, On Tue, 2013-03-05 at 03:47 +, Marc Zyngier wrote: --- /dev/null +++ b/arch/arm64/kvm/inject_fault.c @@ -0,0 +1,117 @@ ... + * kvm_inject_undefined - inject a undefined instruction into the guest s/ a undefined/ an undefined/ -Geoff -- To unsubscribe from this list: send the

[PATCH] KVM: Remove duplicate text in api.txt

2013-01-31 Thread Geoff Levand
Signed-off-by: Geoff Levand ge...@infradead.org --- Saw this in v3.8-rc5, please apply. Documentation/virtual/kvm/api.txt | 13 - 1 file changed, 13 deletions(-) diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index a4df553..a65a6b3 100644