Re: [PATCH 6/9] KVM, pkeys: add pkeys support for permission_fault logic

2015-11-10 Thread Han, Huaitong
On Mon, 2015-11-09 at 14:17 +0100, Paolo Bonzini wrote: > > > static inline bool permission_fault(struct kvm_vcpu *vcpu, > > > struct kvm_mmu *mmu, > > > - unsigned pte_access, > > > unsigned pfec) > > > + unsigned pte_access, unsigned pte_pkeys, > > > unsigned

Re: [PATCH v3 7/7] KVM, pkeys: disable PKU feature without ept

2015-11-18 Thread Han, Huaitong
On Wed, 2015-11-18 at 10:06 +0100, Paolo Bonzini wrote: > > On 18/11/2015 06:44, Huaitong Han wrote: > > This patch disables CPUID:PKU without ept, becase pkeys is not > > supported > > with softmmu. > > Sure, but _what_ makes it impossible to support pkeys with shadow > pages? > > Is it enough

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling

2015-11-18 Thread Han, Huaitong
On Wed, 2015-11-18 at 13:58 -0200, Eduardo Habkost wrote: > On Wed, Nov 18, 2015 at 10:20:15AM +0800, Huaitong Han wrote: > [...] > > @@ -408,6 +420,13 @@ static FeatureWordInfo > > feature_word_info[FEATURE_WORDS] = { > > .cpuid_reg = R_EBX, > > .tcg_features = TCG_7_0_EBX_FEATUR