Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-30 Thread Hidetoshi Seto
Ping. Maintainers, please tell me if still something is required for this patch before applying it. Thanks, H.Seto (2010/11/24 17:01), Jes Sorensen wrote: On 11/24/10 03:38, Hidetoshi Seto wrote: This patch introduce a fallback mechanism for old systems that do not support utimensat

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Hidetoshi Seto
(2010/11/18 17:02), Jes Sorensen wrote: On 11/18/10 01:41, Hidetoshi Seto wrote: This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p

Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Hidetoshi Seto
(2010/11/18 17:28), Philipp Hahn wrote: Hello, Am Donnerstag 18 November 2010 01:41:39 schrieb Hidetoshi Seto: This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: +#ifdef CONFIG_UTIMENSAT +return

[PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-17 Thread Hidetoshi Seto
qemu.git v3: - Use better alternative handling for UTIME_NOW/OMIT - Move qemu_utimensat() to cutils.c V2: - Introduce qemu_utimensat() Acked-by: Chris Wright chr...@sous-sol.org Acked-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- cutils.c

Re: [Qemu-devel] Re: [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2

2010-11-14 Thread Hidetoshi Seto
(2010/11/14 14:58), Chris Wright wrote: * Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: +/* + * Fallback: use utimes() instead of utimensat(). + * See commit 74bc02b2d2272dc88fb98d43e631eb154717f517 for known problem. + */ +struct timeval tv[2]; +int i

[PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-14 Thread Hidetoshi Seto
for UTIME_NOW/OMIT - Move qemu_utimensat() to cutils.c V2: - Introduce qemu_utimensat() Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- cutils.c | 43 +++ hw/virtio-9p-local.c |4 ++-- qemu-common.h| 10 ++ 3

Re: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-11-05 Thread Hidetoshi Seto
(2010/11/05 2:03), Chris Wright wrote: * Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: (2010/10/14 4:11), Blue Swirl wrote: On Wed, Oct 13, 2010 at 8:00 AM, Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: (Add CC to k...@vger) (2010/10/12 10:52), Hao, Xudong wrote: Hi

[PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2

2010-11-05 Thread Hidetoshi Seto
: for each function it appears in.) hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) Signed-off-by: Hidetoshi Seto seto.hideto

Re: [PATCH 1/5] PCI: MSI: Move MSI-X entry definition to pci_regs.h

2010-11-04 Thread Hidetoshi Seto
Yeah, I think there are many virtualization stuff awaiting this change in these days. Reviewed-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com (2010/11/04 15:15), Sheng Yang wrote: Then it can be used by others. Reviewed-by: Matthew Wilcox wi...@linux.intel.com Cc: Jesse Barnes jbar

Re: [PATCH 2/5] PCI: Add mask bit definition for MSI-X table

2010-11-04 Thread Hidetoshi Seto
|= PCI_MSIX_ENTRY_CTRL_MASKBIT !!flag; Anyway thank you very much for doing this work. Reviewed-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Thanks, H.Seto -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH] Fix build on !KVM_CAP_MCE

2010-10-21 Thread Hidetoshi Seto
This patch removes following warnings: target-i386/kvm.c: In function 'kvm_put_msrs': target-i386/kvm.c:782: error: unused variable 'i' target-i386/kvm.c: In function 'kvm_get_msrs': target-i386/kvm.c:1083: error: label at end of compound statement Signed-off-by: Hidetoshi Seto seto.hideto

[PATCH] x86, mce: ignore SRAO only when MCG_SER_P is available

2010-10-21 Thread Hidetoshi Seto
And restruct this block to call kvm_mce_in_exception() only when it is required. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- target-i386/kvm.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index

[PATCH] x86, mce: broadcast mce depending on the cpu version

2010-10-21 Thread Hidetoshi Seto
There is no reason why SRAO event received by the main thread is the only one that being broadcasted. According to the x86 ASDM vol.3A 15.10.4.1, MCE signal is broadcast on processor version 06H_EH or later. This change is required to handle SRAR in smp guests. Signed-off-by: Hidetoshi Seto

Re: [Qemu-devel] Re: [PATCH 11/11] kvm, x86: broadcast mce depending on the cpu version

2010-10-18 Thread Hidetoshi Seto
(2010/10/15 22:30), Marcelo Tosatti wrote: On Fri, Oct 15, 2010 at 10:52:05AM +0900, Hidetoshi Seto wrote: (2010/10/15 10:06), Marcelo Tosatti wrote: On Thu, Oct 14, 2010 at 05:55:28PM +0900, Jin Dongming wrote: There is no reason why SRAO event received by the main thread is the only one

[PATCH uq/master 1/2] kvm, x86: ignore SRAO only when MCG_SER_P is available

2010-10-18 Thread Hidetoshi Seto
And restruct this block to call kvm_mce_in_exception() only when it is required. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- target-i386/kvm.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index

[PATCH uq/master 2/2] kvm, x86: broadcast mce depending on the cpu version

2010-10-18 Thread Hidetoshi Seto
There is no reason why SRAO event received by the main thread is the only one that being broadcasted. According to the x86 ASDM vol.3A 15.10.4.1, MCE signal is broadcast on processor version 06H_EH or later. This change is required to handle SRAR in smp guests. Signed-off-by: Hidetoshi Seto

Re: [Qemu-devel] Re: [PATCH 07/11] kvm, x86: unify sigbus handling, prep

2010-10-14 Thread Hidetoshi Seto
explicitly. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Tested-by: Jin Dongming jin.dongm...@np.css.fujitsu.com --- qemu-kvm.c | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) Don't see the benefit, separate functions

Re: [Qemu-devel] Re: [PATCH 11/11] kvm, x86: broadcast mce depending on the cpu version

2010-10-14 Thread Hidetoshi Seto
version 06H_EH or later. This change is required to handle SRAR in the guest. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Tested-by: Jin Dongming jin.dongm...@np.css.fujitsu.com --- qemu-kvm.c | 63 +-- 1 files changed

Re: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-13 Thread Hidetoshi Seto
'v9fs_wstat_post_chmod': hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/virtio-9p-local.c |8 hw/virtio-9p.c |9 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw

[PATCH] device-assignment: cleanup assigned_dev_ioport_map

2010-10-13 Thread Hidetoshi Seto
Here we already have: AssignedDevRegion *region = r_dev-v_addrs[region_num]; Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/device-assignment.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/device-assignment.c b/hw/device

[PATCH] device-assignment: introduce get_assigned_dev_id

2010-10-13 Thread Hidetoshi Seto
Stop repeating same code. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/device-assignment.c | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 975bf29..a2fa902 100644

Re: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-13 Thread Hidetoshi Seto
(2010/10/14 4:11), Blue Swirl wrote: On Wed, Oct 13, 2010 at 8:00 AM, Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: (Add CC to k...@vger) (2010/10/12 10:52), Hao, Xudong wrote: Hi, Currently qemu-kvm build fail on RHEL5 with gcc 4.1.2, build can pass on Fedora11 with gcc 4.4.1, can

Re: [PATCH] Fix SRAO/SRAR MCE injecting on guest without MCG_SER_P

2010-10-08 Thread Hidetoshi Seto
(2010/10/08 17:25), Huang Ying wrote: On real machine, if MCG_SER_P in MSR_MCG_CAP is not set, SRAO/SRAR MCE should not be raised by hardware. This patch makes QEMU-KVM to follow the same rule. Reported-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Huang Ying ying.hu

Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-07 Thread Hidetoshi Seto
Hi, Huang-san, (2010/10/08 12:15), Huang Ying wrote: Hi, Seto, On Thu, 2010-10-07 at 11:41 +0800, Hidetoshi Seto wrote: (2010/10/07 3:10), Dean Nelson wrote: On 10/06/2010 11:05 AM, Marcelo Tosatti wrote: On Wed, Oct 06, 2010 at 10:58:36AM +0900, Hidetoshi Seto wrote: I got some more

Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-06 Thread Hidetoshi Seto
(2010/10/07 3:10), Dean Nelson wrote: On 10/06/2010 11:05 AM, Marcelo Tosatti wrote: On Wed, Oct 06, 2010 at 10:58:36AM +0900, Hidetoshi Seto wrote: I got some more question: (2010/10/05 3:54), Marcelo Tosatti wrote: Index: qemu/target-i386/cpu.h

Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-05 Thread Hidetoshi Seto
(2010/10/05 3:54), Marcelo Tosatti wrote: Port qemu-kvm's commit 4b62fff1101a7ad77553147717a8bd3bf79df7ef Author: Huang Ying ying.hu...@intel.com Date: Mon Sep 21 10:43:25 2009 +0800 MCE: Relay UCR MCE to guest UCR (uncorrected recovery) MCE is supported in recent Intel

Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

2010-10-05 Thread Hidetoshi Seto
I got some more question: (2010/10/05 3:54), Marcelo Tosatti wrote: Index: qemu/target-i386/cpu.h === --- qemu.orig/target-i386/cpu.h +++ qemu/target-i386/cpu.h @@ -250,16 +250,32 @@ #define PG_ERROR_RSVD_MASK 0x08 #define

Re: PCI passthru issue

2010-09-16 Thread Hidetoshi Seto
(2010/09/17 8:01), Anirban Chakraborty wrote: Hi All, I noticed that the PCI registers are not all mapped to the guest for a PCI pass through device. For example, I was trying to pass through a PCI function (NIC) to a guest and in the guest the MSI-X table offset register is not mapped

Re: [PATCH] Use signed 16-bit values for ivshmem register writes

2010-09-02 Thread Hidetoshi Seto
(2010/08/31 1:58), Cam Macdonell wrote: fixes gcc 4.1 warning Signed-off-by: Cam Macdonell c...@cs.ualberta.ca --- hw/ivshmem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index bbb5cba..fa9c684 100644 --- a/hw/ivshmem.c +++

[PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-02 Thread Hidetoshi Seto
fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/ivshmem.c |4

Re: [PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-02 Thread Hidetoshi Seto
(2010/09/03 10:54), Hidetoshi Seto wrote: fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto seto.hideto

Re: [PATCH] device-assignment: Rework name of assigned pci device

2010-06-30 Thread Hidetoshi Seto
in really need, so now I'm going to follow your recommendation. Details inline. Hidetoshi Seto seto.hideto...@jp.fujitsu.com writes: Thanks Markus, (2010/06/29 14:28), Markus Armbruster wrote: Hidetoshi Seto seto.hideto...@jp.fujitsu.com writes: Hao, Xudong xudong@intel.com writes

[PATCH] Add QMP/qmp-commands.txt to .gitignore

2010-06-30 Thread Hidetoshi Seto
QMP/qmp-commands.txt is a generated file. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index ce66ed5..a32b7c4 100644 --- a/.gitignore +++ b/.gitignore @@ -28,6 +28,7

[PATCH] Add vapic.bin to .gitignore

2010-06-30 Thread Hidetoshi Seto
# This patch is for qemu-kvm.git The vapic.bin is a generated binary file. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index ddc248b..26eba20 100644 --- a/.gitignore

Re: [Qemu-devel] [PATCH] QEMU: Update .gitignore

2010-06-30 Thread Hidetoshi Seto
(2010/07/01 6:33), Aurelien Jarno wrote: On Mon, Jun 21, 2010 at 06:14:17PM +0900, Hidetoshi Seto wrote: (2010/06/21 17:19), Avi Kivity wrote: On 06/21/2010 08:24 AM, Hidetoshi Seto wrote: I think some people have noticed that: $ ./configure $ make $ git status # On branch master

Re: [PATCH] device-assignment: Rework name of assigned pci device

2010-06-29 Thread Hidetoshi Seto
Thanks Markus, (2010/06/29 14:28), Markus Armbruster wrote: Hidetoshi Seto seto.hideto...@jp.fujitsu.com writes: Hao, Xudong xudong@intel.com writes: When assign one PCI device, qemu fail to parse the command line: qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0

[PATCH] Update .gitignore

2010-06-27 Thread Hidetoshi Seto
-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- .gitignore |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 2d7f439..81b1ba4 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,8 @@ config-target.* libhw32 libhw64 libuser +libdis

[PATCH] device-assignment: Rework name of assigned pci device

2010-06-27 Thread Hidetoshi Seto
if the device have neither name nor id, address string like :00:19.0 will be created and passed instead. Once created, new field r_name holds the string to be reused and to be released later. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/device-assignment.c | 59

Re: qemu fail to parse command line with -pcidevice 00:19.0

2010-06-25 Thread Hidetoshi Seto
(2010/06/24 15:08), Markus Armbruster wrote: Note to qemu-devel: this issue is qemu-kvm only. Hao, Xudong xudong@intel.com writes: When assign one PCI device, qemu fail to parse the command line: qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 Error:

[PATCH] QEMU: Update .gitignore

2010-06-21 Thread Hidetoshi Seto
(2010/06/21 17:19), Avi Kivity wrote: On 06/21/2010 08:24 AM, Hidetoshi Seto wrote: I think some people have noticed that: $ ./configure $ make $ git status # On branch master # Untracked files: # (use git add file... to include in what will be committed) # # QMP/qmp

[PATCH] Update .gitignore

2010-06-20 Thread Hidetoshi Seto
/ These are directories generated by ./configure. - QMP/qmp-commands.txt A generated text. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- .gitignore |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 2d7f439..fa4f241

[PATCH] device-assignment, msi: PBA is long

2010-06-16 Thread Hidetoshi Seto
Accidentally a pci_read_long() was replaced with assigned_dev_pci_read_byte() by the commit: commit a81a1f0a7410976be7dbc9a81524a8640f446ab5 Author: Alex Williamson alex.william...@redhat.com device-assignment: Don't use libpci Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com