Re: [PATCH] netfilter: add CHECKSUM target

2010-07-09 Thread Jan Engelhardt
On Friday 2010-07-09 00:29, Michael S. Tsirkin wrote: > > include/linux/netfilter_ipv4/ipt_CHECKSUM.h | 18 +++ > net/ipv4/netfilter/Kconfig | 16 ++ > net/ipv4/netfilter/Makefile |1 + > net/ipv4/netfilter/ipt_CHECKSUM.c | 72 +

Re: [PATCH] netfilter: add CHECKSUM target

2010-07-09 Thread Jan Engelhardt
On Friday 2010-07-09 17:17, Patrick McHardy wrote: > >> This adds a `CHECKSUM' target, which can be used in the iptables mangle >> table. >> >> You can use this target to compute and fill in the checksum in >> an IP packet that lacks a checksum. This is particularly useful, >> if you need to wor

Re: [PATCH] netfilter: add CHECKSUM target

2010-07-11 Thread Jan Engelhardt
On Sunday 2010-07-11 14:27, Michael S. Tsirkin wrote: >> > >> > include/linux/netfilter_ipv4/ipt_CHECKSUM.h | 18 +++ >> > net/ipv4/netfilter/Kconfig | 16 ++ >> > net/ipv4/netfilter/Makefile |1 + >> > net/ipv4/netfilter/ipt_CHECKSUM.c | 7

Re: several messages

2010-07-15 Thread Jan Engelhardt
On Thursday 2010-07-15 11:36, Patrick McHardy wrote: >> +struct xt_CHECKSUM_info { >> +u_int8_t operation; /* bitset of operations */ > >Please use __u8 in public header files. > >> +#include > >Do you really need in.h? > >> + * $Id$ > >Please no CVS IDs. > >> +switch (c) { >> +cas

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Jan Engelhardt
On Monday 2011-02-14 16:11, Eric Dumazet wrote: >Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : >> We see severe memory corruption in kvm while used in conjunction with >> bridge/netfilter. Enabling slab debugging points the finger at a >> netfilter chain invoked from the bridge c